129 Commits (b7faae4bacd990e109b5b7b1a9db1cd3f445a387)

Author	SHA1	Message	Date
James Bardin	e28e11d44c	Fix resource.UniqueId to be properly ordered ... UniqueId attempted to provide an ordered unique id by using a nanosecond timestamp, but doesn't take into account that time is not monotonic increasing. This provides an implementation that will always be increasing.	10 years ago
Radek Simko	86acdccaf2	helper/resource: Add timeout to TimeoutError msg (#8773)	10 years ago
James Nugent	6c23181686	Merge pull request #8383 from kjmkznr/import-aws-s3-b-notification ... provider/aws: Support import `aws_s3_bucket_notification`	10 years ago
James Bardin	481f12cf2c	Remove `first` variable an extra if block ... clean up the code slighly by moving the Sleep in WaitForState to the end of the loop.	10 years ago
James Bardin	82be35a797	Fix races in WaitForState ... The WaitForState method can't read the result values in a timeout because they are still owned by the running goroutine. Keep all values scoped inside the goroutine, and save them into an atomic.Value to be returned. Fixes race introduced in #8510	10 years ago
Radek Simko	506c118383	helper/resource: Show last state in timeout err message	10 years ago
Radek Simko	aef2513b44	helper/resource: Fix WaitForState tests	10 years ago
James Nugent	df06d5623d	Merge pull request #8249 from meteor/glasser/name-prefix-timestamp ... core: name_prefix names now start with a timestamp	10 years ago
Kazunori Kojima	ed05161fd0	provider/aws: Support import `aws_s3_bucket_notification`	10 years ago
James Nugent	6ae7140251	Merge pull request #8370 from hashicorp/dtolnoy-wait ... Do not sleep between first attempt or between successful attempts	10 years ago
James Nugent	0a5acaa0d8	Change error message return structure	10 years ago
David Tolnay	9d3f40a513	Fix bad message from TimeoutError ... Before: Error creating IAM Role my-role: timeout while waiting for state to become 'success'. last error: %!s(<nil>)	10 years ago
David Tolnay	e27a735da2	Do not sleep between first attempt or between successful attempts	10 years ago
David Glasser	4ad825fe08	core: name_prefix names now start with a timestamp ... This means that two resources created by the same rule will get names which sort in the order they are created. The rest of the ID is still random base32 characters; we no longer set the bit values that denote UUIDv4. The length of the ID returned by PrefixedUniqueId is not changed by this commit; that way we don't break any resources where the underlying resource has a name length limit. Fixes #8143.	10 years ago
James Nugent	b551981cc7	testing: Add ComposeAggregateTestFunc ... This commit adds a function which composes a series of TestFuncs, but will run all tests before returning an error, unlike ComposeTestFunc. This is useful when verifying contents of state in acceptance tests and it is desirable to see all the failing cases in one run for slow resources.	10 years ago
James Nugent	b681ab23d3	testing: Add TestCheckResourceAttrSet helper ... This commit adds a TestCheckFunc which ensures that a value is set for a given name/key combination. It is primarily useful for ensuring that computed values are set where it is not possible to know the expected value ahead of time.	10 years ago
James Bardin	074be9ae56	Another race in resource.Retry	10 years ago
Paul Hinze	261043fd1a	Merge pull request #7523 from hashicorp/f-aws-beanstalk-env-poll-timing ... provider/aws: Beanstalk environments, bump the minimum timeout between API calls	10 years ago
Paul Hinze	614806d59f	helper/resource: Fix import test harness, which was modifying state ... Maps are reference types, it turns out :D	10 years ago
clint shryock	de60481428	provider/aws: Rework Beanstalk optional polling ... expose a poll_interval for users to configure polling for updates	10 years ago
Paul Hinze	3b732131d2	Merge pull request #7446 from hashicorp/b-jit-resource-validate ... core: rerun resource validation before plan and apply	10 years ago
Paul Hinze	ad27190852	Merge pull request #7448 from dtolnay/timeout ... Timing out is not success	10 years ago
Paul Hinze	4a1b36ac0d	core: rerun resource validation before plan and apply ... In #7170 we found two scenarios where the type checking done during the `context.Validate()` graph walk was circumvented, and the subsequent assumption of type safety in the provider's `Diff()` implementation caused panics. Both scenarios have to do with interpolations that reference Computed values. The sentinel we use to indicate that a value is Computed does not carry any type information with it yet. That means that an incorrect reference to a list or a map in a string attribute can "sneak through" validation only to crop up... 1. ...during Plan for Data Source References 2. ...during Apply for Resource references In order to address this, we: * add high-level tests for each of these two scenarios in `provider/test` * add context-level tests for the same two scenarios in `terraform` (these tests proved _really_ tricky to write!) * place an `EvalValidateResource` just before `EvalDiff` and `EvalApply` to catch these errors * add some plumbing to `Plan()` and `Apply()` to return validation errors, which were previously only generated during `Validate()` * wrap unit-tests around `EvalValidateResource` * add an `IgnoreWarnings` option to `EvalValidateResource` to prevent active warnings from halting execution on the second-pass validation Eventually, we might be able to attach type information to Computed values, which would allow for these errors to be caught earlier. For now, this solution keeps us safe from panics and raises the proper errors to the user. Fixes #7170	10 years ago
Paul Hinze	5656d7388c	helper/resource: Consolidate unit test override ... I noticed we had two mechanisms for unit test override. One that dropped a sentinel into the env var, and another with a struct member on TestCase. This consolidates the two, using the cleaner struct member internal mechanism and the nicer `resource.UnitTest()` entry point.	10 years ago
David Tolnay	7e1cd34819	Timing out is not success	10 years ago
Patrick Sodré	80936e3562	provider/triton: add machine domain names (#7149) ... * vendor joyent/gosdc/cloudapi * provider/triton: Add machine domain names - Includes acceptance test.	10 years ago
James Nugent	9c7cf639b3	testing: Allow acceptance test to run as unit test ... This commit adds a flag to acceptance tests in order to make appropriately named tests work during `make test` irrespective of the TF_ACC environment variable. This should only be used on tests which are known to be fast.	10 years ago
Radek Simko	1ea5cff9b3	Merge pull request #6946 from TimeIncOSS/f-aws-s3-object-data-source ... provider/aws: Add aws_s3_bucket_object data source	10 years ago
Radek Simko	bf8931b1ab	provider/aws: Mark Lambda function as gone when it's gone (#6924) ... * helper/error: Introduce TimeoutError & UnexpectedStateError * provider/aws: Mark Lambda function as gone when it's gone	10 years ago
Radek Simko	84ab00d92e	helper/resource: Add TestStep.PreventPostDestroyRefresh ... - This is to allow easier testing of data sources which read data from resources created in the same scope	10 years ago
Martin Atkins	031b561ef0	helper/resource: ignore data resource diffs during destroy ... When testing destroy, the test harness calls Refresh followed by Plan, with the expectation that the resulting diff will be empty. Data resources challenge this expectation, because they will always be instantiated during refresh if their configuration isn't computed, and so the subsequent diff will want to destroy what was instantiated. To work around this, we make an exception that data resource destroy diffs may appear in the plan but nothing else. This fixes #6713.	10 years ago
Mitchell Hashimoto	55583baa7e	Merge branch 'f-aws-import'	10 years ago
James Nugent	3ea3c657b5	core: Use OutputState in JSON instead of map ... This commit forward ports the changes made for 0.6.17, in order to store the type and sensitive flag against outputs. It also refactors the logic of the import for V0 to V1 state, and fixes up the call sites of the new format for outputs in V2 state. Finally we fix up tests which did not previously set a state version where one is required.	10 years ago
Mitchell Hashimoto	884980da1a	providers/aws: instance, nat, internet gateway	10 years ago
Mitchell Hashimoto	6a675b4a15	helper/resource: ImportState test can verify states	10 years ago
Mitchell Hashimoto	ec02c8c0e2	helper/resource: testing of almost all aspects of ImportState tests	10 years ago
Mitchell Hashimoto	2d99c451fb	helper/resource: basic ImportState acceptance testing ... Still some TODOs, and more test cases to write, but the basics are all here.	10 years ago
Mitchell Hashimoto	9bd1c9e7ca	helper/resource: reshuffling to prepare for importstate testing	10 years ago
Mitchell Hashimoto	35c87836b4	core: Add terraform_version to state ... This adds a field terraform_version to the state that represents the Terraform version that wrote that state. If Terraform encounters a state written by a future version, it will error. You must use at least the version that wrote that state. Internally we have fields to override this behavior (StateFutureAllowed), but I chose not to expose them as CLI flags, since the user can just modify the state directly. This is tricky, but should be tricky to represent the horrible disaster that can happen by enabling it. We didn't have to bump the state format version since the absense of the field means it was written by version "0.0.0" which will always be older. In effect though this change will always apply to version 2 of the state since it appears in 0.7 which bumped the version for other purposes.	10 years ago
Mitchell Hashimoto	d85df63526	providers/aws: aws_instance id-only	10 years ago
Mitchell Hashimoto	e0da21d381	helper/resource: make id-only check opt-in ... As I've been working through the resources, I'm finding that a lot are going to need some serious work. Given we have hundreds, I think it might be prudent to make this opt-in for now and we can revisit automatic/opt-out at some future point. Importability will likely be opt-in it appears so this will match up with that.	10 years ago
Mitchell Hashimoto	ff7b58f032	providers/aws: peering connection id-only test settings	10 years ago
Mitchell Hashimoto	0ef1b3b84a	providers/aws: response value for DescribeVpcAttribute needs to be ... .Value	10 years ago
Mitchell Hashimoto	1db1bf6639	helper/resource: use the full config for id-only checks ... Originally I used an empty config module. This caused problems since important provider configurations weren't available. Instead, I now set it to use the full config. This isn't an issue since the attributes themselves aren't available to Refresh anyways.	10 years ago
Mitchell Hashimoto	0c8b0bff2c	helper/resource: can specify specific name to id refresh test	10 years ago
Mitchell Hashimoto	1a9fae6b2e	helper/resource: can disable ID refresh check	10 years ago
Mitchell Hashimoto	35f4201b9e	providers/aws: instance_tenancy is computed, set	10 years ago
Mitchell Hashimoto	f2c4f8e9ba	helper/resource: fix tests	10 years ago
Mitchell Hashimoto	5c4f78796b	helper/resource: don't need to id-only check if no test steps	10 years ago
Mitchell Hashimoto	a285c04dc9	helper/resource: only verify id-only run if no error	10 years ago