522 Commits (b6fff854a6e6dac2ebc99438acc05f052d9743cc)

Author	SHA1	Message	Date
David Tolnay	7096e4d3da	Return nonnegative hash if int is 32 bits	10 years ago
Paul Hinze	3b732131d2	Merge pull request #7446 from hashicorp/b-jit-resource-validate ... core: rerun resource validation before plan and apply	10 years ago
Paul Hinze	ad27190852	Merge pull request #7448 from dtolnay/timeout ... Timing out is not success	10 years ago
Paul Hinze	afccf62e3e	Merge pull request #7459 from hashicorp/r-resource-unit-test ... helper/resource: Consolidate unit test override	10 years ago
Paul Hinze	4a1b36ac0d	core: rerun resource validation before plan and apply ... In #7170 we found two scenarios where the type checking done during the `context.Validate()` graph walk was circumvented, and the subsequent assumption of type safety in the provider's `Diff()` implementation caused panics. Both scenarios have to do with interpolations that reference Computed values. The sentinel we use to indicate that a value is Computed does not carry any type information with it yet. That means that an incorrect reference to a list or a map in a string attribute can "sneak through" validation only to crop up... 1. ...during Plan for Data Source References 2. ...during Apply for Resource references In order to address this, we: * add high-level tests for each of these two scenarios in `provider/test` * add context-level tests for the same two scenarios in `terraform` (these tests proved _really_ tricky to write!) * place an `EvalValidateResource` just before `EvalDiff` and `EvalApply` to catch these errors * add some plumbing to `Plan()` and `Apply()` to return validation errors, which were previously only generated during `Validate()` * wrap unit-tests around `EvalValidateResource` * add an `IgnoreWarnings` option to `EvalValidateResource` to prevent active warnings from halting execution on the second-pass validation Eventually, we might be able to attach type information to Computed values, which would allow for these errors to be caught earlier. For now, this solution keeps us safe from panics and raises the proper errors to the user. Fixes #7170	10 years ago
Paul Hinze	5656d7388c	helper/resource: Consolidate unit test override ... I noticed we had two mechanisms for unit test override. One that dropped a sentinel into the env var, and another with a struct member on TestCase. This consolidates the two, using the cleaner struct member internal mechanism and the nicer `resource.UnitTest()` entry point.	10 years ago
David Tolnay	7e1cd34819	Timing out is not success	10 years ago
Clint	a84aa5e914	Revert "helper/schema: Make nested Set(s) in List(s) work" (#7436)	10 years ago
Radek Simko	37d57f4a85	Improve naming convention (resultSet -> exists)	10 years ago
Radek Simko	917ad44cf0	helper/schema: Fix readSet implementation (DiffFieldReader)	10 years ago
Radek Simko	c738c5a9a3	helper/schema: Implement reader-specific readList method	10 years ago
Radek Simko	378b526dc3	helper/schema: Add regression tests for nested Set/List ... Although DiffFieldReader was the one mostly responsible for a buggy behaviour more tests were added throughout the debugging process most of which would fail without the bugfix. - ResourceData - MultiLevelFieldReader - MapFieldReader - DiffFieldReader	10 years ago
Patrick Sodré	80936e3562	provider/triton: add machine domain names (#7149) ... * vendor joyent/gosdc/cloudapi * provider/triton: Add machine domain names - Includes acceptance test.	10 years ago
James Nugent	dbf725bd68	core: Allow dynamic attributes in helper/schema ... The helper/schema framework for building providers previously validated in all cases that each field being set in state was in the schema. However, in order to support remote state in a usable fashion, the need has arisen for the top level attributes of the resource to be created dynamically. In order to still be able to use helper/schema, this commit adds the capability to assign additional fields. Though I do not forsee this being used by providers other than remote state (and that eventually may move into Terraform Core rather than being a provider), the usage and semantics are: To opt into dynamic attributes, add a schema attribute named "__has_dynamic_attributes", and make it an optional string with no default value, in order that it does not appear in diffs: "__has_dynamic_attributes": { Type: schema.TypeString Optional: true } In the read callback, use the d.UnsafeSetFieldRaw(key, value) function to set the dynamic attributes. Note that other fields in the schema _are_ copied into state, and that the names of the schema fields cannot currently be used as dynamic attribute names, as we check to ensure a value is not already set for a given key.	10 years ago
James Nugent	9c7cf639b3	testing: Allow acceptance test to run as unit test ... This commit adds a flag to acceptance tests in order to make appropriately named tests work during `make test` irrespective of the TF_ACC environment variable. This should only be used on tests which are known to be fast.	10 years ago
clint shryock	7d71b8cc3c	helper and terraform interpolate test update	10 years ago
James Bardin	2c7b702d1f	Merge pull request #7091 from hashicorp/jbardin/serialize ... Serialization for hash panics on TypeMap	10 years ago
James Bardin	bab031aac5	Add test for TypeMap in a Schema	10 years ago
James Bardin	d8fbaa7924	Serialization for hash panics on TypeMap ... The serializeCollectionMemberForHash helper can't be called for the MapType values, because MapType doesn't have a schema.Elem. Instead, we can write the key/value pairs directly to the buffer. This still doesn't allow for nested maps or lists, but we need to define that use case before committing to it here.	10 years ago
James Nugent	074545e536	core: Use .% instead of .# for maps in state ... The flatmapped representation of state prior to this commit encoded maps and lists (and therefore by extension, sets) with a key corresponding to the number of elements, or the unknown variable indicator under a .# key and then individual items. For example, the list ["a", "b", "c"] would have been encoded as: listname.# = 3 listname.0 = "a" listname.1 = "b" listname.2 = "c" And the map {"key1": "value1", "key2", "value2"} would have been encoded as: mapname.# = 2 mapname.key1 = "value1" mapname.key2 = "value2" Sets use the hash code as the key - for example a set with a (fictional) hashcode calculation may look like: setname.# = 2 setname.12312512 = "value1" setname.56345233 = "value2" Prior to the work done to extend the type system, this was sufficient since the internal representation of these was effectively the same. However, following the separation of maps and lists into distinct first-class types, this encoding presents a problem: given a state file, it is impossible to tell the encoding of an empty list and an empty map apart. This presents problems for the type checker during interpolation, as many interpolation functions will operate on only one of these two structures. This commit therefore changes the representation in state of maps to use a "%" as the key for the number of elements. Consequently the map above will now be encoded as: mapname.% = 2 mapname.key1 = "value1" mapname.key2 = "value2" This has the effect of an empty list (or set) now being encoded as: listname.# = 0 And an empty map now being encoded as: mapname.% = 0 Therefore we can eliminate some nasty guessing logic from the resource variable supplier for interpolation, at the cost of having to migrate state up front (to follow in a subsequent commit). In order to reduce the number of potential situations in which resources would be "forced new", we continue to accept "#" as the count key when reading maps via helper/schema. There is no situation under which we can allow "#" as an actual map key in any case, as it would not be distinguishable from a list or set in state.	10 years ago
James Nugent	cb9ef298f3	core: Defeat backward compatibilty in mapstructure ... The mapstructure library has a regrettable backward compatibility concern whereby a WeakDecode of []interface{}{} into a target of map[string]interface{} yields an empty map rather than an error. One possibility is to switch to using Decode instead of WeakDecode, but this loses the nice handling of type conversion, requiring a large volume of code to be added to Terraform or HIL in order to retain that behaviour. Instead we add a DecodeHook to our usage of the mapstructure library which checks for decoding []interface{}{} or []string{} into a map and returns an error instead. This has the effect of defeating the code added to retain backwards compatibility in mapstructure, giving us the correct (for our circumstances) behaviour of Decode for empty structures and the type conversion of WeakDecode. The code is identical to that in the HIL library, and packaged into a helper.	10 years ago
James Nugent	91587a49f3	core: Remove unnecessary debug logging ... Some unnecessary debug logging was introduced in 7b6df27e4, this commit removes it so as not to clutter logs.	10 years ago
Radek Simko	1ea5cff9b3	Merge pull request #6946 from TimeIncOSS/f-aws-s3-object-data-source ... provider/aws: Add aws_s3_bucket_object data source	10 years ago
Radek Simko	bf8931b1ab	provider/aws: Mark Lambda function as gone when it's gone (#6924) ... * helper/error: Introduce TimeoutError & UnexpectedStateError * provider/aws: Mark Lambda function as gone when it's gone	10 years ago
Radek Simko	84ab00d92e	helper/resource: Add TestStep.PreventPostDestroyRefresh ... - This is to allow easier testing of data sources which read data from resources created in the same scope	10 years ago
Chris Marchesi	9d7fb89114	core: Adding Sensitive attribute to resource schema ... This an effort to address hashicorp/terraform#516. Adding the Sensitive attribute to the resource schema, opening up the ability for resource maintainers to mark some fields as sensitive. Sensitive fields are hidden in the output, and, possibly in the future, could be encrypted.	10 years ago
Sander van Harmelen	8560f50cbc	Change taint behaviour to act as a normal resource ... This means it’s shown correctly in a plan and takes into account any actions that are dependant on the tainted resource and, vice verse, any actions that the tainted resource depends on. So this changes the behaviour from saying this resource is tainted so just forget about it and make sure it gets deleted in the background, to saying I want that resource to be recreated (taking into account the existing resource and it’s place in the graph).	10 years ago
Martin Atkins	031b561ef0	helper/resource: ignore data resource diffs during destroy ... When testing destroy, the test harness calls Refresh followed by Plan, with the expectation that the resulting diff will be empty. Data resources challenge this expectation, because they will always be instantiated during refresh if their configuration isn't computed, and so the subsequent diff will want to destroy what was instantiated. To work around this, we make an exception that data resource destroy diffs may appear in the plan but nothing else. This fixes #6713.	10 years ago
Mitchell Hashimoto	55583baa7e	Merge branch 'f-aws-import'	10 years ago
James Nugent	3ea3c657b5	core: Use OutputState in JSON instead of map ... This commit forward ports the changes made for 0.6.17, in order to store the type and sensitive flag against outputs. It also refactors the logic of the import for V0 to V1 state, and fixes up the call sites of the new format for outputs in V2 state. Finally we fix up tests which did not previously set a state version where one is required.	10 years ago
Mitchell Hashimoto	884980da1a	providers/aws: instance, nat, internet gateway	10 years ago
Mitchell Hashimoto	b7d4767dd6	helper/schema: pass through import state func	10 years ago
Martin Atkins	6cd22a4c9a	helper/schema: emit warning when using data source resource shim ... For backward compatibility we will continue to support using the data sources that were formerly logical resources as resources for the moment, but we want to warn the user about it since this support is likely to be removed in future. This is done by adding a new "deprecation message" feature to schema.Resource, but for the moment this is done as an internal feature (not usable directly by plugins) so that we can collect additional use-cases and design a more general interface before creating a compatibility constraint.	10 years ago
Martin Atkins	fb262d0dbe	helper/schema: shim for making data sources act like resources ... Historically we've had some "read-only" and "logical" resources. With the addition of the data source concept these will gradually become data sources, but we need to retain backward compatibility with existing configurations that use the now-deprecated resources. This shim is intended to allow us to easily create a resource from a data source implementation. It adjusts the schema as needed and adds stub Create and Delete implementations. This would ideally also produce a deprecation warning whenever such a shimmed resource is used, but the schema system doesn't currently have a mechanism for resource-specific validation, so that remains just a TODO for the moment.	10 years ago
Martin Atkins	6a468dcd83	helper/schema: Resource can be writable or not ... In the "schema" layer a Resource is just any "thing" that has a schema and supports some or all of the CRUD operations. Data sources introduce a new use of Resource to represent read-only resources, which require some different InternalValidate logic.	10 years ago
Martin Atkins	0e0e3d73af	core: New ResourceProvider methods for data resources ... This is a breaking change to the ResourceProvider interface that adds the new operations relating to data sources. DataSources, ValidateDataSource, ReadDataDiff and ReadDataApply are the data source equivalents of Resources, Validate, Diff and Apply (respectively) for managed resources. The diff/apply model seems at first glance a rather strange workflow for read-only resources, but implementing data resources in this way allows them to fit cleanly into the standard plan/apply lifecycle in cases where the configuration contains computed arguments and thus the read must be deferred until apply time. Along with breaking the interface, we also fix up the plugin client/server and helper/schema implementations of it, which are all of the callers used when provider plugins use helper/schema. This would be a breaking change for any provider plugin that directly implements the provider interface, but no known plugins do this and it is not recommended. At the helper/schema layer the implementer sees ReadDataApply as a "Read", as opposed to "Create" or "Update" as in the managed resource Apply implementation. The planning mechanics are handled entirely within helper/schema, so that complexity is hidden from the provider implementation itself.	10 years ago
Mitchell Hashimoto	6a675b4a15	helper/resource: ImportState test can verify states	10 years ago
Mitchell Hashimoto	ec02c8c0e2	helper/resource: testing of almost all aspects of ImportState tests	10 years ago
Mitchell Hashimoto	2d99c451fb	helper/resource: basic ImportState acceptance testing ... Still some TODOs, and more test cases to write, but the basics are all here.	10 years ago
Mitchell Hashimoto	9bd1c9e7ca	helper/resource: reshuffling to prepare for importstate testing	10 years ago
Mitchell Hashimoto	b728e55861	helper/schema: Resource.Data should set latest schema version	10 years ago
Mitchell Hashimoto	c02c6c3f9c	helper/schema: default state func for import	10 years ago
Mitchell Hashimoto	2bb814e3de	helper/schema: adapt to ID being arg to ImportState	10 years ago
Mitchell Hashimoto	03931bfda9	helper/schema: ImportState must set ID on the resource data	10 years ago
Mitchell Hashimoto	445194ebdf	helper/schema: test ImportState	10 years ago
Mitchell Hashimoto	1685054a9a	helper/schema: cleaner way to store Ephemeral	10 years ago
Mitchell Hashimoto	84531a3fd5	helper/schema: sets Importable to true for resources that have importer	10 years ago
Mitchell Hashimoto	19609bde0e	helper/schema: can specify Importer on Resource, InternalValidate	10 years ago
Mitchell Hashimoto	b8121ea63e	helper/schema: Resource.Data to return a ResourceData for a Resource	10 years ago
Mitchell Hashimoto	4e9877179c	helper/schema: start the resource importer	10 years ago