63 Commits (b41f08d79d2a2e8dea1fa690c19bb6dff249e141)

Author	SHA1	Message	Date
Martin Atkins	ba0514106a	return tfdiags.Diagnostics from validation methods ... Validation is the best time to return detailed diagnostics to the user since we're much more likely to have source location information, etc than we are in later operations. This change doesn't actually add any detail to the messages yet, but it changes the interface so that we can gradually introduce more detailed diagnostics over time. While here there are some minor adjustments to some of the messages to improve their consistency with terminology we use elsewhere.	9 years ago
James Bardin	b15258dfec	remove provider inheritance from Tree.Load ... Now that resources can be connected to providers with different paths in the core graph, handling the inheritance in config makes less sense. Removing this to make room for core to walk the Tree and connect resources directly to the proper provider instance.	9 years ago
James Bardin	2ed529f81a	update from review ... Reference modules by terraform address Unquote versions	9 years ago
James Bardin	c510473fd2	remove code added by stale vim buffer	9 years ago
James Bardin	1bf64ec788	add "Updating" output and fix output tests	9 years ago
James Bardin	9c334fe012	update init output ... Change "Downloading" to 'Initializing" to match the provider loading dialog. List each module being loaded. If a regisry module is being downloaded, list the registry host, and the version discovered. Show the source string from the config that is being fetched, rather than the go-getter url. The full source can be found in the logs for debugging. Add much more extensive logging	9 years ago
James Bardin	838ffafc18	stop adding implicit provider configs ... Now that providers in the graph can adopt resources without an explicit provider, there's no need to add the implicit configs to the module.Tree when loading.	9 years ago
James Bardin	3a495ffe56	rename ModuleStorage to Storage ... get rid of stutter and use module.Storage	9 years ago
James Bardin	36eb40a432	export ModuleStorage and use it for Tree.Load ... Exporting ModuleStorage allows us to explicitly pass in the storgae location rather than extracting it out of the getter.Storage interface, set a UI for communiating actions back to the user, and accepting a services Disco for discovery.	9 years ago
James Bardin	9bda82ccf1	add example for the reason behind versionedPathKey	9 years ago
James Bardin	1756b3d09f	ProviderConfig needs an Inherited flag ... If a provider configuration is inherited from another module, any interpolations in that config won't have variables declared locally. Let the config only be validated in it's original location.	9 years ago
James Bardin	0afd4a9097	Lookup registry module versions during Tree.Load. ... Registry modules can't be handled directly by the getter.Storage implementation, which doesn't know how to handle versions. First see if we have a matching module stored that satisfies our constraints. If not, and we're getting or updating, we can look it up in the registry. This essentially takes the place of a "registry detector" for go-getter, but required the intermediate step of resolving the version dependency. This also starts breaking up the huge Tree.Load method into more manageable parts. It was sorely needed, as indicated by the difficulty encountered in this refactor. There's still a lot that can be done to improve this, but at least there are now a few easier to read methods when we come back to it.	9 years ago
James Bardin	0d10564a74	remove the registryDetector ... The detection of registry modules will have to happen in mutliple phases. The go-getter interface requires that the detector return the final URL, while we won't know that until we verify which version we need. This leaves the regisry sources broken, to be re-integrated in a following commit.	9 years ago
James Bardin	ae2903b810	missing current module source in versionedPathKey ... The reason versionedPathKey didn't solve the previous test case was a missing source string for the current module.	9 years ago
James Bardin	0bc279557e	add more metadata to the Tree and the storage path ... Submodules were located by using their module path as the storage key. Now that modules may have versions, a submodule needs to know how to locate the corect source depending on the versions of its ancestors in the tree. Add a version field to each Tree, and a pointer back to the parent Tree to step back through the ancestors. The new versionedPathKey method uses this information to build a unique key for each module, dependent on the ancestor versions. Not only do stored modules need to know their version if it exists, but any relative source needs to know all the ancestor versions in order to resolve correctly.	9 years ago
James Bardin	1f44fd8eb2	move getStorage to moduleStorage too ... Add a test to ensure we don't store different modules with the same relative path in the same location.	9 years ago
James Bardin	3d163917c7	move the getter.Storage into our moduleStorge type ... Wrap the Storage interfaces together.	9 years ago
James Bardin	7416e7a6e0	update the module manifest implementation ... The getter.Storage abstraction is proving entirely inadequate here, but we can't replace it wholesale at the moment. The Tree loader needs to know the location of the manifest before it can start loading any modules. Since the version will have to be part of the hashed storage key, there is no way to know what version of each module are stored. The storageDir function will extract the StorageDir field from the underlying FolderStorage instance for the tree to locate the manifest.	9 years ago
James Bardin	283d88551a	Add a new module storage manifest ... To add registry support, a workaround in the local module storage was added to record the subdirectory containing the module source from within the archive file. Here we replace that temporary implementation with the full manifest needed to record the necessary module metadata for module loading. In order to support versioned modules, the actual stored version needs to be recorded. This can't be derived from the configuration, because the configuration only contains the constraints, and at load time we need to be able to enumerate the stored modules and all versions in order to resolve them. While the local storage key will be derived from the source and version, that information is lost once it's hashed. While the entire storage layer could be replaced to encode the needed data in the path itself, this provides a minimal change to work with the existing storage code.	9 years ago
James Bardin	8933ef8f70	make //subdir notation work with registry modules ... Append the original source subdir to the discovered subdir when locating the files in the module tree.	9 years ago
James Bardin	b0163e69d1	update comments	9 years ago
James Bardin	2e505083cd	change ProviderConfig.Scope to Path ... Though it's intended for "interpolation scope", Path is generally used for this elsewhere.	9 years ago
James Bardin	cb0e37a870	implement provider inheritence during loading ... This implements provider inheritance during config loading, rather than during graph evaluation. At this point it's much simpler to find the desired configuration, and once all providers are declared, all the inheritance code in the graph can be removed. The inheritance is dome by simply copying the RawConfig from the parent ProviderConfig into the module. Since this happens before any evaluation, we record the original interpolation scope in the ProviderConfig so that it can be properly resolved later on.	9 years ago
James Bardin	29e5a355b9	add "version" and "provider" to module config ... Add the Version and Providers fields to the module config. Add ProviderConfig.Scope, which will be used to record the original path of a ProviderConfig for interpolation.	9 years ago
Stefan Staudenmeyer	14792035cf	Aliasing the module to omit errors thrown at build time ... Signed-off-by: Stefan Staudenmeyer <stefan.staudenmeyer@instana.com>	9 years ago
James Bardin	f6e89bb8c3	record the subdirectory in the FolderStorage ... Module detection currently requires calling the registry to determine the subdirectory. Since we're not directly accessing the subdirectory through FolderStorage, and now handling it within terraform so modules can reference sibling paths, we need to call out to the registry every time we load a configuration to verify the subdirectory for the module, which is returned during the Detect. Record the subdirectories for each module in the top-level of the FolderStorage path for retrieval during Tree.Load. This lets us bypass Detection altogether, modules can be loaded without redetecting.	9 years ago
James Bardin	1b01f18920	handle go-getter subdirs in Tree.Load ... In order to remain backward compatible with some modules, we need to handle subdirs during Load. This means duplicating part of the go-getter code path for subDir handling so we can resolve any subDirs and globs internally, while keeping the entire remote directory structure within the file storage.	9 years ago
James Bardin	d216d19f21	change the FolderStorage key ... updating the key will cause the FolderStorage hash to change forcing modules to be re-fetched. This is required because any configurations using the subDir notation will have the configuration in the wrong directory.	9 years ago
James Bardin	6c20141c30	remove subdir handling from Tree.Load ... Terraform was redundantly handling `//dir` notation which should be handled by go-getter. Rather than allowing go-getter to unpack a subdir as expected, the subdir was stripped off and accessed through the module configuration. This scheme will no longer works now that go-getter supports `*` subdirectories (e.g. `//*` would be analogous to `tar --strip-components=1`). Even though this allows Terraform to use go-getter's native unpacking, detection is still done separately because Detect requires a `pwd` which is dependent on the configuration directory and not known to the global FolderStorage.	9 years ago
James Bardin	a83ff57aea	Add registry detector ... Add a getter.Detector for detecting registry modules and looking up the download location of the latest version. This is essentially a temporary API until constraint solving is supported by the registry, as then we'll have to supply the full set of known contraints to the registry at once for resolution and we will fetch specific versions of modules.	9 years ago
Martin Atkins	a8a64c66c0	config/module: helper to visit all modules in a tree	9 years ago
Mitchell Hashimoto	68ee4e0480	config/module: don't panic when referencing undefined module ... Fixes #12788 We would panic when referencing an output from an undefined module. The panic above this is correct but in this case Load will not catch interpolated variables that _reference_ an unloaded/undefined module. Test included.	9 years ago
James Bardin	2a949093ed	report all errors from module validation ... It can be tedious fixing a new module with many errors when Terraform only outputs the first random error it encounters. Accumulate all errors from validation, and format them for the user.	9 years ago
Mitchell Hashimoto	095b7e7831	config/module: disallow root modules named "root" ... Fixes #11038 This is a **short term fix**. Terraform core doesn't currently handle root modules named "root" well because the prefix `[]string{"root"}` has special meaning and Terraform core [currently] can't disambiguate between the root module and a module named "root" in the root module. This PR introduces a short term fix by simply disallowing root modules named "root". This shouldn't break any BC because since 0.8.0 this didn't work at all in many broken ways (including crashes). Longer term, this should be fixed by removing the special prefix at all and having empty paths be root. I started down this path but the core changes necessary are far too scary for a patch release. We can aim for 0.9.	9 years ago
Mitchell Hashimoto	0c30caec7d	config: smarter provider alias usage validation ... Fixes #4789 This improves the validation that valid provider aliases are used. Previously, we required that provider aliases be defined in every module they're used. This isn't correct because the alias may be used in a parent module and inherited. This removes that validation and creates the validation that a provider alias must be defined in the used module or _any parent_. This allows inheritance to work properly. We've always had this type of validation for aliases because we believe its a good UX tradeoff: typo-ing an alias is really painful, so we require declaration of alias usage. It may add a small burden to declare, but since relatively few aliases are used, it improves the scenario where a user fat-fingers an alias name.	9 years ago
Mitchell Hashimoto	55ef966b88	config/module: tree.Child on a nil tree works	10 years ago
Mitchell Hashimoto	098225dc0d	config/module: use the raw source as part of the key ... This changes the key for the storage to be the _raw_ source from the module, not the fully expanded source. Example: it'll be a relative path instead of an absolute path. This allows the ".terraform/modules" directory to be portable when moving to other machines. This was a behavior that existed in <= 0.7.2 and was broken with #8398. This amends that and adds a test to verify.	10 years ago
Mitchell Hashimoto	92336281a5	config/module: use source as part of key	10 years ago
Mitchell Hashimoto	27452f0043	terraform: Module option to Import to add module to graph	10 years ago
Mitchell Hashimoto	3c9a92e04a	command: Context buliding allows empty module trees	10 years ago
Jeff Zohrab	33d30761dd	Add hint to download modules for new users.	10 years ago
Mitchell Hashimoto	06f4ac8166	config/module: use go-getter	11 years ago
Mitchell Hashimoto	2378160803	config/module: determine storage folder by path	11 years ago
Mitchell Hashimoto	f084d8d932	config/module: store the path with the module	11 years ago
Mitchell Hashimoto	1e00b4386c	config/module: Child(nil) or empty will return self	12 years ago
Mitchell Hashimoto	267d45df86	config/module: Can look up Child with Tree.Child	12 years ago
Mitchell Hashimoto	3941dbac5d	fmt	12 years ago
Mitchell Hashimoto	4fbd5abc63	config/module: support GitHub paths without //	12 years ago
Mitchell Hashimoto	7aa30fdf25	config: support subdirectories with the "//" syntax	12 years ago
Mitchell Hashimoto	1ef167602e	config/module: validate that required parameters are passed through	12 years ago