746 Commits (b41f08d79d2a2e8dea1fa690c19bb6dff249e141)

Author	SHA1	Message	Date
Sander van Harmelen	179b32d426	Add a `CredentialsForHost` method to disco.Disco ... By adding this method you now only have to pass a `*disco.Disco` object around in order to do discovery and use any configured credentials for the discovered hosts. Of course you can also still pass around both a `*disco.Disco` and a `auth.CredentialsSource` object if there is a need or a reason for that!	8 years ago
Sander van Harmelen	9ba33e1958	Merge pull request #18360 from hashicorp/svh/b-close-body ... svchost/disco: make sure to close the response body	8 years ago
Sander van Harmelen	2c0c3771a9	Make sure to close the response body ... And fix a few linter warnings while we're at it…	8 years ago
Borys Pierov	c811440188	config: Don't log the private key on error in rsadecrypt	8 years ago
James Bardin	7b5efad725	update missing alias message ... Update the old error message for a missing provider alias, as we no longer automatically inherit providers.	8 years ago
James Bardin	15dc75720e	don't re-use a TempDir path ... Rather than creating and immediately removing a temp directory to get a random path name, fetch files into a subdirectory.	8 years ago
Martin Atkins	5b08fd4f9f	config: Don't expose go implementation details in Resource.Count ... Previously we would return the raw error from strconv.ParseInt, which includes details in its text that expose implementation details and are thus not helpful to the user. Instead, we use a locally-defined error message that talks only about what the caller is expected to know: that count should be parsable as an integer.	8 years ago
Masayuki Morita	e873af9337	Fix panic with substr interpolation function by invalid offset ... Fixes #17041	8 years ago
Pierre-Alain TORET	128f4d19e1	config: Allow build on DragonFlyBSD ... DragonFlyBSD is not officially supported, but allowing it to work is straightforward at the moment so we'll allow it for now.	8 years ago
James Bardin	cf4995d8a7	use the full module name with host for errors ... The module related logs and errors should reference the full module name including the source host.	8 years ago
Rob Campbell	5daeee5f6d	Update various files for new version of "stringer" ... The latest version of stringer now uses strconv instead of fmt.	8 years ago
Martin Atkins	87e1fb4d66	config: a nicer error message for invalid provider constraints ... Previously our error message here was confusing and redundant: Error starting operation: provider.null: invalid version constraint "not valid": Malformed constraint: not valid Instead, we'll generate a full HCL2 diagnostic here, which results in something (subjectively) nicer: Error: Invalid provider version constraint The value "@ 1.0.0" given for provider.null is not a valid version constraint. At the moment this message is an outlier in that the other validation errors are all still just plain Go errors, but over time we'll want to adjust all of these to be full diagnostics so that we can embed source range information in them to help the user find the offending configuration.	8 years ago
James Bardin	e0b2c64645	accessing count directly in an output should is OK ... There should be no warning when accessing a resource's count value directly in an output.	8 years ago
James Bardin	0e7dab09e6	Use the new registry.Client ... The registry code has been moved into the new registry package. Remove the duplicated code and use the new registry and registry/test packages.	8 years ago
Paul Banks	06f067b4e6	Update registry API docs with browse and search (#16846) ... * Verify discovery works without trailing slash on discovery URL * Update registry API docs with browse and search endpoints * Add sample request/responses * Add comment to test to indicate expecations * Fix typo * Remove trailing slash weirdness	8 years ago
David Meyer	fe0cc3b0db	config: new "rsadecrypt" interpolation function ... The primary use-case is to decrypt windows passwords obtained from AWS, but this function is generic and may find other purposes too.	8 years ago
mizuno	01c1142589	config: new "timeadd" interpolation function	8 years ago
James Bardin	048af6e237	Add test fixture to check for warnings	9 years ago
Martin Atkins	cc5e480378	config: detect and warn about access to "counted" attributes ... A common pattern is to conditionally assign to "count" in a resource in order to decide dynamically whether it should be created. In that situation it's necessary to refer to attributes of the resource using the splat syntax, but historically we didn't show errors in output expressions and so people "got away with" incorrect usage in that context. The intent of this warning is to catch potentially-problematic usage of attributes on such resources even if the count happens to be currently set dynamically to 1, which would not generate the error. Then the user can quickly locate and fix the incorrect usage regardless of the current value.	9 years ago
Martin Atkins	ba0514106a	return tfdiags.Diagnostics from validation methods ... Validation is the best time to return detailed diagnostics to the user since we're much more likely to have source location information, etc than we are in later operations. This change doesn't actually add any detail to the messages yet, but it changes the interface so that we can gradually introduce more detailed diagnostics over time. While here there are some minor adjustments to some of the messages to improve their consistency with terminology we use elsewhere.	9 years ago
James Bardin	8091bd627d	move Svchost method to regsrc.Module ... The level of abstraction that needs the "svchost" is the Module, not the FriendlyHost. Us the new method in the module package for registry interaction.	9 years ago
James Bardin	bd576d780a	failing test for module not found error ... The "not found" error should use the raw string directly from the config source, but the existing method was adding the default registry if there was no host indicated.	9 years ago
James Bardin	8619f566bb	validate providers passed to a module exist ... This validation was lost in the migration of inheritance back to core. Make sure a module configuraton doesn't specifiy a provider that doesn't exist.	9 years ago
James Bardin	b79adeae02	save resolved providers for resources to state ... Use the ResourceState.Provider field to store the full name of the provider used during apply. This field is only used when a resource is removed from the config, and will allow that resource to be removed by the exact same provider with which it was created. Modify the locations which might accept the alue of the ResourceState.Provider field to detect that the name is resolved.	9 years ago
James Bardin	b15258dfec	remove provider inheritance from Tree.Load ... Now that resources can be connected to providers with different paths in the core graph, handling the inheritance in config makes less sense. Removing this to make room for core to walk the Tree and connect resources directly to the proper provider instance.	9 years ago
James Bardin	57470f6bf5	remove ProviderConfig Path and Inherited fields ... maving all inheritance into core	9 years ago
James Bardin	3297f60d03	remove raw print statements	9 years ago
James Bardin	2ed529f81a	update from review ... Reference modules by terraform address Unquote versions	9 years ago
James Bardin	c510473fd2	remove code added by stale vim buffer	9 years ago
James Bardin	1bf64ec788	add "Updating" output and fix output tests	9 years ago
James Bardin	9c334fe012	update init output ... Change "Downloading" to 'Initializing" to match the provider loading dialog. List each module being loaded. If a regisry module is being downloaded, list the registry host, and the version discovered. Show the source string from the config that is being fetched, rather than the go-getter url. The full source can be found in the logs for debugging. Add much more extensive logging	9 years ago
James Bardin	b4e9240679	remove implicit provier tests from config/module ... No longer needed	9 years ago
James Bardin	838ffafc18	stop adding implicit provider configs ... Now that providers in the graph can adopt resources without an explicit provider, there's no need to add the implicit configs to the module.Tree when loading.	9 years ago
Martin Atkins	505683dcd3	config/module: produce explicit error for non-registry hosts ... If registry API discovery fails for a particular host then it's better to generate an explicit error message for that early -- so we can tell the user exactly what happened -- rather than assuming a default path and then failing downstream when we get a 404 from that request.	9 years ago
Martin Atkins	288f7c00e4	config/module: allow registry download sources to be relative paths ... It's not always easy or convenient for a web application to determine its own absolute URL to return, so here we pragmatically allow the download source string from a registry to be a path relative to the download endpoint. Since X-Terraform-Get is a go-getter string, not all valid values are valid URLs and so we sniff for certain relative-path-looking prefixes in order to decide whether to apply the relative lookup transform.	9 years ago
James Bardin	eef2129f1a	Storage.GetModule ... Add GetModule for the cli to initialize from a regisry module source. Storage.GetModule fetches a module using the same detection and discovery as used by the normal module loading. The final copy is still done by module.GetCopy to remove vcs files.	9 years ago
James Bardin	ac68f9a16b	make testCredentials token obviously fake	9 years ago
James Bardin	ee56e3226b	test that credentials are added to registry reqs ... Add the missing set in lookupModuleLocation	9 years ago
James Bardin	4e8fe97556	add credentials to module.Storage ... Provide a way to pass in credentials to be used by the module.Storage when contacting registries. Remove the mockTLSServer and use a static discovery map pointing to the http url for tests.	9 years ago
James Bardin	3a495ffe56	rename ModuleStorage to Storage ... get rid of stutter and use module.Storage	9 years ago
James Bardin	f2a7b94692	use the new ModuleStorage in the command package ... Update the command package to use the new module storage. Move the old command output strings into the module storage itself. This could be moved back later either by using ui callbacks, or designing a module storage interface once we know what the final requirements will look like.	9 years ago
James Bardin	36eb40a432	export ModuleStorage and use it for Tree.Load ... Exporting ModuleStorage allows us to explicitly pass in the storgae location rather than extracting it out of the getter.Storage interface, set a UI for communiating actions back to the user, and accepting a services Disco for discovery.	9 years ago
James Bardin	a7df650f01	fix vet error	9 years ago
James Bardin	9bda82ccf1	add example for the reason behind versionedPathKey	9 years ago
James Bardin	d6f75cc022	use URLs rather than strings is registry functions ... Parse all the registry strings as urls, and compine with path.Join to for better validation.	9 years ago
James Bardin	4a0de691f5	update test for error condition	9 years ago
James Bardin	6c808347d7	flag off registry ACC test ... Was missing the TF_ACC check	9 years ago
James Bardin	1756b3d09f	ProviderConfig needs an Inherited flag ... If a provider configuration is inherited from another module, any interpolations in that config won't have variables declared locally. Let the config only be validated in it's original location.	9 years ago
James Bardin	0afd4a9097	Lookup registry module versions during Tree.Load. ... Registry modules can't be handled directly by the getter.Storage implementation, which doesn't know how to handle versions. First see if we have a matching module stored that satisfies our constraints. If not, and we're getting or updating, we can look it up in the registry. This essentially takes the place of a "registry detector" for go-getter, but required the intermediate step of resolving the version dependency. This also starts breaking up the huge Tree.Load method into more manageable parts. It was sorely needed, as indicated by the difficulty encountered in this refactor. There's still a lot that can be done to improve this, but at least there are now a few easier to read methods when we come back to it.	9 years ago
James Bardin	0d10564a74	remove the registryDetector ... The detection of registry modules will have to happen in mutliple phases. The go-getter interface requires that the detector return the final URL, while we won't know that until we verify which version we need. This leaves the regisry sources broken, to be re-integrated in a following commit.	9 years ago