terraform

Commit Graph

Author	SHA1	Message	Date
James Bardin	3fbdee0777	clean up remote.Cmd api Combine the ExitStatus and Err values from remote.Cmd into an error returned by Wait, better matching the behavior of the os/exec package. Non-zero exit codes are returned from Wait as a remote.ExitError. Communicator related errors are returned directly. Clean up all the error handling in the provisioners using a communicator. Also remove the extra copyOutput synchronization that was copied from package to package.	8 years ago
James Bardin	2d7dc605a0	get communicator errors from a remote.Cmd The remote.Cmd struct could not convey any transport related error to the caller, meaning that interrupted commands would show that they succeeded. Change Cmd.SetExited to accept an exit status, as well as an error to store for the caller. Make the status and error fields internal, require serialized access through the getter methods. Users of remote.Cmd should not check both Cmd.Err() and Cmd.ExitStatus() until after Wait returns. Require communicators to call Cmd.Init before executing the command. This will indicate incorrect usage of the remote.Cmd by causing a panic in SetExitStatus.	8 years ago
James Bardin	bdfa97dbdb	add tests for signed host certs This checks that we can verify host certificates signed by a CA	8 years ago
James Bardin	1e7fd1c4ea	add test for host key validation This tests basic known_hosts validation for the ssh communicator.	8 years ago
Wang Guoliang	383b0c176c	optimization:use bytes.Equal instead of bytes.Compare	9 years ago
James Bardin	e6f58f5817	Add upload tests These are skipped without the SSH_UPLOAD_TEST flag, since they require connecting to a running ssh server on localhost as the current user, and one creates a very large file.	9 years ago
Sander van Harmelen	968472a63e	Support recreating clients and configuring Chef Vaults (#8577 ) Fixes #3605 and adds the functionality suggested in PR #7440. This PR is using a different appraoch that (IMHO) feels cleaner and (even more important) adds support for Windows at the same time.	10 years ago
Paul Hinze	2f237eca44	communicator/ssh: correct test typo Copy pasta!!	10 years ago
Paul Hinze	96c20f0dd7	communicator/{ssh,winrm}: seed random script paths Without a seed, the "random" script path locations for the remote-exec provisioner were actually deterministic! Every rand.Int31() would return the same pseudorandom chain starting w/ the numbers: 1298498081, 2019727887, 1427131847, 939984059, ... So here we properly seed the communicators so the script paths are actually random, and multiple runs on a single remote host have much less chance of clobbering each other. Fixes #4186 Kudos to @DustinChaloupka for the correct hunch leading to this fix!	10 years ago
Paul Hinze	801aaf1eec	communicator/ssh: sort agent after static keyfile In the SSH client configuration, we had SSH Agent authentication listed before the static PrivateKey loaded from the `key_file` setting. Switching the default of the `agent` setting exposed the fact that the SSH agent overrides the `key_file` during the handshake. By listing the `key_file` first, we catch the provided key before any query goes out to the agent. Adds a key-based authentication SSH test to cover this new behavior. It fails without the reordering on any machine with an SSH agent running. Fixes #2614	11 years ago
Sander van Harmelen	41748003c0	Updated the PR according to the review comments * We now return an error when you set the script_path to C:\Windows\Temp explaining this is currently not supported * The fix in PR #1588 is converted to the updated setup in this PR including the unit tests Last thing to do is add a few tests for the WinRM communicator…	11 years ago
Sander van Harmelen	c9e9e374bb	Adding some abstractions for the communicators This is needed as preperation for adding WinRM support. There is still one error in the tests which needs another look, but other than that it seems like were now ready to start working on the WinRM part…	11 years ago

12 Commits (b41f08d79d2a2e8dea1fa690c19bb6dff249e141)