terraform

Commit Graph

Author	SHA1	Message	Date
Liam Cervante	411f18e6ac	ephemerals: allow root ephemeral outputs in stacks and test (#37813 ) * ephemerals: allow root ephemeral outputs in stacks and test * remember to set new opt for apply stage	6 months ago
Kristin Laemmert	d4e8f17ded	actions: remove unused variable (+ minor typos & comment cleanup) (#37804 ) * actions: remove unused variable * fix minor comments and logged typos	6 months ago
James Bardin	2227441f7d	don't cache unknown function results The CheckPrior function results validation did not take into account unknown values, because unknown values were not originally allowed in the plugin protocol from which this check was adapted. The test is simple, in that we can just reverse the check which originally didn't allow this change in value. Provider function return values types are defined by the protocol, and should be validated at that call site. The CheckPrior code paths should only be used for the exact purpose of detecting invalid changes in the return value between successive phases of execution.	6 months ago
Sarah French	2e5b5dee5d	Upgrade protoc and protoc-gen-go-grpc versions to matching terraform-plugin-go (#37647 ) * Update protoc version in downloader script * go get google.golang.org/grpc/cmd/protoc-gen-go-grpc v1.5.1 This matched terraform-plugin-go * make protobuf * Run `make protobuf` * Update generator to handle generic types from google.golang.org/grpc Looks like this was added in v1.69.3 in https://github.com/grpc/grpc-go/pull/7057 ? * Run `make generate` * Fix "cannot infer Res" compile error - more usage of generics * More fixing compile errors due to switching to use of a generic * Make putting `google.golang.org/grpc` import into generated files conditional * Run `make generate` * Update more places where generics now need to be used * Update generator to handle any types from google.golang.org/grpc in same switch case.	6 months ago
Liam Cervante	edf0cd66dd	actions: fail invoke plans when action configurations are unknown (#37793 )	6 months ago
Sarah French	88e4c9e3d3	Update inaccurate comment (#37789 )	6 months ago
Sarah French	efb2a1c567	PSS: Let the `init` command recognise when there are no changes in configuration. (#37777 ) * Pull determining of PSS provider's version from current locks into a separate method * Add code for identifying when config and provider version match existing backend state (i.e. no changes) * Update test - locks are now needed before it hits expected error diag return * Add test showing successful init when no config changes are detected. * Update `getStateStorageProviderVersion` to return nil versions for builtin and re-attached providers. This makes comparison easier when determining if config has changed since last init. * Add test coverage for `getStateStorageProviderVersion` * Move testing fixtures around, preparing for different types of changed state_store config changes being tested * Add test showing that changing the state_store config is detected as a change, but handling this scenario isn't implemented yet * Update hashes in test fixture backend state file to be accurate Previously dummy values were fine, but as tests using hashes to identify changes these values need to be accurate! * Update existing test cases so that Terraform uses the same test provider version as described in the backend state file fixture for the test. * Add test showing that changing the PSS provider's config is detected as a change, but handling this scenario isn't implemented yet * Add test showing that swapping to a different state storage implementation in the same provider is detected as a change, but handling this scenario isn't implemented yet * Add test showing that changing the provider used for PSS is detected as a change, but handling this scenario isn't implemented yet * Add test showing that upgrading a provider is detected as a change, but handling this scenario isn't implemented yet * Update test to use v1.2.3 for consistency with other tests Just to avoid any confusion if copy-pasting happens in future. * More corrections to existing test fixtures - unset config should be null, and replace dummy hash values with correct values. * Fix test for using -reconfigure with state_store; the default workspace would already exist in this scenario * Update TestInit_stateStore_configUnchanged to assert that init was a no-op for backend state * Remove unused fixture * Remove test that's replaced by new tests in command/init_test.go * Replace old references to deleted "state-store-changed" test fixture & update test to not expect a value for region attr in provider config * Make test fixture coupling a little more understandable * Refactor detection of no need to migrate into a function * Add TODO about more involved provider version change tests We will allow downgrades to succeed as long as the schema version number is unchanged * Update (configs.StateStore)Hash method to return a single hash that's impacted by: state store config, provider config, state store type, provider source * Update calling code and test helper code to reflect that the nested provider block no longer has its own hash * Remove test; there is now a single hash that SHOULD be affected by the provider block! * Also use provider name, from config, in hash * Update tests to reflect changes in how hashes are made * Remove unused `stateStoreConfigNeedsMigration` function * Remove duplicate isProviderReattached function. * Fixes to affected tests * Allow provider version to impact the state storage hash, update impacted tests and test fixtures * Update tests that now require locks data to be present in test setup * Update comment for accuracy * Fixes to other test fixtures - remove excess hash field, set hash to 0 to indicate they're not set accurately. * Make upgrade test actually use upgrade code path * Add lock files to test fixture directories that represent a project that's had a successful prior init using PSS	6 months ago
Liam Cervante	106f8c6a1f	actions: refactor to simplify test hooks (#37782 )	6 months ago
Daniel Schmidt	accaa8d027	also check against action references in depends_on during config parsing	6 months ago
Daniel Schmidt	085c762cad	actions can not be used in depends_on Fixed #37780	6 months ago
Radek Simko	cbda324977	backend/oss: Bump github.com/aliyun/aliyun-oss-go-sdk to v2.1.1 (#37442 )	6 months ago
Sarah French	76f2982c68	Update the init command's help text to describe PSS-related flags (#37773 )	6 months ago
Sarah French	6b73f710f8	PSS: Implement initialisation of new working directory (or use of `-reconfigure` flag) while using `state_store` (#37732 ) * Minor fixes in diagnostics This can only be done once modules have been parsed and the required providers data is available. There are multiple places where config is parsed, into either Config or Module structs, so this needs to be implemented in multiple places. * Rename test to make it specific to use of backend block in config * Update initBackend to accept whole initArgs collection * Only process --backend-config data, when setting up a `backend`, if that data isn't empty * Simplify how mock provider factories are made in tests * Update mock provider's default logic to track and manage existing workspaces * Add `ProviderSchema` method to `Pluggable` structs. This allows calling code to access the provider schema when using provider configuration data. * Add function for converting a providerreqs.Version to a hashicorp/go-version Version. This is needed for using locks when creating the backend state file. * Implement initial version of init new working directories using `stateStore_C_s`. Default to creating the default workspace if no workspaces exist. * Update test fixtures to match the hashicorp/test mock provider used in PSS tests * Allow tests to obtain locks that include `testingOverrides` providers. The `testingOverrides` field will only be set in tests, so this should not impact end users. * Add tests showing TF can initialize a working directory for the first time (and do the same when forced by -reconfigure flag). Remove replaced tests. * Add -create-default-workspace flag, to be used to disable creating the default workspace by default when -input=false (i.e for use in CI). Refactor creation of default workspace logic. Add tests. * Allow reattached providers to be used during init for PSS * Rename variable to `backendHash` so relation to `backend` is clearer * Allow `(m Meta) Backend` to return warning diagnostics Protect against nil testingOverrides in providerFactoriesFromLocks * Add test case seeing what happens if default workspace selected, doesn't exist, but other workspaces do exist. The consequences here are due to using `selectWorkspace` in `stateStore_C_s`, matching what's done in `backend_C_r_s`. * Address code consistency check failure on PR * Refactor use of mock in test that's experiencing EOF error... * Remove test that requires test to supply input for user prompt This test passes when run in isolation but fails when run alongside other tests, even when skipping all other tests using `testStdinPipe`. I don't think the value of this test is great enough to start changing how we test stdin input. * Allow -create-default-workspace to be used regardless of whether input is enabled or disabled * Add TF_SKIP_CREATE_DEFAULT_WORKSPACE environment variable * Responses to feedback, including making testStdinPipe helper log details of errors copying data to stdin. Note: We cannot call t.Fatal from a non-test goroutine. * Use Errorf instead * Allow backend state files to not include version data when a builtin or reattached provider is in use. * Add clarifying comment about re-attached providers when finding the matching entry in required_providers * Report that the default workspace was created to the view * Refactor: use error comparison via `errors.Is` to identify when no workspaces exist. * Move handling of TF_ENABLE_PLUGGABLE_STATE_STORAGE into init's ParseInit func. * Validate that PSS-related flags can only be used when experiments are enabled, enforce coupling of PSS-related flags when in use. * Slight rewording of output message about default workspace * Update test to assert new output about default workspace	6 months ago
Sebastien Dionne	1047b5355c	Fix typos and linguistic errors in documentation (#37770 ) Signed-off-by: Sebastien Dionne <survivant00@gmail.com>	6 months ago
Sarah French	d11bdf6832	Refactor backend error strings as custom errors or pre-made diagnostics (#37762 ) * Replace `errBackendLocalRead` constant with custom error of same name * Replace `errBackendNoExistingWorkspaces` constant with custom error of same name * Replace `errBackendMigrateLocalDelete` constant with custom error of same name * Replace `errBackendNewUnknown` constant with custom error of same name * Replace `errBackendSavedUnknown` constant with custom error of same name * Replace `errBackendClearSaved` constant with custom error of same name * Replace `errBackendInit` constant with custom error of same name * Replace `errBackendInitCloud` constant with custom error of same name * Replace `errBackendWriteSaved` constant with custom error of same name * Move `migrateOrReconfigDiag` next to custom errors * Replace `errBackendInit` custom error with `func errBackendInitDiag` for creating diagnostics directly * Replace `errBackendInitCloud` custom error with `func errBackendInitCloudDiag` for creating diagnostics directly * Replace `errBackendWriteSaved` custom error with `func errBackendWriteSavedDiag` for creating diagnostics directly * Add new usage of errBackendWriteSavedDiag; this is another place where failing to write to backend state files happens * Add godoc comments * Ensure errors aren't repeated in terminal output, and ensure warnings are not lost.	6 months ago
Kristin Laemmert	8b0ccce413	actions: fix race condition in tests and capture errors from hooks (#37759 )	6 months ago
Sarah French	d6865bf7a9	PSS : Implement Lock and Unlock methods on remote grpc client (#37741 ) * Implement Lock and Unlock methods on grpcClient * Add tests for Lock and Unlock methods * Reuse same lock info variable	6 months ago
Dirk Avery	fc3b1ed174	Merge pull request #37752 from hashicorp/t-bump-go-getter Bump go-getter v1.8.2	6 months ago
Daniel Banck	cc30a8cf1d	Fix crash when showing a cloud plan without having a cloud backend (#37751 ) * Fix crash when showing a cloud plan without a cloud backend * Add changelog	7 months ago
Dirk Avery	edb3f6487d	Bump go-getter v1.8.2	7 months ago
Daniel Schmidt	2714cfde69	standardize on marks.Has	7 months ago
Sarah French	2657a4daec	Set let require_unimplemented_servers default to true when generating code from .proto files (#37737 ) * Remove `require_unimplemented_servers=false` option when generating code from proto files. Run `make protobuf`. This allows require_unimplemented_servers to default to true, and the generated code shows the impacts of that. * Update generator script to embed 'UnimplementedFoobarServer' structs and skip generating code for the `mustEmbedUnimplementedFoobarServer` method that is implemented via that embedding. * Run `make generate` * Embed UnimplementedProviderServer into implementations of ProviderServer * Embed UnimplementedProvisionerServer into implementations of ProvisionerServer	7 months ago
Liam Cervante	6b17cfe2e5	actions: connect invoke flag with TFC (#37544 ) * actions: connect invoke flag with TFC * use latest go-tfe	7 months ago
Liam Cervante	39d1293cf6	actions: consider event type when comparing action triggers (#37733 )	7 months ago
Dirk Avery	c4a7f00c6f	Merge pull request #37721 from hashicorp/t-bump-aws-sdk-go-base AWS European Sovereign Cloud support, bump aws-sdk-go-base	7 months ago
Liam Cervante	9239dd62e9	actions: enforce ephemeral into write-only attributes behaviour (#37701 ) * actions: add test that validates ephemeral behaviour * actuall prevent ephemeral values into non write-only attributes * remove old invalid test	7 months ago
Daniel Schmidt	766373973c	when targeting a resource the associated actions should be run	7 months ago
Daniel Schmidt	e0748b30c4	add interface checks	7 months ago
Daniel Schmidt	7721cd5c50	refactor: make action diff transformer only responsible for attaching action invocations	7 months ago
Daniel Schmidt	327a9922f6	refactor: rename action trigger apply to instance apply	7 months ago
Daniel Schmidt	4322ab20a1	refactor: add abstract action trigger	7 months ago
Daniel Schmidt	0031dcc9ca	refactor: rename targets to action targets	7 months ago
Daniel Schmidt	231b801d4b	refactor: separate action triggers from action invocations through --invoke	7 months ago
Daniel Schmidt	642a27e6c0	refactor: rename action plan to config transformer	7 months ago
Sarah French	d573104221	PSS: Add `stateStoreInitFromConfig` method to `Meta` (#37723 ) * Add SetStateStoreChunkSize to the mock provider for tests * Implement configurable state chunk size * Add chunk size negotiation to `savedStateStore`, update happy path test to assert it's set * Update `savedStateStore` to return diagnostic if a nil factory is passed in, add unhappy path tests * Add test coverage for stateStoreConfig, including use of config overrides with state stores * Add godoc comment for backendInitFromConfig * Avoid nil error in stateStoreConfig when there's no provider factory * Add stateStoreInitFromConfig method and test coverage * Refactor stateStoreInitFromConfig to accept factory directly, instead of accepting all BackendOpts This is to avoid confusion, e.g. unnecessary duplication of config being passed in. * Implement configurable state chunk size * Remove TODO which has since been addressed * Update happy path test for `stateStoreInitFromConfig` to check that chunk size is negotiated * Update chunk size negotiation code in `stateStoreInitFromConfig` to error if the provider doesn't return a chunk size > 0 * Fix test error message --------- Co-authored-by: Radek Simko <radek.simko@gmail.com>	7 months ago
Sarah French	17445f6c5f	PSS: Add chunk size negotiation to `savedStateStore` method, update mock provider for tests. (#37726 ) * Add SetStateStoreChunkSize to the mock provider for tests * Implement configurable state chunk size * Add chunk size negotiation to `savedStateStore`, update happy path test to assert it's set * Update `savedStateStore` to return diagnostic if a nil factory is passed in, add unhappy path tests * Fix test error message * Apply suggestions from code review Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com> * Fix rename --------- Co-authored-by: Radek Simko <radek.simko@gmail.com> Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com>	7 months ago
Daniel Banck	62540da015	search: Drop identity from state if no identity schema is present (#37709 ) * Modernize Go * Check if identity schema is present before decoding state * Test identity decoding from state without schema	7 months ago
Sarah French	aed61af66c	PSS: Implement `Get` and `Put` methods on remote grpc state, using Read/WriteStateBytes RPCs (#37717 ) * Implement Get method on remote gRPC state client, add tests * Implement Put method on remote gRPC state client, add tests	7 months ago
Sarah French	312f296c2d	PSS: Add `savedStateStore` method to `Meta` (#37558 ) * Add test coverage for Meta's `savedBackend` method * Add new Meta `savedStateStore` method and test coverage * Streamline test - remove unneeded assertions and update comments * Remove marks from config before configuring the provider * Remove marks from config before configuring the state store * Add test case for savedStateStore to assert marks aren't passed * Fix call to ConfigureStateStore * Show that tests pass despite not trying to remove marks * Allow Config methods to add marks when reading pluggable state store config from the backend state file * This code is now necessary to let the tests pass * Stop adding marks to PSS-related config when it's parsed from the backend state file * Stop removing marks that aren't there * Remove unnecessary test related to marks	7 months ago
Dirk Avery	9e155d7250	Update for newer telemetry	7 months ago
Dirk Avery	c7c388839f	Merge branch 'main' into t-bump-aws-sdk-go-base	7 months ago
Radek Simko	922fdb2382	Implement LockState & UnlockState provider methods (#37711 )	7 months ago
Dirk Avery	c5cdbf00c6	sync deps	7 months ago
Dirk Avery	5e3a9fbdf3	Bump aws-sdk-go-base	7 months ago
Akella Umesh	ea20db63fb	actions: add missing actions output for terraform apply cli (#37692 )	7 months ago
davidspielmann	04c95feb8d	Improve tests in internal/states (ProviderAddrs, HasCurrent, Unlock) (#37650 )	7 months ago
James Bardin	9c2b2c579a	remove id from generated config turns out the invalid id attributes were captured in the command test, so removing them caused that to fail too.	7 months ago
James Bardin	82889ae987	get correct schema when generating query config During the latest refactor, the wrong schema was fetched when generating configuration from a list resource. Having the list resource schema instead of the managed resource schema prevented the config generation from matching the computed attributes within the state, causing them to show up in the configuration. It turns out the tests for this didn't have computed attributes, so the accidental swap during refactoring didn't cause the tests to fail. A small addition to the tests adding an `id` attribute picks the regression.	7 months ago
Samsondeen	2274026c68	query: add -query flag to validate command (#37671 )	7 months ago
Liam Cervante	898665193c	actions: disable support for deferrals (#37700 )	7 months ago

1 2 3 4 5 ...

3896 Commits (b221cc00957adcd9642b2fd8cf285670405ca53b)