881 Commits (b0163e69d1226db5cc91e4fc4a4e71dc4014c1fa)

Author	SHA1	Message	Date
Martin Atkins	5347f82f9a	command: Include provider versions in "terraform version" ... We encourage users to share the "terraform version" output as part of filing an issue, but previously it only printed the core Terraform version and this left provider maintainers with no information about which _provider_ version an issue relates to. Here we make a best effort to show versions for providers, though we will omit some or all of them if either "terraform init" hasn't been run (and so no providers were selected yet) or if there are other inconsistencies that would cause Terraform to object on startup and require a re-run of "terraform init".	9 years ago
Martin Atkins	34cecfa839	command/e2etest: fix incorrect "terraform version" test ... Two different errors here caused this test to pass even though it was incorrect: the wanted version string was incorrect, but the test for it was also inverted, and so together this made the test pass even though it was actually not testing the output at all.	9 years ago
James Bardin	47c45788bc	Merge pull request #16406 from hashicorp/jbardin/version-package ... Add a standalone version package for all of terraform	9 years ago
Patrick Van Stee	a4a53f6f99	command/validate: Load plugins from plugin_path file ... This was added to other commands in 0.10 but was missed on "validate".	9 years ago
James Bardin	36b8be43e8	use the new version package ... Update all references to the version values to use the new package. The VersionString function was left in the terraform package specifically for the aws provider, which is vendored. We can remove that last call once the provider is updated.	9 years ago
Martin Atkins	865e61b4ea	main+command: provide service disco and creds to commands ... The command package is the main place we need access to these, so that we can use them during init (to install packages, for example) and so that we can use them to configure remote backends. For the moment we're just providing an empty credentials object, which will start to include both statically-configured and helper-program-provided credentials sources in subsequent commits.	9 years ago
Martin Atkins	6f7bc4f5d7	command: use c.showDiagnostics for backend operation errors ... This allows richer diagnostics produced by some subsystems to be displayed in full-fidelity to the user.	9 years ago
Martin Atkins	5cd00a13ec	command: use new diagnostics output for config errors ... This uses the new diagnostics printer for config-related errors in the main five commands that deal with config. The immediate motivation for this is to allow HCL2-produced diagnostics to be printed out in their full fidelity, though it also slightly changes the presentation of other errors so that they are not presented in all red text, which can be hard to read on some terminals.	9 years ago
Martin Atkins	ea81e75a4e	command: utility for rendering tfdiag diagnostics ... This new method showDiagnostics takes any value that would be accepted by tfdiags.Append and renders it to the UI. This is intended to encourage consistent handling of the different kinds of errors and diagnostics that can be produced, and allow richer error objects like the HCL2 diagnostics to be easily unwrapped and shown in their full-fidelity.	9 years ago
Martin Atkins	fc20f419dd	config and command: use errwrap to propagate config load errors ... Previously we were using fmt.Sprintf and thus forcing the stringification of the wrapped error. Using errwrap allows us to unpack the original error at the top of the stack, which is useful when the wrapped error is really a hcl.Diagnostics containing potentially-multiple errors and possibly warnings.	9 years ago
Martin Atkins	86343fa895	Remove test output file accidentally added in 52c97e9f ... Also, fix the missing gitignore rule that caused this to be added in the first place.	9 years ago
James Bardin	91442b7146	Merge pull request #15680 from brunomcustodio/etcdv3-backend ... [WIP] etcd v3 backend with lock support.	9 years ago
Martin Atkins	30e6f4e066	command/e2etest: test installation of plugins from cache ... This is a tough one to unit tests because the behavior is tangled up in the code that hits releases.hashicorp.com, so we'll add this e2etest as some extra insurance that this works end-to-end.	9 years ago
Martin Atkins	5c0670fdf4	command: allow callers to activate a plugin cache ... Here we add a new caller-settable field to command.Meta that activates a read-through cache directory for plugin installation.	9 years ago
Martin Atkins	73d1298572	command/e2etest: test the "running in automation" workflow ... Since we now have a guide that recommends some specific ways to run Terraform in automation, we can mimic those suggestions in an e2e test and thus ensure they keep working. Here we test the three different approaches suggested in the guide: - init, plan, apply (main case) - init, apply (e.g. for deploying to a QA/staging environment) - init, plan (e.g. for verifying a pull request)	9 years ago
Martin Atkins	cb6d4e5f20	command/e2etest: fix TestPrimarySeparatePlan test ... In 6712192724 we stopped counting data source destroys in the destroy tally since they are an implementation detail. This caused this test to start failing, though since the new behavior is correct here we just update the test to match.	9 years ago
Martin Atkins	ece06c35b8	command: parameter autocomplete for "terraform workspace ..." ... Shell tab completion for all of the subcommands under "terraform workspace", providing the appropriate kind of auto-complete for each argument, along with completion for for any flags.	9 years ago
Martin Atkins	793da43a72	command: workspace name autocomplete helper ... This helper is a Predictor for the "complete" package that tries to auto-complete workspace names from the current backend, if it's initialized and operable.	9 years ago
Martin Atkins	e4f18c3f4d	command: multi-argument autocomplete helper ... The predictors built in to the "complete" package assume that the same type of argument is repeated indefinitely, but most Terraform commands don't work like that, so this helper allows us to define a sequence of predictors that apply to each argument in turn.	9 years ago
Martin Atkins	2ed9aa6077	command: autocomplete data for "terraform init"	9 years ago
Martin Atkins	82fefbc599	command: add some common autocomplete predictors ... We use boolean flags and module sources in a lot of places, so we'll define global predictors for these which we can use across many commands.	9 years ago
Sunny	8928c5a60a	command/state-rm: tell the user how many items were removed	9 years ago
Jack Bruno	3f2136d7ee	cli: terraform import -ignore-missing-config ... This new option allows importing without configuration present. Configuration is required by default as a confirmation that the provided resource name is correct, but it can be useful to override this in tools that wrap Terraform to do more involved operations.	9 years ago
Jearvon Dharrie	5afe1d39d1	Add `/downloads` to the outdated version message	9 years ago
Martin Atkins	0fe43c8977	cli: allow disabling "next steps" message in terraform plan ... In #15884 we adjusted the plan output to give an explicit command to run to apply a plan, whereas before this command was just alluded to in the prose. Since releasing that, we've got good feedback that it's confusing to include such instructions when Terraform is running in a workflow automation tool, because such tools usually abstract away exactly what commands are run and require users to take different actions to proceed through the workflow. To accommodate such environments while retaining helpful messages for normal CLI usage, here we introduce a new environment variable TF_IN_AUTOMATION which, when set to a non-empty value, is a hint to Terraform that it isn't being run in an interactive command shell and it should thus tone down the "next steps" messaging. The documentation for this setting is included as part of the "...in automation" guide since it's not generally useful in other cases. We also intentionally disclaim comprehensive support for this since we want to avoid creating an extreme number of "if running in automation..." codepaths that would increase the testing matrix and hurt maintainability. The focus is specifically on the output of the three commands we give in the automation guide, which at present means the following two situations: * "terraform init" does not include the final paragraphs that suggest running "terraform plan" and tell you in what situations you might need to re-run "terraform init". * "terraform plan" does not include the final paragraphs that either warn about not specifying "-out=..." or instruct to run "terraform apply" with the generated plan file.	9 years ago
Martin Atkins	b95610c173	Merge #15387: terraform fmt -check option ... This new option causes fmt to return a non-zero exit code if any inconsistencies are detected.	9 years ago
Martin Atkins	fe4cfd03b5	command/format: restore "(forces new resource)" caption ... In 3ea1592 the plan rendering was refactored to add an extra indirection of producing a display-oriented plan object first and then rendering from that object. There was a logic error while adapting the existing plan rendering code to use the new display-oriented object: the core InstanceDiff object sets the "Destroy" flag (a boolean) for both DiffDestroy and DiffDestroyCreate, and so this code previously checked r.Destroy to recognize the "destroy-create" case. This was incorrectly adapted to a check for the display action being DiffDestroy, when it should actually have been DiffDestroyCreate. The effect of this bug was to cause the "(forces new resource)" annotations to not be displayed on attributes, though the resource-level information still correctly reflected that a new resource was required. This fix restores the attribute-level annotations.	9 years ago
Bruno Miguel Custodio	52c97e9fc9	First steps towards an 'etcdv3' backend.	9 years ago
Martin Atkins	83414beb8f	command: various adjustments to the diff presentation ... The previous diff presentation was rather "wordy", and not very friendly to those who can't see color either because they have color-blindness or because they don't have a color-supporting terminal. This new presentation uses the actual symbols used in the plan output and tries to be more concise. It also uses some framing characters to try to separate the different stages of "terraform plan" to make it easier to visually navigate. The apply command also adopts this new plan presentation, in preparation for "terraform apply" (with interactive plan confirmation) becoming the primary, safe workflow in the next major release. Finally, we standardize on the terminology "perform" and "actions" rather than "execute" and "changes" to reflect the fact that reading is now an action and that isn't actually a _change_.	9 years ago
Martin Atkins	d4efc95191	command: show resource actions using resource addresses ... Previously we were using the internal resource id syntax in the UI. Now we'll use the standard user-facing resource address syntax instead.	9 years ago
Martin Atkins	3ea159297c	command/format: improve consistency of plan results ... Previously the rendered plan output was constructed directly from the core plan and then annotated with counts derived from the count hook. At various places we applied little adjustments to deal with the fact that the user-facing diff model is not identical to the internal diff model, including the special handling of data source reads and destroys. Since this logic was just muddled into the rendering code, it behaved inconsistently with the tally of adds, updates and deletes. This change reworks the plan formatter so that it happens in two stages: - First, we produce a specialized Plan object that is tailored for use in the UI. This applies all the relevant logic to transform the physical model into the user model. - Second, we do a straightforward visual rendering of the display-oriented plan object. For the moment this is slightly overkill since there's only one rendering path, but it does give us the benefit of letting the counts be derived from the same data as the full detailed diff, ensuring that they'll stay consistent. Later we may choose to have other UIs for plans, such as a machine-readable output intended to drive a web UI. In that case, we'd want the web UI to consume a serialization of the _display-oriented_ plan so that it doesn't need to re-implement all of these UI special cases. This introduces to core a new diff action type for "refresh". Currently this is used _only_ in the UI layer, to represent data source reads. Later it would be good to use this type for the core diff as well, to improve consistency, but that is left for another day to keep this change focused on the UI.	9 years ago
Sunny	3a1582c1b9	command/validate: read terraform.tfvars file for variable values ... This is now consistent with the handling of this file for other commands.	9 years ago
Sunny	2d849f8650	command/init: check required_version ... Previously we were checking required_version only during "real" operations, and not during initialization. Catching it during init is better because that's the first command users run on a new working directory.	9 years ago
Martin Atkins	c12d64f340	Use t.Helper() in our test helpers ... Go 1.9 adds this new function which, when called, marks the caller as being a "helper function". Helper function stack frames are then skipped when trying to find a line of test code to blame for a test failure, so that the code in the main test function appears in the test failure output rather than a line within the helper function itself. This covers many -- but probaly not all -- of our test helpers across various packages.	9 years ago
Radek Simko	4e8ccb3127	Merge pull request #15828 from hashicorp/e2e-decoupling ... tools/terraform-bundle: Add e2e tests	9 years ago
Radek Simko	aabab16069	command/init: Remove extra whitespace	9 years ago
Michael Handler	817d1c4869	Output duration in UiHook after successful operation completion.	9 years ago
James Bardin	18af7750d4	Merge pull request #14720 from sevagh/master ... Add salt-masterless provisioner	9 years ago
Radek Simko	9e7e4ff4fb	e2e: Decouple logic for running e2e tests	9 years ago
Radek Simko	28b33c9299	plugin: Display version + source when initializing plugins	9 years ago
Radek Simko	38cb98fb0c	Comply w/ latest changes in mitchellh/cli	9 years ago
James Bardin	ea3e87b584	Merge pull request #15768 from hashicorp/jbardin/remote-import ... Don't ForceLocal for the import backend	9 years ago
James Bardin	5bcc1bae59	Merge pull request #15769 from hashicorp/jbardin/discovery-paths ... load legacy plugin paths	9 years ago
James Bardin	2bb5007690	Merge pull request #15683 from hashicorp/jbardin/remote-state-lineage ... Remove strict lineage check in remote.State	9 years ago
James Bardin	37932c3cd6	make state_rm flag description match state_mv	9 years ago
James Bardin	4034f988df	update import command docs ... Fix the -state and -state-out wording to be consistent with other commands. Remove the erroneous reference to remote state in the website version of the flag description.	9 years ago
James Bardin	54998933f5	load Meta.PluginOverrides in dicovery ... Make sure the override paths from the legacy rc file are loaded for discovery.	9 years ago
James Bardin	fa20d43d80	test loading of Meta.PluginOverrides ... These are currently being skipped in discovery	9 years ago
James Bardin	e3748901b4	Don't ForceLocal for the import backend ... While the `local.Local` backend is the only implementation of `backend.Local`, creating the backend with `ForceLocal` bypasses the `backend.Backend` in the `local.Local` causing a local state to be implicitly created rather than using the configured state backend. Add a test that imports into a configured backend (using the "local" backend as a remote state proxy). This further confirms the confusing nature of ForceLocal, as the backend _is_ local, but not from the viewpoint of meta.Backend.	9 years ago
Sevag Hanssian	867760ed56	Add salt-masterless provisioner	9 years ago