98 Commits (a8c4e81a6e3f2d8d11b57de1ee5e832494dcb4c8)

Author	SHA1	Message	Date
James Bardin	a111635908	Fix panic in interpolate_walk ... Verify that we have enough containers in the stack to look for a map in replaceCurrent.	9 years ago
James Bardin	3c41a7ca1e	Add test for Validate crash ... Crash during Validate walk with nested variable default.	9 years ago
Mitchell Hashimoto	6b4c007894	config: validate backend configuration can't contain interpolations	9 years ago
Mitchell Hashimoto	b6bfc4798d	config: Resource.Count should type check ... Fixes #11800 Type check the value of count so we don't panic on the conversion. I wondered "why didn't we do this before?" There is no excuse for NOT doing it at all but the reasoning was beacuse prior to the list/map work in 0.7, the value couldn't be anything other than a string since any primitive can turn into a string. Regardless, we should've always done this.	9 years ago
Mitchell Hashimoto	cf46e1c3e0	terraform: don't validate computed values in validate ... This disables the computed value check for `count` during the validation pass. This enables partial support for #3888 or #1497: as long as the value is non-computed during the plan, complex values will work in counts. **Notably, this allows data source values to be present in counts!** The "count" value can be disabled during validation safely because we can treat it as if any field that uses `count.index` is computed for validation. We then validate a single instance (as if `count = 1`) just to make sure all required fields are set.	9 years ago
Mitchell Hashimoto	928fce71f7	config: parse "when" and "on_failure" on provisioners	9 years ago
Mitchell Hashimoto	0c30caec7d	config: smarter provider alias usage validation ... Fixes #4789 This improves the validation that valid provider aliases are used. Previously, we required that provider aliases be defined in every module they're used. This isn't correct because the alias may be used in a parent module and inherited. This removes that validation and creates the validation that a provider alias must be defined in the used module or _any parent_. This allows inheritance to work properly. We've always had this type of validation for aliases because we believe its a good UX tradeoff: typo-ing an alias is really painful, so we require declaration of alias usage. It may add a small burden to declare, but since relatively few aliases are used, it improves the scenario where a user fat-fingers an alias name.	9 years ago
Mitchell Hashimoto	3665fea2db	config: validate that data sources don't have provisioners	10 years ago
Martin Atkins	399542a168	core: allow outputs to have descriptions (#9722) ... We allow variables to have descriptions specified, as additional context for a module user as to what should be provided for a given variable. We previously lacked a similar mechanism for outputs. Since they too are part of a module's public interface, it makes sense to be able to add descriptions for these for symmetry's sake. This change makes a "description" attribute valid within an "output" configuration block and stores it within the configuration data structure, but doesn't yet do anything further with it. For now this is useful only for third-party tools that might parse a module's config to generate user documentation; later we could expose the descriptions as part of the "apply" output, but that is left for a separate change.	10 years ago
Mitchell Hashimoto	25d19ef3d0	Merge pull request #10080 from hashicorp/f-tf-version ... terraform: support version requirement in configuration	10 years ago
Mitchell Hashimoto	85d3439fa0	config: parse and validate terraform.required_version	10 years ago
Mitchell Hashimoto	576b61a21d	config: validate depends_on with module values	10 years ago
Mitchell Hashimoto	694b16de5d	config: ignore_changes cannot have interpolations ... This is the limitation of all lifecycle attributes currently. Right now, interpolations are allowed through and the user ends up thinking it should work. We should give an error. In the future it should be possible to support some minimal set of interpolations (static variables, data sources even perhaps) but for now let's validate that this doesn't work.	10 years ago
Mitchell Hashimoto	609219fc65	command/meta: validate config immediately ... * config: test for validating multi-vars (passes) * command/plan: test invalid run * command/meta: validate module on load	10 years ago
James Bardin	94674fe93c	Add a test load of a data source with count	10 years ago
Sander van Harmelen	47dd1ad153	Add wildcard (match all) support to ignore_changes (#8599)	10 years ago
Mitchell Hashimoto	fbf06e2a59	config: vars must be unique	10 years ago
Mitchell Hashimoto	099293b690	config: outputs must be unique	10 years ago
Mitchell Hashimoto	f4faf2274b	config: count can't be a SimpleVariable	10 years ago
James Bardin	1af7ee87a2	Silence log output when not verbose ... Set the default log package output to iotuil.Discard during tests if the `-v` flag isn't set. If we are verbose, then apply the filter according to the TF_LOG env variable.	10 years ago
James Nugent	01cd596c60	core: Fix detection of empty list/map defaults ... This commit changes config parsing from weak decoding lists and maps into []string and map[string]string respectively to decode into []interface{} and map[string]interface{} respectively. This is in order to take advantage of the work integrated in #7082 to defeat the backward compatibility features of the mapstructure library. Test coverage of loading empty variables and validating their default types against expectation.	10 years ago
James Nugent	f1d0fc46aa	core: Fix go vet issues shown by Travis	10 years ago
James Nugent	f49583d25a	core: support native list variables in config ... This commit adds support for native list variables and outputs, building up on the previous change to state. Interpolation functions now return native lists in preference to StringList. List variables are defined like this: variable "test" { # This can also be inferred type = "list" default = ["Hello", "World"] } output "test_out" { value = "${var.a_list}" } This results in the following state: ``` ... "outputs": { "test_out": [ "hello", "world" ] }, ... ``` And the result of terraform output is as follows: ``` $ terraform output test_out = [ hello world ] ``` Using the output name, an xargs-friendly representation is output: ``` $ terraform output test_out hello world ``` The output command also supports indexing into the list (with appropriate range checking and no wrapping): ``` $ terraform output test_out 1 world ``` Along with maps, list outputs from one module may be passed as variables into another, removing the need for the `join(",", var.list_as_string)` and `split(",", var.list_as_string)` which was previously necessary in Terraform configuration. This commit also updates the tests and implementations of built-in interpolation functions to take and return native lists where appropriate. A backwards compatibility note: previously the concat interpolation function was capable of concatenating either strings or lists. The strings use case was deprectated a long time ago but still remained. Because we cannot return `ast.TypeAny` from an interpolation function, this use case is no longer supported for strings - `concat` is only capable of concatenating lists. This should not be a huge issue - the type checker picks up incorrect parameters, and the native HIL string concatenation - or the `join` function - can be used to replicate the missing behaviour.	10 years ago
James Nugent	e57a399d71	core: Use native HIL maps instead of flatmaps ... This changes the representation of maps in the interpolator from the dotted flatmap form of a string variable named "var.variablename.key" per map element to use native HIL maps instead. This involves porting some of the interpolation functions in order to keep the tests green, and adding support for map outputs. There is one backwards incompatibility: as a result of an implementation detail of maps, one could access an indexed map variable using the syntax "${var.variablename.key}". This is no longer possible - instead HIL native syntax - "${var.variablename["key"]}" must be used. This was previously documented, (though not heavily used) so it must be noted as a backward compatibility issue for Terraform 0.7.	10 years ago
Paul Hinze	567a9b9e06	config: remove missing equals test to fix build ... This is behavior that's covered in the parser now - and the error message is nicer to boot!	10 years ago
Paul Hinze	3f72837f4b	core: Make copies when creating destroy nodes ... Fixes an interpolation race that was occurring when a tainted destroy node and a primary destroy node both tried to interpolate a computed count in their config. Since they were sharing a pointer to the _same_ config, depending on how the race played out one of them could catch the config uninterpolated and would then throw a syntax error. The `Copy()` tree implemented for this fix can probably be used elsewhere - basically we should copy the config whenever we drop nodes into the graph - but for now I'm just applying it to the place that fixes this bug. Fixes #4982 - Includes a test covering that race condition.	10 years ago
Paul Hinze	87a9701f91	config: validation error when output is missing value field ... Also lists out invalid keys in errmsg when they are present Closes #4398	10 years ago
Sander van Harmelen	c62370f9e9	Add a function to load JSON directly ... Without this 12 line function it’s impossible to use any of the Terraform code without the need for having the files on disk. As more and more people are using (parts of) Terraform in other software, this seems to be a very welcome addition. It has no negative impact on Terraform itself whatsoever (the function is never called), but it opens up a lot of other use cases. Next to the single new function, I renamed the existing function (and related tests) to better reflect what the function does. So now there is a `LoadDir` function which calls `LoadFile` for each file, which kind of made sense to me, especially when now adding a `LoadJSON` function as well. But of course if the rename is a problem, I can revert that part as it’s not related to the added `LoadJSON` function. Thanks!	11 years ago
Mitchell Hashimoto	cca4964552	config: error in validation if module has self variable	11 years ago
Mitchell Hashimoto	d0a6d78b97	config: test that resources reference good providers	11 years ago
Mitchell Hashimoto	8ee18e2e14	config: happy case test for multiple providers	11 years ago
Mitchell Hashimoto	a599d5f224	config: validate that a multi provider is only configured once each	11 years ago
Paul Hinze	975a96f271	core: protect against count.index in modules ... Modules should get a validation error just like outputs do. refs #1528	11 years ago
Paul Hinze	347690a73e	core: don't crash when count.index is used in the wrong context ... It's bad manners! :) Also adds a validation error up at the configuration layer so the user sees the case from #1528 as an error message. fixes #1528	11 years ago
Mitchell Hashimoto	965fe45b9e	config: self var validation	11 years ago
Mitchell Hashimoto	a31f2a276b	Merge pull request #1015 from hashicorp/b-depends-on-var ... config: depends on cannot contain interpolations [GH-985]	11 years ago
Mitchell Hashimoto	c14e84a657	config: validate provisioner splats can only reference others	11 years ago
Mitchell Hashimoto	f156d0d1bd	config: test we can ref splat of other resources	11 years ago
Mitchell Hashimoto	90a6a627ed	config: validate configuration doens't contain splats to ourselves	11 years ago
Mitchell Hashimoto	0e7b150c5b	config: depends on cannot contain interpolations [GH-985]	11 years ago
Mitchell Hashimoto	4bcf6cf6b2	config: bare splat variables should not be allowed in provisioners ... [GH-636]	11 years ago
Mitchell Hashimoto	a2e40ad731	config: multi-variable access in slice validation fixed [GH-798]	11 years ago
Mitchell Hashimoto	d24082da1e	config: validate that module variables can go to ints, convert [GH-624]	12 years ago
Emil Hessman	4bfe18b40d	argument and verb formatting fixes reported by go vet ... builtin/providers/aws/tags_test.go:56: unrecognized printf verb 'i' builtin/providers/aws/tags_test.go:59: unrecognized printf verb 'i' config/config_test.go:101: possible formatting directive in Fatal call config/config_test.go:157: possible formatting directive in Fatal call config/module/get_file_test.go:91: missing argument for Fatalf(%s): format reads arg 1, have only 0 args helper/schema/schema.go:341: arg v.Type for printf verb %s of wrong type: schema.ValueType helper/schema/schema.go:656: missing argument for Errorf(%s): format reads arg 2, have only 1 args helper/schema/schema.go:912: arg schema.Type for printf verb %s of wrong type: schema.ValueType terraform/context.go:178: arg v.Type() for printf verb %s of wrong type: github.com/hashicorp/terraform/config.VariableType terraform/context.go:486: arg c.Operation for printf verb %s of wrong type: terraform.walkOperation terraform/diff_test.go💯 arg actual for printf verb %s of wrong type: terraform.DiffChangeType terraform/diff_test.go:235: arg actual for printf verb %s of wrong type: terraform.DiffChangeType	12 years ago
Mitchell Hashimoto	4cb1ea6ae1	config: allow exact multi-resource references outside slices	12 years ago
Mitchell Hashimoto	36f225dea0	fmt	12 years ago
Mitchell Hashimoto	7b48924532	config: validate that multi-variables are only used in slices	12 years ago
Mitchell Hashimoto	67d9188a29	config: validate module names are valid	12 years ago
Mitchell Hashimoto	50e5eacc15	config: add NameRegexp	12 years ago
Mitchell Hashimoto	e922b16dba	Merge pull request #377 from hashicorp/f-path-var ... Add ${path.X} variables for path referencing	12 years ago