63 Commits (a8b126aeffdd1876da51e59a7cc685ad030e86d3)

Author	SHA1	Message	Date
Sarah French	a8b126aeff	Upgrade hashicorp/go-getter dependency (#36326) ... * go get github.com/hashicorp/go-getter@v1.7.8 * Sync deps	1 year ago
dependabot[bot]	e538e0f228	build(deps): bump golang.org/x/net from 0.29.0 to 0.33.0 in /internal/backend/remote-state/s3 (#36298) ... * build(deps): bump golang.org/x/net in /internal/backend/remote-state/s3 Bumps [golang.org/x/net](https://github.com/golang/net) from 0.29.0 to 0.33.0. - [Commits](https://github.com/golang/net/compare/v0.29.0...v0.33.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * chore: make syncdeps --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jared Baker <jared.baker@hashicorp.com>	1 year ago
Jan Harrie	b827ca459e	Upgraded github.com/hashicorp/go-slug v0.16.0 => v0.16.3 (#36273) ... * upgraded github.com/hashicorp/go-slug v0.16.0 => v0.16.3 * updated changelog * removed old entry from go-slug * upgraded github.com/hashicorp/go-slug v0.16.0 => v0.16.3 * upgraded github.com/hashicorp/go-slug v0.16.0 => v0.16.3 * Update CHANGELOG.md --------- Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>	1 year ago
Liam Cervante	fa27595fe3	Update go-cty to 1.16.0 (#36262) ... * Update go-cty to 1.16.0 * syndeps	1 year ago
dependabot[bot]	d2c0a0e992	Bump golang.org/x/crypto from 0.27.0 to 0.31.0 (#36203) ... * Bump golang.org/x/crypto from 0.27.0 to 0.31.0 Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.27.0 to 0.31.0. - [Commits](https://github.com/golang/crypto/compare/v0.27.0...v0.31.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * syncdeps --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Liam Cervante <liam.cervante@hashicorp.com>	1 year ago
James Bardin	762f9334de	make syncdeps	1 year ago
James Bardin	3a1324a811	make syncdeps	1 year ago
James Bardin	1699bc2658	sync deps	1 year ago
James Bardin	198ab3ec7b	update go version	1 year ago
Brandon Croft	18ca2d5a79	make syncdeps	2 years ago
Brandon Croft	2a9b79d423	make syncdeps	2 years ago
James Bardin	a34f51cb3f	update HCL to HEAD ... Includes a fix for this PR, we will update to a tagged version before release.	2 years ago
James Bardin	809fe73b84	update deps to match go1.23 ... Make sure tooling dependencies are updated to use go1.23, and get any closely related package updates, like golang.org/x/*	2 years ago
James Bardin	4b2380ca7c	update to go1.23 ... Release notes: https://go.dev/doc/go1.23	2 years ago
James Bardin	8b1f19d923	update go-cty@v1.15.0	2 years ago
Jamie Finnigan	bbd258bd93	move from Go 1.22.4 to 1.22.5 (#35494)	2 years ago
Jamie Finnigan	54f937cc3c	upgrade github.com/hashicorp/go-retryablehttp & deps (#35473)	2 years ago
Sarah French	125cf53470	Add acceptance and internal tests for `gcs` backend, add some test helper functions (#35026) ... * Add TF_ACC checks in gcs tests, separate from the bucket setup logic * Add tests for handling of `encryption_key` and `kms_encryption_key` * Refactor `setupBackend` to take config as an argument * Add test that asserts that setting credentials to `""` in the config doesn't affect use of ENV-supplied credentials * Move non-acceptance tests into separate test file * Add comment about `getWantValue` * Fix use of t.Parallel * Make `preCheckTestAcc` skip tests, so that checks can pass in hashicorp/terraform PRs * Add precheck for credentials in test environment. Skip if missing, to let checks pass in hashicorp/terraform repo. * Update new test to use precheck functions Move `TestBackendEncryptionKeyEmptyConflict` test to internal test file * Address feedback about how expected encryption key is supplied to test cases * Change test case * Address missing return	2 years ago
Radek Simko	5e3a44fc11	deps: Bump go-getter to v1.7.5 (#35376) ... * deps: Bump go-getter to v1.7.5 * make syncdeps	2 years ago
Liam Cervante	0f0414d484	Fix partial address representation in plan for deferred actions (#34966) ... * Fix partial address representation in plan * reflect new type in stacks	2 years ago
Jamie Finnigan	68ceed40e1	move from Go 1.22.1 to 1.22.4 (#35335)	2 years ago
Martin Atkins	91c88f4705	go.mod: go get github.com/apparentlymart/go-versions@v1.0.2 ... This includes a fix in the handling of conflicting constraints referring to prereleases, like "1.0.0-beta.1, !1.0.0-beta.1". Previously the library would incorrectly treat that as a positive match, rather than having the negative override the positive as happens in all other cases.	2 years ago
Jamie Finnigan	368ccbf63a	make syncdeps	2 years ago
Martin Atkins	660ff86c4c	backendbase: Preserve unset arguments as null when not set by env ... Previously we tried a simplification where any attribute with an "SDK-like default" was guaranteed to never be null, because that seemed like a plausible mimic of the legacy SDK's general aversion to nulls. However, the SDK does still respect the absense of an argument as different to its zero value in one narrow case: when the argument isn't set in the configuration, also isn't set by any environment variables, and has no static fallback default. In that case, the SDK's built-in validation rules such as "ConflictsWith" _do_ treat absent as different from zero-value. To allow backends to continue making such distinctions themselves where that's useful, SDKLikeDefaults now leaves an attribute set to null if it wasn't present in the configuration and none of the environment variables or fallback value cause it to end up being a non-empty string. The backend can then choose to bypass the SDKLikeData API and check the cty.Value directly if it wants to distinguish set from zero even though SDKLikeData is designed to avoid the need to do that. This also updates the gcs backend to make use of the new facility, since it wants to raise an error if two arguments are both set even if they are both set to the empty string. Restoring that original error case is the main motivation for this change.	2 years ago
Martin Atkins	c77898c90d	logging: Remove import github.com/coreos/pkg/capnslog ... We were importing this to resolve an init-time conflict with this library when it was indirectly loaded by the etcd libraries. We removed the etcd backends a while back and so we no longer use any of the etcd modules in Terraform, and so this tricky import was our only remaining reference to github.com/coreos/pkg/capnslog. Dropping this eliminates two unnecessary dependencies.	2 years ago
James Bardin	b79589d2d5	udpate submodule deps	2 years ago
Jamie Finnigan	e9a33de0d2	go get github.com/hashicorp/go-getter && go mod tidy (#35041) ... * go get github.com/hashicorp/go-getter && go mod tidy * make syncdeps	2 years ago
Sebastian Rivera	015f795ff0	Rebrand Terraform Cloud to HCP Terraform	2 years ago
Martin Atkins	5868f99413	backend/gcs: Stop using legacy helper/schema ... As part of our efforts to remove the large snapshot of the legacy SDK that we've been using, this replaces the uses of that package with our new lightweight "backendbase" package, which is a collection of helpers that can substitute for most of the parts of the legacy SDK that backends tend to use. For this backend for now we'll use the "SDK like" helpers which aim to retain some of the legacy-SDK-specific assumptions that aren't technically true anymore, such as the idea that null and empty string are equivalent. Hopefully one day we'll be able to wean this backend off of that more completely, but this is a pragmatic way to get away from the legacy SDK without a large rewrite. This also drew attention to the fact that this backend was previously relying on the weird context.Context value that the SDK was passing in to the configure method, even though that context isn't connected up to anything particularly useful. In the long run we should change the backend APIs to pass context.Context to each method that might make network requests, but for now we're using context.TODO so that we can more easily find these cases and update them later once there's a real context to use.	2 years ago
Martin Atkins	5e7d0f0854	go.mod: Update to latest github.com/zclconf/go-cty-debug ... This extends the "CmpOptions" to include a comparer for cty.Path values, so that we don't have to hand-write that in each case where we're comparing data structures containing those.	2 years ago
Martin Atkins	d3b8a55781	go.mod: go get google.golang.org/protobuf@v1.33.0 ... Many of the changes between these two versions seem to be in parts of the library that Terraform doesn't use, but there are a few sensitive parts: - Slight changes to details of how the library implements the JSON encoding of protobuf. Terraform CLI/Core don't use this, but some of the backends might use it indirectly when talking to their underlying APIs. - Some details of the "protoreflect" package for working with protobuf descriptors dynamically (rather than using generated stubs) have changed, but it seems pretty marginal and unlikely to cause problems.	2 years ago
Martin Atkins	84df5562f2	moduleaddrs: Terraform now owns module source address normalization ... We've been gradually chipping away at how much we use go-getter for source packages, because it's generally been a bit of a nightmare and sharing it with other codebases means that any time someone wants to change something we end up needing to find some way to prevent it breaking Terraform's compatibility promises. Here we make one further step: Terraform owns the "detectors" idea that deals with source address normalization, and now always produces fully-qualified addresses for go-getter to chew on only for the getting and decompressing steps. Retaining go-getter for the actual getting part is helpful because we can then benefit from security fixes upstream, but Terraform owning the first layer of parsing means that we can fix in place the definition of what "module source address" syntax means, and thus we can avoid having everything in this codebase indirectly depend on go-getter just because it wants to parse module source addresses. Now only the module installer actually depends indirectly on go-getter, which finally disconnects go-getter's subtree from all of the remote state backend dependency graphs.	2 years ago
Martin Atkins	78ae6af906	legacy/terraform: Minimize the contents of this legacy package ... At one point we were relying on this for a few different things, but now it's here exclusively to support legacy/helper/schema, the legacy SDK snapshot that is still being used by a few of the remote state backends. The SDK only really needs a tiny portion of the functionality from this package, and by deleting as much of the unused stuff as possible we can reduce the indirect dependencies of this package and thus, in turn, the indirect dependencies of the remote state backends. This also selectively deletes a few parts of the legacy SDK that are focused on providers and provisioners, because we know that we have this here only to support the backends that haven't yet been weaned off it, but we'll save a more adventurous purge of _that_ package for another day.	2 years ago
Martin Atkins	56006416ba	go.mod: go get golang.org/x/tools@v0.19.0 ... We use this just for development-time tools like "stringer", so this upgrade should not have any runtime impact.	2 years ago
Martin Atkins	c541757f4a	go.mod: go get golang.org/x/mod@v0.16.0 ... Aside from development tool dependencies we use this only for the directory hashing logic used to compute go module hashes, which we also use for Terraform provider hashes. There are no changes to the dirhash package in this update, so this should have no runtime impact.	2 years ago
Martin Atkins	b059985227	go.mod: go get golang.org/x/sync@v0.6.0 ... This update only changes a documentation comment, so cannot affect runtime behavior.	2 years ago
Martin Atkins	caa7a757bc	go.mod: go get golang.org/x/oauth2@v0.18.0 ... This only upgrades a Google-specific subpackage, and so the only potential impact is to the GCS backend.	2 years ago
Martin Atkins	9c7ece8ad4	go.mod: go get golang.org/x/net@v0.22.0 ... This update is largely focused on QUIC implementation changes, which do not directly affect Terraform. There is one fix for the HTTP2 implementation to terminate the stream if a sender recieves an out-of-bounds window update, which makes the implementation better match the specification. This seems unlikely to cause any practical problems for Terraform.	2 years ago
Martin Atkins	fad9c2a4cd	go.mod: go get golang.org/x/crypto@v0.21.0 ... This update is mostly internal changes that don't affect external behavior. The only update potentially significant to Terraform is the new exclusion of a particular root certificate that is used only for some specific names under the .tr CCTLD, but the certificate database doesn't specify that constraint in a way that the library can understand, so it's excluded to avoid making the trust for that certificate broader than intended.	2 years ago
Martin Atkins	b3f6a6230d	go.mod: go get golang.org/x/sys@v0.18.0 ... This small update does not directly affect any Terraform functionality.	2 years ago
Martin Atkins	61a5c1f57b	go.mod: go get github.com/hashicorp/terraform-registry-address@v0.2.3 ... This is really just a bunch of changes to the upstream go.mod for updates to its own dependencies, but Terraform already has new enough versions of those dependencies for other reasons and so this changes nothing.	2 years ago
Martin Atkins	8603ee0ab5	go.mod: go get github.com/hashicorp/go-slug@v0.14.0 ... This has just some changes to the "sourcebundle" building API, which doesn't affect Terraform CLI or Terraform Core because they currently only consume source bundles, not build them.	2 years ago
Martin Atkins	914618b061	gcs: Adopt the "ReadPathOrContents" helper function ... Package backend previously had a ReadPathOrContents helper that takes a string that could represent either a filename or some literal content, and then reads the given file if it's a filename or just returns the literal content otherwise. We originally used variations of this helper to shim a number of different situations that had originally accepted filenames but later changed to accept literal content, but over time we've eliminated all of those and so the only remaining caller is the gcs backend which uses it to accept GCP credentials either as literal content or as a file containing the credentials. Therefore here we move that helper function to be just an unexported part of the gcs backend package. This is part of an ongoing effort to minimize what each remote state backend depends on (either directly or indirectly) so that we can make gradual progress towards these remote state backends being self-contained enough to move into other codebases. In the short term though, it just puts this helper function closer to its caller so it's easier to maintain them both together if needed.	2 years ago
Martin Atkins	f058de612c	statemgr: Incorporate IntermediateStateConditionalPersister ... This interface was originally in the local backend's package because that backend is the only one that _truly_ runs Terraform operations and thus needs to negotiate how to store the intermediate state snapshots that result from them. However, putting the interface and its supporting types/functions there means that anything that wants to implement this interface needs to import the local backend package, and thus indirectly depends on the entire modules runtime, etc. We already had package stagemgr as a home for the shared stuff used by most state storage managers, and so we'll just move these symbols over there and then we can shed some internal dependencies on package local. This also severs the last dependency link between the remote state backends and the modules runtime, allowing us to shed a bunch of indirect dependencies from those remote state backends.	2 years ago
Martin Atkins	5f2eab6944	providerreqs: Provider requirement/version types in their own package ... As we previously found with "package addrs", any package that contains types used as identifiers or addresses tends to get imported from all over, which means that if we mix real logic with those types in the same package then a lot more packages end up depending indirectly on our external dependencies. In this case, the getproviders package depends on various things we need only during provider installation, such as the library we use for GPG signature verification. Lots of different packages in Terraform need to talk about provider requirements, but only the CLI layer actually needs to do provider installation, and so this commit splits the types we use to talk about requirements into a new package "providerreqs", which package getproviders then depends on. To keep the size of this diff relatively small to start I've left forwarding aliases in package getproviders, which means that not all of the callers needed to be updated all at once. This commit does update all of the packages that the remote state backends depend on though, because that then allows us to reduce the set of indirect dependencies for each of those backends. The nested module go.mod files show that this has disconnected the indirect dependencies on github.com/ProtonMail/go-crypto and on github.com/cloudflare/circl , both of which Terraform CLI uses only for provider installation.	2 years ago
Martin Atkins	5811be26f8	go.mod: Separate modules at code ownership boundaries ... Historically it's been hard for us to keep on top of dependency upgrades as a matter of course because it's unclear which code owners might be affected by or responsible for an upgrade of each module. After trying a few different techniques to try to mitigate this, the most promising one seems to be to tell the Go toolchain that each of these components is a separate Go module, but then to stitch them all back together again using replace directives so that we can mostly ignore these module boundaries in everyday development. The one case where we _do_ need to pay attention to these boundaries is also the case where the separation is useful: upgrading a dependency of any one of these modules might potentially force upgrading it for another module too, and so the Go toolchain will help us notice that interaction and we can immediately which code owners might need to be involved in reviewing and testing that particular upgrade. To make that process less onerous, this adds a new makefile target "make syncdeps" which runs "go mod tidy" in all of the modules at once and thus forces the toolchain to align their dependencies to the extent required for them all to be linked together successfully, and to generate go.mod and/or go.sum diffs that will match our configured code ownership paths to trigger the appropriate code review requests. Hopefully before too long we'll be able to move all the backends out into provider plugins and delete the "legacy" module entirely and then this oddness won't be needed anymore, but as long as we're all trying to play together in this same sandbox this is a small amount of extra ceremony in return for hopefully reducing the level of anxiety involved in keeping the system's dependencies up to date more consistently.	2 years ago
Martin Atkins	1358245617	dependencies: Remove all non-legacy uses of hashicorp/go-multierror ... This functionality is now provided by the "errors" package in the standard library, so the HashiCorp-specific library is obsolete. This also removed our one direct use of github.com/pkg/errors, which we were using in a way that was totally redundant with the stdlib package errors. However, it lives on as an indirect dependency through the Consul backend's dependency on the Consul SDK, which uses that library.	2 years ago
hashicorp-copywrite[bot]	53c34ff49c	Update copyright file headers to BUSL-1.1	3 years ago
hashicorp-copywrite[bot]	325d18262e	[COMPLIANCE] Add Copyright and License Headers	3 years ago
bharathkkb	05ff3c3278	Add a GCS backend specific env var for impersonation	3 years ago