1075 Commits (a5ef403dfd46121baadef1c69c7b9b83fccdcda5)

Author	SHA1	Message	Date
Sander van Harmelen	7ec3f96e3a	command/state: update and fix the state mv command	7 years ago
Sander van Harmelen	19c1241a50	command/state: update and fix the state rm command	7 years ago
James Bardin	e93d69f18b	more nil/known checks before val.LengthInt	7 years ago
Sander van Harmelen	536c2fe6f1	Make `state mv` use the new `states.Filter`	7 years ago
Sander van Harmelen	5e11de460a	Merge pull request #19130 from hashicorp/f-state-push-pull ... command/state: update and fix the state push and pull	7 years ago
Sander van Harmelen	7fbd93b5cd	command/state: update and fix the state push and pull	7 years ago
Sander van Harmelen	a88ba31b63	Merge pull request #19129 from hashicorp/f-show-list ... command/state: update and fix the state list command	7 years ago
Sander van Harmelen	83168ea25f	Merge pull request #19127 from hashicorp/b-prepare-provider ... Make the test compile again	7 years ago
Sander van Harmelen	af1a471a05	command/state: update and fix the state list command	7 years ago
Sander van Harmelen	4d6626b3a8	Terraform show didn’t show absolute paths ... Without using absolute paths any module info is lost in the output. And the attributes were randomly ordered and so changed between different executions of the command.	7 years ago
Sander van Harmelen	b846c5f653	Make the test compile again ... Not sure if these checks still make sense, but without this change the test don’t compile for the related packages.	7 years ago
Martin Atkins	17b883f592	command/format: Include variable values in diagnostic messages ... When HCL encounters an error during expression evaluation, it annotates its diagnostics with information about the expression that was being evaluated and the EvalContext it was evaluated in. This gives us enough information to show helpful hints to the user about the final values of any reference expressions that are present in the expression, which is very useful extra context for expressions that get evaluated multiple times, such as: - Any expression in a block with "count" or "for_each" set - The sub-expressions within a "for" expression	7 years ago
James Bardin	e08a388d3c	check IsKnown on values that may panic	7 years ago
Sander van Harmelen	48ef7ecfa6	Updates after running `make fmt` with Go v1.11.1	7 years ago
James Bardin	fe9ed37dfc	minor fixes for command Apply tests	7 years ago
Martin Atkins	541952bb8f	Revert some work that happened since v0.12-dev branched ... This work was done against APIs that were already changed in the branch before work began, and so it doesn't apply to the v0.12 development work. To allow v0.12 to merge down to master, we'll revert this work out for now and then re-introduce equivalent functionality in later commits that works against the new APIs.	7 years ago
Martin Atkins	8e51363f04	command: Don't allow -var and -var-file when applying saved plan ... This reinstates an old behavior that was lost in the reorganization of how we deal with the -var and -var-file options. This fix is verified by TestApply_planVars now passing.	7 years ago
Martin Atkins	7abf81d8da	command: Restore support for terraform.tfvars.json ... In the new implementation of collecting variables I initially forgot the JSON variant of terraform.tfvars. This fix is verified by TestApply_varFileDefaultJSON now passing.	7 years ago
Martin Atkins	66f96cf842	command: Un-stub and reimplement "terraform state rm" ... This was previously targeting the old state manager and state types, so it needed some considerable rework to get it working again with the new state types. Since our new resource address syntax lacks the weird extra .deposed special case we had before, we instead interpret addresses as whole-instance addresses here and remove the deposed objects along with the current one (if present), since this is more likely to match with user expectations because we don't consider deposed objects to be independently addressable in any other situation. With that said, to be more explicit about what is going on we do now have a -dry-run mode and maintain separate counts of current and deposed instances so that we can expose that in the UI where relevant.	7 years ago
Martin Atkins	40eda180d6	command: go fmt in import_test.go and refresh_test.go	7 years ago
Martin Atkins	8b466811d2	command: Fix a few tests from meta_backend_test.go	7 years ago
Martin Atkins	86b7963bba	command: Fix tests for "terraform providers"	7 years ago
Martin Atkins	5b61cc919b	command: Fix "terraform import" tests	7 years ago
Martin Atkins	7b77e20bdc	command: Fix several "terraform init" tests	7 years ago
Martin Atkins	89d0944e5b	command: Fix even more of the "terraform refresh" tests	7 years ago
Martin Atkins	5d1d6a95f9	command: "go fmt" of plan_test.go	7 years ago
Martin Atkins	e54848b86f	command: Fix many (but not all) "terraform refresh" tests	7 years ago
Martin Atkins	73abb6e8f4	command: Re-enable showing outputs after successful "apply" ... We temporarily disabled this because it needed some further work to update it for the new state models, which has now been done. We no longer need the configuration objects for the outputs because the state itself contains all of the information needed for displaying these.	7 years ago
Martin Atkins	98bbd560b5	command: Fix most (but not all) "terraform plan" tests	7 years ago
Martin Atkins	ca314afc0d	command: Make suitable provider schemas available for all "plan" tests	7 years ago
Martin Atkins	73318a436b	command: go fmt	7 years ago
Martin Atkins	53bb3f57e6	command: Remove tests related to legacy remote state migrations, etc ... We no longer support legacy remote state, so the behaviors these tests were covering are no longer present.	7 years ago
Martin Atkins	275a44f552	command: Reinstate object ids in the UIHook progress logs ... We used to treat the "id" attribute of a resource as special and elevate it into its own struct field "ID" in the state, but the new state format and provider protocol treats it just as any other attribute. However, it's still useful to show the value of a single identifying attribute when there isn't room in the UI for showing all of the attributes, and so here we take a new strategy of considering "id" along with some other conventional names as special only in the UI layer. This new heuristic approach can be adjusted over time as new provider patterns emerge, but for now it covers some common conventions we've seen in real providers. With that said, since all existing providers made for Terraform versions prior to v0.12 were forced to set "id", we won't see any use of other attributes here until providers are updated to remove the placeholder ids they were generating in cases where an id was not actually relevant but was forced by the old protocol. At that point the UX should be improved by showing a more relevant attribute instead. We now also allow for the possibility of no id at all, since that is valid for resources that exist only within the Terraform state, like the ones from the "random" and "tls" providers.	7 years ago
Martin Atkins	43d5206d82	command: Stub the "terraform state mv" tests to remind to fix ... This command isn't yet updated for the new state types, but since we were not returning a non-successful error status here the tests were just failing in a weird way instead. Now we'll fail with a message that makes it clear there is still work to do in the real implementation here.	7 years ago
Martin Atkins	1d64ce8ec0	command: Fix "terraform validate" tests ... We now need to give a provider schema that the test fixtures conform to, so we can validate against it.	7 years ago
Martin Atkins	025540789c	command: Restore the "terraform output" functionality ... We previously stubbed most of this out because it hadn't yet been updated to support the new state types, etc. This restores all of the previous behavior as covered by the tests. We intentionally remove one behavior that was not covered by the tests: we used to allow retrieval of outputs from non-root modules using the -module option, but since we no longer persist non-root outputs in the state we can no longer support this without a full expression evaluation walk, and that'd be overkill for this otherwise-simple command. Descendant module outputs are not part of the public interface of a configuration anyway, so accessing them from outside in this way is an anti-pattern. (For debugging scenarios it is still possible to access these from "terraform console", which _does_ do a full evaluation graph walk to prepare its evaluation scope.)	7 years ago
Martin Atkins	feff10dcb5	command: Fix TestGraph_plan ... The plan file writer requires a backend config to be present, but we don't really need one for the sake of _this_ test, since we don't activate the backend to render a plan graph, and so we just write in a placeholder.	7 years ago
Martin Atkins	c0baedac84	command: Fix tests for "terraform fmt" command ... Some underlying assumptions have shifted here, so although the behavior is still broadly the same we need to accommodate some different details.	7 years ago
Martin Atkins	74582447bb	command: Make input variable values available to "terraform console" ... This fixes TestConsole_tfvars.	7 years ago
Martin Atkins	741d334ee4	command: Even more fixes for "apply" command tests	7 years ago
Martin Atkins	34a29315f7	command: More fixes (but still not all) for "apply" command tests	7 years ago
Martin Atkins	de3944b9bf	command: collect root module variable values for apply/plan/refresh ... This connects a missing link left by earlier refactoring: the command package is responsible for gathering up variable values provided by the user and passing them through to the backend to use in operations.	7 years ago
Martin Atkins	fc2614c939	command: Fix some tests for the "apply" command	7 years ago
Martin Atkins	34c4fd316d	command: Update backend-unchanged fixture for new expectations ... Our serialization of the backend configuration has changed slightly for Terraform 0.12 due to reimplementing it in terms of the HCL2 types, so the base case that should be unchanged during the test needs to be changed.	7 years ago
Martin Atkins	34ebde0b95	command/format: be resilient to incomplete schema when formatting state ... In all real cases the schemas should be populated here, but we don't want to panic in UI rendering code if there's a bug here. This can also be tripped up by tests with incomplete mocks. It's unfortunate that this can therefore mask some problems in tests, but tests can protect against it by asserting on specific output text rather than just assuming that a zero exit status is a pass.	7 years ago
Kristin Laemmert	3cf1b001c2	command/format: revert indentation change for consistency's sake	7 years ago
Kristin Laemmert	db26324b3c	command/format: fix indentation ... also run go mod tidy	7 years ago
Martin Atkins	d63c2fdd8d	command: Show snippet of invalid resource addresses in import ... If we fail to parse the resource address given to "terraform import" then it's helpful to produce a "source code" snippet of what the user provided so they might see more precisely which part of the address was invalid.	7 years ago
Martin Atkins	27d086d8bd	command: Fix TestUntaint	7 years ago
Martin Atkins	1bc10180cb	command: Fix all of the "taint" command tests ... Most of this is just updates to allow for the fact that we now always save the provider address as part of resource state, whereas before it was only saved conditionally. This also updates TestTaint_module for the intentional change that it now expects a child module to be specified using normal resource address syntax, rather than as a separate -module option.	7 years ago