50 Commits (9b6fcc4e86556590df67fd9d02fa504fc8a3a5f2)

Author	SHA1	Message	Date
Alex Pilon	4bf43efcfd	move hcl2shim package to configs	7 years ago
Alex Pilon	83aa07f907	prune NewResourceConfig and update tests	7 years ago
Radek Simko	1cb8f1df80	helper/schema: Fix timeout parsing in ResourceTimeout.ConfigDecode	8 years ago
James Bardin	b88410984b	legacy provider needs to handle StateUpgraders ... In order to not require state migrations to be supported in both MigrateState and StateUpgraders, the legacy provider codepath needs to handle the StateUpgraders transparently during Refresh.	8 years ago
James Bardin	7d24936507	updates to teh StateUpgraders ... Fix documentation. Require StateUpgraders to be add in order, and test in validation.	8 years ago
James Bardin	0c33b26e04	StateUpgrade redux ... It turns out that state upgrades need to be handled differently since providers are going to be backwards compatible. This means that new state upgrades may still be stored in the flatmap format when used wih terraform 0.11. Because we can't account for the specific version which could produce a legacy state, all future state upgrades need to record the schema types for decoding. Rather than defining a single Upgrade function for states, we now have a list of functions, each of which handle upgrading a specific version to the next. In practice this isn't much different from the way many resources implement upgrades themselves, with a separate function for each version dispatched from the MigrateState function. The only added burden is the recording of the schema type, and we intend to supply tools and helper function to prevent the need to copy the entire existing schema in all cases.	8 years ago
James Bardin	9eef5e3f91	implement UpgradeState for schema.Resource ... This is the provider-side UpgradeState implementation for a particular resource. This new function will be called to upgrade a saved state with an old schema version to the current schema. UpgradeState also requires a record of the last schema and version that could have been stored as a flatmapped state. If the stored state is in the legacy flatmap format, this will allow the provider to properly decode the flatmapped state into the expected structure for the new json encoded state. If the stored state's version is below that of the LegacySchema.Version value, it will first be processed by the legacy MigrateState function.	8 years ago
Paddy Carver	b7d19e40f8	Deprecated -> DeprecationMessage. ... At the Enablement team's request, change from using `Deprecated` to `DeprecationMessage`, as it's a string value, not a boolean.	8 years ago
Paddy Carver	0dd2408d65	Export resource deprecation. ... We already had the functionality to make resources deprecated, which was used when migrating resources to data sources, but the functionality was unexported, so only the schema package could do it. Now it's exported, meaning providers can mark entire resources as deprecated. I also added a test in hopefully-the-right place?	8 years ago
James Bardin	798df9dafa	make sure ResourceData timeouts are always set ... Return the global default timeout if the ResourceData timeouts are nil. Set the timeouts from the Resource when calling Resource.Data, so that the config values are always available.	8 years ago
Chris Marchesi	0c0ae3ca7c	helper/schema: CustomizeDiff allowed on writable resources only ... This keeps CustomizeDiff from being defined on data sources, where it would be useless. We just catch this in InternalValidate like the rest of the CRUD functions that are not used in data sources.	9 years ago
Chris Marchesi	529d7e6dae	helper/schema: Review -> CustomizeDiff ... Restoring the naming of this field in the resource back to CustomizeDiff, as this is generally more descriptive of the process that's happening, despite the lengthy name.	9 years ago
Chris Marchesi	c6647a3bb7	helper/schema: CustomizeDiff -> Review ... To keep with the current convention of most other schema.Resource functional fields being fairly short, CustomizeDiff has been changed to "Review". It would be "Diff", however it is already used by existing functions in schema.Provider and schema.Resource.	9 years ago
Chris Marchesi	fa1fc2ca8e	helper/schema: CustomizeDiff invocation test ... Just one more test to check to make sure that CustomizeDiff is called on resource level.	9 years ago
Chris Marchesi	8af9610b87	helper/schema: Hook CustomizeDiffFunc into diff logic ... It's alive! CustomizeDiff logic now has been inserted into the diff process. The test_resource_with_custom_diff resource provides some basic testing and a reference implementation. There should now be plenty of test coverage for this feature via the tests added for ResourceDiff, and the basic test added to the schemaMap.Diff test, and the test resource, but more can be added to test any specific case that comes up otherwise.	9 years ago
Radek Simko	7fceccfbf7	helper/schema: Loosen validation for 'id' field	9 years ago
Radek Simko	07cbd54fbc	Actively disallow reserved field names in schema (#15522)	9 years ago
clint shryock	11dc0c5fdf	Regression test for #767 (https://github.com/hashicorp/terraform/issues/14444)	9 years ago
Clint	3fdeacdca7	helper/schema: Rename Timeout resource block to Timeouts (#12533) ... helper/schema: Rename Timeout resource block to Timeouts - Pluralize configuration argument name to better represent that there is one block for many timeouts - use a const for the configuration timeouts key - update docs	9 years ago
Clint	2fe5976aec	helper/schema: Add configurable Timeouts (#12311) ... * helper/schema: Add custom Timeout block for resources * refactor DefaultTimeout to suuport multiple types. Load meta in Refresh from Instance State * update vpc but it probably wont last anyway * refactor test into table test for more cases * rename constant keys * refactor configdecode * remove VPC demo * remove comments * remove more comments * refactor some * rename timeKeys to timeoutKeys * remove note * documentation/resources: Document the Timeout block * document timeouts * have a test case that covers 'hours' * restore a System default timeout of 20 minutes, instead of 0 * restore system default timeout of 20 minutes, refactor tests, add test method to handle system default * rename timeout key constants * test applying timeout to state * refactor test * Add resource Diff test * clarify docs * update to use constants	9 years ago
Mitchell Hashimoto	3342aa580c	terraform: InstanceState.Meta is value type interface{} ... This changes the type of values in Meta for InstanceState to `interface{}`. They were `string` before. This will allow richer structures to be persisted to this without flatmapping them (down with flatmap!). The documentation clearly states that only primitives/collections are allowed here. The only thing using this was helper/schema for schema versioning. Appropriate type checking was added to make this change safe. The timeout work @catsby is doing will use this for a richer structure.	9 years ago
Mitchell Hashimoto	f7a234bc71	helper/schema: validate Read, Delete are set	10 years ago
James Nugent	074545e536	core: Use .% instead of .# for maps in state ... The flatmapped representation of state prior to this commit encoded maps and lists (and therefore by extension, sets) with a key corresponding to the number of elements, or the unknown variable indicator under a .# key and then individual items. For example, the list ["a", "b", "c"] would have been encoded as: listname.# = 3 listname.0 = "a" listname.1 = "b" listname.2 = "c" And the map {"key1": "value1", "key2", "value2"} would have been encoded as: mapname.# = 2 mapname.key1 = "value1" mapname.key2 = "value2" Sets use the hash code as the key - for example a set with a (fictional) hashcode calculation may look like: setname.# = 2 setname.12312512 = "value1" setname.56345233 = "value2" Prior to the work done to extend the type system, this was sufficient since the internal representation of these was effectively the same. However, following the separation of maps and lists into distinct first-class types, this encoding presents a problem: given a state file, it is impossible to tell the encoding of an empty list and an empty map apart. This presents problems for the type checker during interpolation, as many interpolation functions will operate on only one of these two structures. This commit therefore changes the representation in state of maps to use a "%" as the key for the number of elements. Consequently the map above will now be encoded as: mapname.% = 2 mapname.key1 = "value1" mapname.key2 = "value2" This has the effect of an empty list (or set) now being encoded as: listname.# = 0 And an empty map now being encoded as: mapname.% = 0 Therefore we can eliminate some nasty guessing logic from the resource variable supplier for interpolation, at the cost of having to migrate state up front (to follow in a subsequent commit). In order to reduce the number of potential situations in which resources would be "forced new", we continue to accept "#" as the count key when reading maps via helper/schema. There is no situation under which we can allow "#" as an actual map key in any case, as it would not be distinguishable from a list or set in state.	10 years ago
Martin Atkins	6a468dcd83	helper/schema: Resource can be writable or not ... In the "schema" layer a Resource is just any "thing" that has a schema and supports some or all of the CRUD operations. Data sources introduce a new use of Resource to represent read-only resources, which require some different InternalValidate logic.	10 years ago
Mitchell Hashimoto	b728e55861	helper/schema: Resource.Data should set latest schema version	10 years ago
Mitchell Hashimoto	b8121ea63e	helper/schema: Resource.Data to return a ResourceData for a Resource	10 years ago
Radek Simko	4c6ceef9b8	helper/schema: Allow identification of a new resource in update func	10 years ago
Panagiotis Moustafellos	e4845f75cc	removed extra parentheses	11 years ago
Radek Simko	641b701830	schema: Make validation more strict	11 years ago
Paul Hinze	7eb72e7a12	helper/schema: record schema version when destroy fails ... This was just a missed exit from the resource.Apply function - subsequent refreshes would add the SchemaVersion back into the state, but having the state recorded once without the meta information can cause problems with Atlas's remote state checksumming.	11 years ago
Mitchell Hashimoto	dd24ed4b76	helper/schema: blank ID refresh doesn't exist [GH-1905]	11 years ago
Justin Campbell	bb14bfa657	helper/schema: call InternalValidate w/ schemaMap{}	11 years ago
Paul Hinze	3ba8ed536b	helper/schema: record schema version on apply ... We were previously only recording the schema version on refresh. This caused the state to be incorrectly written after a `terraform apply` causing subsequent commands to run the state through an unnecessary migration.	11 years ago
Paul Hinze	3d4b55e557	helper/schema: schema versioning & migration ... Providers get a per-resource SchemaVersion integer that they can bump when a resource's schema changes format. Each InstanceState with an older recorded SchemaVersion than the cureent one is yielded to a `MigrateSchema` function to be transformed such that it can be addressed by the current version of the resource's Schema.	11 years ago
Mitchell Hashimoto	466a54cfe4	Merge pull request #766 from hashicorp/f-exists-api ... helper/schema: Exists API	11 years ago
Mitchell Hashimoto	448887f3c4	helper/schema: map counts in state	11 years ago
Mitchell Hashimoto	48b9614556	helper/schema: Exists API	11 years ago
Mitchell Hashimoto	d0ce67a5b7	helper/schema: on destroy/create, reset state to be empty [GH-464]	12 years ago
Mitchell Hashimoto	9b2b3a963f	ResourceDiff => InstanceDiff	12 years ago
Mitchell Hashimoto	81d9d70296	helper/schema: conforms to new API, tests pass	12 years ago
Mitchell Hashimoto	5fc41cc272	helper/schema: properly put "id" into attributes	12 years ago
Mitchell Hashimoto	021a23fe99	helper/schema: if update sets the ID to blank, it deletes the resource	12 years ago
Mitchell Hashimoto	2444986fe8	helper/schema: nice error if update isn't supported	12 years ago
Mitchell Hashimoto	c418681cc3	helper/schema: create/update/delete should work for Resource	12 years ago
Mitchell Hashimoto	894187ec18	helper/schema: Resource.Refresh	12 years ago
Mitchell Hashimoto	51a44db6c2	helper/schema: move InternalValidate to schemaMap	12 years ago
Mitchell Hashimoto	a33e4bcdf0	helper/schema: properly validate sub-resources	12 years ago
Mitchell Hashimoto	7bc0be4b81	helper/schema: couple more tests around Computed (+ fix)	12 years ago
Mitchell Hashimoto	7f14708e71	helper/schema: list ForceNew	12 years ago
Mitchell Hashimoto	01b6b5f48e	helper/schema: initial work	12 years ago