20 Commits (94de72c63834acea811c27a585c19eae29374a4b)

Author	SHA1	Message	Date
James Bardin	371660ab8f	cleanup panic output	4 years ago
James Bardin	583e3a5f0b	use 11 for the panic exit code	5 years ago
James Bardin	bd37f43daa	add note about calling PanicHandler first	5 years ago
James Bardin	d03a037567	insert panic handlers	5 years ago
James Bardin	3f31533f86	logging.PanicHandler can now be for internal use ... Repurpose logging.PanicHandler to recover internal panics and print a message to users similar to panicwrap.	5 years ago
Kevin Burke	c047958b57	go.mod,backend: update coreos/etcd dependency to release-3.4 branch ... etcd rewrote its import path from coreos/etcd to go.etcd.io/etcd. Changed the imports path in this commit, which also updates the code version. This lets us remove the github.com/ugorji/go/codec dependency, which was pinned to a fairly old version. The net change is a loss of 30,000 lines of code in the vendor directory. (I first noticed this problem because the outdated go/codec dependency was causing a dependency failure when I tried to put Terraform and another project in the same vendor directory.) Note the version shows up funkily in go.mod, but I verified visually it's the same commit as the "release-3.4" tag in github.com/coreos/etcd. The etcd team plans to fix the release version tagging in v3.5, which should be released soon.	5 years ago
James Bardin	feb7622846	monitor plugin std outputs for unexpected data ... Once a plugin process is started, go-plugin will redirect the stdout and stderr stream through a grpc service and provide those streams to the client. This is rarely used, as it is prone to failing with races because those same file descriptors are needed for the initial handshake and logging setup, but data may be accidentally sent to these nonetheless. The usual culprits are stray `fmt.Print` usage where logging was intended, or the configuration of a logger after the os.Stderr file descriptor was replaced by go-plugin. These situations are very hard for provider developers to debug since the data is discarded entirely. While there may be improvements to be made in the go-plugin package to configure this behavior, in the meantime we can add a simple monitoring io.Writer to the streams which will surface th data as warnings in the logs instead of writing it to `io.Discard`	5 years ago
Paddy	0b5c4a6a2c	Accept TF_LOG=json to enable TRACE logs in JSON format ... This is not currently a supported interface, but we plan to release tool(s) that consume parts of it that are more dependable later, separately from Terraform CLI itself.	5 years ago
Jonathan Hall	49ee3d3ef8	Grammar nit: "setup" as a verb should be spelled "set up"	5 years ago
James Bardin	d52e17e111	hide provider crashes from panicwrap when logging ... When logging is turned on, panicwrap will still see provider crashes and falsely report them as core crashes, hiding the formatted provider error. We can trick panicwrap by slightly obfuscating the error line.	6 years ago
James Bardin	3225d9ac11	record all plugin panics, and print on main exit ... Create a logger that will record any apparent crash output for later processing. If the cli command returns with a non-zero exit status, check for any recorded crashes and add those to the output.	6 years ago
James Bardin	f8893785f0	separate core and provider loggers ... Now that hclog can independently set levels on related loggers, we can separate the log levels for different subsystems in terraform. This adds the new environment variables, `TF_LOG_CORE` and `TF_LOG_PROVIDER`, which each take the same set of log level arguments, and only applies to logs from that subsystem. This means that setting `TF_LOG_CORE=level` will not show logs from providers, and `TF_LOG_PROVIDER=level` will not show logs from core. The behavior of `TF_LOG` alone does not change. While it is not necessarily needed since the default is to disable logs, there is also a new level argument of `off`, which reflects the associated level in hclog.	6 years ago
James Bardin	c2af5333e8	use a log sink to capture logs for panicwrap ... Use a separate log sink to always capture trace logs for the panicwrap handler to write out in a crash log. This requires creating a log file in the outer process and passing that path to the child process to log to.	6 years ago
James Bardin	b61488a8ba	write traceback to log crash log	6 years ago
James Bardin	1d9d82973b	move panicwrap handler to logging package	6 years ago
James Bardin	a3a20e0396	remove LevelFilter ... We want to always be using the hclogger to filter whenever possible	6 years ago
James Bardin	0b31ffa587	use a single log writer ... Use a single log writer instance for all std library logging. Setup the std log writer in the logging package, and remove boilerplate from test packages.	6 years ago
James Bardin	abf6b9b378	get properly configured hcloggers ... make sure plugins get hcloggers configured to match core	6 years ago
James Bardin	211edf5d75	use hclog as the default logger ... Inject hclog as the default logger in the main binary.	6 years ago
James Bardin	6ca477f042	move helper/logging to internal ... remove a dead code file too	6 years ago