102 Commits (94de72c63834acea811c27a585c19eae29374a4b)

Author	SHA1	Message	Date
James Bardin	953c448f9a	add simple error indicating backend removal ... There are no good options for inserting diagnostics into the backend lookup, or creating a backend which reports it's removal because none of the init or GetSchema functions return any errors. Keep a registry of the removed backend so that we can at least notify users that a backend was removed vs an invalid name.	4 years ago
James Bardin	799ab6c951	remove deprecated etcd backend ... This allows us to remove the manual replace directives github.com/dgrijalva/jwt-go and google.golang.org/grpc, so that we can remove the CVE warnings and update the grpc packages. While the etcdv3 backend is also marked as deprecated, the changes here are done in a manner to keep that backend working for the time being.	4 years ago
Nicolas Vanheuverzwijn	bb1c134b94	http-backend: http backend lock error return LockError instead of generic error	4 years ago
Kagashino	cab6cee385	fix: backend/cos - remove cos object write lock either when unlock state file	4 years ago
James Bardin	0c7d39aca5	deprecate unmaintained backends	4 years ago
Anna Winkler	22c121df86	Bump compatibility version to 1.3.0 for terraform core release (#30988) ... * Bump compatibility version to 1.3.0 for terraform core release Co-authored-by: Brandon Croft <brandon.croft@gmail.com>	4 years ago
James Bardin	df0a70bfb6	check for cancellation before apply confirmation ... When executing an apply with no plan, it's possible for a cancellation to arrive during the final batch of provider operations, resulting in no errors in the plan. The run context was next checked during the confirmation for apply, but in the case of -auto-approve that confirmation is skipped, resulting in the canceled plan being applied. Make sure we directly check for cancellation before confirming the plan.	4 years ago
Tom Bamford	d08bc4463d	Azure Backend: support OIDC authentication	4 years ago
Keith Clawson	23dffee568	Always use token in backend config when provided	4 years ago
Tom Harvey	2eb9118cd1	backend/remote-state/azure: defaulting the Azure Backend to use MSAL (#30891) ... * backend/remote-state/azure: defaulting the Azure Backend to use MSAL Fixes #30881 * backend/remote-state/azurerm: deprecating `use_microsoft_graph`	4 years ago
Eng Zer Jun	fedd315275	test: use `T.TempDir` to create temporary test directory (#30803) ... This commit replaces `ioutil.TempDir` with `t.TempDir` in tests. The directory created by `t.TempDir` is automatically removed when the test and all its subtests complete. Prior to this commit, temporary directory created using `ioutil.TempDir` needs to be removed manually by calling `os.RemoveAll`, which is omitted in some tests. The error handling boilerplate e.g. defer func() { if err := os.RemoveAll(dir); err != nil { t.Fatal(err) } } is also tedious, but `t.TempDir` handles this for us nicely. Reference: https://pkg.go.dev/testing#T.TempDir Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>	4 years ago
Lars Lehtonen	88c9b90c93	internal/backend/remote-state/oss: fix dropped error (#30352)	4 years ago
Luces Huayhuaca	bdc7d8c0a1	Upgrade go-tfe dependency to use 1.0 version. It contains breaking changes, so we are updating method signatures, method names and the type of optional parameters, as needed. (#30626)	4 years ago
Theo Chupp	d15a2bc024	fix: local variables should not be overridden by remote variables during `terraform import` (#29972) ... * fix: local variables should not be overridden by remote variables during `terraform import` * chore: applied the same fix in the 'internal/cloud' package * backport changes from cloud package to remote package Co-authored-by: Alisdair McDiarmid <alisdair@users.noreply.github.com> Co-authored-by: uturunku1 <luces.huayhuaca@gmail.com>	4 years ago
Krista LaFentres (she/her)	6dcf00aefc	Merge pull request #30344 from hashicorp/lafentres/refactor-show-command ... cli: Refactor show command & migrate to command arguments and views	4 years ago
Krista LaFentres	64e1241ae3	backend/local: Remove unused DisablePlanFileStateLineageChecks flag ... Now that show command has been refactored to remove its dependence on a local backend and local run, this flag is no longer needed to fix #30195.	4 years ago
Martin Atkins	36c4d4c241	core and backend: remove redundant handling of default variable values ... Previously we had three different layers all thinking they were responsible for substituting a default value for an unset root module variable: - the local backend, via logic in backend.ParseVariableValues - the context.Plan function (and other similar functions) trying to preprocess the input variables using terraform.mergeDefaultInputVariableValues . - the newer prepareFinalInputVariableValue, which aims to centralize all of the variable preparation logic so it can be common to both root and child module variables. The second of these was also trying to handle type constraint checking, which is also the responsibility of the central function and not something we need to handle so early. Only the last of these consistently handles both root and child module variables, and so is the one we ought to keep. The others are now redundant and are causing prepareFinalInputVariableValue to get a slightly corrupted view of the caller's chosen variable values. To rectify that, here we remove the two redundant layers altogether and have unset root variables pass through as cty.NilVal all the way to the central prepareFinalInputVariableValue function, which will then handle them in a suitable way which properly respects the "nullable" setting. This commit includes some test changes in the terraform package to make those tests no longer rely on the mergeDefaultInputVariableValues logic we've removed, and to instead explicitly set cty.NilVal for all unset variables to comply with our intended contract for PlanOpts.SetVariables, and similar. (This is so that we can more easily catch bugs in callers where they _don't_ correctly handle input variables; it allows us to distinguish between the caller explicitly marking a variable as unset vs. not describing it at all, where the latter is a bug in the caller.)	4 years ago
Alisdair McDiarmid	768741c0f7	command/show: Disable plan state lineage checks ... When showing a saved plan, we do not need to check the state lineage against current state, because the plan cannot be applied. This is relevant when plan and apply specify a `-state` argument to choose a non-default state file. In this case, the stored prior state in the plan will not match the default state file, so a lineage check will always error.	4 years ago
James Bardin	8c4031ef15	don't persist a nil state from Apply ... Apply should not return a nil state to be persisted.	4 years ago
Chris Arcand	f521ba6cd7	Remove 'enhanced' backend type distinction ... As explained in the changes: The 'enhanced' backend terminology, which only truly pertains to the 'remote' backend with a single API (Terraform Cloud/Enterprise's), has been found to be a confusing vestige which need only be explained in the context of the 'remote' backend. These changes reorient the explanation(s) of backends to pertain more directly to their primary purpose, which is storage of state snapshots (and not implementing operations). That Terraform operations are still _implemented_ by the literal `Backend` and `Enhanced` interfaces is inconsequential a user of Terraform, an internal detail.	4 years ago
Katy Moe	b1c071bb57	pass hclog logger to retryable client	4 years ago
Tom Harvey	a1c7c0dfa4	Update internal/backend/remote-state/azure/backend.go ... Co-authored-by: Tom Bamford <tbamford@hashicorp.com>	4 years ago
tombuildsstuff	ffe9a41468	internal/backend/remote-state/azure: adding tests covering MSAL	4 years ago
tombuildsstuff	a2cad7d579	internal/backend/remote-state/azure: prefixing the existing tests with ADAL	4 years ago
tombuildsstuff	9f710558ce	internal/backend/remote-state/azure: adding a feature-toggle to use MSAL	4 years ago
tombuildsstuff	27a34d6c2c	internal/backend/remote-state/azure: updating the link to the client secret ... This redirects to the registry so we should point there directly	4 years ago
tombuildsstuff	5133d30b71	internal/backend/remote-state/azure: code changes for go-azure-helpers v0.18.0	4 years ago
Jared Ledvina	61a5808680	k8s-backend - Initial context support for library update ... Signed-off-by: Jared Ledvina <jared.ledvina@datadoghq.com>	4 years ago
Chris Arcand	779c958fbf	cloud: Add streamlined 'remote' backend state migration path ... For Terraform Cloud users using the 'remote' backend, the existing 'pattern' prompt should work just fine - but because their workspaces are already present in TFC, the 'migration' here is really just realigning their local workspaces with Terraform Cloud. Instead of forcing users to do the mental gymnastics of what it means to migrate from 'prefix' - and because their remote workspaces probably already exist and already conform to Terraform Cloud's naming concerns - streamline the process for them and calculate the necessary pattern to migrate as-is, without any user intervention necessary.	4 years ago
xiaozhu36	e0a2716601	backend/oss: Removes the ConflictWith tag which on the attributes assume_role* to fix the incompatible error	4 years ago
xiaozhu36	5d19a34f88	backend/oss: Supports the new attribute sts_endpoint	5 years ago
James Bardin	2ebdc099ac	Merge pull request #29307 from hayorov/main ... Flatten `assume_role` block for OSS backend	5 years ago
James Bardin	81e709d185	Merge pull request #29825 from hashicorp/jbardin/no-panicwrap ... Remove the use of panicwrap in the Terraform CLI	5 years ago
Brandon Croft	dbbfae5a1c	refactor ParseVariableValues into separate operations ... 1. ParseDeclaredValues: parses unparsed variables into terraform.InputValues 2. ProbeUndeclaredVariableValues: compares variable declarations with unparsed values to warn/error about undeclared variables	5 years ago
Chris Arcand	1791b71196	cloud: TestCloud_backendWithTags ... Implementing this test was quite a rabbithole, as in order to satisfy backendTestBackendStates() the workspaces returned from backend.Workspaces() must match exactly, and the shortcut taken to test pagination in 3cc58813f0 created an impossible circumstance that got plastered over with the fact that prefix filtering is done clientside, not by the API as it should be. Tagging does not rely on clientside filtering, and expects that the request made to the TFC API returns exactly those workspaces with the given tags. These changes include a better way to test pagination, wherein we actually create over a page worth of valid workspaces in the mock client and implement a simplified pagination behavior to match how the TFC API actually works.	5 years ago
Chris Arcand	471dd479e8	Update go-tfe to 26689e ... These changes include additions to fulfill the interface for the client mock, plus moving all that logic (which needn't be duplicated across both the remote and cloud packages) over to the cloud package under a dedicated mock client file.	5 years ago
Chris Arcand	ea8ad0b15a	Initial commit of 'cloud' package ... The cloud package intends to implement a new integration for Terraform Cloud/Enterprise. The purpose of this integration is to better support TFC users; it will shed some overly generic UX and architecture, behavior changes that are otherwise backwards incompatible in the remote backend, and technical debt - all of which are vestiges from before Terraform Cloud existed. This initial commit is largely a porting of the existing 'remote' backend, which will serve as an underlying implementation detail and not be a typical user-level backend. This is because to re-implement the literal backend interface is orthogonal to the purpose of this integration, and can always be migrated away from later. As this backend is considered an implementation detail, it will not be registered as a declarable backend. Within these changes it is, for easy of initial development and a clean diff.	5 years ago
James Bardin	d03a037567	insert panic handlers	5 years ago
Alex Khaerov	6f1eceb0e2	Revert autoupdate	5 years ago
xiaozhu36	7afaea4cf2	backend/oss: Fixes the nil pointer panic error when missing access key or secret key	5 years ago
Alex Khaerov	14f366dbf4	Update documentation	5 years ago
Alex Khaerov	f32702c5c2	Support deprecated assume_role block	5 years ago
Alex Khaerov	de8810cdd9	Merge branch 'hashicorp:main' into main	5 years ago
Martin Atkins	39779e7021	backend/remote-state/cos: Don't use github.com/likexian/gokit ... We don't use this library anywhere else in Terraform, and this backend was using it only for trivial helpers that are easy to express inline anyway. The new direct code is also type-checkable, whereas these helper functions seem to be written using reflection. This gives us one fewer dependency to worry about and makes the test code for this backend follow a similar assertions style as the rest of this codebase.	5 years ago
James Bardin	ef3c98466d	Merge pull request #29755 from hashicorp/jbardin/first-plan-lineage ... Check for stale plan with no state metadata	5 years ago
James Bardin	5ffa0839f9	only check serial when applying the first plan ... Ensure that we still check for a stale plan even when it was created with no previous state. Create separate errors for incorrect lineage vs incorrect serial. To prevent confusion when applying a first plan multiple times, only report it as a stale plan rather than different lineage.	5 years ago
Martin Atkins	bee7403f3e	command/workspace_delete: Allow deleting a workspace with empty husks ... Previously we would reject attempts to delete a workspace if its state contained any resources at all, even if none of the resources had any resource instance objects associated with it. Nowadays there isn't any situation where the normal Terraform workflow will leave behind resource husks, and so this isn't as problematic as it might've been in the v0.12 era, but nonetheless what we actually care about for this check is whether there might be any remote objects that this state is tracking, and for that it's more precise to look for non-nil resource instance objects, rather than whole resources. This also includes some adjustments to our error messaging to give more information about the problem and to use terminology more consistent with how we currently talk about this situation in our documentation and elsewhere in the UI. We were also using the old State.HasResources method as part of some of our tests. I considered preserving it to avoid changing the behavior of those tests, but the new check seemed close enough to the intent of those tests that it wasn't worth maintaining this method that wouldn't be used in any main code anymore. I've therefore updated those tests to use the new HasResourceInstanceObjects method instead.	5 years ago
Megan Bang	9b9b26a3cd	update error message for invalid json	5 years ago
megan07	7dda3366a6	Update internal/backend/remote-state/gcs/backend.go ... Co-authored-by: appilon <apilon@hashicorp.com>	5 years ago
Megan Bang	81201d69a3	check valid json	5 years ago