terraform

Commit Graph

Author	SHA1	Message	Date
Liam Cervante	448775102c	terraform test: Push evaluation of variables to as late as possible (#35014 ) * terraform test: Push evaluation of variables to as late as possible * Update internal/moduletest/hcl/variable_cache.go Co-authored-by: kmoe <5575356+kmoe@users.noreply.github.com> * address comments --------- Co-authored-by: kmoe <5575356+kmoe@users.noreply.github.com>	2 years ago
Liam Cervante	6963c54bec	terraform test: don't remove sensitive marks from inputs (#35021 )	2 years ago
Martin Atkins	30e2fd6525	Handle marks a little more consistently In the very first implementation of "sensitive values" we were unfortunately not disciplined about separating the idea of "marked value" from the idea of "sensitive value" (where the latter is a subset of the former). The first implementation just assumed that any marking whatsoever meant "sensitive". We later improved that by adding the marks package and the marks.Sensitive value to standardize on the representation of "sensitive value" as being a value marked with _that specific mark_. However, we did not perform a thorough review of all of the mark-handling codepaths to make sure they all agreed on that definition. In particular, the state and plan models were both designed as if they supported arbitrary marks but then in practice marks other than marks.Sensitive would be handled in various inconsistent ways: dropped entirely, or interpreted as if marks.Sensitive, and possibly do so inconsistently when a value is used only in memory vs. round-tripped through a wire/file format. The goal of this commit is to resolve those oddities so that there are now two possible situations: - General mark handling: some codepaths genuinely handle marks generically, by transporting them from input value to output value in a way consistent with how cty itself deals with marks. This is the ideal case because it means we can add new marks in future and assume these codepaths will handle them correctly without any further modifications. - Sensitive-only mark preservation: the codepaths that interact with our wire protocols and file formats typically have only specialized support for sensitive values in particular, and lack support for any other marks. Those codepaths are now subject to a new rule where they must return an error if asked to deal with any other mark, so that if we introduce new marks in future we'll be forced either to define how we'll avoid those markings reaching the file/wire formats or extend the file/wire formats to support the new marks. Some new helper functions in package marks are intended to standardize how we deal with the "sensitive values only" situations, in the hope that this will make it easier to keep things consistent as the codebase evolves in future. In practice the modules runtime only ever uses marks.Sensitive as a mark today, so all of these checks are effectively covering "should never happen" cases. The only other mark Terraform uses is an implementation detail of "terraform console" and does not interact with any of the codepaths that only support sensitive values in particular.	2 years ago
Martin Atkins	5a944133e6	command/jsonstate: Reject unsupported marks Our JSON state format has support for sensitive marks in particular but lacks generalized support and so cannot deal with any other marks. Previously it just assumed that any mark must be the sensitive mark, but now we'll reject other marks to ensure that if any new marks are added we must consider whether and how the JSON state format should handle them.	2 years ago
UKEME BASSEY	a4415c030a	making json data more useful for client consumption	2 years ago
UKEME BASSEY	7fb13b8868	fixing tests	2 years ago
UKEME BASSEY	c7bbc09631	move all command args from command/init to args/init	2 years ago
UKEME BASSEY	ce7824f905	add interrupt error to the diags so each component becomes responsible for rendering the errors	2 years ago
UKEME BASSEY	0ea25e3b40	fixing tests internal/command/init, view and argumento	2 years ago
UKEME BASSEY	ba8386b8a2	json does not support interactive prompt so dont allow setting of both -migrate-state and -json options	2 years ago
UKEME BASSEY	ea8d0869d8	convert all logs to be view type exclusive for human or json format	2 years ago
UKEME BASSEY	370a471ecb	fix json -help display and failing tests	2 years ago
UKEME BASSEY	26f01d699a	add test for -json support	2 years ago
UKEME BASSEY	a3f3b64e4c	add -json to tf init	2 years ago
UKEME BASSEY	7709db45dc	add init view test	2 years ago
UKEME BASSEY	14c53f74f2	add init view for json and human type view	2 years ago
Liam Cervante	924958bce0	plan renderer: ensure JSON strings are completely JSON (#34959 )	2 years ago
Martin Atkins	c1342f4f6a	terraform test: Include test case execution time in JUnit XML Our currently-experimental JUnit XML output didn't previously include the "time" attribute for test runs at all, but from testing with common JUnit XML consumers we've learned that populating this is effectively mandatory because otherwise software just assumes that it's zero, producing a misleading result. We'll now populate it based on the test runner's measure of the execution time, assuming that the test runner actually measured it. If not, we'll leave it omitted and thus get the same behavior as before, which in practice means that most software will treat it as zero anyway. Because JUnit XML output is still experimental with the goal of getting feedback on exactly how we map the Terraform testing model onto that Java-oriented format, this is intentionally not supported for remote test runs in Terraform Cloud yet. It isn't really practical for Terraform Cloud to participate in short-lived Terraform CLI experiments, because Terraform Cloud has a different release schedule than Terraform CLI does. However, if this experiment is successful then we will eventually need to find a way to plumb this additional information through the JSON logs and ensure that it arrives in the locally-generated JUnit XML output.	2 years ago
Martin Atkins	c8611b51d7	terraform test: JUnit XML output sets testcase classname JUnit XML output from "terraform test" is currently experimental, because we're still trying to decide how best to map Terraform's testing concepts onto the Java-oriented JUnit XML format. The first round of feedback showed that some JUnit consumers completely ignore test suite names, and instead expect each test case to specify which "class" it belongs to. Those tools then might allow grouping or filtering the tests by "class". Despite the Java-oriented terminology, it seems that "classname" is really just interpreted something like "test group name", where the classname and the name together represent the full test case identifier. With that in mind then, we'll now duplicate the test suite name (which in our case is the filename of the test scenario file) into the classname attribute of each testcase element. For now we'll retain the per-suite names, always containing the same value, because we also have evidence of some consumers preferring to find this information in that location.	2 years ago
Martin Atkins	14b08c3745	terraform: Move variable validation into its separate node type The parent commit added a new node to the graph for each existing input variable node, but that node didn't do anything yet. Now those new nodes are actually responsible for checking the variable's validation rules, instead of that being included in the same graph node that decides the variable's final value. This also refines the validation node graph transformer to only insert a validation node if there's at least one rule to check, which should avoid bloating the graph for anyone who isn't actually using input variable validation. Therefore the plan graph builder tests revert back to their old expected result because that input configuration does not include any validation rules. For the moment this just moves around functionality that already existed and doesn't add anything new, but having the validation handled in a separate graph node means that we can evaluate the validation rules in the EvalContext of the module where the variable was declared instead of where it was defined, and so a future commit will allow -- initially just as an experiment -- validation rules that can refer to other objects in the module where the variable is declared, including the values of other input variables. As a nice bonus, this fixed a small bug in "terraform test" where problems with variable values defined in the test run were reported as problems with the variable declaration, rather than with the expression assigning the value to it. Since it's now NodeRootVariable that decides the definition source range, rather than the validation-rule-checking helper, it has access to the source range provided in a terraform.InputValue object, which was already populated correctly for per-test-run definitions.	2 years ago
Nick Fagerlund	dc9a13a975	Catch a missing err check in apply command Plan and refresh already had this, but apply would deref a nil opReq and panic.	2 years ago
Nick Fagerlund	1781c8e8e9	Experimental `-allow-deferral` flag for enabling deferred actions on CLI Now that deferred actions is a top-level per-plan option, here's a lil command-line option for turning it on! - It's called `-allow-deferral`. - It is ONLY legal to use if this is an experimental build, i.e. compiled with `go build -ldflags "-w -s -X 'main.experimentsAllowed=yes'"` or the like. Implementation notes: The design constraint here was, "please avoid having to change the build infrastructure or alter the function of every args parsing function". So, since `extendedFlagSet()` doesn't have access to the var that says we're in an experimental build, I had to move the validation for that particular flag to later in the process, when we're building the operation request.	2 years ago
Craig Sloggett	f20b055618	Prevent duplicate error messages for unset environment variables Track and report each unset environment variable only once, even if it's referenced multiple times in the Terraform configuration.	2 years ago
Craig Sloggett	b53db4ef14	Ensure environment variables are set when interpolating rawPath	2 years ago
Craig Sloggett	302c6deddc	Interpolate environment variables when configuring dev_overrides	2 years ago
Martin Atkins	58b48f4bab	provider/terraform: Use new convention for function names When we added these functions we hadn't yet settled on a single convention for how provider-contributed functions ought to be named, and so these followed the convention previously used for Terraform's own built-in functions. We've now decided to use the new provider namespace as an opportunity to partially fix the historical design error of naming functions as all lowercase without any separation between words. This makes the provider functions inconsistent with the built-in functions, but should at least hopefully encourage the provider functions to be consistent with one another, so that the rule for which to use is relatively easy to remember. This also switches the word order because the provider functions convention prefers the verb to come first: encode_tfvars instead of tfvarsencode.	2 years ago
Martin Atkins	dbde17b535	terraform console: Multi-line entry support The console command, when running in interactive mode, will now detect if the input seems to be an incomplete (but valid enough so far) expression, and if so will produce another prompt to accept another line of expression input. This is primarily to make it easier to paste in multi-line expressions taken from elsewhere, but it could also be used for manual input. The support for multi-line _editing_ is limited by the fact that the readline dependency we use doesn't support multiline input and so we're currently doing this in spite of that library. Hopefully we'll be able to improve on that in future either by contributing multi-line editing support upstream or by switching to a different readline dependency. The delimiter-counting heuristic employed here is similar to the one used by HCL itself to decide whether a newline should end the definition of an attribute, but this implementation is simpler because it doesn't need to produce error messages or perform any recovery. Instead, it just bails out if it encounters something strange so that the console session can return a parse error. Because some invalid input may cause a user to become "stuck" in a multi- line sequence, we consider a blank line as intent to immediately try to evaluate what was entered, and also interpret SIGINT (e.g. Ctrl+C) as cancellation of multi-line input, assuming that at least one line was already entered, extending the previous precedent that SIGINT cancels when at least one character was already entered at the prompt.	2 years ago
Liam Cervante	c6ff573180	Include provider functions in scope used to evaluate test assertions (#34825 )	2 years ago
Martin Atkins	88cb4aeea3	backendrun: Separate the types/etc for backends that support operations We previously had all of the types and helpers for all kinds of backends together in package backend. That kept things relatively simple, but it also meant that the majority of backends that only deal with remote state storage ended up still indirectly depending on the entire Terraform modules runtime, configuration loader, etc, etc, which brings into scope a bunch of external dependencies that the remote state backends don't really need. Since backends that support operations are a rare exception, we'll move the types and helpers for those into a separate package "backendrun", and then the main package backend can have a much more modest set of types and, more importantly, a modest set of dependencies on other packages in this codebase. This is part of an ongoing effort to reduce the exposure of Terraform Core and CLI code to the remote backends and vice-versa, so that in the long run we can more often treat them as separate for dependency maintenance purposes.	2 years ago
Martin Atkins	545980d664	langrefs: Separate package for expression reference analysis Finding references in an expression is a static analysis operation, but we previously had it grouped in with "package lang" that primarily deals with dynamic evaluation of expressions. We need to do static analysis in far more locations than we do full expression evaluation, the static-analysis-only callers don't need anything else from package lang, and the reference-analysis functions are self-contained little wrappers around the address parsing logic in package addrs anyway. Splitting these into a separate package therefore minimizes which packages depend indirectly on package lang, and thus which packages depend indirectly on the implementations of the built-in functions. Some of the built-in functions rely on dependencies we don't use anywhere else, so cutting these out shrinks how many packages indirectly depend on those external dependencies. In particular, they are no longer in the indirect import chain for the "legacy" module.	2 years ago
Martin Atkins	5f2eab6944	providerreqs: Provider requirement/version types in their own package As we previously found with "package addrs", any package that contains types used as identifiers or addresses tends to get imported from all over, which means that if we mix real logic with those types in the same package then a lot more packages end up depending indirectly on our external dependencies. In this case, the getproviders package depends on various things we need only during provider installation, such as the library we use for GPG signature verification. Lots of different packages in Terraform need to talk about provider requirements, but only the CLI layer actually needs to do provider installation, and so this commit splits the types we use to talk about requirements into a new package "providerreqs", which package getproviders then depends on. To keep the size of this diff relatively small to start I've left forwarding aliases in package getproviders, which means that not all of the callers needed to be updated all at once. This commit does update all of the packages that the remote state backends depend on though, because that then allows us to reduce the set of indirect dependencies for each of those backends. The nested module go.mod files show that this has disconnected the indirect dependencies on github.com/ProtonMail/go-crypto and on github.com/cloudflare/circl , both of which Terraform CLI uses only for provider installation.	2 years ago
Martin Atkins	66bec6c3c7	command: TestWorkspace_deleteWithState uses modern state format This test is intending to test behavior in the presence of a state snapshot but was achieving that using the legacy state snapshot format that we preserved only for its previous (now eliminated, in an earlier commit) purpose of implementing the CLI backend state format. Instead, we'll construct a state snapshot format using the modern API for doing that, which therefore constructs a modern state snapshot file as would be created by today's Terraform. This eliminates the last use of the "legacy/terraform" package aside from the calls from other packages under "legacy".	2 years ago
Martin Atkins	06f51dbe04	command/workdir: Model the "backend state" file format Historically (before there were "backends") Terraform had a single state file format used both for real state snapshots and for tracking where remote state was stored. Terraform v0.12 caused these two to be split because we adopted state snapshot version 4 for real snapshots but retained a subset of version 3 for tracking the remote backend configuration in the local working directory. Unfortunately we previously kept that working by retaining a snapshot of the entire Terraform v0.11 "terraform" package as legacy/terraform, which happened to still be around because we also needed to retain a copy of the entire legacy SDK to keep the remote state backends working. This now hoists just the tiny slice of legacy terraform package functionality needed to implement the "backend state" file format into package workdir. This package is a good home for it because it's part of the working directory state. Ideally it would be accessed through methods of the workdir.Dir type, but that's too disruptive a refactor to combine into this and so that'll need to wait for another day; for now we'll keep the existing callers doing their access through our "clistate" package that is itself a forked snapshot of what statemgr.Filesystem used to be in Terraform v0.11. This removes all but one of the uses of "legacy/terraform" aside from calls in the other packages under "legacy". We'll clean up the last one in a later commit, because it's not related to the backend state file format.	2 years ago
Martin Atkins	1358245617	dependencies: Remove all non-legacy uses of hashicorp/go-multierror This functionality is now provided by the "errors" package in the standard library, so the HashiCorp-specific library is obsolete. This also removed our one direct use of github.com/pkg/errors, which we were using in a way that was totally redundant with the stdlib package errors. However, it lives on as an indirect dependency through the Consul backend's dependency on the Consul SDK, which uses that library.	2 years ago
thirdkeyword	8284cde302	remove repetitive words Signed-off-by: thirdkeyword <fliterdashen@gmail.com>	2 years ago
Mark DeCrane	57d2802053	Merge pull request #34746 from hashicorp/modify-dev-override-warn-with-backend Modify provider dev override warning to include a remote backend specific line	2 years ago
Mark DeCrane	b83275f05d	chore: remove extra newline char	2 years ago
Mark DeCrane	51ae7d32a7	fix: check for local operations, separate warning for remote execution	2 years ago
Mark DeCrane	9580ee27f9	chore: add remote backend specfic warnings to dev override warning	2 years ago
Nick Fagerlund	c9c24706aa	Merge pull request #34741 from hashicorp/nf/feb24-provider-addrs-in-statuses Stacks, Hooks: Include full provider addresses	2 years ago
James Bardin	dada9d683e	Merge pull request #34740 from hashicorp/jbardin/render-string-null-changes try to render some changes between `""` and `null`	2 years ago
Nick Fagerlund	ccab5f1e55	Rename some UiHook tests for easier ad-hoc runs	2 years ago
Nick Fagerlund	94ea534e40	Refactor terraform.Hook to use a resource-identifying wrapper struct The terraform.Hook interface lets other areas of code perform streaming reactions to various events, generally in the service of some UI somewhere. Nearly all of the methods on this interface take an `addrs.AbsResourceInstance` as their first argument, to identify the resource that's being operated on. However, that addrs struct doesn't necessarily contain everything you might want in order to uniquely and usefully identify a resource. It has the module instance and resource instance addresses, but it lacks the provider source address, which can affect how the consuming UI should display the resource's events. (For example, Terraform Cloud wants reliable info about who maintains a given provider, what cloud provider it operates on, and where to find its documentation.) Instead of polluting `addrs.AbsResourceInstance` with extra information that isn't relevant to other call sites, let's change the first argument of each Hook method to be a wrapper struct defined in the package that owns the Hook interface, and add the provider address to that wrapper as a sibling of the resource address. This causes a big noisy commit today, but should streamline future updates to the UI-facing "identity" of a resource; existing callers can ignore any new fields they're uninterested in, or exploit new info as needed. Other than making new information available for future edits to Hook implementing types, this commit should have no effect on existing behavior.	2 years ago
Nick Fagerlund	d81a546e55	Lints: hook_count_test, "redundant type from slice composite literal" I was in the file for other reasons, and wanted to reduce noise in my editor.	2 years ago
Martin Atkins	573c2db658	provider/terraform: Terraform-specific encoding functions Using the new possibility of provider-contributed functions, this introduces three new functions which live in the terraform.io/builtin/terraform provider, rather than being language builtins, due to their Terraform-domain-specific nature. The three new functions are: - tfvarsencode: takes a mapping value and tries to transform it into Terraform CLI's "tfvars" syntax, which is a small subset of HCL that only supports key/value pairs with constant values. - tfvarsdecode: takes a string containing content that could potentially appear in a "tfvars" file and returns an object representing the raw variable values defined inside. - exprencode: takes an arbitrary Terraform value and produces a string that would yield a similar value if parsed as a Terraform expression. All three of these are very specialized, of use only in unusual situations where someone is "gluing together" different Terraform configurations etc when the usual strategies such as data sources are not suitable. There's more information on the motivations for (and limitations of) each function in the included documentation.	2 years ago
James Bardin	bdd5a2cd33	try to render some empty string -> null changes Changes between empty strings and `null` were hidden in the CLI output, because the SDK could not reliably detect the difference and may return either value depending on the situation. This legacy behavior can be confusing for authors of new provider which can correctly handle `null`, and it would be preferable to be able to render those changes in the CLI. While we don't have enough information to detect when the legacy behavior is required, we can detect a number of cases where it's certain that we are not dealing with a legacy schema and should output the full diff.	2 years ago
Daniel Schmidt	8564e934aa	Merge pull request #34699 from hashicorp/terraform-test-use-vars-within-blocks test: allow using global variables in suite-level variable definitions	2 years ago
Daniel Schmidt	0529299cc3	run terraform fmt on test	2 years ago
Liam Cervante	c46515c5da	stacks: add support for external providers to validate context (#34701 )	2 years ago
Daniel Schmidt	7ae7a203d8	test: allow using global variables in suite-level variable definitions Closes #34534	2 years ago
Liam Cervante	82361afd73	plan rendering: fix truncation of very large numbers (#34702 )	2 years ago
Daniel Schmidt	adf008d489	adjust tests to new implementation	2 years ago
Daniel Schmidt	19f9bdac14	handle multi-line string diffs correctly	2 years ago
Daniel Schmidt	a64df71152	fix comment	2 years ago
Daniel Schmidt	1531fee472	clarify comment	2 years ago
Daniel Schmidt	2a625b75a4	handle reordering explicitly	2 years ago
Daniel Schmidt	31bd2b5be0	plan: compare individual elements if list is same length Closes #33779	2 years ago
Liam Cervante	f0b61090a2	Move the testing MockProvider into a dedicated shared package (#34681 ) * move the testing MockProvider into a dedicated shared package * address comments * fix new changes	2 years ago
Martin Atkins	884e1fb2a4	terraform: Plans can be "complete" and "applyable" These ideas are both already implied by some logic elsewhere in the system, but until now we didn't have the decision logic centralized in a single place that could therefore evolve over time without necessarily always updating every caller together. We'll now have the modules runtime produce its own boolean ruling about each characteristic, which callers can rely on for the mechanical decision-making of whether to offer the user an "approve" prompt, and whether to remind the user after apply that it was an incomplete plan that will probably therefore need at least one more plan/apply round to converge. The "Applyable" flag directly replaces the previous method Plan.CanApply, with equivalent logic. Making this a field instead of a method means that we can freeze it as part of a saved plan, rather than recalculating it when we reload the plan, and we can export the field value in our export formats like JSON while ensuring it'll always be consistent with what Terraform is using internally. Callers can (and should) still use other context in the plan to return more tailored messages for specific situations they already know about that might be useful to users, but with these flags as a baseline callers can now just fall back to a generic presentation when encountering a situation they don't yet understand, rather than making the wrong decision and causing something strange to happen. That is: a lack of awareness of a new rule will now cause just a generic message in the UI, rather than incorrect behavior. This commit mostly just deals with populating the flags, and then all of the direct consequences of that on our various tests. Further changes to actually make use of these flags elsewhere in the system will follow in later commits, both in this repository and in other repositories.	2 years ago
Daniel Schmidt	91ea23aee5	remove outdated comment	2 years ago
Daniel Schmidt	14feb738a7	update comment	2 years ago
Daniel Schmidt	472a07ad6e	fix typo Co-authored-by: Liam Cervante <liam.cervante@hashicorp.com>	2 years ago
Daniel Schmidt	be262b52d7	make using the plugin cache opt-in	2 years ago
Daniel Schmidt	f720a060ff	use plugin cache for provider lock across for all platforms The cache architecture already supports multi-platform, the only downside is that this might grow the cache. This seems expected.	2 years ago
Daniel Schmidt	2c98e6a347	improve provider lock speed by using cache Closes #33837	2 years ago
Martin Atkins	89a53e9105	command/test: Fix invalid XML processing instruction Annoyingly, I seem to have flubbed this slightly while I was adapting to use enc.EncodeToken instead of (as originally written) just writing the literal processing instruction bytes onto the front of the buffer directly. This made the output invalid for any XML processor that interprets the special "xml" processing instruction. It'll now be valid again.	2 years ago
HenriBlacksmith	49663bfc33	terraform fmt: add .tfmock.hcl as a supported file extension (#34580 ) * terraform fmt: add .tfmock.hcl as a supported file extension * terraform fmt: add test cases for .tfmock.hcl files formatting * fix: update test to run on .tfmock.hcl files	2 years ago
James Bardin	c4a2f74054	Merge pull request #34567 from hashicorp/jbardin/handling-instance-value-marks apply schema marks to returned instance values	2 years ago
James Bardin	8994e914b7	add sensitive attributes to test json output	2 years ago
James Bardin	8655b08b19	fix sensitive_attributes in test Add the missing sensitive_attributes to the test state, and update the output to reflect the new `"checks"` attribute name.	2 years ago
Liam Cervante	9658f9df6b	mocking overrides: default to concrete empty object when values are missing (#34563 )	2 years ago
Liam Cervante	430970c02b	terraform test: Fix crash when file level variables reference variables. (#34531 ) * terraform test: Fix crash when referencing variables within the file level variable block * also allow functions within variables blocks * add tests	2 years ago
Brian Flad	3b4964270f	internal/command/jsonprovider: Remove root jsonfunction object from function output (#34536 ) Previously, the `providers schema -json` output would include the root object from `metadata functions -json`. This object had its own `format_version` property, which would be confusing with the root `format_version` property already present. This change still uses the `jsonfunction` package for consistency between cty and provider function JSON handling, but removes that extra object, instead making `functions` directly a mapping of names to signatures/definitions. This also adds a code comment to hint maintainers that jsonprovider format versioning is tied to jsonfunction format versioning. Example output prior to change: ```jsonc { "format_version": "1.0", "provider_schemas": { "registry.terraform.io/bflad/framework": { // ... "functions": { "format_version": "1.0", "function_signatures": { "example": { "description": "Echoes given argument as result", "summary": "Example function", "return_type": "string", "parameters": [ { "name": "input", "description": "String to echo", "type": "string" } ] } } } } } } ``` Example output after change: ```jsonc { "format_version": "1.0", "provider_schemas": { "registry.terraform.io/bflad/framework": { // ... "functions": { "example": { "description": "Echoes given argument as result", "summary": "Example function", "return_type": "string", "parameters": [ { "name": "input", "description": "String to echo", "type": "string" } ] } } } } } ```	2 years ago
Martin Atkins	4a0d06c13e	terraform test: Report skipped runs in JUnit XML output Previously we were just ignoring skipped runs completely, but JUnit XML has some elements/attributes for describing those and so we'll populate those too now.	2 years ago
Martin Atkins	b43ddd8ff6	terraform test: Experimental JUnit XML reporting This adds an experimental new option -junit-xml=FILENAME for the "terraform test" command. When specified, it writes a JUnit XML report to the specified filename once the test run is complete, while continuing to report test progress in the UI in the usual way. This is only experimental for now because it remains to be seen if this particular mapping to the JUnit XML schema is actually useful in real software -- this format is woefully underdocumented and implemented slightly differently by each consumer -- and so we might change this significantly before stabilizing it, or remove it altogether if it turns out that there's no useful mapping to JUnit XML here. Hopefully those who are interested in JUnit XML reports will try this experiment against their favorite JUnit XML-consuming software and report back whether the report is presented in a helpful way. It's a de-facto convention for JUnit XML to be reported separately to a file, rather than replacing the normal test run output, since tools that consume this format tend to present its results in a separate and less prominent place than the output of the command itself. This option is designed to follow that convention for consistency with various other software that produces this format. The implementation here is intentionally pretty minimal and simplistic just as a starting point for gathering feedback. The main priority is that it be easy to evolve this based on feedback and to remove it altogether if we decide not to stabilize this at all. If this does become stabilized, it might deserve being factored out into a separate package so that we can minimize the amount of logic embedded directly inside the views package, and it will certainly need some unit tests to represent what we've committed to supporting in future versions.	2 years ago
Brian Flad	1298fcd412	Add missing function deprecation_message to JSON output and website documentation (#34520 ) Reference: https://github.com/hashicorp/terraform/pull/34450	2 years ago
James Bardin	b3c5590f01	Merge pull request #34450 from hashicorp/jbardin/provider-functions-json-schema Add functions definitions to the `providers schema -json` output	2 years ago
James Bardin	2e74fec583	add optional Summary field to function json	2 years ago
Nick Fagerlund	9d7737b2fe	Merge pull request #34447 from hashicorp/nf/dec23-grpc-metadata-cloudplugin Cloudplugin: Pass configuration via gRPC metadata	2 years ago
Nick Fagerlund	ff62192819	Adjust CloudPluginConfig doc comments	2 years ago
Liam Cervante	7e18b1183d	Add test verifying issue #34476 has been fixed (#34478 )	2 years ago
Nick Fagerlund	1a492b9dbb	Add test for (CloudPluginConfig).ToMetadata()	2 years ago
Nick Fagerlund	c398d0340f	Catch a missing assign-after-append I believe this is a slice append under the hood, which would mean `.Append()` consumes the original receiver and you shouldn't touch it afterwards.	2 years ago
Nick Fagerlund	7a1c49c61d	Append cloud plugin config metadata in plugin client requests - The cloud plugin wants a go-tfe client to get stuff from TFC. - Terraform knows how to find all the info you need in order to configure a go-tfe client, but it's sometimes scattered across configs and env vars and credentials helpers, and trying to re-implement the resolution logic identically in another codebase would be error-prone. - Therefore, it'd be best if Terraform did that resolution and just passed the plugin all the config info it needs. There are two options for that handoff: 1. Adding it as an additional argument to the primary Execute RPC interface. 2. Passing it as gRPC metadata, which is a pile of arbitrary key => list-of-strings pairs transmitted via HTTP/2 headers. The crux of the decision here is whether a proliferation of plugin protocol versions whenever we need to add more config data is better or worse than a fuzzy and typeless key/value bag. This PR is an implementation of option 2, for discussion and evaluation. (And after all, this is considered an experimental feature anyway.) It assembles the necessary information, translates it to the required metadata format, and attaches it to the request at the proper moment to get everything over to the plugin. As previous commits foreshadowed, we're leaning on the existing logic in the Cloud backend for pretty much all of this.	2 years ago
Nick Fagerlund	e1f0165693	Cloud command: Use cloud backend to find plugin config and service URLs The plugin needs some config info in order to actually build a go-tfe client and _do_ anything, and the Cloud backend is the one place that already knows how to look up and reconcile all the possible sources of that info. So, we'll just find a Cloud backend and pick its pockets. This also replaces our reimplementations of hostname lookup and service discovery, using work the Cloud backend already did.	2 years ago
James Bardin	6553e55dfa	marshal provider functions into the json schemas Add provider functions to the json schema output for providers. We leverage the jsonfunction package here to ensure that the serialization is kept identical, so that the consumers of the json function definitions can work equally with both.	2 years ago
James Bardin	a74c847656	test MarshalProviderFunctions Provider functions should marshal identically to an equivalent cty functions.	2 years ago
James Bardin	8c41a1e036	MarshalProviderFunctions	2 years ago
James Bardin	d7a1ebb1b7	add special cases for jsonfunction The jsonfunction package has special cases for some internal functions, and wee need to add the namespaced equivalents to those lists.	2 years ago
Jamie Finnigan	05b0bdac99	adopt hashicorp/cli fork of mitchellh/cli (#34429 )	2 years ago
kmoe	8f3aa0e099	jsonformat: render forget-only attr changes as no-op (#34403 ) * jsonplan: document forget actions * jsonformat: format forget changes as no-op Previous to this commit, forget-only actions (i.e. "forget", not "create then forget") would be rendered using the forget action symbol for the top-level resource, and the delete action symbol for each resource attribute, with a new value of "null". This attribute rendering is identical to that for resource deletion, which might suggest to some users that Terraform plans to delete the resource, not just remove it from state. This commit tweaks the renderer so forget-only changes render as no-ops but with the forget action symbol and resource change comment.	2 years ago
James Bardin	a9cc3baf1a	ensure unmanaged plugins have an address Unmanaged plugins use a slightly different factory function which was missed when adding the address to the plugin struct. This made little difference in most cases, but now with the new global schema cache it would prevent the plugin's schema from being cached due to lack of a key. The end result was acceptance tests for very large providers would take considerably longer due to the overhead of repeatedly generating the schema. There is no good way to check the internals of an unmanaged provider in a unit test, but this PR puts the setup functionality in a single helper function so that unmanaged providers use the same setup codepath as the standard set of plugins.	2 years ago
Martin Atkins	17f420102f	states: Local values no longer live in state Back when we added local values (a long time ago now!) we put their results in state mainly just because it was the only suitable shared data structure to keep them in. They are a bit ideosyncratic there because we intentionally discard them when serializing state to a snapshot, and that's just fine because they never need to be retained between runs anyway. We now have namedvals.State for all of our named value result storage needs, so we can remove the local-value-related fields of states.Module and use the relevant map inside the local value state instead. As of this commit, states.State now tracks only the data that we actually persist between runs in state snapshots, which will hopefully avoid future bugs resulting from the former difference in fidelity between a freshly-created in-memory state vs. one loaded from a snapshot.	2 years ago
Martin Atkins	b0b8d4aa6f	states: Only track root module output values For a very long time we've had an annoying discrepancy between the in-memory state model and our state snapshot format where the in-memory format stores output values for all modules whereas the snapshot format only tracks the root module output values because those are all we actually need to preserve between runs. That design wart was a result of us using the state both as an internal and an external artifact, due to having nowhere else to store the transient values of non-root module output values while Terraform Core does its work. We now have namedvals.State to internally track all of the throwaway results from named values that don't need to persist between runs, so now we'll use that for our internal work instead and reserve the states.State model only for the data that we will preserve between runs in state snapshots. The namedvals internal model isn't really designed to support enumerating all of the output values for a particular module call, but our expression evaluator currently depends on being able to do that and so we have a temporary inefficient implementation of that which just scans the entire table of values as a stopgap just to avoid this commit growing even larger than it already is. In a future commit we'll rework the evaluator to support the PartialEval mode and at the same time move the responsiblity for enumerating all of the output values into the evaluator itself, since it should be able to determine what it's expecting by analyzing the configuration rather than just by trusting that earlier evaluation has completed correctly. Because our legacy state string serialization previously included output values for all modules, some of our context tests were accidentally depending on the implementation detail of how those got stored internally. Those tests are updated here to test only the data that is a real part of Terraform Core's result, by ensuring that the relevant data appears somewhere either in a root output value or in a resource attribute.	2 years ago
Liam Cervante	5cbf7c5f96	Add docs for automatic var files in test directories (#34349 )	2 years ago
Nick Fagerlund	d2e07f6f03	Add `TF_CLOUD_PLUGIN_DEV_OVERRIDE` to enable cloudplugin dev Currently, Terraform will only run properly signed versions of the experimental cloud plugin that were downloaded from a TFC instance that provides the appropriate service. That obstructs development on new cloud plugin features! Our internal teams will need a "dev override" capability, like what we offer provider authors. However, unlike with providers, we don't have to integrate this into a heterogeneous mix of sources for mirroring and caching a wide range of binaries. There's only one cloud plugin, HashiCorp controls it, and end users should never need to override the location of the binary for non-development reasons. Thus, we have the luxury of being quite a bit stupider in how we handle the override signal. Instead of adding it to the CLI config file schema, we'll just use a single environment variable whose value is the path to an alternate binary. Enter: `TF_CLOUD_PLUGIN_DEV_OVERRIDE`.	2 years ago
Nick Fagerlund	9a7fae5ff1	Typo fix	2 years ago
Kubo	c98e355ca1	terraform test: Collect variables from default var file within testing directory (#34341 ) * Add logic to collect variables for terrafrom test * Add tests for test variable collection * Update the test variable collection implementation * Update internal/backend/local/test.go Co-authored-by: Liam Cervante <liam.cervante@hashicorp.com> * Update internal/backend/local/test.go Co-authored-by: Liam Cervante <liam.cervante@hashicorp.com> * Move test variables into var file * resolve diff from cross-branch switch * go fmt --------- Co-authored-by: Liam Cervante <liam.cervante@hashicorp.com>	2 years ago
Martin Atkins	7055650270	terraform console: Option to evaluate in a planned state Previously "terraform console" always evaluated in a kinda strange context where resource instance data comes from the prior state, but other derived of values end up being calculated dynamically based on the current configuration, which is okay for simple cases but can be confusing if the configuration has changed significantly since the most recent apply, or if there haven't yet been any applied changes. Now we'll allow an optional new mode where Terraform runs the normal plan phase (as if running "terraform plan") and then uses the resulting _planned state_ as the basis for evaluation, allowing evaluation against a partial approximation of what the world ought to look like if these changes were applied, without having to actually apply them first. As with the previous use of the eval walk, it's possible that an erroneous situation will still produce a partial evaluation scope, and so the console still allows evaluation against that scope but with a caveat that it might produce unexpected results. In practice this can be useful for debugging situations like when unknown values block planning of an object, to allow inspection of the values that are contributing to that blocked planning operation even though the plan is not yet complete.	2 years ago
Martin Atkins	0f845adfdb	moduletest: EvalContext lives outside of the "terraform" package The initial implementation of the module testing language included some elements deeply embedded inside "package terraform", which is primarily concerned with the traditional Terraform language, which we might now call the "module language" to distinguish it from the test language and the stacks language. That was a reasonable design decision due to the modules runtime needing to evaluate some expressions in a similar way to how the modules language does it, but unfortunately it caused the test language runtime to depend a little too closely on some current implementation details of how the modules runtime deals with expression evaluation, and those details are about to change as we teach Terraform to be able to deal with unknown values in new places, as part of resolving this issue: https://github.com/hashicorp/terraform/issues/30937 This commit therefore refactors the test runtime a little so that it doesn't intrude so deeply into the module runtime's business. Instead of directly extending the module runtime's expression evaluator, we'll instead call into it in a similar way to how the "terraform console" command does, by wrapping the evaluation data produced by the module runtime to extend it with the only two special things that the test runtime needs: references to the output values of previous runs, and references to test-only variables that aren't declared as part of the module under test. This effectively means that the test runtime can now evaluate a superset of the expressions that would be valid in the global scope of the module under test using only the public API of the modules runtime, with no testing-specific evaluation logic embedded inside the modules runtime. This new strategy is also somewhat similar to how the stacks runtime calls into the modules runtime to evaluate components, but the stacks runtime only actually cares about output values and so doesn't need a full evaluation scope. This means the result here is a little more symmetrical with the approach we took in stacks, which will hopefully allow experience working on one to translate better to the other.	2 years ago
Liam Cervante	9ea1aa0a86	terraform test: skip destroy step for empty run blocks (#34331 )	2 years ago
Liam Cervante	392e2a6e21	Fix the compile error in command/test_test.go (#34324 )	2 years ago
Liam Cervante	6670ab43f7	terraform test: rearrange the order of destroy operations (#34293 )	2 years ago
Liam Cervante	08eafe0f2e	Fix flaky test in command/test_test.go (#34320 )	2 years ago
kmoe	a718f70f85	Add removed block (#34251 ) * terraform: remove redundant code NodeDestroyResourceInstance is never instantiated with a DeposedKey of anything other than states.NotDeposed, so the deleted code is never run. Deposed objects get a NodeDestroyDeposedResourceInstanceObject instead. * tfdiags: add helper func * configs: introduce removed block type * terraform: add forget action * renderer: render forget actions * terraform: deposed objects can be forgotten Deposed objects encountered during planning spawn NodePlanDeposedResourceInstanceObject, which previously generated a destroy change. Now it will generate a forget change if the deposed object is a forget target, and a destroy change otherwise. The apply graph gains a new node type, NodeForgetDeposedResourceInstanceObject, whose execution simply removes the object from the state. * configs: add RemoveTarget address type * terraform: modules can be forgotten * terraform: error if removed obj still in config * tests: better error on restore state fail * Update CHANGELOG.md	2 years ago
Martin Atkins	844b1616e8	command/graph: Simpler resource-only graph by default Unless a user specifically requests a real operation graph using the -type option, we'll by default present a simplified graph which only represents the relationships between resources, since resources are the main side-effects and so the ordering of these is more interesting than the ordering of Terraform's internal implementation details.	2 years ago
Martin Atkins	0811395e6f	states: State.AllResourceInstanceObjectAddrs should say "Managed" This method used the more appropriate name AllManagedResourceInstanceObjectAddrs in its docstring, but was incorrectly named just AllResourceInstanceObjectAddrs in its actual definition, obscuring the fact that it filters out everything except objects from managed resources. Now we'll use the originally-documented name to make this clearer. This also factors out the implementation into a separate unexported function that takes the filtering criteria as an argument, since in future commits we're going to add other variations of this which return different subsets of the resource instance objects in the state.	2 years ago
Martin Atkins	ac562eeb6f	states: State.AllResourceInstanceObjectAttrs returns a set Originally we had this function returning a slice of an anonymous struct type because we hadn't yet recognized "resource instance object" as a first-class address type. We do now have addrs.AbsResourceInstanceObject to represent that sort of thing, and so we'll use that here. This also means we can return a set of addresses rather than a slice, which is semantically better as this set of addresses is not inherently ordered. Some existing callers were depending on the sort.SliceStable we were originally doing to make the result dependable, and so now we have a generic helper for turning addrs.Set into a sorted slice of the same type using our address types' "Less" methods that describe their natural or preferred ordering.	2 years ago
Martin Atkins	13e26b60dd	addrs: Adopt DeposedKey as an address type; remove states.Generation Previously we had states.DeposedKey as our representation of the unique keys used to differentiate between multiple deposed objects on the same resource instance. That type is useful in various places, but its presence in the "states" package made it troublesome to import for some callers. Since its purpose is as an identifier, this type is more at home in the "addrs" package. The states package retains a small number of aliases to preserve compatibility with a few existing callers for now, until we have the stomach for a more invasive change. This also removes the largely-redundant states.Generation interface type, which initially was intended as a way to distinguish between "current" objects and deposed objects, but didn't really add anything because we already have addrs.NotDeposed to represent that situation. Instead, we just ended up with various bits of boilerplate adapter code converting between the two representations. Everything now uses addrs.DeposedKey and uses addrs.NotDeposed to identify non-deposed objects.	2 years ago
Liam Cervante	dedb296773	terraform test: connect mock behaviour to test framework (#34205 ) * connect mock behaviour to test framework * fix calling unconfigured providers	2 years ago
Liam Cervante	57edb9c248	testing framework: add warnings for override blocks with invalid targets (#34181 ) * testing framework: add warnings for override blocks with invalid targets * pre-add the override sources for upcoming features * address comments	2 years ago
Liam Cervante	b9f6b23ba3	testing framework: add support for functions in variables and providers (#34204 )	2 years ago
Liam Cervante	ad77877136	terraform test: remove marks before passing variables as inputs to a plan (#34190 ) * remove marks before passing variables as inputs to a plan * fix doc comments	2 years ago
Liam Cervante	f90d71f723	testing framework: allow providers to reference run blocks (#34118 ) * testing framework: allow providers to reference run block * missing copywrite header	2 years ago
James Bardin	6985a6c44b	missing Type in marshalModuleCall Attribute The type isn't needed here for what marshalModuleCall is doing (converting hcl config into the generic plan json config output), but the new check in configschema prevents the invalid Attribute value.	3 years ago
Liam Cervante	5bbdc4c3b6	terraform test: allow providers in test files to reference variables (#34069 ) * Process only relevant variables in the testing framework * add support for variables within test provider configurations * remove unused function * fix consistency checks	3 years ago
Liam Cervante	5294c2bb47	Process only relevant variables in the testing framework (#34072 )	3 years ago
Liam Cervante	01c0480e77	Test framework will produce regular updates in -json mode (#33953 ) * Test framework will produce regular updates in -json mode * add tests * docs * docs tweaking	3 years ago
James Bardin	2664c062c9	Merge pull request #33932 from hashicorp/jbardin/import-for-each Import block expansion with for_each	3 years ago
Liam Cervante	8ecda5f708	Increase timeout length after fatal interrupts for test cloud runs (#33956 )	3 years ago
Liam Cervante	fba5dad097	Test files should be marked as skipped if all their run blocks were skipped (#33950 )	3 years ago
James Bardin	2c4608fe9e	update import validate test The diagnostics have been made more accurate, pointing to the problematic line rather than just the import block name.	3 years ago
James Bardin	e1a8270bde	expose ImportTarget.IDString for legacy import Let the legacy import path set IDString directly, simplifying the handling slightly. This also uncovered a long broken test which used an invalid import target.	3 years ago
James Bardin	5f13eecc38	remove ImportTarget.ID field	3 years ago
James Bardin	df23c703ce	import block decode Update the import configuration block to decode for_each and to into raw expressions, so that we can later evaluate those during expansion.	3 years ago
Liam Cervante	f8d4664bcd	Add additional validation around unknown and null values in test variables (#33861 ) * Add additional validation around unknown values in test variables * address comments	3 years ago
Liam Cervante	ffbcaf8bef	Implement TFC integration for private module registry test runs (#33710 ) * implement module testing via TFC * ready for review * fix static checks * licence headers	3 years ago
Liam Cervante	1c7dfa22b7	Add warning when testing and combining expect_failures with apply operations	3 years ago
Liam Cervante	84e2ebc225	apply defaults when processing variables for assertions	3 years ago
Liam Cervante	041b54fb4b	explicitely disallow duplicate run block names in test files (#33836 )	3 years ago
Liam Cervante	a560730376	Make the test command fail if resources could not be cleaned up (#33809 ) * Make the test command fail if resources could not be cleaned up * remove redundant return statement	3 years ago
Liam Cervante	91d26b6ea6	Refactor file and run block feedback frequency (#33840 ) * Refactor file and run block feedback frequency * fix consistency checks * make generate	3 years ago
Liam Cervante	802d49a9ca	Handle null outputs in Terraform test files (#33781 )	3 years ago
Brandon Croft	5867c4124e	Ignore remote version conflict when running force-unlock	3 years ago
Liam Cervante	487eeda94e	[testing framework] Add documentation (#33454 ) * [terraform test] add docs * Apply suggestions from code review Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * polish remaining comments * Apply suggestions from code review Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * address remaining comments * typo * update verbose machine readable docs * standardise new JSON field names --------- Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com>	3 years ago
CJ Horton	1706d643d6	more missing headers	3 years ago
Liam Cervante	4c83e2d524	Terraform test directory must be local to the config directory (#33760 )	3 years ago
Liam Cervante	edcc35c96c	testing framework: move local implementation into local directory (#33734 )	3 years ago
Liam Cervante	2ea141b3f4	Embed the schemas directly in the testing framework JSON verbose outputs (#33755 )	3 years ago
Jared Baker	c566bcd6f7	Merge pull request #33730 from hashicorp/s3/modernization backend/s3: Update S3 client to AWS SDK Go V2	3 years ago
Liam Cervante	5e63aa01c7	Allow referencing higher level variables from run blocks (#33722 )	3 years ago
Liam Cervante	9bc5c7afbb	Include run block for JSON fatal interrupt test summaries (#33720 )	3 years ago
Jared Baker	de02f3461b	internal/command: fix slices.SortFunc signature	3 years ago
Brandon Croft	114f876f81	Merge pull request #33602 from hashicorp/TF-8071-download-and-verify-the-plugin-in-terraform Download and authenticate the cloudplugin	3 years ago
Brandon Croft	3d1e07dcf3	Write command output to Meta.Streams, more plugin err handling	3 years ago
Brandon Croft	8f4a430e41	refactor: cloudplugin VersionManager -> BinaryManager	3 years ago
CJ Horton	98b81d3c50	add missing copyright headers	3 years ago
Liam Cervante	9742f22c4e	Introduce 'run' keyword for referencing outputs from earlier run blocks (#33683 ) * introduce 'run' keyword for referencing outputs from earlier run blocks * fix code consistency	3 years ago
Liam Cervante	836c64f172	simplify test_context evaluation (#33677 )	3 years ago
Brandon Croft	63e017b81b	cloudplugin: download and verify plugin Adds a client that encapsulates the process of downloading a cloudplugin manifest from a Terraform Cloud, downloads the appropriate binary to the specified location, and validates that it was distributed by HashiCorp	3 years ago
hashicorp-copywrite[bot]	53c34ff49c	Update copyright file headers to BUSL-1.1	3 years ago
Liam Cervante	126f34e4e8	Implement updates to testing framework based on recent feedback	3 years ago
Liam Cervante	3cce200d0e	Fix root cause of race condition in testing framework tests	3 years ago
Liam Cervante	f1ca74f09f	Update JSON_UI_VERSION after test framework changes	3 years ago
Liam Cervante	f8b1fe47dd	Make config errors more important during init operations (#33628 ) * make config errors more important during init operations * address comments	3 years ago
James Bardin	e26d07dda4	Merge pull request #33634 from hashicorp/jbardin/init-from-module-warnings Allow `get` and `init -from-module` to complete when there are configuration validation errors	3 years ago
James Bardin	ea1144995f	update callers of InstallModules Update callers of InstallModules and have `get` return only install errors.	3 years ago
kmoe	765c25d2ed	allow interpolation in import block id (#33618 ) The import block id field can now reference variables, attributes, and module outputs, as long as the result is a known non-empty string at plan time. A null or unknown value will result in an error. This commit slightly modifies the legacy CLI terraform import code path to construct a synthetic hcl.Expression from the import id passed in from the command line, with no intended change of functionality.	3 years ago
Liam Cervante	8b764f2e1b	fix race condition in no_provides_in_main test (#33616 )	3 years ago
Liam Cervante	3bea1171af	test framework: expand variables available to test assertions (#33611 )	3 years ago
Liam Cervante	4560a83721	test framework: include transformed config before validating config (#33608 )	3 years ago
Liam Cervante	f397954c52	testing framework: allow users to specify deeply nested testing directories (#33584 )	3 years ago
Liam Cervante	4122ba86fc	terraform test: fix crash when using nested modules from test run blocks (#33589 )	3 years ago
Liam Cervante	e1019b3641	testing framework: validate the configuration before terraform test (#33559 ) * testing framework: call validate on the configuration before running terraform test * address comments * make tests pass after merge * fix tests	3 years ago
Liam Cervante	55792309eb	test framework: add support for testing files to fmt command (#33576 )	3 years ago
Liam Cervante	080ddead6e	testing framework: perform a plan before starting any tests (#33561 )	3 years ago
Liam Cervante	083c9afd5b	testing framework: add trace and debug statements during test executions (#33554 )	3 years ago
Brandon Croft	e5ce25099c	Apply suggestions from code review Co-authored-by: Sebastian Rivera <sebastian.rivera@hashicorp.com>	3 years ago
Brandon Croft	9bb566dcdb	Update cloudplugin type casting to simplify adding future versions	3 years ago
Brandon Croft	2c3d134705	Adds `cloud` subcommand with some toy options	3 years ago
Brandon Croft	fec1ca69ac	Fix console godoc	3 years ago
Sebastian Rivera	08e58fd484	Fix saved plan test regressions, fixtures	3 years ago
Nick Fagerlund	1cbc95ce56	Use wrapped types to clean up error reporting in show command Since terraform show can accept three different kinds of file to act on, its error messages were starting to become untidy and unhelpful. The main issue was that if we successfully identified the file type but then ran into some problem while reading or processing it, the "real" error would be obscured by some other useless errors (since a file of one type is necessarily invalid as the other types). This commit tries to winnow it down to just one best error message, in the "happy path" case where we know what we're dealing with but hit a snag. (If we still have no idea, then we fall back to dumping everything.)	3 years ago
Nick Fagerlund	ed27fa096e	command/views/show_test: Update method arguments, add test cases	3 years ago
Nick Fagerlund	12af8518ff	command/show_test: Update expected error text	3 years ago
Nick Fagerlund	3a9ce2afb1	Update show command and view to support inspecting cloud plans One funny bit: We need to know the ViewType at the point where we ask the Cloud backend for the plan JSON, because we need to switch between two distinctly different formats for human show vs. `show -json`. I chose to pass that by stashing it on the command struct; passing it as an argument would also work, but one, the argument lists in these nested method calls were getting a little unwieldy, and two, many of these functions had to be receiver methods anyway in order to call methods on Meta.	3 years ago
Nick Fagerlund	0df3c143bb	New plans.Quality type for display-relevant facts about a plan This commit replaces the existing jsonformat.PlanRendererOpt type with a new type with identical semantics, located in the plans package. We needed to be able to exchange the facts represented by `jsonformat.PlanRendererOpt` across some package boundaries, but the jsonformat package is implicated in too many dependency chains to be safe for that purpose! So, we had to make a new one. The plans package seems safe to import from all the places that must emit or accept this info, and already contains plans.Mode, which is effectively a sibling of this type.	3 years ago
Nick Fagerlund	f9d937a4dd	Apply a confirmable run when given a saved cloud plan (#33270 ) It displays a run header with link to web UI, like starting a new plan does, then confirms the run and streams the apply logs. If you can't apply the run (it's from a different workspace, is in an unconfirmable state, etc. etc.), it displays an error instead. Notable points along the way: * Implement `WrappedPlanFile` sum type, and update planfile consumers to use it instead of a plain `planfile.Reader`. * Enable applying a saved cloud plan * Update TFC mocks — add org name to workspace, and minimal support for includes on MockRuns.ReadWithOptions.	3 years ago
Brandon Croft	c1a730314d	Relocate localterraform.com aliasing to backend configurators Previously, remote and cloud backends would automatically alias localterraform.com as the configured hostname during configuration. This turned out to be an issue with how backends could potentially be used within the builtin terraform_remote_state data source. Those data sources each configure the same service discovery with different targets for localterraform.com, and do so simultaneously, creating an occasional concurrent map read & write panic when multiple data sources are defined. localterraform.com is obviously not useful for every backend configuration. Therefore, I relocated the alias configuration to the callers, so they may specify when to use it. The modified design adds a new method to backend.Enhanced to allow configurators to ask which aliases should be defined.	3 years ago
Liam Cervante	ad26644578	Fix flaky test in views package (#33560 )	3 years ago
Liam Cervante	c91f91cc9e	testing framework: change test file extension to .tftest.hcl (#33553 )	3 years ago
Liam Cervante	ca85d3bf85	Implement word wrapping in the terraform test view functions (#33547 ) * Implement word wrapping in the terraform test view functions * Update internal/command/views/test.go Co-authored-by: CJ Horton <17039873+radditude@users.noreply.github.com> --------- Co-authored-by: CJ Horton <17039873+radditude@users.noreply.github.com>	3 years ago
Liam Cervante	6c7db16566	testing framework: refactor interrupt logic for immediate exits (#33532 ) * testing framework: refactor interrupt logic * fix formatting	3 years ago
Liam Cervante	6882dd9530	testing framework: introduce test command optional flags (#33504 ) * testing framework: introduce test command optional flags * address consistency checks	3 years ago
Liam Cervante	2cc81cfec6	testing framework: implement panic handling (#33525 )	3 years ago
Liam Cervante	837716a703	testing framework: finalise expect_failures functionality (#33506 )	3 years ago
Martin Atkins	7bee77bdd3	command: Start of propagating OpenTelemetry context Several times over the years we've considered adding tracing instrumentation to Terraform, since even when running in isolation as a CLI program it has a "distributed system-like" structure, with lots of concurrent internal work and also some work delegated to provider plugins that are essentially temporarily-running microservices. However, it's always felt a bit overwhelming to do it because much of Terraform predates the Go context.Context idiom and so it's tough to get a clean chain of context.Context values all the way down the stack without disturbing a lot of existing APIs. This commit aims to just get that process started by establishing how a context can propagate from "package main" into the command package, focusing initially on "terraform init" and some other commands that share some underlying functions with that command. OpenTelemetry has emerged as a de-facto industry standard and so this uses its API directly, without any attempt to hide it behind an abstraction. The OpenTelemetry API is itself already an adapter layer, so we should be able to swap in any backend that uses comparable concepts. For now we just discard the tracing reports by default, and allow users to opt in to delivering traces over OTLP by setting an environment variable when running Terraform (the environment variable was established in an earlier commit, so this commit builds on that.) When tracing collection is enabled, every Terraform CLI run will generate at least one overall span representing the command that was run. Some commands might also create child spans, but most currently do not.	3 years ago
Craig Wright	8f5064e6b4	Merge pull request #33433 from chaosaffe/fix-getcommand-helptext	3 years ago
Liam Cervante	87ed762619	Make flaky 'TestTest_DoubleInterrupt' test more robust (#33503 )	3 years ago
Liam Cervante	4862812c94	testing framework: introduce interrupts for stopping tests (#33477 ) * [testing framework] prepare for beta phase of development * [Testing Framework] Add module block to test run blocks * [testing framework] allow tests to define and override providers * testing framework: introduce interrupts for stopping tests * remove panic handling, will do it properly later	3 years ago
Liam Cervante	4b34902fab	[testing framework] allow tests to define and override providers (#33466 ) * [testing framework] prepare for beta phase of development * [Testing Framework] Add module block to test run blocks * [testing framework] allow tests to define and override providers	3 years ago
Liam Cervante	5acc95dda7	[Testing Framework] Add module block to test run blocks (#33456 ) * [testing framework] prepare for beta phase of development * [Testing Framework] Add module block to test run blocks	3 years ago
Liam Cervante	c9bc7e8479	Add input validation into the 'checks' outputs and tracking (#33481 )	3 years ago
CJ Horton	2622e89cfb	Merge pull request #33448 from agustinguayama/fix/small_typo fix typo in terraform/internal/command /init.go	3 years ago
James Bardin	6be6f69d61	Merge pull request #33482 from hashicorp/jbardin/schema-cache Refactor providers.Schemas and add a global schema cache	3 years ago
kmoe	d1a5dfa1ad	command: test plan -refresh= arg ordering (#33483 ) * main: disambiguate arg ordering test Make it extra clear what order of args we are asserting. * command: fix plan -refresh=false test The test for plan -refresh=false was not functioning, since ReadResource will not be called if the resource is not in prior state. Add a new fixture directory with state, and also test the converse, to prevent regression. * command: add test for refresh flag precedence A consumer relies on the fact that running terraform plan -refresh=false -refresh true gives the same result as terraform plan -refresh=true.	3 years ago
James Bardin	cf5ebaf685	s/Schemas/ProviderSchema/	3 years ago
James Bardin	36d34135ad	replace remaining types in tests	3 years ago
James Bardin	d487ce20e1	update jsonprovider to use new schema type	3 years ago
James Bardin	53901a7e62	Add basic global schema cache Add a single global schema cache for providers. This allows multiple provider instances to share a single copy of the schema, and prevents loading the schema multiple times for a given provider type during a single command. This does not currently work with some provider releases, which are using GetProviderSchema to trigger certain initializations. A new server capability will be introduced to trigger reloading their schemas, but not store duplicate results.	3 years ago
Liam Cervante	ea162f6ab5	[testing framework] prepare for beta phase of development (#33445 )	3 years ago
Liam Cervante	3613e972c5	Plan renderer: Support users indexing integer paths with stringified numbers (#33475 )	3 years ago
Agustin Guayama	db5b81d2c1	fix typo in terraform/internal/command /init.go	3 years ago
Liam Cervante	2eb99a0e44	Fix the Terraform build after recent merges (#33436 )	3 years ago
Liam Cervante	212ae6c4ba	Introduce separate testing scope for reference validation (#33339 )	3 years ago
Liam Cervante	dfc26c2ac4	[Testing Framework] Add test command to Terraform CLI (#33327 ) * Add test structure to views package for rendering test output * Add test file HCL configuration and parser functionality * Adds a TestContext structure for evaluating assertions against the state and plan * Add test command to Terraform CLI	3 years ago
Liam Cervante	ed822559e5	[Testing framework] Implement JSON view functionality for test command (#33400 )	3 years ago
kmoe	fbff64ad45	configs: remove import block duplicate id check (#33434 )	3 years ago
Jason Murray	79669df479	Remove PATH from GetCommand helpText	3 years ago
Andrew Hickman	49f99db1c2	`terraform show -json`: Add Errored field to output for plan (#33372 ) * Add Errored field to JSON output * Fix test error message	3 years ago
Liam Cervante	ce8fd2943d	[Testing Framework] Add test structure to views package for rendering test output (#33324 ) * Add test structure to views package for rendering test output * address comments	3 years ago
Liam Cervante	48c818927c	Remove old implementation of terraform test command	3 years ago
Katy Moe	7ce5503c7a	views: fix wordwrap	3 years ago
kmoe	5900d1177c	cloud: assert import block compatibility (#33282 ) * cloud: assert import block compatibility * check for import <> TFC compatibility during init * imports are not in alphabetical order 🙃 --------- Co-authored-by: CJ Horton <cjhorton@hashicorp.com>	3 years ago
kmoe	4386a15684	command: help text for generate-config-out (#33279 )	3 years ago
Martin Atkins	696cd68913	command/views: Describe unknown collection bounds in diagnostics	3 years ago
kmoe	be2ad69eda	plannable import: safer config generation and schema filters (#33232 ) * genconfig: fix nil nested block panic * genconfig: null NestingSingle blocks should be absent A NestingSingle block that is null in state should be completely absent from config. * configschema: make FilterOr variadic * configschema: apply filters to nested types * configschema: filter helper/schema id attribute The legacy SDK adds an Optional+Computed "id" attribute to the resource schema even if not defined in provider code. During validation, however, the presence of an extraneous "id" attribute in config will cause an error. Remove this attribute so we do not generate an "id" attribute where there is a risk that it is not in the real resource schema. * configschema: filter test * terraform: do not pre-validate generated config Config generated from a resource's import state may fail validation in the case of schema behaviours such as ExactlyOneOf and ConflictsWith. We don't want to fail the plan now, because that would give the user no way to proceed and fix the config to make it valid. We allow the plan to complete and output the generated config. * generate config alongside import process Rather than waiting until we call `plan()`, generate the configuration at the point of the import call, so we have the necessary data to return in case planning fails later. The `plan` and `state` predeclared variables in the plan() method were obfuscating the actual return of nil throughout, so those identifiers were removed for clarity. * move generateHCLStringAttributes closer to caller * store generated config in plan on error * test for config gen with error * add simple warning when generating config --------- Co-authored-by: James Bardin <j.bardin@gmail.com>	3 years ago
kmoe	b4d1146f58	plannable import: improve gen config human plan output (#33194 ) * renderer: remove hard-coded config gen path * mention config gen file in plan next steps	3 years ago
CJ Horton	bd6ba6cf99	check for duplicate import blocks (#33190 ) Importing to the same target address twice or importing the same ID to multiple different resources of the same type is not allowed.	3 years ago
Liam Cervante	d5fed58fc5	plannable import: write generated config to out flag (#33186 ) * plannable import: write generated config to out flag * Add example command to diagnostic	3 years ago
CJ Horton	5d7864316e	Merge pull request #33160 from hashicorp/radditude/apply-counts Populate import counts during applies and clean up output	3 years ago
Liam Cervante	192cb255a6	checks: no longer experimental (#33184 )	3 years ago
Liam Cervante	4d837df546	Plannable import: Add generated config to JSON and human-readable plan output (#33154 ) * command: keep our promises * remove some nil config checks Remove some of the safety checks that ensure plan nodes have config attached at the appropriate time. * add GeneratedConfig to plan changes objects Add a new GeneratedConfig field alongside Importing in plan changes. * add config generation package The genconfig package implements HCL config generation from provider state values. Thanks to @mildwonkey whose implementation of terraform add is the basis for this package. * generate config during plan If a resource is being imported and does not already have config, attempt to generate that config during planning. The config is generated from the state as an HCL string, and then parsed back into an hcl.Body to attach to the plan graph node. The generated config string is attached to the change emitted by the plan. * complete config generation prototype, and add tests * Plannable import: Add generated config to json and human-readable plan output --------- Co-authored-by: Katy Moe <katy@katy.moe>	3 years ago
Liam Cervante	79f7f59155	Plannable import: Generate config for imported resources during the plan. (#33153 ) * command: keep our promises * remove some nil config checks Remove some of the safety checks that ensure plan nodes have config attached at the appropriate time. * add GeneratedConfig to plan changes objects Add a new GeneratedConfig field alongside Importing in plan changes. * add config generation package The genconfig package implements HCL config generation from provider state values. Thanks to @mildwonkey whose implementation of terraform add is the basis for this package. * generate config during plan If a resource is being imported and does not already have config, attempt to generate that config during planning. The config is generated from the state as an HCL string, and then parsed back into an hcl.Body to attach to the plan graph node. The generated config string is attached to the change emitted by the plan. * complete config generation prototype, and add tests --------- Co-authored-by: Katy Moe <katy@katy.moe>	3 years ago
CJ Horton	bc084858b1	add import hooks for plan and apply Separate hooks used for the legacy import command for those used by the new import mechanism; also add apply output for imports.	3 years ago
Liam Cervante	2793af042c	Revert "Plannable import: Make the streamed logs more consistent during a plan operation (#33155 )" This reverts commit `3c20f7b340`.	3 years ago
Liam Cervante	3c20f7b340	Plannable import: Make the streamed logs more consistent during a plan operation (#33155 )	3 years ago
hashicorp-copywrite[bot]	bb36298b21	[COMPLIANCE] Add Copyright and License Headers	3 years ago
Liam Cervante	77f10c4f68	Imports should come before Adds in change summaries (#33147 )	3 years ago
Liam Cervante	81eb73731d	[Plannable Import] Implement streamed logs for plan (#33106 ) * [plannable import] embed the resource id within the changes * [Plannable Import] Implement streamed logs for -json plan * use latest structs * remove implementation plans from TODO	3 years ago
Liam Cervante	54c1c1162f	[Plannable Import] Implement human-readable plan rendering (#33113 ) * [plannable import] embed the resource id within the changes * add the plannable imports to the json and human plans * latest importing struct	3 years ago
hashicorp-copywrite[bot]	325d18262e	[COMPLIANCE] Add Copyright and License Headers	3 years ago
Liam Cervante	b5576159da	Migrate 'state show' command to new renderer (#33116 ) * Migrate 'state show' command to new renderer * handle error	3 years ago
Lauren	50c3f53595	add resource_drift logtype	3 years ago
Liam Cervante	b54668f44c	make the unknown attribute renderer consider the force replacement metadata (#33065 )	3 years ago
Liam Cervante	14123e277c	Include sensitive metadata from the schema when building the json state output (#33059 ) * include sensitive metadata from the schema when building the json state output * found another test case	3 years ago
Liam Cervante	519a18aedf	Propagate unknown and sensitive metadata to dynamic attributes (#33057 ) * propagate unknown and sensitive metadata to dynamic attributes * update goimports and add some comments	3 years ago
Liam Cervante	357012a2f3	Refactor of differ to make code reuse easier (#33054 ) * refactor of differ to make code reuse easier * fix imports	3 years ago
Liam Cervante	aae6990d38	Add native `plantimestamp` function to Terraform (#32980 ) * add plantimestamp function * documentation * add missing links * fix typo	3 years ago
Sebastian Rivera	e6c3aab6c5	Merge pull request #33018 from hashicorp/tf-5529-sro-tfe-version-check	3 years ago
Liam Cervante	2c624acea1	Fix rendering unknown values in map and null string primitives (#33029 ) * fix rendering unknown values in map and null string primitives * Update map.go * fix code consistency checks	3 years ago
Sebastian Rivera	300a60f393	Fix typo in format version check	3 years ago
Liam Cervante	978263efe9	Checks: Introduce check blocks into the terraform node and transform graph (#32735 ) * Add support for scoped resources * refactor existing checks addrs and add check block addr * Add configuration for check blocks * introduce check blocks into the terraform node and transform graph * address comments * address comments * don't execute checks during destroy operations * don't even include check nodes for destroy operations	3 years ago
James Bardin	86c0c3bf80	Merge pull request #32846 from hashicorp/fix-32793 emit a warning msg if invalid CLI configuration file location	3 years ago
Reda Khaled	bf723bd65a	fix(init_test.go): in TestInitProvidersLocalOnly tst, set TF_CLI_CONFIG_FILE env var to an empty val	3 years ago
Reda Khaled	fa9d044c58	bugfix(cliconfig.go): emit a warning msg if bad CLI config file path	3 years ago
James Bardin	06f1ceb026	add some output values to the show state test	3 years ago
James Bardin	5ed7f2a798	always use the RenderHuman constructor	3 years ago
Liam Cervante	15ecdb66c8	Fix no-op outputs causing the plan renderer to skip the 'no changes' message (#32820 ) * Fix no-op outputs causing the plan renderer to skip the 'no changes' message * fix imports	3 years ago
Alisdair McDiarmid	8df065a2fe	initwd: Switch from earlyconfig to configs This is a mostly mechanical refactor with a handful of changes which are necessary due to the semantic difference between earlyconfig and configs. When parsing root and descendant modules in the module installer, we now check the core version requirements inline. If the Terraform version is incompatible, we drop any other module loader diagnostics. This ensures that future language additions don't clutter the output and confuse the user. We also add two new checks during the module load process: * Don't try to load a module with a `nil` source address. This is a necessary change due to the move away from earlyconfig. * Don't try to load a module with a blank name (i.e. `module ""`). Because our module loading manifest uses the stringified module path as its map key, this causes a collision with the root module, and a later panic. This is the bug which triggered this refactor in the first place.	3 years ago

... 3 4 5 6 7 ...

819 Commits (9212a2efddbb04069009d5e03eefa366944f013f)