1401 Commits (8eb3f2cf52d72fcbe30d5bdf6a2ff4c2a234f0ee)

Author	SHA1	Message	Date
Kristin Laemmert	49fc53d1d1	provider source enhancements ... * configs: move ProviderConfigCompact[Str] from addrs to configs The configs package is aware of provider name and type (which are the same thing today, but expected to be two different things in a future release), and should be the source of truth for a provider config address. This is an intermediate step; the next step will change the returned types to something based in the configs package. * command: rename choosePlugins to chooseProviders to clarify scope of function * use `Provider.LegacyString()` (instead of `Provider.Type`) consistently * explicitly create legacy-style provider (continuing from above change)	6 years ago
Martin Atkins	c06675c616	command: New -compact-warnings option ... When warnings appear in isolation (not accompanied by an error) it's reasonable to want to defer resolving them for a while because they are not actually blocking immediate work. However, our warning messages tend to be long by default in order to include all of the necessary context to understand the implications of the warning, and that can make them overwhelming when combined with other output. As a compromise, this adds a new CLI option -compact-warnings which is supported for all the main operation commands and which uses a more compact format to print out warnings as long as they aren't also accompanied by errors. The default remains unchanged except that the threshold for consolidating warning messages is reduced to one so that we'll now only show one of each distinct warning summary. Full warning messages are always shown if there's at least one error included in the diagnostic set too, because in that case the warning message could contain additional context to help understand the error.	6 years ago
Kristin Laemmert	f8a23da480	explicitly create legacy-style provider	6 years ago
Kristin Laemmert	86e450a85f	use LegacyString() consistently	6 years ago
Kristin Laemmert	efafadbe5e	command: rename choosePlugins to chooseProviders to clarify scope of function	6 years ago
Kristin Laemmert	67fc4dd5a1	configs: move ProviderConfigCompact[Str] from addrs to configs ... The configs package is aware of provider name and type (which are the same thing today, but expected to be two different things in a future release), and should be the source of truth for a provider config address.	6 years ago
James Bardin	f281eb2b44	Merge pull request #23595 from hashicorp/jbardin/deprecate-destroy-references ... Update destroy provisioner warnings	6 years ago
Pam Selle	d8c31a1efa	Merge pull request #23581 from hashicorp/pselle/show-panic-23377 ... Fix panic on show plan	6 years ago
Pam Selle	9c4d3cc1b1	Add a test	6 years ago
James Bardin	42a2bb4da3	expand test tempdir symlinks to fix tests on macos	6 years ago
James Bardin	96d1e57191	fix type in state mv test	6 years ago
James Bardin	b715ef2590	don't print just warnings when loading backend cfg ... Any warnings will be caught again when the entire config is loaded, and duplicated in the output.	6 years ago
Kristin Laemmert	e3416124cc	addrs: replace "Type string" with "Type Provider" in ProviderConfig ... * huge change to weave new addrs.Provider into addrs.ProviderConfig * terraform: do not include an empty string in the returned Providers / Provisioners - Fixed a minor bug where results included an extra empty string	6 years ago
James Bardin	4896052736	Merge pull request #23582 from hashicorp/jbardin/state-mv ... Allow moving instances to new resources	6 years ago
Aaron Heesakkers	3dfeb67708	command/internal-plugin: Strip off TF_CLI_ARGS arguments ... These are not meaningful for the `internal-plugin` subcommand, which is for internal use only.	6 years ago
James Bardin	a5cb36b34c	Allow moving instances to new resources ... If a state mv target happens to be a resource that doesn't exist, allow the creation of the new resource inferring the EachMode from the target address.	6 years ago
Pam Selle	2b8e876bdb	Don't inspect an empty set, return false	6 years ago
Pam Selle	ba9cb786c3	Merge pull request #23546 from tmshn/dry-plan-color ... make plan-diff format a bit more dry	6 years ago
Kristin Laemmert	9891d0354a	providers: use addrs.Provider as map keys for provider.Factory (#23548) ... * terraform/context: use new addrs.Provider as map key in provider factories * added NewLegacyProviderType and LegacyString funcs to make it explicit that these are temporary placeholders This PR introduces a new concept, provider fully-qualified name (FQN), encapsulated by the `addrs.Provider` struct.	6 years ago
tmshn	fcc1a76d5e	make plan-diff format a bit more dry	6 years ago
Kristin Laemmert	6728e521c1	addrs: rename Provider Name to more accurate Provider Type (#23449)	6 years ago
Kristin Laemmert	99225b8d76	command/jsonstate,plan: fix panic with null values (#23492) ... The code responsible for marshalling attribute values was checking for nil values, but not null. Fixes #23485, #23274	6 years ago
Martin Atkins	7081c26e54	command: Don't show more than two of the same warning ... Some of our warnings are produced in response to particular configuration constructs which might appear many times across a Terraform configuration. To avoid the warning output dwarfing all of the other output, we'll use ConsolidateWarnings to limit each distinct warning summary to appear at most twice, and annotate the final one in the sequence with an additional paragraph noting that some number of them have been hidden. This is intended as a compromise to ensure that these warnings are still seen and noted but to help ensure that we won't produce so many of them as to distract from other output that appears alongside them. This applies only to warnings relating to specific configuration ranges; errors will continue to be shown individually, and sourceless warnings (which are rare in Terraform today) will likewise remain ungrouped because they are less likely to be repeating the same statement about different instances of the same problem throughout the configuration.	7 years ago
Simon Brady	7a9fa93724	command/plan: Fix panic in plan output with string containing null and whitespace (#23102) ... * command/plan: Fix panic in plan output with string containing null and whitespace * command/format: add test for null string with whitespace	7 years ago
Martin Atkins	d0f50ff83f	command: Don't treat config warnings as errors ... Meta.backendConfig was incorrectly treating the second return value from loadBackendConfig as if it were go "error" rather than tfdiags.Diagnostics, which in turn meant that it would treat warnings like errors. This had confusing results because it still returned that tfdiags.Diagnostics value in its own diagnostics return value, causing the caller to see warnings even though the backendConfig function had taken the error codepath.	7 years ago
Ethan	6833ac290b	command: Use full URL for the download page when prompting for upgrade ... This makes it more likely that a terminal emulator will detect the URL as a clickable link.	7 years ago
Thayne McCombs	a895a42f85	command/format: fix missing elements at the end of lists in diffs	7 years ago
James Bardin	bee703360c	Merge pull request #23252 from hashicorp/jbardin/abs-state-dependencies ... store absolute addresses for resource dependencies in the state	7 years ago
Martin Atkins	7db2825646	command/format: multi-line rendering for unchanged strings ... We have a special treatment for multi-line strings that are being updated in-place where we show them across multiple lines in the plan output, but we didn't use that same treatment for rendering multi-line strings in isolation such as when they are being added for the first time. Here we detect when we're rendering a multi-line string in a no-change situation and render it using the diff renderer instead, using the same value for old and new and thus producing a multi-line result without any diff markers at all. This improves consistency between the change and no-change cases, and makes multi-line strings (such as YAML in block mode) readable in all cases.	7 years ago
James Bardin	46dbb3dde5	use Dependencies to connect creator and destroyer ... The DestroyEdgeTransformer cannot determine ordering from the graph when the destroyers are from orphaned resources, because there are no references to resolve. The new stored Dependencies provides what we need to connect the instances in this case. We also add the StateDependencies method directly in the GraphNodeResourceInstance interface, since all instances already implement this, and we don't need another optional interface to check. The old code in DestroyEdgeTransformer may no longer be needed in the long run, but that can be determined separately, since too many of the tests start with an incomplete state and rely on the Dependencies being determined from the configuration alone.	7 years ago
James Bardin	886af20f07	fixup some test comparisons	7 years ago
Josh Grancell	ac3578a0bc	command/output: Absence of outputs is not an error	7 years ago
Martin Atkins	d0cbbb6a00	command/format: Remove defunct "Plan" type and associated symbols ... This "Plan" type, along with the other types it directly or indirectly embeds and the associated functions, are adaptations of the flatmap-oriented plan renderer logic from Terraform 0.11 and prior. The current diff rendering logic is in diff.go, and so the contents of the plan.go file are defunct apart from the DiffActionSymbol function that both implementations share. Therefore here we move DiffActionSymbol into diff.go and then remove plan.go entirely, in the interests of dead code removal.	7 years ago
Martin Atkins	9a62ab3014	command: "terraform show" renders plans like "terraform plan" ... During the Terraform 0.12 work we briefly had a partial update of the old Terraform 0.11 (and prior) diff renderer that could work with the new plan structure, but could produce only partial results. We switched to the new plan implementation prior to release, but the "terraform show" command was left calling into the old partial implementation, and thus produced incomplete results when rendering a saved plan. Here we instead use the plan rendering logic from the "terraform plan" command, making the output of both identical. Unfortunately, due to the current backend architecture that logic lives inside the local backend package, and it contains some business logic around state and schema wrangling that would make it inappropriate to move wholesale into the command/format package. To allow for a low-risk fix to the "terraform show" output, here we avoid some more severe refactoring by just exporting the rendering functionality in a way that allows the "terraform show" command to call into it. In future we'd like to move all of the code that actually writes to the output into the "command" package so that the roles of these components are better segregated, but that is too big a change to block fixing this issue.	7 years ago
rajata07	f40f8bd4e3	small fix with command usage 'terraform workspace New'	7 years ago
James Bardin	2c3c011f20	change state dependencies to AbsResource addrs ... We need to be able to reference all possible dependencies for ordering when the configuration is no longer present, which means that absolute addresses must be used. Since this is only to recreate the proper ordering for instance destruction, only resources addresses need to be listed rather than individual instance addresses.	7 years ago
Kristin Laemmert	4b10a6e1bf	command/jsonplan: fix bug with nested modules output (#23092) ... `marshalPlannedValues` builds a map of modules to their children in order to output the resource changes in a tree. The map was built from the list of resource changes. However if a module had no resources itself, and only called another module (a very normal case), that module would not get added to the map causing none of its children to be output in `planned_values`. This PR adds a walk up through a given module's ancestors to ensure that each module, even those without resources, would be added.	7 years ago
Radek Simko	c1ea09141f	Merge pull request #23063 from hashicorp/svchost-migration ... Replace svchost package with hashicorp/terraform-svchost	7 years ago
Kristin Laemmert	96af863065	command/validate: warn if unused flags are set on the command line (#22989) ... * command/validate: output a warning if unused flags are set The -var and -var-file command line flags are accepted, but not used, in `terraform validate`. This PR adds a warning for users who set either of those flags, so they know that setting them has no effect.	7 years ago
Radek Simko	32f9722d9d	Replace import paths & set UA string where necessary	7 years ago
Martin Atkins	8664749b59	backend: Allow certain commands to opt out of required variable checks ... Terraform Core expects all variables to be set, but for some ancillary commands it's fine for them to just be set to placeholders because the variable values themselves are not key to the command's functionality as long as the terraform.Context is still self-consistent. For such commands, rather than prompting for interactive input for required variables we'll just stub them out as unknowns to reflect that they are placeholders for values that a user would normally need to provide. This achieves a similar effect to how these commands behaved before, but without the tendency to produce a slightly invalid terraform.Context that would fail in strange ways when asked to run certain operations.	7 years ago
Martin Atkins	e21f0fa61e	backend/local: Handle interactive prompts for variables in UI layer ... During the 0.12 work we intended to move all of the variable value collection logic into the UI layer (command package and backend packages) and present them all together as a unified data structure to Terraform Core. However, we didn't quite succeed because the interactive prompts for unset required variables were still being handled _after_ calling into Terraform Core. Here we complete that earlier work by moving the interactive prompts for variables out into the UI layer too, thus allowing us to handle final validation of the variables all together in one place and do so in the UI layer where we have the most context still available about where all of these values are coming from. This allows us to fix a problem where previously disabling input with -input=false on the command line could cause Terraform Core to receive an incomplete set of variable values, and fail with a bad error message. As a consequence of this refactoring, the scope of terraform.Context.Input is now reduced to only gathering provider configuration arguments. Ideally that too would move into the UI layer somehow in a future commit, but that's a problem for another day.	7 years ago
Jeff Green	e505845a63	command/apply: remove duplicate statement (#23011)	7 years ago
Kristin Laemmert	a9da6f0e5b	command/jsonstate: properly marshal deposed resources (#23027) ... * command/jsonstate: properly marshal deposed resources This PR addresses 2 issues: `show -json` would crash if there was not a `Current` `states.ResourceInstance` for a given resource, and `deposed` resource instances were not shown at all. Fixes #22642	7 years ago
Nick Fagerlund	02d793f0ff	website / help: reconcile 'validate' command docs	7 years ago
Martin Atkins	39e609d5fd	vendor: switch to HCL 2.0 in the HCL repository ... Previously we were using the experimental HCL 2 repository, but now we'll shift over to the v2 import path within the main HCL repository as part of actually releasing HCL 2.0 as stable. This is a mechanical search/replace to the new import paths. It also switches to the v2.0.0 release of HCL, which includes some new code that Terraform didn't previously have but should not change any behavior that matters for Terraform's purposes. For the moment the experimental HCL2 repository is still an indirect dependency via terraform-config-inspect, so it remains in our go.sum and vendor directories for the moment. Because terraform-config-inspect uses a much smaller subset of the HCL2 functionality, this does still manage to prune the vendor directory a little. A subsequent release of terraform-config-inspect should allow us to completely remove that old repository in a future commit.	7 years ago
Kristin Laemmert	54661ec1df	command/import: fix error during import when implied provider was not used (#22855) ... * command/import: properly use `-provider` supplied on the command line The import command now attaches the provider configuration in the resource instance, if set. That config is attached to the NodeAbstractResource during the import graph building. This prevents errors when the implied provider is not actually in the configuration at all, which may happen when a configuration is using the `-beta` version of a provider (and only that `-beta` version). * command/import: fix variable reassignment and update docs Fixes #22564	7 years ago
Lars Lehtonen	85b2000223	command/show: Fix dropped errors (#22772)	7 years ago
Kristin Laemmert	120bb0a66c	plugin/discovery: use new addrs.ProviderType in place of a provider typeName string (#22724) ... This is a relatively small change meant to lay the foundation for future enhancements to providers' address.	7 years ago
Martin Atkins	0ca6b578f5	command/login: Remove unimplemented -into-file option ... This was a vestige from earlier prototyping when we were considering supporting adding credentials to existing .tfrc native syntax files. However, that proved impractical because the CLI config format is still HCL 1.0 and that can't reliably perform programmatic surgical updates, so we'll remove this option for now. We might add it back in later if it becomes more practical to support it.	7 years ago
Martin Atkins	8381112a5c	command: Tests for the "terraform login" command ... These run against a stub OAuth server implementation, verifying that we are able to run an end-to-end login transaction for both the authorization code and the password grant types. This includes adding support for authorization code grants to our stub OAuth server implementation; it previously supported only the password grant type.	7 years ago
Martin Atkins	7ccd6204c4	command: Swappable implementation of launching web browsers ... For unit testing in particular we can't launch a real browser for testing, so this indirection is primarily to allow us to substitute a mock when testing a command that can launch a browser. This includes a simple mock implementation that expects to interact with a running web server directly.	7 years ago
Martin Atkins	daf733af33	command/login: UI cleanup	7 years ago
Martin Atkins	f25cb008f1	command/login: Save the new API token ... Once we've successfully obtained an API token, we'll can save it in the credentials store.	7 years ago
Martin Atkins	a1e387a0e5	command: A stub OAuth server implementation for login testing	7 years ago
Martin Atkins	f605bde562	command/login: Password-based credentials request	7 years ago
Martin Atkins	cfc1c4900d	command/login: Use Cli.Ask to request confirmation ... This is more straightforward than using readline because it already works properly with panicwrap.	7 years ago
Martin Atkins	0b346e589a	command/login: Show login consent prompt before proceeding ... Because we're going to pass the credentials we obtain on to some credentials store (either a credentials helper or a local file on disk) we ought to disclose that first and give the user a chance to cancel out and set up a different credentials storage mechanism first if desired. This also includes the very beginnings of support for the owner password grant type when running against app.terraform.io. This will be used only temporarily at initial release to allow a faster initial release without blocking on implementation of a full OAuth flow in Terraform Cloud.	7 years ago
Martin Atkins	6bba3ceb42	command: "terraform login" command	7 years ago
Martin Atkins	cf43663e85	command/e2etest: Fix TestInitProviders ... The canonical location of the "template" provider is now in the hashicorp namespace rather than the terraform-providers namespace, so the output has changed to reflect that.	7 years ago
Pam Selle	0d0df8e3f4	Merge pull request #22145 from jeffb4/terraform-21483-allow-vars-for-console ... fix, use extended flags for terraform console	7 years ago
Martin Atkins	c4076fe6a2	command/cliconfig: EmptyCredentialsSourceForTests ... A more convenient interface to get a throwaway empty credentials source for use in tests, which doesn't interact at all with the real CLI configuration directory.	7 years ago
Kristin Laemmert	f4af55d611	command/console: use user-supplied plugin-dir (#22616) ... Previously `terraform console` would output an `init required` error if it was run in a directory originally `init`ed with a `-plugin-dir` specified. Fixes #17826	7 years ago
Martin Atkins	8272d3b101	command/cliconfig: Remove command dependency ... This was a leftover from the migration of these types from the main package, but we don't actually need or want this here because this particular detail is still handled by the main package, and because the cliconfig package must not depend on the command package in order to avoid an import cycle.	7 years ago
Martin Atkins	1e2da4f776	command/cliconfig: New CredentialsSource implementation ... This new implementation is not yet used, but should eventually replace the technique of composing together various types from the svchost/auth package, since our requirements are now complex enough that they're more straightforward to express in direct code within a single type than as a composition of the building blocks in the svchost/auth package.	7 years ago
Hasan Ramezani	f7b1ef876c	command/workspace: Added `show` subcommand to workspace command help text. (#22367)	7 years ago
Kristin Laemmert	c9d62bb2f6	command: discard output from flags package and return errs directly (#22373) ... Any command using meta.defaultFlagSet *might* occasionally exit before the flag package's output got written. This caused flag error messages to get lost. This PR discards the flag package output in favor of directly returning the error to the end user.	7 years ago
Alex Pilon	4bf43efcfd	move hcl2shim package to configs	7 years ago
Pam Selle	ce8e7811ae	Merge pull request #18823 from minamijoyo/fix-multibyte-trucate ... command/hook_ui: Truncate the ID considering multibyte characters	7 years ago
kmoe	3a0c1794b6	Merge pull request #22320 from hashicorp/svh/f-fmt-help ... Mention the -no-color option	7 years ago
Sander van Harmelen	e81fafeefa	Mention the -no-color option ... This option is a valid option for the fmt subcommand, but it isn't listed in the help text.	7 years ago
James Bardin	3cda2bd7a5	Merge pull request #22299 from hashicorp/jbardin/state-mv ... allow moving resource to new modules not in state	7 years ago
hiroqn	de4235698b	command/0.12upgrade: honor user-supplied plugin-dir ... Fixes #21594	7 years ago
James Bardin	32f7f58345	allow moving resource to new modules not in state ... Create the missing modules in the state when moving resources to a module that doesn't yet exist. This allows for refactoring of configuration into new modules, without having to create dummy resources in the module before the "state mv" operations.	7 years ago
Martin Atkins	e1590d0a70	command/cliconfig: Factor out CLI config handling ... This is just a wholesale move of the CLI configuration types and functions from the main package into its own package, leaving behind some type aliases and wrappers for now to keep existing callers working. This commit alone doesn't really achieve anything, but in future commits we'll expand the functionality in this package.	7 years ago
James Bardin	8b2646c2a6	Merge pull request #22149 from hashicorp/jbardin/state-show-deposed ... account for deposed in terraform show	7 years ago
James Bardin	345dfaccb6	Account for deposed instances in show command, adding the details for ... each deposed instance. Prevent crash if the current instance is missing.	7 years ago
Kristin Laemmert	a16e1fc0a1	command/init: omit a warning if -backend-config is used with no backend (#22164) ... * command/init: omit a warning if -backend-config is used with no backend block Terraform would silently accept - and swallow - `-backend-config` on the CLI when there was no `backend` block. Since it is mostly expected to override existing backend configuration, terraform should omit a warning if there is no backend configuration to override. If the user intended to override the default (local) backend configuration, they can first add a `backend` block to the `terraform` block to silence the warning (or just ignore it): ```hcl terraform { backend "local" {} } ```	7 years ago
Jeff Bachtel	4ad7907b0c	fix, use extended flags for terraform console ... Allows -var and -var-file flags as expected	7 years ago
Alex Pilon	d5997e05db	prune dead code from command/meta	7 years ago
appilon	b143c04216	Merge pull request #22125 from hashicorp/appilon/move-VarEnvPrefix ... [SDK cleanup] Move VarEnvPrefix out of terraform pkg	7 years ago
Alex Pilon	e3bc1e7d5c	move VarEnvPrefix out of terraform pkg	7 years ago
Alex Pilon	0450f487fa	move IsEmptyDir to configs package	7 years ago
James Bardin	e4640a43d7	fix show-json test to expect error from nested mod ... One of the show json command tests expected no error when presented with an invalid configuration in a nested module. Modify the test created in PR #21569 so that it can still verify there is no panic, but now expect an error from init.	7 years ago
Masayuki Morita	ca9b643c73	docs: Fix typo in (*Meta) RunOperation comments	7 years ago
Pam Selle	1666df3668	Merge pull request #21911 from Biteable/no-nopop-in-plan-show ... Fixes #21907	7 years ago
Antoine Jacoutot	37a6331ebf	command/version: drop empty line on version check (#14858) ... We always add an empty line when asking/checking the version. We should only do that if there is a new version available. While this is purely cosmetic, it reads better and is consistent with packer.	7 years ago
Dirk Avery	02efe97a59	command/import: change import message to 'prepared' (#20018) ... * Change import message to 'prepared' * Update command/hook_ui.go Co-Authored-By: Kristin Laemmert <mildwonkey@users.noreply.github.com>	7 years ago
Radek Simko	5b9f2fafc8	Standardise directory name for test data	7 years ago
Jon Burgess	c0b1220a92	Fixes #21907 ... Don't show no-ops in `terraform show`, since it's not something that will change any state.	7 years ago
Martin Atkins	b1e92b3769	vendor: go get github.com/hashicorp/hcl2@0b64543c968c ... This includes a fix to make sure that an expression with a static string index, like foo["bar"], will be parsed as a traversal rather than as a dynamic index expression.	7 years ago
Pam Selle	82dcd5276e	Normalize in the fmt -check test	7 years ago
Radek Simko	f342824647	Merge pull request #21334 from hashicorp/b-cmd-show-reduce-whitespaces ... command/format: Reduce extra whitespaces & new lines	7 years ago
Tim Sharpe	615110e13e	provisioner: new Puppet provisioner (#18851) ... * Basic Puppet provisioner * (fixup) fix snake_case use in Bolt * (fixup) Remove unused ValidateFunc * (fixup) Check bolt result status * (lint) go fmt * Requested changes * Remove PE autodetection * Apply suggestions from @svanharmelen Co-Authored-By: rodjek <tim@sharpe.id.au> * Tag all JSON fields in bolt output * Defer comm.Disconnect() as suggested * Make bolt timeout configurable * Update builtin/provisioners/puppet/resource_provisioner.go Co-Authored-By: rodjek <tim@sharpe.id.au> * Make extension_requests and custom_attributes configurable	7 years ago
James Bardin	e71e3d85a9	Merge pull request #21611 from hashicorp/jbardin/private-data-read ... Make sure resource private data is carried through the entire resource lifecycle	7 years ago
James Bardin	ac2219ba6e	don't lose Private state data during copy ... Fix the scope of the private data copy in DeepCopy. Make sure Dependencies matches nil vs empty so that Equal compares correctly between copied states	7 years ago
Ivan Kalita	5b6b1663ef	backend/http: implement retries for the http backend (#19702) ... Fixes #19619	7 years ago
Kristin Laemmert	b9f114aa25	command/show (json): marshal the state snapshot included with the plan file (#21597) ... * command/show: marshal the state snapshot from the planfile The planfile contains a state snapshot with certain resources updated (outputs and datasources). Previously `terraform show -json PLANFILE` was using the current state instead of the state inside the plan as intended. This caused an issue when the state included a terraform_remote_state datasource. The datasource's state gets refreshed - and therefore upgraded to the current state version - during plan, but that won't persist to state until apply. * update comment to reflect new return	7 years ago
Kristin Laemmert	06a3333316	note: this is an unusual edgecase in the category of "probably should not happen" ... If https://github.com/hashicorp/terraform/issues/21543 is fixed, we can remove this check.	7 years ago
Kristin Laemmert	703f024cbd	command/show (-json): fix panic if a moduleCall has a nil config ... In the unlikely event that a moduleCall has a nil config - for example, if a nested module call includes a variable with a typo in an attribute - continue gracefully.	7 years ago