59 Commits (8c928e83589d90a031f811fae52a81be7153e82f)

Author	SHA1	Message	Date
Martin Atkins	8c928e8358	main: Consult local directories as potential mirrors of providers ... This restores some of the local search directories we used to include when searching for provider plugins in Terraform 0.12 and earlier. The directory structures we are expecting in these are different than before, so existing directory contents will not be compatible without restructuring, but we need to retain support for these local directories so that users can continue to sideload third-party provider plugins until the explicit, first-class provider mirrors configuration (in CLI config) is implemented, at which point users will be able to override these to whatever directories they want. This also includes some new search directories that are specific to the operating system where Terraform is running, following the documented layout conventions of that platform. In particular, this follows the XDG Base Directory specification on Unix systems, which has been a somewhat-common request to better support "sideloading" of packages via standard Linux distribution package managers and other similar mechanisms. While it isn't strictly necessary to add that now, it seems ideal to do all of the changes to our search directory layout at once so that our documentation about this can cleanly distinguish "0.12 and earlier" vs. "0.13 and later", rather than having to document a complex sequence of smaller changes. Because this behavior is a result of the integration of package main with package command, this behavior is verified using an e2etest rather than a unit test. That test, TestInitProvidersVendored, is also fixed here to create a suitable directory structure for the platform where the test is being run. This fixes TestInitProvidersVendored.	6 years ago
Martin Atkins	e9d0822b2a	command: Accept a "provider source" from the main package ... Following the same approach we use for other CLI-Config-able objects like the service discovery system, the main package is responsible for producing a suitable implementation of this interface which the command package can then use. When unit testing in the command package we can then substitute mocks as necessary, following the dependency inversion principle.	6 years ago
Pam Selle	78b1220558	Remove config.go and update things using its aliases	6 years ago
Radek Simko	32f9722d9d	Replace import paths & set UA string where necessary	6 years ago
Martin Atkins	cfc1c4900d	command/login: Use Cli.Ask to request confirmation ... This is more straightforward than using readline because it already works properly with panicwrap.	7 years ago
Martin Atkins	22a2580e93	main: Use the new cliconfig package credentials source ... This should not cause any change in behavior yet, but using this new implementation will allow the "terraform login" and "terraform logout" commands to store and forget credentials when they are implemented in subsequent commits.	7 years ago
Martin Atkins	e1590d0a70	command/cliconfig: Factor out CLI config handling ... This is just a wholesale move of the CLI configuration types and functions from the main package into its own package, leaving behind some type aliases and wrappers for now to keep existing callers working. This commit alone doesn't really achieve anything, but in future commits we'll expand the functionality in this package.	7 years ago
Matthew Sanabria	be04e70a0f	Adding documentation for TF_CLI_CONFIG_FILE environment variable (#20834) ... Fixes #15849	7 years ago
Sander van Harmelen	52a1b22f7a	Implement the remote enhanced backend ... This is a refactored version of the `remote` backend that was initially added to Terraform v0.11.8 which should now be compatible with v0.12.0.	7 years ago
Martin Atkins	a3403f2766	terraform: Ugly huge change to weave in new State and Plan types ... Due to how often the state and plan types are referenced throughout Terraform, there isn't a great way to switch them out gradually. As a consequence, this huge commit gets us from the old world to a _compilable_ new world, but still has a large number of known test failures due to key functionality being stubbed out. The stubs here are for anything that interacts with providers, since we now need to do the follow-up work to similarly replace the old terraform.ResourceProvider interface with its replacement in the new "providers" package. That work, along with work to fix the remaining failing tests, will follow in subsequent commits. The aim here was to replace all references to terraform.State and its downstream types with states.State, terraform.Plan with plans.Plan, state.State with statemgr.State, and switch to the new implementations of the state and plan file formats. However, due to the number of times those types are used, this also ended up affecting numerous other parts of core such as terraform.Hook, the backend.Backend interface, and most of the CLI commands. Just as with 5861dbf3fc before, I apologize in advance to the person who inevitably just found this huge commit while spelunking through the commit history.	7 years ago
Martin Atkins	bd10b84a8e	command/format: include source snippets in diagnostics ... If we get a diagnostic message that references a source range, and if the source code for the referenced file is available, we'll show a snippet of the source code with the source range highlighted. At the moment we have no cache of source code, so in practice this codepath can never be visited. Callers to format.Diagnostic will be gradually updated in subsequent commits.	7 years ago
Sander van Harmelen	7fb2d1b8de	Implement the Enterprise enhanced remote backend	8 years ago
Sander van Harmelen	179b32d426	Add a `CredentialsForHost` method to disco.Disco ... By adding this method you now only have to pass a `*disco.Disco` object around in order to do discovery and use any configured credentials for the discovered hosts. Of course you can also still pass around both a `*disco.Disco` and a `auth.CredentialsSource` object if there is a need or a reason for that!	8 years ago
Martin Atkins	275ab4a74e	main: don't print the CLI config into the logs ... Now that we're expecting "credentials" blocks in the config (with auth tokens for private module registries, etc) we should not print out the config contents into the log, or else people will probably end up accidentally disclosing their credentials when sharing debug output with us, or will be reluctant to share debug output.	8 years ago
Martin Atkins	11ba1d2a4c	main: factor out CLI config loading into its own function ... Previously we handled all of the config sources directly within the main function. We're going to make CLI config loading more complex shortly, so having this encapsulated in its own function will avoid creating even more clutter inside the main function. Along the way here we also switch from using native Go "error" to using tfdiags.Diagnostics, so that we can potentially issue warnings here too in future, and so that we can return multiple errors.	8 years ago
Martin Atkins	a2c59c6ecd	main: validate credentials blocks in CLI config ... We require that each "credentials" block has a valid hostname and that there be no more than one "credentials_helper" block. There are some more sophisticated validations we could do here, such as checking if the same host is declared more than once, but since this config handling will be rewritten to use HCL2 in the near future, and this sort of check is easier to do in the HCL2 API, we just check the basic stuff for now and plan to revisit later.	8 years ago
Martin Atkins	cb17a9a607	main: allow enabling plugin caching via config file or environment ... Either the environment variable TF_PLUGIN_CACHE_DIR or a setting in the CLI config file (~/.terraformrc on Unix) allow opting in to the plugin caching behavior. This is opt-in because for new users we don't want to pollute their system with extra directories they don't know about. By opting in to caching, the user is assuming the responsibility to occasionally prune the cache over time as older plugins become stale and unused.	9 years ago
Martin Atkins	3f401f0cd4	main: make configuration available when initializing commands ... This, in principle, allows us to make use of configuration information when we populate the Meta structure, though we won't actually make use of that until a subsequent commit.	9 years ago
Martin Atkins	9b5ae9143a	main: enable basic subcommand autocomplete ... The CLI package has automatic support for shell autocomplete (bash and zsh, at time of writing) for subcommands, so all we need to do here is just opt into it. Users can install this into their shells by running: terraform -install-autocomplete	9 years ago
Martin Atkins	8364383c35	Push plugin discovery down into command package ... Previously we did plugin discovery in the main package, but as we move towards versioned plugins we need more information available in order to resolve plugins, so we move this responsibility into the command package itself. For the moment this is just preserving the existing behavior as long as there are only internal and unversioned plugins present. This is the final state for provisioners in 0.10, since we don't want to support versioned provisioners yet. For providers this is just a checkpoint along the way, since further work is required to apply version constraints from configuration and support additional plugin search directories. The automatic plugin discovery behavior is not desirable for tests because we want to mock the plugins there, so we add a new backdoor for the tests to use to skip the plugin discovery and just provide their own mock implementations. Most of this diff is thus noisy rework of the tests to use this new mechanism.	9 years ago
Martin Atkins	5ac311e2a9	main: synchronize writes to VT100-faker on Windows ... We use a third-party library "colorable" to translate VT100 color sequences into Windows console attribute-setting calls when Terraform is running on Windows. colorable is not concurrency-safe for multiple writes to the same console, because it writes to the console one character at a time and so two concurrent writers get their characters interleaved, creating unreadable garble. Here we wrap around it a synchronization mechanism to ensure that there can be only one Write call outstanding across both stderr and stdout, mimicking the usual behavior we expect (when stderr/stdout are a normal file handle) of each Write being completed atomically.	9 years ago
Mitchell Hashimoto	3dfc46abd3	log the Go runtime version at TF startup ... This will help us debug issues which have been caused by Go bugs.	9 years ago
Mitchell Hashimoto	518ae5ef02	support nested subcommands with TF_CLI_ARGS	9 years ago
Mitchell Hashimoto	df93e5120c	allow targeted TF_CLI_ARGS_x	9 years ago
Mitchell Hashimoto	53796fcdb0	test for blank args for TF_CLI_ARGS	9 years ago
Mitchell Hashimoto	7f67b32169	main: add TF_CLI_ARGS to specify additional CLI args	9 years ago
Mitchell Hashimoto	e9c35eae32	Forward SIGTERM and handle that as an interrupt	9 years ago
Mitchell Hashimoto	557375f2a2	Update panicwrap to pass through all interrupt signals	9 years ago
Justin Nauman	bf48d0132c	Checkpoint signature fixes ... - Currently the disable_checkpoint setting from $HOME/.terraformrc is never respsected due to: -- The runCheckpoint go routine being fired off prior to loading configuration -- The config.Merge method not actually merging in the c2s settings	9 years ago
James Bardin	797a1b339d	DebugInfo and DebugGraph ... Implement debugInfo and the DebugGraph DebugInfo will be a global variable through which graph debug information can we written to a compressed archive. The DebugInfo methods are all safe for concurrent use, and noop with a nil receiver. The API outside of the terraform package will be to call SetDebugInfo to create the archive, and CloseDebugInfo() to properly close the file. Each write to the archive will be flushed and sync'ed individually, so in the event of a crash or a missing call to Close, the archive can still be recovered. The DebugGraph is a representation of a terraform Graph to be written to the debug archive, currently in dot format. The DebugGraph also contains an internal buffer with Printf and Write methods to add to this buffer. The buffer will be written to an accompanying file in the debug archive along with the graph. This also adds a GraphNodeDebugger interface. Any node implementing `NodeDebug() string` can output information to annotate the debug graph node, and add the data to the log. This interface may change or be removed to provide richer options for debugging graph nodes. The new graph builders all delegate the build to the BasicGraphBuilder. Having a Name field lets us differentiate the actual builder implementation in the debug graphs.	9 years ago
James Bardin	6b7a079bff	Add a way to avoid panicwrap when debugging ... When trying to use a debugger, you don't want the terraform to run in a new child process. Setting TF_FORK=0 will skip panicwrap and continue running the program in the current process. This will also give direct access to log output, and stdout.	10 years ago
Mitchell Hashimoto	b8036095d4	Logs contain CLI args	10 years ago
Chris Bednarski	3c774af9c2	Warn when an internal plugin is overridden ... Also added documentation explaining what happened and how to fix it	10 years ago
Chris Bednarski	e942a74def	Set a log prefix for each plugin and remove go-dynect global log prefix (#6336)	10 years ago
Mitchell Hashimoto	d1b46e99bd	Add `terraform state list` command ... This introduces the terraform state list command to list the resources within a state. This is the first of many state management commands to come into 0.7. This is the first command of many to come that is considered a "plumbing" command within Terraform (see "plumbing vs porcelain": http://git.661346.n2.nabble.com/what-are-plumbing-and-porcelain-td2190639.html). As such, this PR also introduces a bunch of groundwork to support plumbing commands. The main changes: - Main command output is changed to split "common" and "uncommon" commands. - mitchellh/cli is updated to support nested subcommands, since terraform state list is a nested subcommand. - terraform.StateFilter is introduced as a way in core to filter/search the state files. This is very basic currently but I expect to make it more advanced as time goes on. - terraform state list command is introduced to list resources in a state. This can take a series of arguments to filter this down. Known issues, or things that aren't done in this PR on purpose: - Unit tests for terraform state list are on the way. Unit tests for the core changes are all there.	10 years ago
James Nugent	8e4da4e2a1	deps: Vendor github.com/hashicorp/go-plugin	10 years ago
James Nugent	c77144bd5b	core: Fix console colors on Windows ... This brings in the go-colorable library when running on Windows in order to output console colors correctly instead of leaving the codes in place as is currently the case.	10 years ago
Paul Hinze	4bd4e18def	core: use same logging setup for acctests ... We weren't doing any log setup for acceptance tests, which made it difficult to wrangle log output in CI. This moves the log setup functions we use in `main` over into a helper package so we can use them for acceptance tests as well. This means that acceptance tests will by default be a _lot_ quieter, only printing out actual test output. Setting `TF_LOG=trace` will restore the full prior noise level. Only minor behavior change is to make `ioutil.Discard` the default return value rather than a `nil` that needs to be checked for.	10 years ago
Sander van Harmelen	a465c6f4cc	Remove duplicate code ... Seems to be a refactoring leftover of some kind as on lines 146-148 these calls are done again…	11 years ago
Mitchell Hashimoto	c84af741de	Log the version info for easier debugging	11 years ago
Mitchell Hashimoto	70191d22a6	Add checkpoint	12 years ago
Mitchell Hashimoto	1510f12efc	output errors to the proper location in main.go [GH-288]	12 years ago
Mitchell Hashimoto	238ec05f2f	Fix issue where output could be truncated	12 years ago
Mitchell Hashimoto	4fd3dff829	main: auto-discover plugins [GH-190] ... /cc @pearkes @armon - exe dir and pwd	12 years ago
Mitchell Hashimoto	2e2f6bf0f4	main: clean up the code surrounding config file loading	12 years ago
Camilo Aguilar	fd361c1eb6	Clarifies that what failed loading is the CLI configuration as opposed to Terraform TF files	12 years ago
Camilo Aguilar	d3a609ac52	Ports Packer code to load CLI configuration and external plugins	12 years ago
Mitchell Hashimoto	3a8606c117	Recognize -version	12 years ago
Armon Dadgar	1c4321a503	Setup provisioners for CLI	12 years ago
Mitchell Hashimoto	0e88867052	Compile	12 years ago