64 Commits (885a366f2e2f727773efd6d8fad17a1dc2ebab6f)

Author	SHA1	Message	Date
Martin Atkins	d0e6a4c69a	lang: Add "formatdate" function ... We missed this one on a previous pass of bringing in most of the cty stdlib functions. This will resolve #17625 by allowing conversion from Terraform's conventional RFC 3339 timestamps into various other formats.	7 years ago
Martin Atkins	c753df6a93	lang/funcs: templatefile function ... This function is similar to the template_file data source offered by the template provider, but having it built in to the language makes it more convenient to use, allowing templates to be rendered from files anywhere an inline template would normally be allowed: user_data = templatefile("${path.module}/userdata.tmpl", { hostname = format("petserver%02d", count.index) }) Unlike the template_file data source, this function allows values of any type in its variables map, passing them through verbatim to the template. Its tighter integration with Terraform also allows it to return better error messages with source location information from the template itself. The template_file data source was originally created to work around the fact that HIL didn't have any support for map values at the time, and even once map support was added it wasn't very usable. With HCL2 expressions, there's little reason left to use a data source to render a template; the only remaining reason left to use template_file is to render a template that is constructed dynamically during the Terraform run, which is a very rare need.	7 years ago
Martin Atkins	2be524d6ac	core: Validate depends_on and ignore_changes traversals ... Both depends_on and ignore_changes contain references to objects that we can validate. Historically Terraform has not validated these, instead just ignoring references to non-existent objects. Since there is no reason to refer to something that doesn't exist, we'll now verify this and return errors so that users get explicit feedback on any typos they may have made, rather than just wondering why what they added seems to have no effect. This is particularly important for ignore_changes because users have historically used strange values here to try to exploit the fact that Terraform was resolving ignore_changes against a flatmap. This will give them explicit feedback for any odd constructs that the configuration upgrade tool doesn't know how to detect and fix.	7 years ago
Martin Atkins	e63a1dfb96	lang: EvalExpr only convert if wantType is not dynamic ... This actually seems to be a bug in the underlying cty Convert function since converting to cty.DynamicPseudoType should always just return the input verbatim, but it seems like it's actually converting unknown values of any type to be cty.DynamicVal, losing the type information. We should eventually fix this in cty too, but having this extra check in the Terraform layer is harmless and allows us to make progress without context-switching.	7 years ago
Martin Atkins	30497bbfb7	lang/funcs: zipmap accepts tuple of values and produces object ... Now that our language supports tuple/object types in addition to list/map types, it's convenient for zipmap to be able to produce an object type given a tuple, since this makes it symmetrical with "keys" and "values" such the the following identity holds for any map or object value "a" a == zipmap(keys(a), values(a)) When the values sequence is a tuple, the result has an object type whose attribute types correspond to the given tuple types. Since an object type has attribute names as part of its definition, there is the additional constraint here that the result has an unknown type (represented by the dynamic pseudo-type) if the given values is a tuple and the given keys contains any unknown values. This isn't true for values as a list because we can predict the resulting map element type using just the list element type.	8 years ago
Martin Atkins	3b49028b77	core: Static-validate resource references against schemas ... In the initial move to HCL2 we started relying only on full expression evaluation to catch attribute errors, but that's not sufficient for resource attributes in practice because during validation we can't know yet whether a resource reference evaluates to a single object or to a list of objects (if count is set). To address this, here we reinstate some static validation of resource references by analyzing directly the reference objects, disregarding any instance index if present, and produce errors if the remaining subsequent traversal steps do not correspond to items within the resource type schema. This also allows us to produce some more specialized error messages for certain situations. In particular, we can recognize a reference like aws_instance.foo.count, which in 0.11 and prior was a weird special case for determining the count value of a resource block, and offer a helpful error showing the new length(aws_instance.foo) usage pattern. This eventually delegates to the static traversal validation logic that was added to the configschema package in a previous commit, which also includes some specialized error messages that distinguish between attributes and block types in the schema so that the errors relate more directly to constructs the user can see in the configuration. In future we could potentially move more of the checks from the dynamic schema construction step to the static validation step, but resources are the reference type that most needs this immediately due to the ambiguity caused by the instance indexing syntax. We can safely refactor other reference types to be statically validated in later releases. This is verified by two pre-existing context validate tests which we temporarily disabled during earlier work (now re-enabled) and also by a new validate test aimed specifically at the special case for the "count" attribute.	8 years ago
Martin Atkins	ecc42b838c	lang/funcs: Fix crash and improve precision of keys/values functions ... The "values" function wasn't producing consistently-ordered keys in its result, leading to crashes. This fixes #19204. While working on these functions anyway, this also improves slightly their precision when working with object types, where we can produce a more complete result for unknown values because the attribute names are part of the type. We can also produce results for known maps that have unknown elements; these unknowns will also appear in the values(...) result, allowing them to propagate through expressions. Finally, this adds a few more test cases to try different permutations of empty and unknown values.	8 years ago
Martin Atkins	8c01cf7293	lang/funcs: Fix broken test for lookup function ... When the value we're looking in has an object type, we need to know the key in order to decide the result type. Therefore an object lookup with an unknown key must produce cty.DynamicVal, not an unknown value with a known type.	8 years ago
Martin Atkins	8f578c365f	lang/funcs: Permit object types in the "length" function ... The implementation already allowed this, so this was just an oversight in the type checking function. This fixes #19278.	8 years ago
Radek Simko	b41cda7d7a	Return cty.DynamicPseudoType instead	8 years ago
Radek Simko	4856d81300	lang: Fix crash in lookup function	8 years ago
James Bardin	9e3c23d890	verify that all LengthInt calls are known ... There were some funcs with LengthInt calls on unknown values	8 years ago
Radek Simko	edaa4bbc82	lang: Add fileexists function	8 years ago
Kristin Laemmert	fd77e56fd6	lookup will return a tuple type when passed an object	8 years ago
Kristin Laemmert	f54ee830d3	lang/funcs: update values to accept object types	8 years ago
Kristin Laemmert	4ec904bca7	funcs/lang lookup: validate that argument is map or object type	8 years ago
Kristin Laemmert	d1d0ede069	lang/funcs: return default value if provided when object lookup fails to find attr	8 years ago
Kristin Laemmert	46e168a682	lang/funcs: update lookup() to accept object-typed values for "map" arg	8 years ago
Martin Atkins	c990c9f36d	lang/funcs: Don't panic if coalescelist gets an unknown list	8 years ago
Martin Atkins	db58b88c2d	lang/funcs: short-circuit with unknown index and tuple collection ... Since we need to know the index to know the result type for a tuple, we need a special case here to deal with that situation and return cty.DynamicVal; we can't predict the result type exactly until we know the element type.	8 years ago
Martin Atkins	efe631d9ec	lang/funcs: in "sort", don't panic if given a null string ... It is incorrect to use a null string, but that should be reported as an error rather than a panic.	8 years ago
Martin Atkins	479c6b2466	move "configschema" from "config" to "configs" ... The "config" package is no longer used and will be removed as part of the 0.12 release cleanup. Since configschema is part of the "new world" of configuration modelling, it makes more sense for it to live as a subdirectory of the newer "configs" package.	8 years ago
Martin Atkins	ccd90bcf35	lang/funcs: never include the private key in error output ... This is based on c811440188 made against the old "config" package implementations, but also catches a few other cases where we would previously have printed the private key into the error messages.	8 years ago
Kristin Laemmert	c23a971ed1	minor fixes	8 years ago
Kristin Laemmert	0dbecc54c0	functions: ValuesFunc - cleanup return type	8 years ago
Kristin Laemmert	a213c4a648	functions: add tests and support for unknown values	8 years ago
Kristin Laemmert	d802d5c624	functions: pr feedback fixes	8 years ago
Kristin Laemmert	ff4b3d763b	functions: fix lookup()'s handling of numberical defaults	8 years ago
Kristin Laemmert	4f5c03339a	functions: ZipmapFunc	8 years ago
Kristin Laemmert	605e23db6b	various code review fixes	8 years ago
Kristin Laemmert	6463dd90e9	functions: TransposeFunc, SliceFunc	8 years ago
Kristin Laemmert	30671d85ad	functions: MergeFunc	8 years ago
Kristin Laemmert	aecd7b2e62	functions: LookupFunc	8 years ago
Kristin Laemmert	4d8c398f8e	functions: KeysFunc	8 years ago
Kristin Laemmert	21daabe680	functions: MapFunc	8 years ago
Kristin Laemmert	da02e0da4d	functions: ListFunc	8 years ago
Kristin Laemmert	529c2c3cc9	functions: FlattenFunc	8 years ago
Kristin Laemmert	4dd3ffc127	porting matchkeys	8 years ago
Kristin Laemmert	b979053361	general cleanup - addressing code review	8 years ago
Kristin Laemmert	498ffbf77b	adding some test cases and tweaking implementation to address them	8 years ago
Kristin Laemmert	0cbcd75ebb	port distinct and chunklist functions	8 years ago
Kristin Laemmert	8aac7587f7	port index and contains functions	8 years ago
Kristin Laemmert	e697e7d733	port compact function	8 years ago
Kristin Laemmert	1901d5d184	port coalescelist function	8 years ago
Kristin Laemmert	04ac87747c	base64decode: check that the decoded (not encoded) string is valid UTF-8	8 years ago
Kristin Laemmert	74f2d58b8b	base64decode: check that the decoded (not encoded) string is valid UTF-8	8 years ago
Kristin Laemmert	6171ba3b8a	base64decodeFunc now checks for valid UTF-8	8 years ago
Kristin Laemmert	b6d3d69d3a	port cidr functions	8 years ago
Kristin Laemmert	10ef61c71c	porting many functions	8 years ago
Kristin Laemmert	602b59cdc4	porting functions	8 years ago