terraform

Commit Graph

Author	SHA1	Message	Date
Martin Atkins	606e7c991f	flatmap: be resilient to lying "foo.#" key We use the .# key primarily as a hint that we have a list, but its value describes how many items the writer thinks were in the list. Since this information is redundant with the _actual_ data, it's potentially useful as a form of corrupted data detection but this function isn't equipped to actually report on such a problem (no error return value, and not in a good place for UI feedback anyway), so instead we'll largely ignore this value and just go by the number of items we encounter. The result of this is that when the counts mismatch we will go by the number of items actually holding the prefix, rather than panicking as we would've before. This fixes the crashes in #15300, #15135 and #15334, though it does not address any root-cause for the count to be incorrect in the first place, so there may be something to fix here somewhere else.	9 years ago
James Bardin	f7adde0c44	remove maps with empty counts during expand When we encounter maps with empty counts, remove them from the expansion to prevent already empty sub-elements from being retained. Convert TestExpand to subtests for easier debugging.	9 years ago
Sander van Harmelen	3d0073e05c	core: fix a crash by suggesting a different approach to solve #11170 (#13541 ) * Revert #11245, #11321, #11498 and #11757 These PR’s are all related to issue #11170 for which I would like to propose a different solution then the one currently implemented. * A different approach to solve #11170 This approach has (IMHO) a few advantages with regards to the solution currently implemented. I will elaborate on this in the PR.	9 years ago
James Bardin	057941ce18	make flatmap.Expand understand computed sets For historical reasons, sets are represented as sparse lists in a flatmap, however a computed set does not have a numeric index. Strip the `~` flag from a computed set's index during expansion, and add it back in the prefix after sorting.	9 years ago
Mitchell Hashimoto	c6d0333dc0	flatmap: mark computed list as a computed value in Expand Fixes #12183 The fix is in flatmap for this but the entire issue is a bit more complex. Given a schema with a computed set, if you reference it like this: lookup(attr[0], "field") And "attr" contains a computed set within it, it would panic even though "field" is available. There were a couple avenues I could've taken to fix this: 1.) Any complex value containing any unknown value at any point is entirely unknown. 2.) Only the specific part of the complex value is unknown. I took route 2 so that the above works without any computed (since "name" is not computed but something else is). This may actually have an effect on other parts of Terraform configs, however those similar configs would've simply crashed previously so it shouldn't break any pre-existing configs.	9 years ago
James Bardin	1cec04b8a7	Add test for set expansion in flatmap.Expand	9 years ago
James Bardin	c7f5d8b7e7	Add tests for nested structues in flatmap.Expand	9 years ago
Mitchell Hashimoto	308b88a8d8	flatmap: never auto-convert ints	12 years ago
Mitchell Hashimoto	1277c324d0	flatmap: deeper nesting tests	12 years ago
Mitchell Hashimoto	ad2f448911	flatmap: expand	12 years ago

10 Commits (7ee433955536db3fdff2dba9548cd2e88ae8a43c)