terraform

Commit Graph

Author	SHA1	Message	Date
James Bardin	2cbb6bf92f	udpate code which was failing staticckeck Some updates to staticcheck were catching more errors. Most of these were format functions without a format string, but rather than adding more exceptions I just fixed them all. This did also catch some incorrectly wrapped errors.	2 years ago
James Bardin	809fe73b84	update deps to match go1.23 Make sure tooling dependencies are updated to use go1.23, and get any closely related package updates, like golang.org/x/*	2 years ago
James Bardin	4b2380ca7c	update to go1.23 Release notes: https://go.dev/doc/go1.23	2 years ago
Radek Simko	5a38b5323f	backend/local: Indicate ephemerality in variable prompts (#35694 )	2 years ago
James Bardin	f844ba0be6	Merge pull request #34988 from hashicorp/nolegacysdk-kubernetes backend/kubernetes: Remove legacy helper/schema dependency	2 years ago
James Bardin	5001b937fe	remove unused replace directive	2 years ago
James Bardin	84b4bfa270	Merge pull request #34987 from hashicorp/nolegacysdk-pg backend/pg: Stop using legacy helper/schema	2 years ago
James Bardin	17e79d6d4c	remove unused replace directive	2 years ago
kmoe	a2039517a5	states: store ephemeral output values in memory (#35676 ) Ephemeral root output values must be kept in the in-memory state representation, but not written to the state file. To achieve this, we store ephemeral root outputs separately from non-ephemeral root outputs, so Terraform can access them during a single plan or apply phase. Ephemeral root outputs always have a value of null in the state file. This means that the "terraform output" command, that reads the state file, reports null values for these outputs. Consumers of 'terraform output -json' should use the presence of '"ephemeral": true' in such output to interpret the value correctly.	2 years ago
James Bardin	a168379937	update test fixtures There were two failing ACC tests with this update. One from from a newer version of pg, which causes a different auth error message. The other is is directly related to this PR, which was checking for a specific schema error, which is now `invalid value for "skip_schema_creation"` when a non-bool argument is present.	2 years ago
kmoe	fab3673f8d	lang: stabilise ephemeral values experiment (#35636 ) * lang: stabilise ephemeral values experiment Stabilise the ephemeral values experiment and ephemeralasnull experimental function. * simplify handling of apply time input vars As the final step in stabilising the ephemeral values experiment, we can remove the separate code path for handling input variables supplied via -var and -var-file during apply. The intent here is conveyed in the tests: when applying a saved plan, all ephemeral variables set in the plan (the "apply-time variables"), must be set, and no others. As per the TODO copied from the prototype, there is some more work to be done here in making the handling of undeclared variables during apply as sophisticated as that during plan, emitting helpful warnings (for example) when input variables are supplied unnecessarily via environment variables. * experiments: officially conclude EV experiment --------- Co-authored-by: Radek Simko <radek.simko@gmail.com>	2 years ago
Radek Simko	64d1b075e4	backend/local: Allow ephemeral values to be set via prompt during apply (#35626 )	2 years ago
James Bardin	8383cbcc2a	update more tests	2 years ago
Jeff Bonhag	8b2941455a	Upgrade go-tfe from 1.51.0 to 1.58.0 (#35495 ) * go get github.com/hashicorp/go-tfe@v1.58.0 * Switch to go.uber.org/mock for mocks	2 years ago
Martin Atkins	fce24d588f	backend/kubernetes: Remove legacy helper/schema dependency As with most of our remote state backends, this one was depending on just a tiny slice of the (enormous and now-poorly-understood) legacy SDK. In an effort to eliminate the legacy SDK snapshot from this codebase, this replaces it with functionality from our new "backendbase" package, which aims to provide just a narrow set of utilities to minimize the churn caused by removing the legacy SDK and thus reduce the risk of this change. This is currently using the "SDK-like" utilities, which emulate some of the questionable-but-convenient assumptions the legacy SDK makes, such as the idea that empty string and null are equivalent. Hopefully in future we can wean this backend even further off of these older assumptions, but the priority for now is to eliminate the legacy SDK without significantly disturbing the shape of the existing working code.	2 years ago
Martin Atkins	3cc1c1e4e7	backend/pg: Stop using legacy helper/schema The legacy SDK is a very heavy dependency that this backend was only using tiny parts of. We'll now instead use our new "backendbase" package, which aims to provide a smaller set of helper functions that cover the main use-cases that the existing backends were relying on the SDK to meet, but with considerably less code and fewer layers of abstraction.	2 years ago
James Bardin	8b1f19d923	update go-cty@v1.15.0	2 years ago
Jamie Finnigan	bbd258bd93	move from Go 1.22.4 to 1.22.5 (#35494 )	2 years ago
Jamie Finnigan	54f937cc3c	upgrade github.com/hashicorp/go-retryablehttp & deps (#35473 )	2 years ago
Sarah French	125cf53470	Add acceptance and internal tests for `gcs` backend, add some test helper functions (#35026 ) * Add TF_ACC checks in gcs tests, separate from the bucket setup logic * Add tests for handling of `encryption_key` and `kms_encryption_key` * Refactor `setupBackend` to take config as an argument * Add test that asserts that setting credentials to `""` in the config doesn't affect use of ENV-supplied credentials * Move non-acceptance tests into separate test file * Add comment about `getWantValue` * Fix use of t.Parallel * Make `preCheckTestAcc` skip tests, so that checks can pass in hashicorp/terraform PRs * Add precheck for credentials in test environment. Skip if missing, to let checks pass in hashicorp/terraform repo. * Update new test to use precheck functions Move `TestBackendEncryptionKeyEmptyConflict` test to internal test file * Address feedback about how expected encryption key is supplied to test cases * Change test case * Address missing return	2 years ago
Radek Simko	5e3a44fc11	deps: Bump go-getter to v1.7.5 (#35376 ) * deps: Bump go-getter to v1.7.5 * make syncdeps	2 years ago
Liam Cervante	0f0414d484	Fix partial address representation in plan for deferred actions (#34966 ) * Fix partial address representation in plan * reflect new type in stacks	2 years ago
Jamie Finnigan	68ceed40e1	move from Go 1.22.1 to 1.22.4 (#35335 )	2 years ago
Martin Atkins	9dd16a7fba	command: "terraform apply" accepts variable values with saved plan To support ephemeral values we need a more complicated set of rules about what input variables can and must be set when applying a saved plan. The command itself does not have enough information to implement those rules itself, so we'll let them pass through and check this in the local backend's apply phase instead. The local backend's apply phase already had basic support for dealing with apply-time variable values, but it'll now also be responsible for rejecting attempts to set variables when the experiment isn't enabled, to keep all of this logic in roughly the same place.	2 years ago
Martin Atkins	598e67a0f2	backend/local: Handle apply-time values for ephemeral input variables When the ephemeral variables experiment is active we can potentially have input variables whose values need to be provided separately in both the plan and apply phases, as a compromise to avoid writing those values as part of a saved plan file and to allow the given value to vary between the two phases if necessary. The CLI layer must therefore re-process the given input variable values during the apply phase whenever this experiment is active for the root module and the plan recorded at least one apply-time variable name. To reduce the risk of this new logic accidentally impacting non-experimental usage, the whole call is guarded by whether the root module is participating in the experiment. Checking just the root module is sufficient here because only the root input variables are directly handled by the CLI layer; input variables for descendent modules are handled entirely within the modules runtime.	2 years ago
Martin Atkins	91c88f4705	go.mod: go get github.com/apparentlymart/go-versions@v1.0.2 This includes a fix in the handling of conflicting constraints referring to prereleases, like "1.0.0-beta.1, !1.0.0-beta.1". Previously the library would incorrectly treat that as a positive match, rather than having the negative override the positive as happens in all other cases.	2 years ago
MicahKimel	3258744166	Remove invalid warning during cleanup phase (#35172 ) * stop invalid warning during cleanup phase * stop invalid warning during cleanup phase * invalid warning during cleanup phase * remove unwanted comment * update GetVariables parameter for including warnings * invalid warning during cleanup phase test case * update invalid warnings in cleanup test case to throw a warning for the validation variable before cleanup phase * remove unwanted warnings	2 years ago
James Bardin	b955c9d95f	Merge pull request #35165 from hashicorp/bump_golang_x_net update golang.org/x/net, addressing CVE-2023-45288	2 years ago
Sebastian Rivera	7012371d1f	Merge pull request #35176 from hashicorp/sebasslash/tf-15302_modifiable-snapshot-interval Add `TF_STATE_PERSIST_INTERVAL` environment variable.	2 years ago
Sebastian Rivera	a72d02135b	Define StatePersistInterval as command meta field	2 years ago
Jamie Finnigan	368ccbf63a	make syncdeps	2 years ago
Brandon Croft	716fcce239	chore: add command ctx to GetRootOutputValues	2 years ago
Liam Cervante	bba161ce6b	terraform test: remove planned state from plan (#35049 )	2 years ago
Martin Atkins	1df01fdd2b	backend/local: Allow experiments when loading config from snapshot If a saved plan is being applied using a Terraform CLI/Core build that allows use of language experiments then that should be allowed when the configuration is being loaded from the snapshot saved in a plan file, in the same way as it would've been handled when preparing to generate that plan file. The local backend doesn't get told directly whether it should allow experiments, and instead its operation comes with a pre-configured configuration loader that may have the experiment flag set internally. When we load from snapshot we can't use the operation's own config loader because that loads from the real filesystem, and so we'll copy over the experiments-allowed flag from the operation's config loader to achieve consistency while still loading the configuration from the snapshot in the plan file. Without this a plan successfully created with experiments would fail with confusing errors during apply, because the snapshot config loader would not accept the same experiments that the plan-time config loader did.	2 years ago
Alex Ott	5422c0d3f6	Make persist interval configurable via environment variable Signed-off-by: Alex Ott <alexott@gmail.com>	2 years ago
Martin Atkins	660ff86c4c	backendbase: Preserve unset arguments as null when not set by env Previously we tried a simplification where any attribute with an "SDK-like default" was guaranteed to never be null, because that seemed like a plausible mimic of the legacy SDK's general aversion to nulls. However, the SDK does still respect the absense of an argument as different to its zero value in one narrow case: when the argument isn't set in the configuration, also isn't set by any environment variables, and has no static fallback default. In that case, the SDK's built-in validation rules such as "ConflictsWith" _do_ treat absent as different from zero-value. To allow backends to continue making such distinctions themselves where that's useful, SDKLikeDefaults now leaves an attribute set to null if it wasn't present in the configuration and none of the environment variables or fallback value cause it to end up being a non-empty string. The backend can then choose to bypass the SDKLikeData API and check the cty.Value directly if it wants to distinguish set from zero even though SDKLikeData is designed to avoid the need to do that. This also updates the gcs backend to make use of the new facility, since it wants to raise an error if two arguments are both set even if they are both set to the empty string. Restoring that original error case is the main motivation for this change.	2 years ago
Martin Atkins	c77898c90d	logging: Remove import github.com/coreos/pkg/capnslog We were importing this to resolve an init-time conflict with this library when it was indirectly loaded by the etcd libraries. We removed the etcd backends a while back and so we no longer use any of the etcd modules in Terraform, and so this tricky import was our only remaining reference to github.com/coreos/pkg/capnslog. Dropping this eliminates two unnecessary dependencies.	2 years ago
James Bardin	b79589d2d5	udpate submodule deps	2 years ago
Jamie Finnigan	e9a33de0d2	go get github.com/hashicorp/go-getter && go mod tidy (#35041 ) * go get github.com/hashicorp/go-getter && go mod tidy * make syncdeps	2 years ago
Nick Fagerlund	40b6f21b3d	Merge pull request #35050 from hashicorp/rebrand-hcp-terraform Rebrand Terraform Cloud to HCP Terraform	2 years ago
Sebastian Rivera	015f795ff0	Rebrand Terraform Cloud to HCP Terraform	2 years ago
Liam Cervante	448775102c	terraform test: Push evaluation of variables to as late as possible (#35014 ) * terraform test: Push evaluation of variables to as late as possible * Update internal/moduletest/hcl/variable_cache.go Co-authored-by: kmoe <5575356+kmoe@users.noreply.github.com> * address comments --------- Co-authored-by: kmoe <5575356+kmoe@users.noreply.github.com>	2 years ago
Martin Atkins	5868f99413	backend/gcs: Stop using legacy helper/schema As part of our efforts to remove the large snapshot of the legacy SDK that we've been using, this replaces the uses of that package with our new lightweight "backendbase" package, which is a collection of helpers that can substitute for most of the parts of the legacy SDK that backends tend to use. For this backend for now we'll use the "SDK like" helpers which aim to retain some of the legacy-SDK-specific assumptions that aren't technically true anymore, such as the idea that null and empty string are equivalent. Hopefully one day we'll be able to wean this backend off of that more completely, but this is a pragmatic way to get away from the legacy SDK without a large rewrite. This also drew attention to the fact that this backend was previously relying on the weird context.Context value that the SDK was passing in to the configure method, even though that context isn't connected up to anything particularly useful. In the long run we should change the backend APIs to pass context.Context to each method that might make network requests, but for now we're using context.TODO so that we can more easily find these cases and update them later once there's a real context to use.	2 years ago
Liam Cervante	6963c54bec	terraform test: don't remove sensitive marks from inputs (#35021 )	2 years ago
Martin Atkins	5e7d0f0854	go.mod: Update to latest github.com/zclconf/go-cty-debug This extends the "CmpOptions" to include a comparer for cty.Path values, so that we don't have to hand-write that in each case where we're comparing data structures containing those.	2 years ago
Martin Atkins	397ea6d05c	moduletest: Capture optional "execution meta" for test runs For now this is only to have a place to save the execution duration, but wrapped in a separate struct so that we can distinguish between cases when it is set and when it isn't, because not all test runners will necessarily populate this and even those that do might not populate it in situations where, for example, a test run gets skipped due to an upstream failure. As of this commit, nothing makes use of this new information. A future commit will use it as part of the experimental JUnit XML output from "terraform test", since the JUnit XML format de-facto _requires_ an execution duration for every test case.	2 years ago
Nick Fagerlund	0a4c6c3cb8	Merge pull request #34914 from hashicorp/nf/mar24-enable-deferred-actions Allow enabling deferred actions in PlanOpts	2 years ago
Martin Atkins	40255906f0	go.mod: Update OpenTelemetry dependencies to v1.24.0 We previously had a strange assortment of different versions, but it's typically best to have all of these fixed to the same version because otherwise there can be quirky interactions where e.g. an interface type has changed without updating its implementors, etc. This intentionally does not yet upgrade the contrib packages or exporters because they imply other dependency upgrades that we want to perform separately first, so we can avoid changing too much at once.	2 years ago
Nick Fagerlund	1781c8e8e9	Experimental `-allow-deferral` flag for enabling deferred actions on CLI Now that deferred actions is a top-level per-plan option, here's a lil command-line option for turning it on! - It's called `-allow-deferral`. - It is ONLY legal to use if this is an experimental build, i.e. compiled with `go build -ldflags "-w -s -X 'main.experimentsAllowed=yes'"` or the like. Implementation notes: The design constraint here was, "please avoid having to change the build infrastructure or alter the function of every args parsing function". So, since `extendedFlagSet()` doesn't have access to the var that says we're in an experimental build, I had to move the validation for that particular flag to later in the process, when we're building the operation request.	2 years ago
Jared Baker	c140e2eef1	Merge branch 'main' into patch-1	2 years ago

1 2 3 4 5 ...

449 Commits (7e767490c87bae2fa2b60da33ecefa1b7a220afa)