433 Commits (7bee77bdd3dc67de0973e1c19bd5a1685dc805c0)

Author	SHA1	Message	Date
Martin Atkins	7bee77bdd3	command: Start of propagating OpenTelemetry context ... Several times over the years we've considered adding tracing instrumentation to Terraform, since even when running in isolation as a CLI program it has a "distributed system-like" structure, with lots of concurrent internal work and also some work delegated to provider plugins that are essentially temporarily-running microservices. However, it's always felt a bit overwhelming to do it because much of Terraform predates the Go context.Context idiom and so it's tough to get a clean chain of context.Context values all the way down the stack without disturbing a lot of existing APIs. This commit aims to just get that process started by establishing how a context can propagate from "package main" into the command package, focusing initially on "terraform init" and some other commands that share some underlying functions with that command. OpenTelemetry has emerged as a de-facto industry standard and so this uses its API directly, without any attempt to hide it behind an abstraction. The OpenTelemetry API is itself already an adapter layer, so we should be able to swap in any backend that uses comparable concepts. For now we just discard the tracing reports by default, and allow users to opt in to delivering traces over OTLP by setting an environment variable when running Terraform (the environment variable was established in an earlier commit, so this commit builds on that.) When tracing collection is enabled, every Terraform CLI run will generate at least one overall span representing the command that was run. Some commands might also create child spans, but most currently do not.	3 years ago
Craig Wright	8f5064e6b4	Merge pull request #33433 from chaosaffe/fix-getcommand-helptext	3 years ago
Liam Cervante	87ed762619	Make flaky 'TestTest_DoubleInterrupt' test more robust (#33503)	3 years ago
Liam Cervante	4862812c94	testing framework: introduce interrupts for stopping tests (#33477) ... * [testing framework] prepare for beta phase of development * [Testing Framework] Add module block to test run blocks * [testing framework] allow tests to define and override providers * testing framework: introduce interrupts for stopping tests * remove panic handling, will do it properly later	3 years ago
Liam Cervante	4b34902fab	[testing framework] allow tests to define and override providers (#33466) ... * [testing framework] prepare for beta phase of development * [Testing Framework] Add module block to test run blocks * [testing framework] allow tests to define and override providers	3 years ago
Liam Cervante	5acc95dda7	[Testing Framework] Add module block to test run blocks (#33456) ... * [testing framework] prepare for beta phase of development * [Testing Framework] Add module block to test run blocks	3 years ago
Liam Cervante	c9bc7e8479	Add input validation into the 'checks' outputs and tracking (#33481)	3 years ago
CJ Horton	2622e89cfb	Merge pull request #33448 from agustinguayama/fix/small_typo ... fix typo in terraform/internal/command /init.go	3 years ago
James Bardin	6be6f69d61	Merge pull request #33482 from hashicorp/jbardin/schema-cache ... Refactor providers.Schemas and add a global schema cache	3 years ago
kmoe	d1a5dfa1ad	command: test plan -refresh= arg ordering (#33483) ... * main: disambiguate arg ordering test Make it extra clear what order of args we are asserting. * command: fix plan -refresh=false test The test for plan -refresh=false was not functioning, since ReadResource will not be called if the resource is not in prior state. Add a new fixture directory with state, and also test the converse, to prevent regression. * command: add test for refresh flag precedence A consumer relies on the fact that running terraform plan -refresh=false -refresh true gives the same result as terraform plan -refresh=true.	3 years ago
James Bardin	cf5ebaf685	s/Schemas/ProviderSchema/	3 years ago
James Bardin	36d34135ad	replace remaining types in tests	3 years ago
James Bardin	d487ce20e1	update jsonprovider to use new schema type	3 years ago
James Bardin	53901a7e62	Add basic global schema cache ... Add a single global schema cache for providers. This allows multiple provider instances to share a single copy of the schema, and prevents loading the schema multiple times for a given provider type during a single command. This does not currently work with some provider releases, which are using GetProviderSchema to trigger certain initializations. A new server capability will be introduced to trigger reloading their schemas, but not store duplicate results.	3 years ago
Liam Cervante	ea162f6ab5	[testing framework] prepare for beta phase of development (#33445)	3 years ago
Liam Cervante	3613e972c5	Plan renderer: Support users indexing integer paths with stringified numbers (#33475)	3 years ago
Agustin Guayama	db5b81d2c1	fix typo in terraform/internal/command /init.go	3 years ago
Liam Cervante	2eb99a0e44	Fix the Terraform build after recent merges (#33436)	3 years ago
Liam Cervante	212ae6c4ba	Introduce separate testing scope for reference validation (#33339)	3 years ago
Liam Cervante	dfc26c2ac4	[Testing Framework] Add test command to Terraform CLI (#33327) ... * Add test structure to views package for rendering test output * Add test file HCL configuration and parser functionality * Adds a TestContext structure for evaluating assertions against the state and plan * Add test command to Terraform CLI	3 years ago
Liam Cervante	ed822559e5	[Testing framework] Implement JSON view functionality for test command (#33400)	3 years ago
kmoe	fbff64ad45	configs: remove import block duplicate id check (#33434)	3 years ago
Jason Murray	79669df479	Remove PATH from GetCommand helpText	3 years ago
Andrew Hickman	49f99db1c2	`terraform show -json`: Add Errored field to output for plan (#33372) ... * Add Errored field to JSON output * Fix test error message	3 years ago
Liam Cervante	ce8fd2943d	[Testing Framework] Add test structure to views package for rendering test output (#33324) ... * Add test structure to views package for rendering test output * address comments	3 years ago
Liam Cervante	48c818927c	Remove old implementation of terraform test command	3 years ago
Katy Moe	7ce5503c7a	views: fix wordwrap	3 years ago
kmoe	5900d1177c	cloud: assert import block compatibility (#33282) ... * cloud: assert import block compatibility * check for import <> TFC compatibility during init * imports are not in alphabetical order 🙃 --------- Co-authored-by: CJ Horton <cjhorton@hashicorp.com>	3 years ago
kmoe	4386a15684	command: help text for generate-config-out (#33279)	3 years ago
Martin Atkins	696cd68913	command/views: Describe unknown collection bounds in diagnostics	3 years ago
kmoe	be2ad69eda	plannable import: safer config generation and schema filters (#33232) ... * genconfig: fix nil nested block panic * genconfig: null NestingSingle blocks should be absent A NestingSingle block that is null in state should be completely absent from config. * configschema: make FilterOr variadic * configschema: apply filters to nested types * configschema: filter helper/schema id attribute The legacy SDK adds an Optional+Computed "id" attribute to the resource schema even if not defined in provider code. During validation, however, the presence of an extraneous "id" attribute in config will cause an error. Remove this attribute so we do not generate an "id" attribute where there is a risk that it is not in the real resource schema. * configschema: filter test * terraform: do not pre-validate generated config Config generated from a resource's import state may fail validation in the case of schema behaviours such as ExactlyOneOf and ConflictsWith. We don't want to fail the plan now, because that would give the user no way to proceed and fix the config to make it valid. We allow the plan to complete and output the generated config. * generate config alongside import process Rather than waiting until we call `plan()`, generate the configuration at the point of the import call, so we have the necessary data to return in case planning fails later. The `plan` and `state` predeclared variables in the plan() method were obfuscating the actual return of nil throughout, so those identifiers were removed for clarity. * move generateHCLStringAttributes closer to caller * store generated config in plan on error * test for config gen with error * add simple warning when generating config --------- Co-authored-by: James Bardin <j.bardin@gmail.com>	3 years ago
kmoe	b4d1146f58	plannable import: improve gen config human plan output (#33194) ... * renderer: remove hard-coded config gen path * mention config gen file in plan next steps	3 years ago
CJ Horton	bd6ba6cf99	check for duplicate import blocks (#33190) ... Importing to the same target address twice or importing the same ID to multiple different resources of the same type is not allowed.	3 years ago
Liam Cervante	d5fed58fc5	plannable import: write generated config to out flag (#33186) ... * plannable import: write generated config to out flag * Add example command to diagnostic	3 years ago
CJ Horton	5d7864316e	Merge pull request #33160 from hashicorp/radditude/apply-counts ... Populate import counts during applies and clean up output	3 years ago
Liam Cervante	192cb255a6	checks: no longer experimental (#33184)	3 years ago
Liam Cervante	4d837df546	Plannable import: Add generated config to JSON and human-readable plan output (#33154) ... * command: keep our promises * remove some nil config checks Remove some of the safety checks that ensure plan nodes have config attached at the appropriate time. * add GeneratedConfig to plan changes objects Add a new GeneratedConfig field alongside Importing in plan changes. * add config generation package The genconfig package implements HCL config generation from provider state values. Thanks to @mildwonkey whose implementation of terraform add is the basis for this package. * generate config during plan If a resource is being imported and does not already have config, attempt to generate that config during planning. The config is generated from the state as an HCL string, and then parsed back into an hcl.Body to attach to the plan graph node. The generated config string is attached to the change emitted by the plan. * complete config generation prototype, and add tests * Plannable import: Add generated config to json and human-readable plan output --------- Co-authored-by: Katy Moe <katy@katy.moe>	3 years ago
Liam Cervante	79f7f59155	Plannable import: Generate config for imported resources during the plan. (#33153) ... * command: keep our promises * remove some nil config checks Remove some of the safety checks that ensure plan nodes have config attached at the appropriate time. * add GeneratedConfig to plan changes objects Add a new GeneratedConfig field alongside Importing in plan changes. * add config generation package The genconfig package implements HCL config generation from provider state values. Thanks to @mildwonkey whose implementation of terraform add is the basis for this package. * generate config during plan If a resource is being imported and does not already have config, attempt to generate that config during planning. The config is generated from the state as an HCL string, and then parsed back into an hcl.Body to attach to the plan graph node. The generated config string is attached to the change emitted by the plan. * complete config generation prototype, and add tests --------- Co-authored-by: Katy Moe <katy@katy.moe>	3 years ago
CJ Horton	bc084858b1	add import hooks for plan and apply ... Separate hooks used for the legacy import command for those used by the new import mechanism; also add apply output for imports.	3 years ago
Liam Cervante	2793af042c	Revert "Plannable import: Make the streamed logs more consistent during a plan operation (#33155)" ... This reverts commit 3c20f7b340.	3 years ago
Liam Cervante	3c20f7b340	Plannable import: Make the streamed logs more consistent during a plan operation (#33155)	3 years ago
hashicorp-copywrite[bot]	bb36298b21	[COMPLIANCE] Add Copyright and License Headers	3 years ago
Liam Cervante	77f10c4f68	Imports should come before Adds in change summaries (#33147)	3 years ago
Liam Cervante	81eb73731d	[Plannable Import] Implement streamed logs for plan (#33106) ... * [plannable import] embed the resource id within the changes * [Plannable Import] Implement streamed logs for -json plan * use latest structs * remove implementation plans from TODO	3 years ago
Liam Cervante	54c1c1162f	[Plannable Import] Implement human-readable plan rendering (#33113) ... * [plannable import] embed the resource id within the changes * add the plannable imports to the json and human plans * latest importing struct	3 years ago
hashicorp-copywrite[bot]	325d18262e	[COMPLIANCE] Add Copyright and License Headers	3 years ago
Liam Cervante	b5576159da	Migrate 'state show' command to new renderer (#33116) ... * Migrate 'state show' command to new renderer * handle error	3 years ago
Lauren	50c3f53595	add resource_drift logtype	3 years ago
Liam Cervante	b54668f44c	make the unknown attribute renderer consider the force replacement metadata (#33065)	3 years ago
Liam Cervante	14123e277c	Include sensitive metadata from the schema when building the json state output (#33059) ... * include sensitive metadata from the schema when building the json state output * found another test case	3 years ago