453 Commits (76ea6c59cd06dbb710d0b3adbd11f9985c2f2e05)

Author	SHA1	Message	Date
James Nugent	ef3aad1231	core: Correctly format nested outputs ... This commit pretty prints outputs which consist of nested complex structures (e.g. lists of lists, lists of maps). Fixes #7143.	10 years ago
James Nugent	1ca51ab454	Merge pull request #7589 from hashicorp/b-data-source-plan-counts ... command: Do not count data sources in plan totals	10 years ago
Derek Abdine	7bdc060d24	provider/logentries: Implementing logentries provider (#7067) ... * logentries provider * logentries vendoring * logentries docs	10 years ago
Paul Hinze	d5a941a0a4	command: Do not count data sources in plan totals ... Fixes #7483	10 years ago
James Bardin	b0b2923027	Merge pull request #7443 from hashicorp/jbardin/GH-7264 ... core: Use -state-out option when applying from a plan	10 years ago
James Bardin	6b5ee73e86	Use -state-out option when applying from a plan ... When working from an existing plan, we weren't setting the PathOut field for a LocalState. This required adding an outPath argument to the StateFromPlan function to avoid having to introspect the returned state.State interface to find the appropriate field. To test we run a plan first and provide the new plan to apply with `-state-out` set.	10 years ago
James Bardin	db83a779ab	Fix plan output for data sources ... Data sources are given a special plan output when the diff would show it creating a new resource, to indicate that there is only a logical data resource being read. Data sources nested in modules weren't formatted in the plan output in the same way. This checks for the "data." part of the path in nested modules, and adds acceptance tests for the plan output.	10 years ago
James Nugent	b190aa05a5	core: Add missing OutputStates in synthetic state ... In cases where we construct state directly rather than reading it via the usual methods, we need to ensure that the necessary maps are initialized correctly.	10 years ago
James Nugent	aa5dc453ee	cli: Fix registration of `state mv`. ... Fixes #7259.	10 years ago
James Nugent	75ab4a9970	core: Fix crash with tainted resource ... This commit fixes a crash in `terraform show` where there is no primary resource, but there is a tainted resource, because of the changes made to tainted resource handling in 0.7.	10 years ago
James Nugent	7aec98237c	core: Format empty lists and maps in output ... `terraform output` and it's brethren now consolidate empty maps and lists on a single line of output instead of the pathological behaviour of taking three lines previously. The same code paths are used across all output mechanisms: ``` $ cat main.tf variable "emptystring" { type = "string" default = "" } variable "emptylist" { type = "list" default = [] } variable "emptymap" { type = "map" default = {} } output "emptystring" { value = "${var.emptystring}" } output "emptylist" { value = "${var.emptylist}" } output "emptymap" { value = "${var.emptymap}" } $ terraform apply Apply complete! Resources: 0 added, 0 changed, 0 destroyed. Outputs: emptylist = [] emptymap = {} emptystring = $ terraform output emptylist = [] emptymap = {} emptystring = $ terraform show Outputs: emptylist = [] emptymap = {} emptystring = ```	10 years ago
Paul Hinze	1a0893ddc7	command/plan: remove -backup from help text ... The `-backup` flag no longer applies since `terrafom plan` does not write state. Fixes #7087	10 years ago
Maxime Bury	c98f391bee	Add basic implementation for remote state on azure (#7064) ... * Add basic implementation for remote state on azure * Don't auto-provision the container * Fix compilation errors * Add factory to the remote map * Add documentation * Add acceptance tests	10 years ago
James Nugent	c96a8d5302	core: Update `terraform show` to deal with lists ... Fixes #6931.	10 years ago
Matt Morrison	cbfb4d8b86	remote state: Add GCS provider for remote state	10 years ago
Chris Marchesi	9d7fb89114	core: Adding Sensitive attribute to resource schema ... This an effort to address hashicorp/terraform#516. Adding the Sensitive attribute to the resource schema, opening up the ability for resource maintainers to mark some fields as sensitive. Sensitive fields are hidden in the output, and, possibly in the future, could be encrypted.	10 years ago
James Nugent	5a0f6565d3	Merge pull request #6672 from apparentlymart/random-provider ... Logical Resources for Random Values	10 years ago
Sander van Harmelen	d97b24e3c1	Add tests and fix last issues	10 years ago
Sander van Harmelen	8560f50cbc	Change taint behaviour to act as a normal resource ... This means it’s shown correctly in a plan and takes into account any actions that are dependant on the tainted resource and, vice verse, any actions that the tainted resource depends on. So this changes the behaviour from saying this resource is tainted so just forget about it and make sure it gets deleted in the background, to saying I want that resource to be recreated (taking into account the existing resource and it’s place in the graph).	10 years ago
Paul Hinze	aee1520ac5	core: Make refresh message explicitly point out lack of state persist ... Helps make clear to users that refresh only occurs in-memory during plan per @jen20's recommendation	10 years ago
Paul Hinze	ae73aa2fb4	core: Do not persist state after plans ... This makes the behavior of plans much more predictable, as they no longer potentially have side effects on shared remote state.	10 years ago
James Nugent	28ad394264	build: Update generated internal plugin list	10 years ago
James Nugent	8e732c104b	core: Error over panic if output type unknown	10 years ago
James Nugent	3ea3c657b5	core: Use OutputState in JSON instead of map ... This commit forward ports the changes made for 0.6.17, in order to store the type and sensitive flag against outputs. It also refactors the logic of the import for V0 to V1 state, and fixes up the call sites of the new format for outputs in V2 state. Finally we fix up tests which did not previously set a state version where one is required.	10 years ago
Martin Atkins	3e34ddbf38	New "random" provider, representing randomness ... This provider will have logical resources that allow Terraform to "manage" randomness as a resource, producing random numbers on create and then retaining the outcome in the state so that it will remain consistent until something explicitly triggers generating new values. Managing randomness in this way allows configurations to do things like random distributions and ids without causing "perma-diffs".	10 years ago
Martin Atkins	2ca10ad962	command: Show data source reads differently in plans ... Internally a data source read is represented as a creation diff for the resource, but in the UI we'll show it as a distinct icon and color so that the user can more easily understand that these operations won't affect any real infrastructure. Unfortunately by the time we get to formatting the plan in the UI we only have the resource names to work with, and can't get at the original resource mode. Thus we're forced to infer the resource mode by exploiting knowledge of the naming scheme.	10 years ago
Martin Atkins	bfee4b0295	command: don't show old values for create diffs in plan ... New resources logically don't have "old values" for their attributes, so showing them as updates from the empty string is misleading and confusing. Instead, we'll skip showing the old value in a creation diff.	10 years ago
Martin Atkins	5d27a5b3e2	command: Show id only when refreshing managed resources ... Data resources don't have ids when they refresh, so we'll skip showing the "(ID: ...)" indicator for these. Showing it with no id makes it look like something is broken.	10 years ago
Martin Atkins	60c24e3319	command: Prevent data resources from being tainted ... Since the data resource lifecycle contains no steps to deal with tainted instances, we must make sure that they never get created. Doing this out in the command layer is not the best, but this is currently the only layer that has enough information to make this decision and so this simple solution was preferred over a more disruptive refactoring, under the assumption that this taint functionality eventually gets reworked in terms of StateFilter anyway.	10 years ago
Mitchell Hashimoto	b728f8c018	terraform: import state ID should be sent to hook	10 years ago
Mitchell Hashimoto	f6a59734ef	command: UI for import	10 years ago
Mitchell Hashimoto	d6c059c43e	command/import: tests passing	10 years ago
Mitchell Hashimoto	3c9a92e04a	command: Context buliding allows empty module trees	10 years ago
Mitchell Hashimoto	182a8a28c0	command/import more wip	10 years ago
Mitchell Hashimoto	ff94381e7e	command/import wip	10 years ago
Mitchell Hashimoto	d94f503501	command/state meta: State func	10 years ago
Mitchell Hashimoto	f34ef1f92a	command: compilation works ... This still isn't ready. But this gets tests passing and compilation working	10 years ago
Mitchell Hashimoto	04598baa25	website: document state mv	10 years ago
Mitchell Hashimoto	c966a70ff9	command: update docs for state mv	10 years ago
Mitchell Hashimoto	32d0d29b56	command: test for moving into another state file	10 years ago
Mitchell Hashimoto	235e860118	command/state mv: handle -state-out to a different path	10 years ago
Mitchell Hashimoto	c4e5355a02	command/state mv	10 years ago
James Nugent	6a20e8927d	core: Fix issues from rebasing dev-0.7 onto master ... - Fix sensitive outputs for lists and maps - Fix test prelude which was missed during conflict resolution - Fix `terraform output` to match old behaviour and not have outputs header and colouring - Bump timeout on TestAtlasClient_UnresolvableConflict	10 years ago
James Nugent	9d77e0af6c	core: Add new providers to internal list	10 years ago
Mitchell Hashimoto	473a58a672	Add `terraform state list` command ... This introduces the terraform state list command to list the resources within a state. This is the first of many state management commands to come into 0.7. This is the first command of many to come that is considered a "plumbing" command within Terraform (see "plumbing vs porcelain": http://git.661346.n2.nabble.com/what-are-plumbing-and-porcelain-td2190639.html). As such, this PR also introduces a bunch of groundwork to support plumbing commands. The main changes: - Main command output is changed to split "common" and "uncommon" commands. - mitchellh/cli is updated to support nested subcommands, since terraform state list is a nested subcommand. - terraform.StateFilter is introduced as a way in core to filter/search the state files. This is very basic currently but I expect to make it more advanced as time goes on. - terraform state list command is introduced to list resources in a state. This can take a series of arguments to filter this down. Known issues, or things that aren't done in this PR on purpose: - Unit tests for terraform state list are on the way. Unit tests for the core changes are all there.	10 years ago
Chris Bednarski	e942a74def	Set a log prefix for each plugin and remove go-dynect global log prefix (#6336)	10 years ago
James Nugent	991dc3f86f	core: Add Cobbler provider to internal plugin list	10 years ago
James Nugent	e57a399d71	core: Use native HIL maps instead of flatmaps ... This changes the representation of maps in the interpolator from the dotted flatmap form of a string variable named "var.variablename.key" per map element to use native HIL maps instead. This involves porting some of the interpolation functions in order to keep the tests green, and adding support for map outputs. There is one backwards incompatibility: as a result of an implementation detail of maps, one could access an indexed map variable using the syntax "${var.variablename.key}". This is no longer possible - instead HIL native syntax - "${var.variablename["key"]}" must be used. This was previously documented, (though not heavily used) so it must be noted as a backward compatibility issue for Terraform 0.7.	10 years ago
James Nugent	6aac79e194	state: Add support for outputs of multiple types ... This commit adds the groundwork for supporting module outputs of types other than string. In order to do so, the state version is increased from 1 to 2 (though the "public-facing" state version is actually as the first state file was binary). Tests are added to ensure that V2 (1) state is upgraded to V3 (2) state, though no separate read path is required since the V2 JSON will unmarshal correctly into the V3 structure. Outputs in a ModuleState are now of type map[string]interface{}, and a test covers round-tripping string, []string and map[string]string, which should cover all of the types in question. Type switches have been added where necessary to deal with the interface{} value, but they currently default to panicking when the input is not a string.	10 years ago
Chris Bednarski	6360e6c8b6	Implemented internal plugin calls; which allows us to compile plugins into the main terraform binary	10 years ago
Mitchell Hashimoto	35c87836b4	core: Add terraform_version to state ... This adds a field terraform_version to the state that represents the Terraform version that wrote that state. If Terraform encounters a state written by a future version, it will error. You must use at least the version that wrote that state. Internally we have fields to override this behavior (StateFutureAllowed), but I chose not to expose them as CLI flags, since the user can just modify the state directly. This is tricky, but should be tricky to represent the horrible disaster that can happen by enabling it. We didn't have to bump the state format version since the absense of the field means it was written by version "0.0.0" which will always be older. In effect though this change will always apply to version 2 of the state since it appears in 0.7 which bumped the version for other purposes.	10 years ago
Mitchell Hashimoto	e133452663	command/state: pattern => address	10 years ago
Mitchell Hashimoto	5737c0a13b	website: update docs for state show	10 years ago
Mitchell Hashimoto	f6692e66ac	add command/state show	10 years ago
Mitchell Hashimoto	d1b46e99bd	Add `terraform state list` command ... This introduces the terraform state list command to list the resources within a state. This is the first of many state management commands to come into 0.7. This is the first command of many to come that is considered a "plumbing" command within Terraform (see "plumbing vs porcelain": http://git.661346.n2.nabble.com/what-are-plumbing-and-porcelain-td2190639.html). As such, this PR also introduces a bunch of groundwork to support plumbing commands. The main changes: - Main command output is changed to split "common" and "uncommon" commands. - mitchellh/cli is updated to support nested subcommands, since terraform state list is a nested subcommand. - terraform.StateFilter is introduced as a way in core to filter/search the state files. This is very basic currently but I expect to make it more advanced as time goes on. - terraform state list command is introduced to list resources in a state. This can take a series of arguments to filter this down. Known issues, or things that aren't done in this PR on purpose: - Unit tests for terraform state list are on the way. Unit tests for the core changes are all there.	10 years ago
James Nugent	b62f6af158	core: Add support for marking outputs as sensitive (#6559) ... * core: Add support for marking outputs as sensitive This commit allows an output to be marked "sensitive", in which case the value is redacted in the post-refresh and post-apply list of outputs. For example, the configuration: ``` variable "input" { default = "Hello world" } output "notsensitive" { value = "${var.input}" } output "sensitive" { sensitive = true value = "${var.input}" } ``` Would result in the output: ``` terraform apply Apply complete! Resources: 0 added, 0 changed, 0 destroyed. Outputs: notsensitive = Hello world sensitive = <sensitive> ``` The `terraform output` command continues to display the value as before. Limitations: Note that sensitivity is not tracked internally, so if the output is interpolated in another module into a resource, the value will be displayed. The value is still present in the state.	10 years ago
Dan Carley	64c1280951	command/fmt: Improve documentation for -diff and defaults (#6398) ... * command/fmt: Document -diff doesn't disable -write As noted in hashicorp/terraform#6343, this description misleadingly suggested that the `-diff` option disables the `-write` option. This isn't the case and because of the default options (described in c753390) the behaviour of `terraform fmt -diff` is actually the same as `terraform fmt -write -list -diff`. Replace the "instead of rewriting" description to clarify that. Documentation in hcl/fmtcmd is corrected in hashicorp/hcl#117 but it's not really necessary to bump the dependency version. * command/fmt: Show flag defaults in help text These were documented on the website but not in the `-help` text. This should help to clarify that you need to pass `-list=false -write=false -diff` if you only want to see diffs. Accordingly I've replaced the word "disabled" with "always false" in the STDIN special cases so that it matches the terminology used in the defaults and better indicates that it is overridden. NB: The 3x duplicated defaults and documentation makes me feel uneasy once again. I'm not sure how to solve that, though.	10 years ago
Paul Hinze	c74c5fe7f0	Update HCL to latest, unskip fmt tests ... See https://github.com/hashicorp/hcl/pull/115	10 years ago
Paul Hinze	ac10a7979d	command/fmt tests: temporarily skip newline failures ... Skipping tests to get the master build green while I sort out these failing tests. They should be fixed for real in just a few here.	10 years ago
Mitchell Hashimoto	08ad84d8b2	command: defer the lock unlock	10 years ago
Mitchell Hashimoto	284bc92c04	command: show periodic messages about continued ops	10 years ago
David Glasser	b44f7f28e0	Document saved plan use in `terraform apply -help` (#6126) ... Wording borrowed from the website docs.	10 years ago
David Glasser	320773d6c1	command: delete unused class	10 years ago
Martin Atkins	fa703db8a6	Merge #4955: "terraform fmt" command	10 years ago
Paul Hinze	c7f5450a96	command: Add `terraform untaint` ... - [x] Docs - [x] Command Unit Tests - [x] State Unit Tests Closes #4820	10 years ago
Dan Carley	d883b76070	command/fmt: Test non-default options ... To ensure that these are passed over to `fmtcmd` correctly.	10 years ago
Dan Carley	79e2753e41	command/fmt: Disable list/write when using STDIN ... These options don't make sense when passing STDIN. `-write` will raise an error because there is no file to write to. `-list` will always say `<standard input>`. So disable whenever using STDIN, making the command much simpler: cat main.tf | terraform fmt -	10 years ago
Dan Carley	e9128769b5	command/fmt: Accept input from STDIN ... So that you can do automatic formatting from an editor. You probably want to disable the `-write` and `-list` options so that you just get the re-formatted content, e.g. cat main.tf | terraform fmt -write=false -list=false - I've added a non-exported field called `input` so that we can override this for the tests. If not specified, like in `commands.go`, then it will default to `os.Stdin` which works on the command line.	10 years ago
Dan Carley	1b967e612f	command/fmt: Accept optional directory argument ... So that you can operate on files in a directory other than your current working directory.	10 years ago
Dan Carley	c753390399	command/fmt: Default write and list to true ... The most common usage usage will be enabling the `-write` and `-list` options so that files are updated in place and a list of any modified files is printed. This matches the default behaviour of `go fmt` (not `gofmt`). So enable these options by default. This does mean that you will have to explicitly disable these if you want to generate valid patches, e.g. `terraform fmt -diff -write=false -list=false`	10 years ago
Dan Carley	cc41c7cfa0	command/fmt: Add new fmt command ... This uses the `fmtcmd` package which has recently been merged into HCL. Per the usage text, this rewrites Terraform config files to their canonical formatting and style. Some notes about the implementation for this initial commit: - all of the fmtcmd options are exposed as CLI flags - it operates on all files that have a `.tf` suffix - it currently only operates on the working directory and doesn't accept a directory argument, but I'll extend this in subsequent commits - output is proxied through `cli.UiWriter` so that we write in the same way as other commands and we can capture the output during tests - the test uses a very simple fixture just to ensure that it is working correctly end-to-end; the fmtcmd package has more exhaustive tests - we have to write the fixture to a file in a temporary directory because it will be modified and for this reason it was easier to define the fixture contents as a raw string	10 years ago
James Nugent	b787fe2798	Merge pull request #5012 from jrnt30/TF-5011-Backend-flag-normalization ... Fixes #5011 - Backend downcased for init	10 years ago
stack72	1628f19bc1	Fixing some golint issues on the new validate command	10 years ago
Soren Mathiasen	db69a2959b	Added verify command	10 years ago
Justin Nauman	61240b4250	Fixes #5011 - Backend downcased for init	10 years ago
Paul Hinze	4a51e4fe91	core: write planfile even on empty plans ... This makes the planfile workflow more consistent. If a plan yields a noop, the apply of that planfile will noop. Fixes #1783	10 years ago
Paul Hinze	e67fc0fe9b	command: Change module-depth default to -1 ... This means that terraform commands like `plan`, `apply`, `show`, and `graph` will expand all modules by default. While modules-as-black-boxes is still very true in the conceptual design of modules, feedback on this behavior has consistently suggested that users would prefer to see more verbose output by default. The `-module-depth` flag and env var are retained to allow output to be optionally limited / summarized by these commands.	10 years ago
Mitchell Hashimoto	6a972a7713	command/init: put remote state config at proper path [GH-2927]	10 years ago
James Nugent	a5e51f6dad	command/refresh: Fix import formats to prevent flapping	11 years ago
Paul Hinze	0e277a6714	core: test coverage around map key regression ... tests to cover the HCL-level issue fixed in https://github.com/hashicorp/hcl/pull/65	11 years ago
James Nugent	50b5e7c1a5	Validate context after input of vars on refresh ... Fixes #4013.	11 years ago
James Nugent	890e214c00	Add failing test replicating #4013	11 years ago
Jake Champlin	39e7f42490	Clear up `destroy --target` message ... When destroying infrastructure with `--target`, print out which infrastructure will be destroyed instead of saying `Terraform will delete all your managed infrastructure`. ``` terraform destroy --target aws_instance.test2 --target aws_instance.test1 Do you really want to destroy? Terraform will delete the following infrastructure: aws_instance.test2 aws_instance.test1 There is no undo. Only 'yes' will be accepted to confirm ``` Omitting `--target` arguments will use the default input description. ``` $ terraform destroy Do you really want to destroy? Terraform will delete all your managed infrastructure. There is no undo. Only 'yes' will be accepted to confirm. ```	11 years ago
James Nugent	a49b162dd1	Prompt for input variables before context validate ... Also adds a regression test using Mock UI. Fixes #3767.	11 years ago
James Nugent	f4c03ec2a6	Reflect new comment format in stringer.go ... As of November 8th 2015, (4b07c5ce8a), the word "Code" is prepended to the comments in Go source files generated by the stringer utility.	11 years ago
Paul Hinze	9428e9f1d1	command: fix failing TestPlan_noState test ... Turns out that isolating statefiles in the Apply tests is an important step to prevent leaking .tfstate in a common dir, which can affect other tests.	11 years ago
Paul Hinze	715437537d	command: fix flaky parallelism tests ... Thanks to @mitchellh for helping sort out concurrency stuff here.	11 years ago
John Gosset	61e890ecc9	Update list of backends in RemoteConfigCommand's Help() method	11 years ago
Martin Atkins	e4e9c13c20	Merge #3136: Colorize the 'forces new resource' message	11 years ago
Mitchell Hashimoto	344e7c26b5	fix a bunch of tests from go-getter import	11 years ago
Panagiotis Moustafellos	e4845f75cc	removed extra parentheses	11 years ago
Paul Hinze	374070d066	website: docs for parallelism setting ... /cc @stack72 @knuckolls @mitchellh	11 years ago
Paul Hinze	e1a46904d6	command: pull parallelism default up to CLI layer ... /cc @knuckolls @josephholsten	11 years ago
Kevin Nuckolls	bf9c5c46d0	Tests for apply parallelism=1 and parallelism=2	11 years ago
Kevin Nuckolls	fc60b2858c	Added -parallelism to refresh and plan cli UI	11 years ago
Kevin Nuckolls	f59c71b35a	works for apply, no tests yet	11 years ago
Radek Simko	57bea9f26c	Merge pull request #3223 from scalp42/typos ... remove various typos	11 years ago
Mitchell Hashimoto	4d37704d53	command/get: fix typo	11 years ago
Anthony Scalisi	198e1a5186	remove various typos	11 years ago
Martin Atkins	7c56550633	In plan summary, be more honest about force-new changes. ... Previously the plan summary output would consider -/+ diffs as changes even though they actually destroy and create instances. This was misleadning and inconsistent with the accounting that gets done for the similar summary written out after "apply". Instead we now count the -/+ diffs as both adds and removes, which should mean that the counts output in the plan summary should match those in the apply summary, as long as no errors occur during apply. This fixes #3163.	11 years ago