221 Commits (73dda868cca4010a244fceabea2d5812abdd0c2a)

Author	SHA1	Message	Date
Martin Atkins	73dda868cc	Move backend/ to internal/backend/ ... This is part of a general effort to move all of Terraform's non-library package surface under internal in order to reinforce that these are for internal use within Terraform only. If you were previously importing packages under this prefix into an external codebase, you could pin to an earlier release tag as an interim solution until you've make a plan to achieve the same functionality some other way.	5 years ago
James Bardin	feb7622846	monitor plugin std outputs for unexpected data ... Once a plugin process is started, go-plugin will redirect the stdout and stderr stream through a grpc service and provide those streams to the client. This is rarely used, as it is prone to failing with races because those same file descriptors are needed for the initial handshake and logging setup, but data may be accidentally sent to these nonetheless. The usual culprits are stray `fmt.Print` usage where logging was intended, or the configuration of a logger after the os.Stderr file descriptor was replaced by go-plugin. These situations are very hard for provider developers to debug since the data is discarded entirely. While there may be improvements to be made in the go-plugin package to configure this behavior, in the meantime we can add a simple monitoring io.Writer to the streams which will surface th data as warnings in the logs instead of writing it to `io.Discard`	5 years ago
James Bardin	a4a6b40bee	update getproviders tests for new key	5 years ago
James Bardin	e1d790be61	update HC PublicKey	5 years ago
Paddy	0b5c4a6a2c	Accept TF_LOG=json to enable TRACE logs in JSON format ... This is not currently a supported interface, but we plan to release tool(s) that consume parts of it that are more dependable later, separately from Terraform CLI itself.	5 years ago
Pam Selle	242f319638	Give suggestions & remind users to use required_providers when provider not in registry (#28014) ... * Add helper suggestion when failed registry err When someone has a failed registry error on init, remind them that they should have required_providers in every module * Give suggestion for a provider based on reqs Suggest another provider on a registry error, from the list of requirements we have on init. This skips the legacy lookup process if there is a similar provider existing in requirements.	5 years ago
Masayuki Morita	31a5aa1878	command/init: Add a new flag `-lockfile=readonly` (#27630) ... Fixes #27506 Add a new flag `-lockfile=readonly` to `terraform init`. It would be useful to allow us to suppress dependency lockfile changes explicitly. The type of the `-lockfile` flag is string rather than bool, leaving room for future extensions to other behavior variants. The readonly mode suppresses lockfile changes, but should verify checksums against the information already recorded. It should conflict with the `-upgrade` flag. Note: In the original use-case described in #27506, I would like to suppress adding zh hashes, but a test code here suppresses adding h1 hashes because it's easy for testing. Co-authored-by: Alisdair McDiarmid <alisdair@users.noreply.github.com>	5 years ago
Kristin Laemmert	106bcd3bf0	update to match new default branch name (#27909)	5 years ago
Kristin Laemmert	e5a7586559	moduletest: update provider to match recent provider interface changes (#27904) ... this fixes a bad merge on my part	5 years ago
Kristin Laemmert	ff05362d51	providers.Interface: rename ValidateDataSourceConfig to ValidateDataResourceConfig (#27874) ... * providers.Interface: rename ValidateDataSourceConfig to ValidateDataResourceConfig This PR came about after renaming ValidateResourceTypeConfig to ValidateResourceConfig: I now understand that we'd called it the former instead of the latter to indicate that the function wasn't necessarily operating on a resource that actually exists. A possibly-more-accurate renaming of both functions might then be ValidateManagedResourceConfig and ValidateDataResourceConfig. The next commit will update the protocol (v6 only) as well; these are in separate commits for reviewers and will get squashed together before merging. * extend renaming to protov6	5 years ago
Martin Atkins	7f78342953	command: Experimental "terraform test" command ... This is just a prototype to gather some feedback in our ongoing research on integration testing of Terraform modules. The hope is that by having a command integrated into Terraform itself it'll be easier for interested module authors to give it a try, and also easier for us to iterate quickly based on feedback without having to coordinate across multiple codebases. Everything about this is subject to change even in future patch releases. Since it's a CLI command rather than a configuration language feature it's not using the language experiments mechanism, but generates a warning similar to the one language experiments generate in order to be clear that backward compatibility is not guaranteed.	5 years ago
Martin Atkins	8330f8e991	internal/moduletest: Experimental module testing helpers ... As part of ongoing research into Terraform testing we'd like to use an experimental feature to validate our current understanding that expressing tests as part of the Terraform language, as opposed to in some other language run alongside, is a good and viable way to write practical module integration tests. This initial experimental incarnation of that idea is implemented as a provider, just because that's an easier extension point for research purposes than a first-class language feature would be. Whether this would ultimately emerge as a provider similar to this or as custom language constructs will be a matter for future research, if this first experiment confirms that tests written in the Terraform language are the best direction to take. The previous incarnation of this experiment was an externally-developed provider apparentlymart/testing, listed on the Terraform Registry. That helped with showing that there are some useful tests that we can write in the Terraform language, but integrating such a provider into Terraform will allow us to make use of it in the also-experimental "terraform test" command, which will follow in subsequent commits, to see how this might fit into a development workflow.	5 years ago
Kristin Laemmert	7b7273e3aa	Add support for plugin protocol v6 (#27826) ... * Add support for plugin protocol v6 This PR turns on support for plugin protocol v6. A provider can advertise itself as supporting protocol version 6 and terraform will use the correct client. Todo: The "unmanaged" providers functionality does not support protocol version, so at the moment terraform will continue to assume that "unmanaged" providers are on protocol v5. This will require some upstream work on go-plugin (I believe). I would like to convert the builtin providers to use protocol v6 in a future PR; however it is not necessary until we remove protocol v6. * add e2e test for using both plugin protocol versions - copied grpcwrap and made a version that returns protocol v6 provider - copied the test provider, provider-simple, and made a version that's using protocol v6 with the above fun - added an e2etest	5 years ago
James Bardin	3da5d2bdf6	Merge pull request #27692 from alexwlchan/abolish-the-heirarchy ... Correct the spelling of heirarchy/hierarchy throughout	5 years ago
Pam Selle	e1c25337c7	Delete readme, add doc.go to helper/schema ... Remove the README that had old user-facing information, replacing it with a doc.go that describes the package and points to the plugin SDK for external consumers.	5 years ago
Kristin Laemmert	f6505870cc	Mildwonkey/providers interface renaming (#27805) ... * providers.Interface: huge renamification This commit renames a handful of functions in the providers.Interface to match changes made in protocol v6. The following commit implements this change across the rest of the codebase; I put this in a separate commit for ease of reviewing and will squash these together when merging. One noteworthy detail: protocol v6 removes the config from the ValidateProviderConfigResponse, since it's never been used. I chose to leave that in place in the interface until we deprecate support for protocol v5 entirely. Note that none of these changes impact current providers using protocol v5; the protocol is unchanged. Only the translation layer between the proto and terraform have changed.	5 years ago
Kristin Laemmert	7943312ebd	Merge pull request #27699 from hashicorp/mildwonkey/protocolv6 ... Mildwonkey/protocolv6	5 years ago
Martin Atkins	f91a3b87c1	terminal: Helpers for doing fmt-ish operations on the streams ... It's pretty common to want to apply the various fmt.Fprint... functions to our two output streams, and so to make that much less noisy at the callsite here we have a small number of very thin wrappers around the underlying fmt package functionality. Although we're aiming to not have too much abstraction in this "terminal" package, this seems justified in that it is only a very thin wrapper around functionality that most Go programmers are already familiar with, and so the risk of this causing any surprises is low and the improvement to readability of callers seems worth it.	5 years ago
Martin Atkins	ffba8064ed	terminal: StreamsForTesting helper ... This is to allow convenient testing of functions that are designed to work directly with *terminal.Streams or the individual stream objects inside. Because the InputStream and OutputStream APIs expose directly an *os.File, this does some extra work to set up OS-level pipes so we can capture the output into local buffers to make test assertions against. The idea here is to keep the tricky stuff we need for testing confined to the test codepaths, so that the "real" codepaths don't end up needing to work around abstractions that are otherwise unnecessary.	5 years ago
Pam Selle	aa24bfec47	Emit ProviderAlreadyInstalled when provider installed ... Emit the ProviderAlreadyInstalled event when we successfully verify that we've already installed this provider and are skipping installation	5 years ago
Kristin Laemmert	f3a057eb35	plugin-protocol v6 ... This is the first commit for plugin protocol v6. This is currently unused (dead) code; future commits will add the necessary conversion packages, extend configschema, and modify the providers.Interface. The new plugin protocol includes the following changes: - A new field has been added to Attribute: NestedType. This will be the key new feature in plugin protocol v6 - Several massages were renamed for consistency with the verb-noun pattern seen in _most_ messages. - The prepared_config has been removed from PrepareProviderConfig (renamed ValidateProviderConfig), as it has never been used. - The provisioner service has been removed entirely. This has no impact on built-in provisioners. 3rd party provisioners are not supported by the SDK and are not included in this protocol at all.	5 years ago
Alex Chan	4ec80fa18d	Correct the spelling of heirarchy/hierarchy throughout	5 years ago
Jonathan Hall	49ee3d3ef8	Grammar nit: "setup" as a verb should be spelled "set up"	5 years ago
Pam Selle	aedca597dd	Reuse installed target dir providers in init ... In init, we can check to see if the target dir already has the provider we are seeking and skip further querying/installing of that provider.	5 years ago
Nick Fagerlund	a60120477c	Update links to CLI docs in code comments, messages, and readme	5 years ago
Pam Selle	084cec6346	Merge pull request #27447 from Filirom1/fix-27445 ... Providers: Fix init with broken link in plugin_cache_dir	5 years ago
James Bardin	9f2a6d33be	move remaining helper packages to internal	5 years ago
Martin Atkins	17728c8fe8	internal/terminal: Interrogate and initialize the terminal, if any ... This is a helper package that creates a very thin abstraction over terminal setup, with the main goal being to deal with all of the extra setup we need to do in order to get a UTF-8-supporting virtual terminal on a Windows system.	5 years ago
Kristin Laemmert	86a63e8e39	remove unused legacy plugin package (#27493)	5 years ago
Romain Philibert	5ae5c99ba0	fix: do not fail when provider symlink is broken. Only print a warning. ... fix https://github.com/hashicorp/terraform/issues/27445	5 years ago
Anthony Sottile	8cd72e51cb	fix file mode on lock file (#27205) ... Signed-off-by: Anthony Sottile <asottile@umich.edu>	5 years ago
Martin Atkins	21d6fb5a37	depsfile: Don't panic when lock file is unreadable ... Previously we were expecting that the *hcl.File would always be non-nil, even in error cases. That isn't always true, so now we'll be more robust about it and explicitly return an empty locks object in that case, along with the error diagnostics. In particular this avoids a panic in a strange situation where the user created a directory where the lock file would normally go. There's no meaning to such a directory, so it would always be a mistake and so now we'll return an error message about it, rather than panicking as before. The error message for the situation where the lock file is a directory is currently not very specific, but since it's HCL responsible for generating that message we can't really fix that at this layer. Perhaps in future we can change HCL to have a specialized error message for that particular error situation, but for the sake of this commit the goal is only to stop the panic and return a normal error message.	5 years ago
Martin Atkins	4b3e237668	command/init: Hint about providers in other namespaces ... If a user forgets to specify the source address for a provider, Terraform will assume they meant a provider in the registry.terraform.io/hashicorp/ namespace. If that ultimately doesn't exist, we'll now try to see if there's some other provider source address recorded in the registry's legacy provider lookup table, and suggest it if so. The error message here is a terse one addressed primarily to folks who are already somewhat familiar with provider source addresses and how to specify them. Terraform v0.13 had a more elaborate version of this error message which directed the user to try the v0.13 automatic upgrade tool, but we no longer have that available in v0.14 and later so the user must make the fix themselves.	5 years ago
James Bardin	6529659455	internal/providercache: staticcheck	5 years ago
James Bardin	d22e08bd32	internal/earlyconfig: staticcheck	5 years ago
James Bardin	f0c3ddf5a1	internal/getproviders: staticcheck	5 years ago
James Bardin	276dfe634f	internal/providercache: staticcheck	5 years ago
James Bardin	1f359bab03	internal/typeexpr: staticcheck ... diagnostics were appended to diags shadowing the intended value.	5 years ago
James Bardin	76cb40005a	add grpcwrap.Provisioner ... Rename grpcwrap.New() to grpcwrap.Provider() Add a grpcwrap function to create a test proivisioner plugin.	5 years ago
James Bardin	03d11f988e	remove old test provider	5 years ago
James Bardin	eee581ae54	simple provider for internal testing ... Simple is a minimal provider implementation using the grpcwrap package, intended for use in internal tests.	5 years ago
James Bardin	65340f51be	wrap the terraform provider for grpc tests	5 years ago
James Bardin	b1c104834e	grpcwrap: convert provider interface to grpcserver ... grpcwrap wraps a core providers.Interface and converts it to a tfplugin5.ProviderServer to allow for easier protocol testing.	5 years ago
James Bardin	811a3a81e9	add test provider bin for e2etest ... One e2etest still requires the bin, so add that back temporarily.	5 years ago
James Bardin	b32362da9d	internal/legacy/builtin/providers/test ... Move the test provider into the interal/legacy directory, until we can factor it out of the e2e test.	5 years ago
James Bardin	5bbac72a85	internal/legacy/helper/plugin ... This is used internally for testing	5 years ago
James Bardin	e4edce22ca	internal/legacy/helper/schema ... moving helper/schema into the ineternal/legacy tree	5 years ago
James Bardin	a49e7eee8b	internal/legacy/terraform ... This is a partial copy of the terraform package to preserve the legacy types for internal use.	5 years ago
James Bardin	ccf19fbf5e	regenerate plugin proto with correct tooling ... The proto file is structurally unchanged, though it now requires a go import path option.	5 years ago
James Bardin	7eb491719f	normalize temp dir paths in tests ... The temporary directory on some systems (most notably MacOS) contains symlinks, which would not be recorded by the installer. In order to make these paths comparable in the tests we need to eval the symlinks in the paths before giving them to the installer.	5 years ago