18 Commits (72de171edde8564cf9e37ca703fe1b4e715be5ec)

Author	SHA1	Message	Date
Liam Cervante	14418bd198	terraform test: move override evaluation into expander (#35030) ... * terraform test: move override evaluation into expander * clarify comment	2 years ago
Martin Atkins	53f00667d5	instances: Some additional commentary ... The internal API here was a little unclear, so this is just some retroactive additional documentation resulting from me having "relearned" how this API works after some time away from it, in the hope that future maintainers will not need to repeat that exercise.	2 years ago
Martin Atkins	73df33fe6e	instances: Fix data race in Expander.ExpandAbsModuleCall ... This method must hold a read lock while it does its work, or else it will race with calls to register the expansion mode for other module calls.	2 years ago
Martin Atkins	0c3a581ff0	instances: Expander.ExpandAbsModuleCall ... This is a similar idea to Expander.ExpandModule but for situations where we already know exactly which containing module we're evaluating inside, and thus we can just pluck out the leaf instance keys of that specific dynamic call, rather than the full recursive expansion of every containing module. Expander.ExpandModule is useful when implementing DynamicExpand for a graph node because main graph nodes always represent static configuration objects, but this new Expander.ExpandAbsModuleCall is more appropriate for use during expression evaluation of references to a module call because in that case we'll know which specific module instance address we're using as the evaluation scope. A future commit will actually use this new method from the expression evaluator in the modules runtime.	2 years ago
Martin Atkins	8fe469e3d4	instances: "skipUnregistered" instead of "skipUnknown" internally ... Recently we've introduced the idea of the expansion of a particular module or resource not yet being known, which has inadvertently introduced some ambiguity about what "unknown" means in this package: "unknown" previously represented "not registered yet", which is different than having explicitly registered that we don't know. To remove that ambiguity, we'll now use the term "unregistered" to talk about the "not registered yet" situation, and reserve "unknown" for when we know that we definitely don't know. This is only an internal naming change within the package and doesn't affect any exported API.	2 years ago
Martin Atkins	d9a4f9a06b	instances: Methods for retrieving the instance keys of modules/resources ... These new methods both take into account the possibility of there being unknown keys, which will be useful for the expression evaluator to decide whether it can return a specific type or not.	2 years ago
Martin Atkins	ea0fd23407	instances: RepetitionData placeholders to use for unknown expansion ... Now that Expander can support unknown expansions for modules and resource instances, we'll need some placeholders to use when evaluating the configurations of those objects to predict as much as possible what the final configurations of all of their instances will look like. This is a similar problem to checking whether a not-yet-expanded object has valid configuration during the "validate" phase: we're essentially asking what configuration all instances of the object will have in common, and leaving unknown anything that might vary between instances. Nothing is using these yet, but uses will follow in later commits.	2 years ago
Martin Atkins	ad53ca6020	instances: Expander.UnknownResourceInstances ... This is the resource instance equivalent of UnknownModuleInstances added in an earlier commit, returning a result that represents a set of possible resource instance addresses that _might_ be declared by the currently-unknown count or for_each argument.	2 years ago
Martin Atkins	9e80dfde2a	instances: Expander.UnknownModuleInstances ... This new method effectively returns a set of all of the instances of a particular module whose addresses can't be fully determined yet, but does so in the form of a set of patterns that match all of those as-yet-unknown instance addresses. So far this isn't used anywhere but in a future commit Terraform Core can use this to generate placeholder unknown values when walking inside unexpanded modules once we make it legal to have an unknown value for the repetition argument of a module call.	2 years ago
Martin Atkins	a58ee3eceb	instances: Allow registering expansion as "unknown" ... In preparation for supporting partial planning when count or for_each are not known enough to finalize instance keys, this allows the core graph walk to register when it encounters an object whose repetition argument isn't yet "known enough" to actually expand, which then allows downstreams to still expand the subset of instances whose addresses are fully known but (for now) quietly ignores any subtrees under objects that cannot be expanded yet. In subsequent commits we'll add additional API for finding the partial addresses of objects that _cannot_ fully expand yet, so that the graph walk can still keep track of those and report them to the user.	2 years ago
hashicorp-copywrite[bot]	53c34ff49c	Update copyright file headers to BUSL-1.1	3 years ago
hashicorp-copywrite[bot]	325d18262e	[COMPLIANCE] Add Copyright and License Headers	3 years ago
James Bardin	b213386a73	InstancesForModule should not panic ... instances.Set is only used after all instances have been processes, so it should therefor only handle known instances and not panic when given an address that traverses an unexpanded module.	4 years ago
Martin Atkins	ec6fe93fa8	instances: Non-existing module instance has no resource instances ... Previously we were treating it as a programming error to ask for the instances of a resource inside an instance of a module that is declared but whose declaration doesn't include the given instance key. However, that's actually a valid situation which can arise if, for example, the user has changed the repetition/expansion mode for an existing module call and so now all of the resource instances addresses it previously contained are "orphaned". To represent that, we'll instead say that an invalid instance key of a declared module behaves as if it contains no resource instances at all, regardless of the configurations of any resources nested inside. This then gives the result needed to successfully detect all of the former resource instances as "orphaned" and plan to destroy them. However, this then introduces a new case for NodePlannableResourceInstanceOrphan.deleteActionReason to deal with: the resource configuration still exists (because configuration isn't aware of individual module/resource instances) but the module instance does not. This actually allows us to resolve, at least partially, a previous missing piece of explaining to the user why the resource instances are planned for deletion in that case, finally allowing us to be explicit to the user that it's because of the module instance being removed, which internally we call plans.ResourceInstanceDeleteBecauseNoModule. Co-authored-by: Alisdair McDiarmid <alisdair@users.noreply.github.com>	4 years ago
Martin Atkins	aa414f3ab3	refactoring: First round of ValidateMoves rules ... This is a first pass at implementing refactoring.ValidateMoves, covering the main validation rules. This is not yet complete. A couple situations not yet covered are represented by commented test cases in TestValidateMoves, although that isn't necessarily comprehensive. We'll do a further pass of filling this out with any other subtleties before we ship this feature.	5 years ago
Martin Atkins	51346f0d87	instances: Expander.AllInstances ... In order to precisely implement the validation rules for "moved" statements we need to be able to test whether particular instances were declared in the configuration. The instance expander is the source of record for which instances we decided while creating a plan, but it's API is far more involved than what our validation rules need, so this new AllInstances method returns a wrapper object with a more straightforward API that provides read-only access to just the question of whether particular instances got registered in the expander already. This API covers all three of the kinds of objects that move statements can refer to. It includes module calls and resources, even though they aren't _themselves_ "instances" in the sense we usually mean, because the module instance addresses they are contained within _are_ instances and so we need to take their dynamic instance keys into account when answering these queries.	5 years ago
Martin Atkins	b9a93a0fe7	Move addrs/ to internal/addrs/ ... This is part of a general effort to move all of Terraform's non-library package surface under internal in order to reinforce that these are for internal use within Terraform only. If you were previously importing packages under this prefix into an external codebase, you could pin to an earlier release tag as an interim solution until you've make a plan to achieve the same functionality some other way.	5 years ago
Martin Atkins	bc31dbc179	Move instances/ to internal/instances/ ... This is part of a general effort to move all of Terraform's non-library package surface under internal in order to reinforce that these are for internal use within Terraform only. If you were previously importing packages under this prefix into an external codebase, you could pin to an earlier release tag as an interim solution until you've make a plan to achieve the same functionality some other way.	5 years ago