774 Commits (6dcf00aefc56b48bae54822a6e62eacffd2bc3ea)

Author	SHA1	Message	Date
James Bardin	d469e86331	revert 6b8b0617 ... Revert the evaluation change from #29862. While returning a dynamic value for all expanded resources during validation is not optimal, trying to work around this using unknown maps and lists is causing other undesirable behaviors during evaluation.	4 years ago
Martin Atkins	c4d46e7c6b	getmodules: Re-allow git:: source with ref=COMMIT_ID ... Earlier versions of this code allowed "ref" to take any value that would be accepted by "git checkout" as a valid target of a symbolic ref. We inadvertently accepted a breaking change to upstream go-getter that broke that as part of introducing a shallow clone optimization, because shallow clone requires selecting a single branch. To restore the previous capabilities while retaining the "depth" argument, here we accept a compromise where "ref" has the stronger requirement of being a valid named ref in the remote repository if and only if "depth" is set to a value greater than zero. If depth isn't set or is less than one, we will do the old behavior of just cloning all of the refs in the remote repository in full and then switching to refer to the selected branch, tag, or naked commit ID as a separate step. This includes a heuristic to generate an additional error message hint if we get an error from "git clone" and it looks like the user might've been trying to use "depth" and "ref=COMMIT" together. We can't recognize that error accurately because it's only reported as human-oriented git command output, but this heuristic should hopefully minimize situations where we show it inappropriately. For now this is a change in the Terraform repository directly, so that we can expedite the fix to an already-reported regression. After this is released I tend to also submit a similar set of changes to upstream go-getter, at which point we can revert Terraform to using the upstream getter.GitGetter instead of our own local fork.	4 years ago
Martin Atkins	b0ff17ef2a	getmodules: Inline our own fork of getter.GitGetter ... This is a pragmatic temporary solution to allow us to more quickly resolve an upstream regression in go-getter locally within Terraform, so that the work to upstream it for other callers can happen asynchronously and with less time pressure. This commit doesn't yet include any changes to address the bug, and instead aims to be functionally equivalent to getter.GitGetter. A subsequent commit will then address the regression, so that the diff of that commit will be easier to apply later to the upstream to get the same effect there.	4 years ago
Chris Arcand	8b8fe2771f	Merge pull request #30142 from hashicorp/chrisarcand/remote-backend-no-workspaces-regression ... command/meta_backend: Allow the remote backend to have no workspaces [again]	4 years ago
Chris Arcand	98978b3853	command/meta_backend: Allow the remote backend to have no workspaces [again] ... A regression introduced in d72a413ef8 The comment explains, but TLDR: The remote backend actually *depended* on being able to write it's backend state even though an 'error' occurred (no workspaces).	4 years ago
Martin Atkins	096cddb4b7	command/format: Limitation of plans.ResourceInstanceDeleteBecauseNoModule ... This is an explicit technical debt note that our plan renderer isn't able to give a fully-specific hint in this particular case of deletion reason. This reason code means that at least one of the module instance keys in the resource's module path doesn't match an instance declared in the configuration, but the plan data structure doesn't retain enough information to know which is the first step in the path which refers to a missing instance, and so we just always return the whole thing. This would be confusing if we return module.foo[0].module.bar not being in the configuration as a result of module.foo not using "count"; it would be better to say "module.foo[0] is not in the configuration" instead. It would be most ideal to handle all of the different situations that ResourceInstanceDeleteBecauseWrongRepetition's rendering does, so that we can go further and explain exactly _why_ that module instance isn't declared anymore. We can do neither of those things today because only the Terraform Core "expander" component knows that information, and we've discarded that by the time we get to rendering a plan. To fix this one day would require preserving in the plan information about which module instances are declared, as a separate sidecar data structure from which resource instances we're taking actions on, and then using that to identify which step in addr.Module here first selects an invalid instance.	4 years ago
Martin Atkins	ec6fe93fa8	instances: Non-existing module instance has no resource instances ... Previously we were treating it as a programming error to ask for the instances of a resource inside an instance of a module that is declared but whose declaration doesn't include the given instance key. However, that's actually a valid situation which can arise if, for example, the user has changed the repetition/expansion mode for an existing module call and so now all of the resource instances addresses it previously contained are "orphaned". To represent that, we'll instead say that an invalid instance key of a declared module behaves as if it contains no resource instances at all, regardless of the configurations of any resources nested inside. This then gives the result needed to successfully detect all of the former resource instances as "orphaned" and plan to destroy them. However, this then introduces a new case for NodePlannableResourceInstanceOrphan.deleteActionReason to deal with: the resource configuration still exists (because configuration isn't aware of individual module/resource instances) but the module instance does not. This actually allows us to resolve, at least partially, a previous missing piece of explaining to the user why the resource instances are planned for deletion in that case, finally allowing us to be explicit to the user that it's because of the module instance being removed, which internally we call plans.ResourceInstanceDeleteBecauseNoModule. Co-authored-by: Alisdair McDiarmid <alisdair@users.noreply.github.com>	4 years ago
Chris Arcand	f521ba6cd7	Remove 'enhanced' backend type distinction ... As explained in the changes: The 'enhanced' backend terminology, which only truly pertains to the 'remote' backend with a single API (Terraform Cloud/Enterprise's), has been found to be a confusing vestige which need only be explained in the context of the 'remote' backend. These changes reorient the explanation(s) of backends to pertain more directly to their primary purpose, which is storage of state snapshots (and not implementing operations). That Terraform operations are still _implemented_ by the literal `Backend` and `Enhanced` interfaces is inconsequential a user of Terraform, an internal detail.	4 years ago
James Bardin	0771a214d8	skip provider resolution when there are errors ... If there are errors loading the configuration, don't try to resolve the provider names, as those names may not even be valid.	4 years ago
Alisdair McDiarmid	5d7cb81c0c	lang: Redact sensitive values from function errors ... Some function errors include values derived from arguments. This commit is the result of a manual audit of these errors, which resulted in: - Adding a helper function to redact sensitive values; - Applying that helper function where errors include values derived from possibly-sensitive arguments; - Cleaning up other errors which need not include those values, or were otherwise incorrect.	4 years ago
Chris Arcand	f4f5b7c968	Merge pull request #30059 from hashicorp/barrettclark/explicit-local-empty-migrate-messaging ... Cloud: Do not ask to migrate empty default workspace	4 years ago
Barrett Clark	c706c8f92b	Do not ask to migrate empty default workspace ... When migrating from an explicit local backend to Terraform Cloud, we ask if you want to migrate the state. If there is no state to migrate we should not ask if they want to migrate the emptiness.	4 years ago
Barrett Clark	e08a02e7bf	Fixes Issue #29959, Apply w/o init error message ... When going from a local backend to Terraform Cloud, if you skip the `terraform init` and run `terraform apply` this will give the user more clear instructions.	4 years ago
Luces Huayhuaca	d72a413ef8	command/meta_backend: Prompt to select workspace before saving backend config (#29945) ... When terraform detects that a user has no workspaces that map to their current configuration, it will prompt the user to create a new workspace and enter a value name. If the user ignores the prompt and exits it, the legacy backend (terraform.tfstate) will be left in a awkward state: 1. This saved backend config will show a diff for the JSON attributes "serial", "tags" and "hash" 2. "Terraform workspace list" will show an empty list 3. "Terraform apply" will run successfully using the previous workspace, from the previous config, not the one from the current saved backend config 4. The cloud config is not reflective of the current working directory Solution: If the user exits the prompt, the saved backend config should not be updated because they did not select a new workspace. They are back at the beginning where they are force to re run the init cmd again before proceeding with new changes.	4 years ago
Martin Atkins	affe2c3295	addrs: Expose the registry address parser's error messages ... Previously we ended up losing all of the error message detail produced by the registry address parser, because we treated any registry address failure as cause to parse the address as a go-getter-style remote address instead. That led to terrible feedback in the situation where the user _was_ trying to write a module address but it was invalid in some way. Although we can't really tighten this up in the default case due to our compatibility promises, it's never been valid to use the "version" argument with anything other than a registry address and so as a compromise here we'll use the presence of "version" as a heuristic for user intent to parse the source address as a registry address, and thus we can return a registry-address-specific error message in that case and thus give more direct feedback about what was wrong. This unfortunately won't help someone trying to install from the registry _without_ a version constraint, but I didn't want to let perfect be the enemy of the good here, particularly since we recommend using version constraints with registry modules anyway; indeed, that's one of the main benefits of using a registry rather than a remote source directly.	4 years ago
kmoe	8f923cea08	Merge pull request #30048 from hashicorp/kmoe/http-backend-debug-log ... backend/http: supply logging.LogOutput() to retryable client	4 years ago
Alisdair McDiarmid	8ec9ad0407	Merge pull request #30029 from hashicorp/alisdair/add-sensitive-marks-for-nested-attributes ... configs: Add sensitive marks for nested attributes	4 years ago
Alisdair McDiarmid	d24403799e	Merge pull request #30019 from hashicorp/alisdair/fix-provider-schema-for-deleted-resource-instance ... core: Fix schema loading for deleted resources	4 years ago
Katy Moe	b1c071bb57	pass hclog logger to retryable client	4 years ago
Chris Arcand	b5af7b6c92	Merge pull request #29987 from hashicorp/chrisarcand/backend-flag-with-tfc ... command/init: Add -cloud alias to -backend, adjust `init` help output	4 years ago
Alisdair McDiarmid	fbed52a353	configs: Add sensitive marks for nested attributes ... Object values returned from providers have their attributes marked as sensitive based on the provider schema. This was not fully implemented for nested attribute types, which is corrected in this commit.	4 years ago
Alisdair McDiarmid	5ddf5e1f7d	core: Fix schema loading for deleted resources ... Resource instances removed from the configuration would previously use the implied provider address. This is correct for default providers, but incorrect for those from other namespaces or hosts. The fix here is to use the stored provider config if it is present.	4 years ago
Barrett Clark	a6b56ad76f	Merge pull request #29997 from hashicorp/barrettclark/cloud-input-false ... Cloud integration requires input for migrations	4 years ago
Barrett Clark	419676cb69	Cloud integration requires input for migrations ... We cannot programmatically migrate workspaces to Terraform Cloud without prompts, so `-input=false` should not be allowed in those cases. There are 4 scenarios where we need input from a user to complete migrating workspaces to Terraform Cloud. 1.) Migrate from a single local workspace to Terraform Cloud * Terraform config for a local backend. Implicit local (no backend specified) is fine. * `terraform init` and `terraform apply` * Change the Terraform config to use the cloud block * `terraform init -input=false` * You should now see an error message 2.) Migrate from a remote backend with a prefix to Terraform Cloud with tags * Create a workspace in Terraform Cloud manually. The name should include a prefix, like "app-one" * Have the terraform config use `backend "remote"` with a prefix set to "app-" * `terraform init` and `terraform apply` * Update the Terraform config to use a cloud block with `tags = ["app"]`. There should not be a prefix defined in the config now. * `terraform init -input=false` * You should now see an error message 3.) Migrate from multiple local workspaces to a single Terraform Cloud workspace * Create one or many local workspaces * `terraform init` and `terraform apply` in each * Change the Terraform config to use the cloud block * `terraform init -input=false` * You should now see an error message 4.) Migrate to Terraform Cloud and ask for a workspace name * Create several local workspaces * `terraform init` and `terraform apply` in each * Change the Terraform config to use the cloud block with tags * `terraform init -input=false` * You should now see an error message	4 years ago
Luces Huayhuaca	f63b6198ca	Create a function for logic that assigns value to initReason var after changing backend configuration (#29967) ... * Create a function for logic that assigns value to initReason var after changing backend configuration Create func determineInitReason() for logic block that assigns value to initReason var after changing backend/cloud configuration block or migrating to a different type of backend configuration. Also clarify 'cloud' configuration block message to say 'Terraform Cloud configuration block has changed' instead of 'Terraform Cloud configuration has changed'.	4 years ago
Alisdair McDiarmid	a8b9d086b2	cli: Fix nested single and map diff rendering ... Indentation was out by two spaces. This is now consistent with the other displays of object/map values: four spaces for each nesting level.	4 years ago
Chris Arcand	a0c7c1dc8d	command/init: Adjust init help output ... Some of the wording here needed adjusting with the change that backends largely reflect state snapshot storage (removing 'enhanced' designation), and that a 'backend' is not necessarily always present.	4 years ago
Chris Arcand	33d7c1e6d6	command/init: Add -cloud alias (of -backend) ... This fixes an issue where a user could not disable initialization of the 'cloud' configuration block (As is possible with -backend=false), as well as add some syntactic sugar around -backend by adding a mutually exclusive -cloud alias.	4 years ago
Alisdair McDiarmid	b562c4fb84	cli: Fix nested set diff rendering indentation	4 years ago
Alisdair McDiarmid	2d0349d9a4	cli: Fix diff for nested set unchanged elements ... Unchanged elements in nested attributes backed by sets were previously misrendered as empty objects. This commit removes the additional brackets and adds a count of unchanged elements.	4 years ago
Krista LaFentres	2fc4e06890	Fix failing lint check for deprecated x/crypto/openpgp library	4 years ago
Barrett Clark	7aeaec9b48	Update tests for new prompts ... * Remove double question to migrate * Remove parallelism (it has been flaky) * Add subtests to apply_auto_approve_test (it was overlooked before)	4 years ago
Martin Atkins	7d6d31eff8	command/init: Skip redundant state migration prompt in Cloud mode ... The specialized Terraform Cloud migration process asks right up top whether the user wants to migrate state, because there are various other questions contingent on that answer. Therefore we ought to just honor their earlier answer when we get to the point of actually doing the state migration, rather than prompting again. This is tricky because we're otherwise just reusing a codepath that's common to both modes. Hopefully we can find a better way to do this in a later commit, but for the moment our main motivation is minimizing risk to the very next release.	4 years ago
Barrett Clark	27aa51687e	Fix cloud e2e tests for updated migration flow	4 years ago
Martin Atkins	bac59d2480	command/init: Be explicit that some options are not relevant for Cloud ... There are a few command line options for "terraform init" which are only relevant when working with traditional backends, with the Cloud integration previously just mostly ignoring them, or sometimes misbehaving slightly due to them creating an unreasonable situation. Now we'll catch these and return explicit errors, in order to be clear that these options are not needed nor supported in Cloud mode.	4 years ago
Martin Atkins	c28b57b4d6	cloud/e2e: Additional context for failing to find expected output ... This just gives a little extra information to work with when trying to understand why a test failed. It doesn't change what any of the tests are actually trying to test.	4 years ago
Martin Atkins	e5172fea95	cloud: DetectConfigChangeType helper ... This aims to encapsulate the somewhat-weird logic we currently use to distinguish between the various "terraform init" situations involving Terraform Cloud mode, in the hope of making codepaths that branch based on this slightly easier to read. This isn't yet used, but uses of it will follow in subsequent commits.	4 years ago
Tom Harvey	a1c7c0dfa4	Update internal/backend/remote-state/azure/backend.go ... Co-authored-by: Tom Bamford <tbamford@hashicorp.com>	4 years ago
tombuildsstuff	ffe9a41468	internal/backend/remote-state/azure: adding tests covering MSAL	4 years ago
tombuildsstuff	a2cad7d579	internal/backend/remote-state/azure: prefixing the existing tests with ADAL	4 years ago
tombuildsstuff	9f710558ce	internal/backend/remote-state/azure: adding a feature-toggle to use MSAL	4 years ago
tombuildsstuff	27a34d6c2c	internal/backend/remote-state/azure: updating the link to the client secret ... This redirects to the registry so we should point there directly	4 years ago
tombuildsstuff	5133d30b71	internal/backend/remote-state/azure: code changes for go-azure-helpers v0.18.0	4 years ago
Jared Ledvina	61a5808680	k8s-backend - Initial context support for library update ... Signed-off-by: Jared Ledvina <jared.ledvina@datadoghq.com>	4 years ago
Barrett Clark	02aacb09e6	Merge pull request #29863 from hashicorp/barrettclark/migrate-empty-default-workspace ... Cloud: Migrate empty default workspace prompt	4 years ago
Barrett Clark	a146a2746e	Add clarifying commend and e2e test ... This pull request focuses on removing the prompt to rename the default workspace when it is empty. Functionality already exists to not migrate an empty workspace. This commit adds some clarifying language in the comment where we do the evaluation to know whether to ask for a new name or not. I also added an end to end test, which I should have added to begin with.	4 years ago
kmoe	18ab3512fa	Merge pull request #29943 from hashicorp/kmoe/moved-block-resource-type ... refactoring: error when changing resource type during move	4 years ago
Katy Moe	aeecc6a627	add AffectedAbsResource to interface	4 years ago
Barrett Clark	a9eb62d692	Cloud: Migrate empty default workspace prompt ... Given: You have multiple explicit local workspaces, and the `default` workspace is empty. When: You migrate the workspaces to Terraform Cloud. Then: Terraform should _not_ ask for a workspace to migrate the `default` workspace to in Terraform Cloud.	4 years ago
Simão Gomes Viana	5bbd108572	funcs: defer close file in funcs ... Files opened by these two functions were not being closed, leaking file descriptors. Close files that were opened when the function exist.	4 years ago
Barrett Clark	388c430ece	Merge pull request #29883 from hashicorp/barrettclark/cloud-e2e-tests ... Cloud: Make e2e Tests Less Chatty, and More Stable	4 years ago
Omar Ismail	9b675f8b70	Add skip for cloud e2e tests when env vars missing	4 years ago
Chris Arcand	bf76cc98ef	command: Suggestions on migration copy from user feedback ... Some small edits to the TFC migration copy.	4 years ago
Katy Moe	11566b1d11	introduce AbsMoveableResource ... AbsMoveableResource is an AbsMoveable that is either a resource or a resource instance. This interface represents a moveable that has a resource type.	4 years ago
Katy Moe	7162e79fdf	return error on resource type mismatch ... A resource move is invalid if the two resource( instance)s are of different resource types. Check for this during move validation.	4 years ago
Katy Moe	dc3ed6271c	add failing test for resource type mismatch	4 years ago
Katy Moe	4305271cff	remove occurrences of AbsMovable	4 years ago
Katy Moe	1dabdf0dcd	normalise test names	4 years ago
James Bardin	33bcc715a0	Merge pull request #29928 from hashicorp/jbardin/ignore_null_map ... `ignore_changes` converting null maps to empty maps, and applying marks.	5 years ago
Omar Ismail	57a4b51e87	remove build tags for cloud e2e	5 years ago
Barrett Clark	5ef82ddd2f	Cloud: fix e2e tests ... - Fix tests and remove commented code - Remove parallel for some flaky tests - Add README	5 years ago
Brandon Croft	1f01ba4dbc	fix(run variables): support all variable types (map, list, bool, number, null, string) ... All run variables remain encoded as strings in the API but will now be expressed as an HCL value to be evaluated correctly by the remote terraform. Previously, only strings were supported. Examples: string: `"quoted literal"` (strings must be quoted) map: `{ foo = "bar" }` list: `["foo", "bar"]` bool: `true` null: `null` number: `0.0001` This requires the API to anticipate that all run variables will be HCL values	5 years ago
Brandon Croft	9441666d9a	Merge pull request #29903 from hashicorp/pull-mock-gotfe-changes ... Pull changes made to mocks in go-tfe	5 years ago
James Bardin	9d19086c8e	test for null map and fix lost map marks ... Add a test to ensure ignore_changes does not change null maps to empty maps. Fix when a marked map revers the changes ignored within that map.	5 years ago
James Bardin	40174b634a	ignore_changes changing a null map to empty ... Fix an error where using `ignore_changes` would cause some null maps to be saved as an empty map.	5 years ago
kmoe	64635edfb9	Merge pull request #29885 from hashicorp/kmoe/more-init-interrupts ... command: make module installation interruptible	5 years ago
Katy Moe	6da61bf07b	revert change to installModules diag handling ... Error diags from c.installModules() no longer cause getModules() to exit early. Whether installModules completed successfully, errored, or was cancelled, we try to update the manifest as best we can, preferring incomplete information to none.	5 years ago
kmoe	40ec62c139	command: make module installation interruptible ... Earlier work to make "terraform init" interruptible made the getproviders package context-aware in order to allow provider installation to be cancelled. Here we make a similar change for module installation, which is now also cancellable with SIGINT. This involves plumbing context through initwd and getmodules. Functions which can make network requests now include a context parameter whose cancellation cancels those requests. Since the module installation code is shared, "terraform get" is now also interruptible during module installation.	5 years ago
Krista LaFentres	c44c589f0a	Error if backup or backup-out options are used without the state option on non-local backends for the state mv command	5 years ago
Chris Arcand	21750037d5	cloud: Help output typos	5 years ago
uturunku1	58304b678c	import path to go mocks in tfe	5 years ago
Luces Huayhuaca	4e3218b4d5	cloud: convert uses of worspaces.operations into workspaces.executionMode (#29844) ... * convert uses of worspaces.operations into workspaces.executionMode The cloud package currently uses a deprecated API on workspaces to determine a workspace's execution mode. Deprecated: Operations (boolean) New hotness: Execution mode (string - "local", "remote", or "agent") More details: https://www.terraform.io/docs/cloud/api/workspaces.html#request-body All uses of Operations field coming from the client (within the cloud package) should be converted to the appropriate ExecutionMode equivalent. Also, we need to update all acknowledgment of operations field on the tests that are testing the behavior of workspaces. Co-authored-by: Nick Fagerlund <nick.fagerlund@gmail.com> Co-authored-by: Nick Fagerlund <nick.fagerlund@gmail.com>	5 years ago
Chris Arcand	779c958fbf	cloud: Add streamlined 'remote' backend state migration path ... For Terraform Cloud users using the 'remote' backend, the existing 'pattern' prompt should work just fine - but because their workspaces are already present in TFC, the 'migration' here is really just realigning their local workspaces with Terraform Cloud. Instead of forcing users to do the mental gymnastics of what it means to migrate from 'prefix' - and because their remote workspaces probably already exist and already conform to Terraform Cloud's naming concerns - streamline the process for them and calculate the necessary pattern to migrate as-is, without any user intervention necessary.	5 years ago
Chris Arcand	2690f738aa	Merge pull request #29878 from hashicorp/tweak-multi-to-multi-migration-tfc ... cloud: Autoselect migrated current workspace + migrate UX adjustments	5 years ago
Chris Arcand	6f25ad3e17	cloud: Display the newly renamed workspaces after a migration	5 years ago
Chris Arcand	c3bf5d4512	cloud: Automatically select renamed current workspace ... After migrating to TFC with renamed workspaces, automatically select what was the previous current workspace on behalf of the user. We don't need to make the user reselect.	5 years ago
Chris Arcand	f80b2177c8	cloud: Tweak multi-to-multi migration UX ... Note these change do break the internal/cloud/e2e tests; they are in a sad state that needs adjusting anyway, so I'm not updating them for these changes at this time.	5 years ago
James Bardin	5a8021f03d	Merge pull request #29868 from xiaozhu36/xiaozhu ... backend/oss: Removes the ConflictWith tag which on the attributes assume_role* to fix the incompatible error	5 years ago
James Bardin	913f9cc44a	Merge pull request #29862 from hashicorp/jbardin/validate-resource-values ... generate precise resource types during validate	5 years ago
xiaozhu36	e0a2716601	backend/oss: Removes the ConflictWith tag which on the attributes assume_role* to fix the incompatible error	5 years ago
Chris Arcand	858dc96859	Merge pull request #29853 from hashicorp/cloud-tags-workspace ... Cloud: Update Workspace during Tags strategy	5 years ago
Omar Ismail	1da7031855	cloud: Add tags to workspace if necessary when fetching state	5 years ago
Chris Arcand	f04ea2bd3d	Merge pull request #29860 from hashicorp/fix-init-after-error-take-two ... command: Update backend hash value only after a successful migration	5 years ago
Chris Arcand	7c0c2e952f	command: Don't always update backend hash when fetching the saved backend ... The Meta.backend_C_r_S_unchanged() method was sadly a bit of a mess. It seems to have originally been used as a method to be called when the backend is not changing, with an extra assumption that if the configured backend's hash doesn't match the one in state, surely the hash should just be updated as an option might have been moved to command line flags. However, this function was used throughout this file as 'the method to load the initialized (but not necessarily configured) backend', regardless of whether or not it is the same (unchanged). This is in addition to Meta.backendFromState(), which is used to load the same thing except in the main codepath of 'init -backend=false'. These changes separate the concerns of backend_C_r_S_unchanged() by 1) Fetching the saved backend (savedBackend()) 2) Updating the hash value in the backend cache when appropriate (either by leaving it to the caller to do themselves or by calling updateSavedupdateSavedBackendHash()) This allows migration codepaths to *not* update the hash value until after a migration has successfully taken place.	5 years ago
James Bardin	647d36062c	we don't need an abs provider address ... We only lookup providers by provider type to get the schema, so there's no reason to generate anything more specific.	5 years ago
James Bardin	6b8b0617bb	generate precise resource types during validate ... Allow `GetResource` to return correct types values during validation, rather than relying on `cty.DynamicVal` as a placeholder. This allows other dependent expressions to be more correctly evaluated.	5 years ago
Łukasz Sierant	19cce931a8	Test case for changing backend hash during aborted state migration ... Pulled and updated from https://github.com/hashicorp/terraform/pull/26260	5 years ago
Billy Keyes	52ca30273f	command/format: improve list nested attribute rendering (#29827) ... * command/format: fix list nested attr diff rendering Previously, diffs only rendered correctly if all changed elements appeared before all unchanged elements. Once an unchanged element was found, all remaining elements were skipped. This usually led to the output being an empty list with a weird amount of space between the brackets. * command/format: improve list nested attr rendering This makes several changes that make diffs for lists clearer and more consistent: * Separate items with brackets instead of only new lines. This better matches the input syntax and avoids confusion from the first and last brackets implying there is a single item. * Render an action symbol for each element of the list * Use the correct action symbol for new and deleted items * Fix the alignment of opening and closing brackets I also refactored the structure so it is similar to the set and map cases to minimize duplication of the new prints. * Fix re-use of blockBodyDiffResult struct	5 years ago
kmoe	ba4b6652fa	Merge pull request #29849 from hashicorp/kmoe/ignore_changes-override ... configs: fix ignore_changes config override bug	5 years ago
Barrett Clark	13ec9b539c	Merge pull request #29846 from hashicorp/barrettclark/parrelize-cloud-e2e-tests ... cloud: Allow cloud tests to be run in parallel	5 years ago
James Bardin	834f61cd54	Merge pull request #29841 from xiaozhu36/xiaozhu ... backend/oss: Supports the new attribute sts_endpoint	5 years ago
Katy Moe	8e640ae151	fix typo	5 years ago
Katy Moe	257c24ff75	IgnoreAllChanges should override during merge	5 years ago
Katy Moe	df6dad5070	add failing test for IgnoreAllChanges override	5 years ago
Barrett Clark	9c13521d76	Allow cloud tests to be run in parallel ... Add the `-parallel N` switch to tell the tests to run in N processes: ``` TFE_TOKEN=$TFE_TOKEN TFE_HOSTNAME=$TFE_HOSTNAME TF_ACC=1 go test -v \ -tags=e2e ./internal/cloud/e2e/... -parallel 4 ```	5 years ago
Nick Fagerlund	02e62c9851	Cloud: Init without erroring when no workspaces match the `tags` (#29835) ... Previously, `terraform init` was throwing an error if you configured the cloud block with `tags` and there weren't any tagged workspaces yet. Confusing and alienating, since that that's a fairly normal situation! Basically TFC was handling an empty list of workspaces worse than other backends, because it doesn't support an unnamed default workspace. This commit catches that condition during `Meta.selectBackend()` and asks the user to pick a name for their first tagged workspace. If they cancel out, we still error, but if we know what name they want, we can handle it the same way as a nonexistent workspace specified in `name` -- just pass it to `Meta.SetWorkspace()`, and let the workspace get implicitly created when `InitCommand.Run()` eventually calls `StateMgr()`.	5 years ago
James Bardin	b91d9435ea	Merge pull request #29832 from hashicorp/jbardin/nullable-variable ... configs: explicitly nullable variable values	5 years ago
James Bardin	6d050c166e	udpate diagnostic message	5 years ago
Martin Atkins	94cbc8fb5d	experiments: config_driven_move has concluded ... Based on feedback during earlier alpha releases, we've decided to move forward with the current design for the first phase of config-driven refactoring. Therefore here we've marked the experiment as concluded with no changes to the most recent incarnation of the functionality. The other changes here are all just updating test fixtures to no longer declare that they are using experimental features.	5 years ago
Alisdair McDiarmid	a61bd8a96b	cloud: Fix prerelease version constraint checks	5 years ago