774 Commits (6cc3e1d0bd635cdae92b3e0055c19d86dfa7a222)

Author	SHA1	Message	Date
Martin Atkins	995042666a	config/hcl2shim: ValuesSDKEquivalent float64 comparison of numbers ... The SDK uses only the native int and float64 types internally for values that are specified as being "number" in schema, so for SDK purposes only a float64 level of precision is significant. To avoid any weirdness introduced as we shim and un-shim numbers, we'll reduce floating point numbers to float64 precision before comparing them to try to mimic the result the SDK itself would've gotten from comparing its own float64 versions of these values using the Go "==" operator.	7 years ago
Martin Atkins	6b03c81375	config/hcl2shim: ValuesSDKEquivalent function ... This is a first pass of an "approximately equal" function that tries to mimic the reduced precision caused by the field reader abstraction in helper/schema so that we can distinguish between meaningful changes to the proposed new state and incidental ones that just result from the loss of precision in the SDK implementation.	7 years ago
Martin Atkins	4e14ab7557	config: Remove "setproduct" function, which is now in lang/funcs	7 years ago
Martin Atkins	9d11d427a8	config: Rename "product" function to "setproduct" ... This hopefully makes it clearer that it works with sets rather than real numbers, avoiding confusion with "sum", "min", "max", etc.	7 years ago
Fábio Matavelli	acd17d9075	Create product interpolation function ... This creates the product interpolation function that returns the cartesian product of a list of lists.	7 years ago
James Bardin	c7269bec02	Revert "insert empty objects into config from empty blocks" ... This reverts commit 3677522a28. Later changes negate the need for this, and removing these again prevents us from having to strip them back out when helper/schema doesn't want them.	7 years ago
James Bardin	f3c80b4765	add zero values to sets with a flatmap count of 1 ... If a flatmap value has a count of 1 and no other attributes, it usually indicates the equivalent configuration of an empty (or default value) set block. Treat this as containing a single zero value object and insert that into the set.	7 years ago
James Bardin	3677522a28	insert empty objects into config from empty blocks ... When creating a legacy config from a cty.Value, empty nested blocks should corespond to empty objects in the config.	7 years ago
James Bardin	6fee1f24ab	don't add duplicate unknowns to a set ... The flatmap shim was lazily adding duplicate items and letting cty.Set clear them out, but if those duplicates contains unknown values they can't be checked for equality and will end up remaining in the set.	8 years ago
James Bardin	f959b560a2	trim index steps from RequiresNew paths ... Only GetAttrSteps can actually trigger RequiresNew, but the flatmaps paths will point to the indexed value that caused the change.	8 years ago
Martin Atkins	93630cf95f	config/hcl2shim: ConfigValueFromHCL2Block function ... This is a more specialized version of ConfigValueFromHCL2 which is specifically for config values that represent the content of a block body in the configuration. By using the schema of that block we can more precisely emulate the old HCL1/HIL behaviors by distinguishing attributes from blocks and applying some slightly different behaviors for the handling of null values and of empty collections that are representing the absense of blocks of a particular type.	8 years ago
James Bardin	5c436bb820	add a nested map test to hcl2shim	8 years ago
James Bardin	9d8ca4515e	unknown collections in a flatmap ... Unknown collections in a flatmap also need to be converted to unknown values.	8 years ago
Martin Atkins	8cc8bacce3	config/hcl2shim: Treat DynamicVal like any other unknown value in flatmap	8 years ago
Kristin Laemmert	d1f27ce8c2	registry: renaming module-specific registry functions	8 years ago
James Bardin	f4416ee1df	update the new RequiresReplace function ... Make the function work specifically how we need for RequiresReplace. Skip index changes, any set changes are only recorded as the set itself, and filter out duplicate paths. Add a few more tests to check for various nested structures.	8 years ago
James Bardin	30ff37f335	change PathFromFlatmapKey to RequiresReplace ... Rather than try and make a generalized path function here, what we really need in a function to generate the paths needed for RequiresReplace. This needs to take into account that sets elements don't need to be indexed themselves, and changes to collection index values aren't needed.	8 years ago
James Bardin	44e993ec29	add hcl2shim.PathFromFlatmapKey ... PathFromFlatmapKey is used to convert a flatmap key to a cty.Path, and ensures it conforms to the type schema. This is used when handling Diffs, where the ResourceAttrDiffs are indexed by the flatmapped key values, and we need to convert those to addresses to apply to a cty.Value.	8 years ago
James Bardin	05e85885f9	handle Null collections in flatmaps ... When creating a flatmap from a cty.Value, there may be Null collections which don't need to be added to the flatmap at all. Skip over these to avoid panicking in ElementIterator with a Null value.	8 years ago
James Bardin	c28ce02f2a	return a nil flatmap when presented with a NullVal ... A nil flatmap will be encoded as a NullVal of the correct type. When Converting a NullVal back to a flatmap, return nil immediately rather than attempting to build the values.	8 years ago
James Bardin	ac8ee20233	return a NullVal when presented with a nil flatmap ... This allows us to decode the cty.Value back to a nil map, rather than trying to create a map with nil values.	8 years ago
Martin Atkins	479c6b2466	move "configschema" from "config" to "configs" ... The "config" package is no longer used and will be removed as part of the 0.12 release cleanup. Since configschema is part of the "new world" of configuration modelling, it makes more sense for it to live as a subdirectory of the newer "configs" package.	8 years ago
Martin Atkins	299fe25a04	hcl2shim: Handle unknown values when shimming to/from flatmap ... Previously unknown values were round-tripping through flatmap and coming out as known strings containing the UnknownVariableValue. (The classic bug that, ironically, was one of the big reasons to write cty!) Now we properly handle unknown values in both directions: going in to flatmap we write UnknownVariableValue at the appropriate key (as the count for sequences or maps) and then coming out of flatmap we turn UnknownVariableValue back into a cty unknown value of the requested type.	8 years ago
Martin Atkins	ccc1b6990f	config/hcl2shim: shims from flatmap to cty and vice-versa ... These particular shims will have a pretty limited lifetime in mainline Terraform code (primarily to stub out the new expression evaluator against the old state structs until the new format is implemented) but will live on for some time in state migration and provider plugin compatibility shims.	8 years ago
Martin Atkins	ebafa51723	command: Various updates for the new backend package API ... This is a rather-messy, complex change to get the "command" package building again against the new backend API that was updated for the new configuration loader. A lot of this is mechanical rewriting to the new API, but meta_config.go and meta_backend.go in particular saw some major changes to interface with the new loader APIs and to deal with the change in order of steps in the backend API.	8 years ago
Martin Atkins	22d140e883	configschema: Block.CoerceValue method ... The usual way to use a configschema.Block is to obtain a hcldec spec from it and then decode an hcl.Body. There are inevitably situations though where a body has already been decoded into a cty.Value before we know which schema we need to use. This new method CoerceValue is intended to deal with this case, applying the schema to an already-decoded value in what should be an intuitive way for most situations.	8 years ago
Martin Atkins	d6c6f8852c	configschema: include description in schema ... We will need access to this information in order to render interactive input prompts, and it will also be useful in returning schema information to external tools such as text editors that have autocomplete-like functionality.	8 years ago
Martin Atkins	c51d22bdeb	config/hcl2shim: don't put nils in ConfigValue maps ... Absent values are omitted by the old code we are emulating in HCL, so we must do the same here in order to avoid breaking assumptions in the helper/schema layer.	8 years ago
Sander van Harmelen	179b32d426	Add a `CredentialsForHost` method to disco.Disco ... By adding this method you now only have to pass a `*disco.Disco` object around in order to do discovery and use any configured credentials for the discovered hosts. Of course you can also still pass around both a `*disco.Disco` and a `auth.CredentialsSource` object if there is a need or a reason for that!	8 years ago
Sander van Harmelen	9ba33e1958	Merge pull request #18360 from hashicorp/svh/b-close-body ... svchost/disco: make sure to close the response body	8 years ago
Sander van Harmelen	2c0c3771a9	Make sure to close the response body ... And fix a few linter warnings while we're at it…	8 years ago
Borys Pierov	c811440188	config: Don't log the private key on error in rsadecrypt	8 years ago
James Bardin	7b5efad725	update missing alias message ... Update the old error message for a missing provider alias, as we no longer automatically inherit providers.	8 years ago
James Bardin	15dc75720e	don't re-use a TempDir path ... Rather than creating and immediately removing a temp directory to get a random path name, fetch files into a subdirectory.	8 years ago
Martin Atkins	5b08fd4f9f	config: Don't expose go implementation details in Resource.Count ... Previously we would return the raw error from strconv.ParseInt, which includes details in its text that expose implementation details and are thus not helpful to the user. Instead, we use a locally-defined error message that talks only about what the caller is expected to know: that count should be parsable as an integer.	8 years ago
Masayuki Morita	e873af9337	Fix panic with substr interpolation function by invalid offset ... Fixes #17041	8 years ago
Pierre-Alain TORET	128f4d19e1	config: Allow build on DragonFlyBSD ... DragonFlyBSD is not officially supported, but allowing it to work is straightforward at the moment so we'll allow it for now.	8 years ago
James Bardin	cf4995d8a7	use the full module name with host for errors ... The module related logs and errors should reference the full module name including the source host.	8 years ago
Rob Campbell	5daeee5f6d	Update various files for new version of "stringer" ... The latest version of stringer now uses strconv instead of fmt.	8 years ago
Martin Atkins	87e1fb4d66	config: a nicer error message for invalid provider constraints ... Previously our error message here was confusing and redundant: Error starting operation: provider.null: invalid version constraint "not valid": Malformed constraint: not valid Instead, we'll generate a full HCL2 diagnostic here, which results in something (subjectively) nicer: Error: Invalid provider version constraint The value "@ 1.0.0" given for provider.null is not a valid version constraint. At the moment this message is an outlier in that the other validation errors are all still just plain Go errors, but over time we'll want to adjust all of these to be full diagnostics so that we can embed source range information in them to help the user find the offending configuration.	8 years ago
James Bardin	e0b2c64645	accessing count directly in an output should is OK ... There should be no warning when accessing a resource's count value directly in an output.	8 years ago
James Bardin	0e7dab09e6	Use the new registry.Client ... The registry code has been moved into the new registry package. Remove the duplicated code and use the new registry and registry/test packages.	8 years ago
Paul Banks	06f067b4e6	Update registry API docs with browse and search (#16846) ... * Verify discovery works without trailing slash on discovery URL * Update registry API docs with browse and search endpoints * Add sample request/responses * Add comment to test to indicate expecations * Fix typo * Remove trailing slash weirdness	8 years ago
David Meyer	fe0cc3b0db	config: new "rsadecrypt" interpolation function ... The primary use-case is to decrypt windows passwords obtained from AWS, but this function is generic and may find other purposes too.	8 years ago
mizuno	01c1142589	config: new "timeadd" interpolation function	8 years ago
James Bardin	048af6e237	Add test fixture to check for warnings	9 years ago
Martin Atkins	cc5e480378	config: detect and warn about access to "counted" attributes ... A common pattern is to conditionally assign to "count" in a resource in order to decide dynamically whether it should be created. In that situation it's necessary to refer to attributes of the resource using the splat syntax, but historically we didn't show errors in output expressions and so people "got away with" incorrect usage in that context. The intent of this warning is to catch potentially-problematic usage of attributes on such resources even if the count happens to be currently set dynamically to 1, which would not generate the error. Then the user can quickly locate and fix the incorrect usage regardless of the current value.	9 years ago
Martin Atkins	ba0514106a	return tfdiags.Diagnostics from validation methods ... Validation is the best time to return detailed diagnostics to the user since we're much more likely to have source location information, etc than we are in later operations. This change doesn't actually add any detail to the messages yet, but it changes the interface so that we can gradually introduce more detailed diagnostics over time. While here there are some minor adjustments to some of the messages to improve their consistency with terminology we use elsewhere.	9 years ago
James Bardin	8091bd627d	move Svchost method to regsrc.Module ... The level of abstraction that needs the "svchost" is the Module, not the FriendlyHost. Us the new method in the module package for registry interaction.	9 years ago
James Bardin	bd576d780a	failing test for module not found error ... The "not found" error should use the raw string directly from the config source, but the existing method was adding the default registry if there was no host indicated.	9 years ago