10 Commits (6440c839474f052d8997bb5cec19c2743e5108e6)

Author	SHA1	Message	Date
Martin Atkins	39e609d5fd	vendor: switch to HCL 2.0 in the HCL repository ... Previously we were using the experimental HCL 2 repository, but now we'll shift over to the v2 import path within the main HCL repository as part of actually releasing HCL 2.0 as stable. This is a mechanical search/replace to the new import paths. It also switches to the v2.0.0 release of HCL, which includes some new code that Terraform didn't previously have but should not change any behavior that matters for Terraform's purposes. For the moment the experimental HCL2 repository is still an indirect dependency via terraform-config-inspect, so it remains in our go.sum and vendor directories for the moment. Because terraform-config-inspect uses a much smaller subset of the HCL2 functionality, this does still manage to prune the vendor directory a little. A subsequent release of terraform-config-inspect should allow us to completely remove that old repository in a future commit.	7 years ago
Pam Selle	234c1c482a	Add a comment	7 years ago
Pam Selle	cd83e6108d	Fixes issue where attribute in nested is not of list type/is invalid and would panic	7 years ago
James Bardin	6e222375c7	invlaid use of dynamic with attrs should not panic ... Mistakenly using dynamic on an attribute will lead to a panic when attempting to resolve variable references with a partial body, because the dynamic blocks have yet to be expanded and validated. Check that the block element type is actually an object before generating a schema.	7 years ago
James Bardin	0133dda311	allow empty dynamic blocks with ConfigModeAttr ... If a dynamic block is evaluated zero times, the body content will contain 0 blocks. Allow the probe for ConfigModeAttr to accept that no blocks with a matching attribute should still be converted to a block if they are called with dynamicExpand.	7 years ago
Martin Atkins	ffcf9fc51b	lang/blocktoattr: Apply fixup within already-fixed-up blocks too ... When a top-level list-of-object contains an attribute that is also list-of-object we need to do the fixup again inside the nested body (using our synthetic attributes-only schema) so that the attr-as-blocks mechanism can apply within the nested blocks too.	7 years ago
Martin Atkins	6c5819f910	configs/configupgrade: Prefer block syntax for list-of-object attributes ... In order to preserve pre-v0.12 idiom for list-of-object attributes, we'll prefer to use block syntax for them except for the special situation where the user explicitly assigns an empty list, where attribute syntax is required in order to allow existing provider logic to differentiate from an implicit lack of blocks.	7 years ago
Martin Atkins	003317d7c8	lang: Detect references when a list/set attr is defined using blocks ... For compatibility with documented patterns from existing providers we are now allowing (via a pre-processing step) any attribute whose type is a list-of-object or set-of-object type to optionally be assigned using one or more blocks whose type is the attribute name. The pre-processing functionality was implemented in previous commits but we were not correctly detecting references within these blocks that are, from the perspective of the primary schema, invalid. Now we'll use an alternative implementation of variable detection that is able to apply the same schema rewriting technique we used to implement the transform and thus can find all of the references as if they were already in their final locations.	7 years ago
Martin Atkins	8746e9e8ad	lang/blocktoattr: ExpandedVariables function ... Because we handle FixUpBlockAttrs after dynamic block expansion, when resolving variables we unfortunately need to consider the possibility of both dynamic block expansion _and_ the block attrs fixup. To accommodate this we have a variant of dynblock.VariablesHCLDec that instead walks using the configschema.Block representation of the schema and applies the same opportunistic schema rewrite used by FixUpBlockAttrs at each body encountered during the walk.	7 years ago
Martin Atkins	6dcf8195b8	lang/blocktoattr: Selectively allow block syntax to be used for attributes ... This preprocessing step allows users to use nested block syntax to specify elements of an attribute that is defined as being a list or set of an object type. This restores part of the unintended flexibility permitted in Terraform v0.11 so that we can work around a few tricky edges where provider implementations were relying on Terraform's failure to validate this in earlier versions. For any body that is pre-processed using this new helper, we will recognize when a configuration author uses nested block syntax with a name that is specified in the schema as an attribute of a suitable type and tweak the schema just in time before decoding to expect that usage and then fix up the result on the way out to conform to the original schema. Achieving this requires an abstraction inversion because only Terraform's high-level schema has enough information to decide how to rewrite the incoming low-level schema. We must therefore here implement HCL's lowest-level API interface in terms of the higher-level abstractions of hcldec and Terraform's configschema. Because of the abstraction inversion this fixup mechanism cannot be used generally for arbitrary HCL bodies but we can use it carefully inside the lang package where its own API can guarantee the necessary invariants for this to work.	7 years ago