187 Commits (6440c839474f052d8997bb5cec19c2743e5108e6)

Author	SHA1	Message	Date
James Bardin	a3c9b33b7b	output buffer must be synchronized	6 years ago
Sander van Harmelen	9453308c78	Make sure the WinRM communicator can reconnect	6 years ago
Sander van Harmelen	10aab86051	Make sure we use MaxRetries correctly ... Even if MaxRetries is 0, we should still execute the loop one time in order to run the Chef-Client at least once. Also waiting only makes sense when we have `attempts` left. And last but not least we want to exit immediately when the exit code is not in the retry list. So this PR fixes three small issues to make everything work as expected.	6 years ago
Sander van Harmelen	a614056925	Refactor the code a bit to make it more idiomatic	6 years ago
Brian Dwyer	2f4067cf70	Clean up and add docs ... Signed-off-by: Brian Dwyer <Brian.Dwyer@broadridge.com>	6 years ago
Brian Dwyer	4701ed2e02	Gracefully handle Chef RFC062 Exit Codes ... Signed-off-by: Brian Dwyer <Brian.Dwyer@broadridge.com>	6 years ago
David McNeil	3a079b04db	Change file permission ordering to avoid race condition ... Signed-off-by: David McNeil <mcneil.david2@gmail.com>	6 years ago
David McNeil	b95daa87c8	Fix permissions of habitat provision's user.toml ... Signed-off-by: David McNeil <mcneil.david2@gmail.com>	6 years ago
Alex Harvey	cbeedfca35	provisioner/puppet: fix bug when connection type was not set in config (#23057) ... Before this, the Terraform Puppet provisioner would error out in a confusing way if the type attribute in a connection block was not given. Apparently an omitted type leads to type having a value "" which must be then assumed to mean "ssh". Fixes #23004	7 years ago
Kyle Mott	30895a6cf5	Merge cleanup, remove `license` parameter in favor of bool `accept_license`, adjust how license acceptance is done, update hab provisioner doc.	7 years ago
Kyle Mott	e3d1876f44	Merge upstream	7 years ago
Mudassar Shafique	50a6c69ab5	Habitat License Acceptance changes. These changes add a new argument that allows users to accept Habitat End User License. ... It also containts doc updates for Habitat and Chef provisioner	7 years ago
Kyle Mott	997761ef41	Remove commented out code.	7 years ago
Kyle Mott	164332bfa1	Update Linux Habitat Provisioner to support new licensing, options cleanup.	7 years ago
Alex Pilon	c993fc3c1b	better error handling for type assertions	7 years ago
Alex Pilon	4bf43efcfd	move hcl2shim package to configs	7 years ago
Alex Pilon	d1448fc319	restore test ... switch provisioner validation to cast to []interface{} first	7 years ago
Alex Pilon	83aa07f907	prune NewResourceConfig and update tests	7 years ago
Pam Selle	291cf8c5a4	Revert "Habitat License Acceptance changes. "	7 years ago
Pam Selle	9020636f93	Merge pull request #21345 from mudash/master ... Habitat License Acceptance changes.	7 years ago
Alex Pilon	7f8f198719	remove UnknownVariabeValue from config and update references to shim	7 years ago
Radek Simko	5b9f2fafc8	Standardise directory name for test data	7 years ago
Tim Sharpe	615110e13e	provisioner: new Puppet provisioner (#18851) ... * Basic Puppet provisioner * (fixup) fix snake_case use in Bolt * (fixup) Remove unused ValidateFunc * (fixup) Check bolt result status * (lint) go fmt * Requested changes * Remove PE autodetection * Apply suggestions from @svanharmelen Co-Authored-By: rodjek <tim@sharpe.id.au> * Tag all JSON fields in bolt output * Defer comm.Disconnect() as suggested * Make bolt timeout configurable * Update builtin/provisioners/puppet/resource_provisioner.go Co-Authored-By: rodjek <tim@sharpe.id.au> * Make extension_requests and custom_attributes configurable	7 years ago
Mudassar Shafique	258319e6b0	Adding a comment to explain a testcase	7 years ago
Mudassar Shafique	e78658de4c	Habitat License Acceptance changes. These changes add a new argument that allows users to accept Habitat End User License.	7 years ago
Jurnell Cockhren	1242e08473	fix(salt-masterless): Compare retrieved variable values with defaults	7 years ago
Jurnell Cockhren	996f845d4b	fix(salt-masterless): set the default values for state and pillar remote locations	7 years ago
Sander van Harmelen	56e6c60f76	Merge pull request #18533 from alice-sawatzky/master ... change chef linux provisioner to use user:group chown syntax	8 years ago
Sean Chittenden	d749420a25	Fix drift caused from gofmt when running make dev and go 1.11. ... A fresh checkout of `origin/master` does not build atm using the `dev` target because `master` has not been formatted using `gofmt` from Go 1.11 (tis has been the case for a while if you've been running devel). None of the drift in question is especially new but now that Go 1.11 has been released and gofmt's formatting guidelines have been updated, it would be *really* nice if the code in `master` reflected the current tooling in order to avoid having to fight this drift locally. * 8mo: https://github.com/hashicorp/terraform/blame/master/backend/remote-state/s3/backend_test.go#L260-L261 * 6mo: https://github.com/hashicorp/terraform/blame/master/builtin/provisioners/chef/linux_provisioner_test.go#L124 * 1yr: 7cfeffe36b/command/init.go (L75-L76) * 12d: 7cfeffe36b/command/meta_backend_test.go (L1437) * 2yr: 7cfeffe36b/helper/schema/resource_timeout_test.go (L26) * 4yr: 7cfeffe36b/helper/schema/schema_test.go (L2059) * 1yr: 7cfeffe36b/plugin/discovery/get_test.go (L151)	8 years ago
Alice Sawatzky	15c65f981b	change chef linux provisioner to use user:group chown syntax	8 years ago
Skyler Layne	d1124a4e3d	Update resource_provisioner.go ... fix spacing for service url.	8 years ago
Andre Bindewald	de43f01d65	provisioner/local-exec: Support custom environment variables on Windows ... Due to an incorrect slice allocation, the environment variable list was created with an empty string element for each real element added. It appears that this was silently ignored on Unix, but caused the following environment settings to be ignored altogether on Windows.	8 years ago
James Bardin	f8b691f743	Merge pull request #17781 from hashicorp/jbardin/habitat ... `enable` habitat supervisor service before `start`	8 years ago
James Bardin	c1edaadc7b	Merge pull request #17403 from rwc/hab-provisioner-updates ... [provisioner-habitat] Fix package channel honoring and documentation	8 years ago
Marko Springfeldt	a201b04b26	`enable` habitat supervisor service before `start` ... Signed-off-by: Arash Zandi <arash.zandi@smartb.eu>	8 years ago
James Bardin	e9e4ee4940	Merge pull request #17609 from hashicorp/jbardin/remote-command ... clean up remote.Cmd api	8 years ago
James Bardin	ad8642e2c2	have remote.ExitError format errors and status ... Since all use cases of ExitStatus are just putting it into fmt.Errorf, usually with the command string, have ExitStatus do that for the caller.	8 years ago
James Bardin	56acda00bc	add timeout test to remote-exec ... Add a test to remote-exec to make sure the proper timeout is honored during apply. TODO: we need some test helpers for provisioners, so they can all be verified.	8 years ago
James Bardin	9b4b5f2a72	use correct context for communicator.Retry ... The timeout for a provisioner is expected to only apply to the initial connection. Keep the context for the communicator.Retry separate from the global cancellation context.	8 years ago
Scott Hain	07aeea51da	Updates the chef provisioner to allow specifying a channel (#17355) ... * Updates the chef provisioner to allow specifying a channel This also updates the omnitruck url to the current url. Signed-off-by: Scott Hain <shain@chef.io> * Update omnitruck URL Signed-off-by: Scott Hain <shain@chef.io>	8 years ago
James Bardin	3fbdee0777	clean up remote.Cmd api ... Combine the ExitStatus and Err values from remote.Cmd into an error returned by Wait, better matching the behavior of the os/exec package. Non-zero exit codes are returned from Wait as a remote.ExitError. Communicator related errors are returned directly. Clean up all the error handling in the provisioners using a communicator. Also remove the extra copyOutput synchronization that was copied from package to package.	8 years ago
James Bardin	a1061ed931	update the chef and habitat error handling ... Use the new ExitStatus method, and also check the cmd.Err() method for errors. Remove leaks from the output goroutines in both provisioners by deferring their cleanup, and returning early on all error conditions.	8 years ago
James Bardin	a715430d24	fix exit status handling in salt-masterless ... Convert to the new Cmd.ExitStatus() method in the salt-masterless provisioner. Add calls to Wait and remove race conditions around setting the status.	8 years ago
James Bardin	af132a186d	remove timeout from remote-exec command context ... The timeout for the remote command was taken from the wrong config field, and the connection timeout was being used which is 5 min. Any remote command taking more than 5 min would be terminated by disconnecting the communicator. Remove the timeout from the context, and rely on the global timeout provided by terraform. There was no way to get the error from the communicator previously, so the broken connection was silently ignored and the provisioner returned successfully. Now we can use the new cmd.Err() method to retrieve any errors encountered during execution.	8 years ago
Kristiyan Nikolov	999f9096c1	provisioner/local-exec: Allow passing environment variables	8 years ago
Paweł Socha	be8d39210d	Wait for ssh connection	8 years ago
Paweł Socha	627bb24ea6	fix ssh problem with communicator.Retry	8 years ago
Rob Campbell	bbd3d7f7a2	Updates the capitalization of the bind documenation for habitat ... provisioner. Also fixes an issue where channels and URLs are not honored in the initial package install. Signed-off-by: Rob Campbell <rcampbell@chef.io>	8 years ago
chrisjob1021	10bb21e9c4	provisioner/local-exec: Optional "working_dir" argument ... This new argument allows overriding of the working directory of the child process, with the default still being the working directory of Terraform itself.	8 years ago
James Bardin	0345d960b2	simplify remote-exec runScripts ... There no reason to retry around the execution of remote scripts. We've already established a connection, so the only that could happen here is to continually retry uploading or executing a script that can't succeed. This also simplifies the streaming output from the command, which doesn't need such explicit synchronization. Closing the output pipes is sufficient to stop the copyOutput functions, and they don't close around any values that are accessed again after the command executes.	8 years ago