638 Commits (6440c839474f052d8997bb5cec19c2743e5108e6)

Author	SHA1	Message	Date
Martin Atkins	8f27409007	backend/remote: Support HCL variable values in local operations ... For remote operations, the remote system (Terraform Cloud or Enterprise) writes the stored variable values into a .tfvars file before running the remote copy of Terraform CLI. By contrast, for operations that only run locally (like "terraform import"), we fetch the stored variable values from the remote API and add them into the set of available variables directly as part of creating the local execution context. Previously in the local-only case we were assuming that all stored variables are strings, which isn't true: the Terraform Cloud/Enterprise UI allows users to specify that a particular variable is given as an HCL expression, in which case the correct behavior is to parse and evaluate the expression to obtain the final value. This also addresses a related issue whereby previously we were forcing all sensitive values to be represented as a special string "<sensitive>". That leads to type checking errors for any variable specified as having a type other than string, so instead here we use an unknown value as a placeholder so that type checking can pass. Unpopulated sensitive values may cause errors downstream though, so we'll also produce a warning for each of them to let the user know that those variables are not available for local-only operations. It's a warning rather than an error so that operations that don't rely on known values for those variables can potentially complete successfully. This can potentially produce errors in situations that would've been silently ignored before: if a remote variable is marked as being HCL syntax but is not valid HCL then it will now fail parsing at this early stage, whereas previously it would've just passed through as a string and failed only if the operation tried to interpret it as a non-string. However, in situations like these the remote operations like "terraform plan" would already have been failing with an equivalent error message anyway, so it's unlikely that any existing workspace that is being used for routine operations would have such a broken configuration.	7 years ago
Martin Atkins	9f9f22091e	backend/remote: Unlock workspace if Context fails ... Previously any error case in the Context method would cause us to leave the remote workspace locked on exit, requiring manual action to unlock it.	7 years ago
Martin Atkins	b10f058cbb	backend/remote: Only load variables if we're going to use them ... Some commands don't use variables at all or use them in a way that doesn't require them to all be fully valid and consistent. For those, we don't want to fetch variable values from the remote system and try to validate them because that's wasteful and likely to cause unnecessary error messages. Furthermore, the variables endpoint in Terraform Cloud and Enterprise only works for personal access tokens, so it's important that we don't assume we can _always_ use it. If we do, then we'll see problems when commands are run inside Terraform Cloud and Enterprise remote execution contexts, where the variables map always comes back as empty.	7 years ago
Martin Atkins	a8d01e3940	backend/remote: Report invalid variables only remotely ... The remote backend uses backend.ParseVariableValues locally only to decide if the user seems to be trying to use -var or -var-file options locally, since those are not supported for the remote backend. Other than detecting those, we don't actually have any need to use the results of backend.ParseVariableValues, and so it's better for us to ignore any errors it produces itself and prefer to just send a potentially-invalid request to the remote system and let the remote system be responsible for validating it. This then avoids issues caused by the fact that when remote operations are in use the local system does not have all of the required context: it can't see which environment variables will be set in the remote execution context nor which variables the remote system will set using its own generated -var-file based on the workspace stored variables.	7 years ago
Radek Simko	7860f55e4f	Version tools per Go convention under tools.go	7 years ago
Pam Selle	a5f2f4cbba	Update messaging for .terraformignore	7 years ago
Radek Simko	32f9722d9d	Replace import paths & set UA string where necessary	7 years ago
Martin Atkins	8664749b59	backend: Allow certain commands to opt out of required variable checks ... Terraform Core expects all variables to be set, but for some ancillary commands it's fine for them to just be set to placeholders because the variable values themselves are not key to the command's functionality as long as the terraform.Context is still self-consistent. For such commands, rather than prompting for interactive input for required variables we'll just stub them out as unknowns to reflect that they are placeholders for values that a user would normally need to provide. This achieves a similar effect to how these commands behaved before, but without the tendency to produce a slightly invalid terraform.Context that would fail in strange ways when asked to run certain operations.	7 years ago
Martin Atkins	e21f0fa61e	backend/local: Handle interactive prompts for variables in UI layer ... During the 0.12 work we intended to move all of the variable value collection logic into the UI layer (command package and backend packages) and present them all together as a unified data structure to Terraform Core. However, we didn't quite succeed because the interactive prompts for unset required variables were still being handled _after_ calling into Terraform Core. Here we complete that earlier work by moving the interactive prompts for variables out into the UI layer too, thus allowing us to handle final validation of the variables all together in one place and do so in the UI layer where we have the most context still available about where all of these values are coming from. This allows us to fix a problem where previously disabling input with -input=false on the command line could cause Terraform Core to receive an incomplete set of variable values, and fail with a bad error message. As a consequence of this refactoring, the scope of terraform.Context.Input is now reduced to only gathering provider configuration arguments. Ideally that too would move into the UI layer somehow in a future commit, but that's a problem for another day.	7 years ago
Martin Atkins	39e609d5fd	vendor: switch to HCL 2.0 in the HCL repository ... Previously we were using the experimental HCL 2 repository, but now we'll shift over to the v2 import path within the main HCL repository as part of actually releasing HCL 2.0 as stable. This is a mechanical search/replace to the new import paths. It also switches to the v2.0.0 release of HCL, which includes some new code that Terraform didn't previously have but should not change any behavior that matters for Terraform's purposes. For the moment the experimental HCL2 repository is still an indirect dependency via terraform-config-inspect, so it remains in our go.sum and vendor directories for the moment. Because terraform-config-inspect uses a much smaller subset of the HCL2 functionality, this does still manage to prune the vendor directory a little. A subsequent release of terraform-config-inspect should allow us to completely remove that old repository in a future commit.	7 years ago
Collin J. Doering	6d838ed76c	Allow s3 backends to contain more then 1000 workspaces ... * backend/remote-state/s3/backend_state.go: Prior to this commit, the terraform s3 backend did not paginate calls to s3 when finding workspaces, which resulted in workspaces 'disappearing' once they are switched away from, even though the state file still exists. This is due to the ListBucket operation defaulting MaxItems to 1000, so terraform s3 backends that contained more then 1000 workspaces did not function as expected. This rectifies this situation by paginating calls to s3 when finding workspaces. Signed-off-by: Collin J. Doering <collin@rekahsoft.ca>	7 years ago
Paul Thrasher	f2ef8ef317	slow down tfce polling to 1s ... Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	7 years ago
Paul Thrasher	4e308ef362	typos. some code, some text. ... Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	7 years ago
Paul Thrasher	d2eaffabea	vendor latest go-tfe ... Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	7 years ago
Paul Thrasher	d3fc3dee6e	clean up go mod for go-tfe ... Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	7 years ago
Paul Thrasher	e2831b3d1e	tfce test additions ... Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	7 years ago
Paul Thrasher	bc2d888b7b	update to go-tfe 0.3.23 ... this fixes the attr types Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	7 years ago
Paul Thrasher	39817ac476	cost estimation status polling ... Properly wait for cost estimation to finish running before outputting the results. Waits 500 milliseconds between checks, rather than backing off exponentially, because we are not in a run queue. At the point we're waiting, we expect cost estimation to be run in a timely manner.	7 years ago
Paul Thrasher	979bba0f32	tfce mock fix ... Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	7 years ago
Kristin Laemmert	006ef022e6	Merge pull request #22918 from hashicorp/mildwonkey/to-e2e-or-not-e2e ... Sundry fixes to e2e tests	7 years ago
Kristin Laemmert	68dfc3046d	backend/remote-state: etcdv3, oss, and manta acc tests should fail ... faster The acceptance tests for etcdv3, oss and manta were not validating required env variablea, chosing to assume that if one was running acceptance tests they had already configured the credentials. It was not always clear if this was a bug in the tests or the provider, so I opted to make the tests fail faster when required attributes were unset (or "").	7 years ago
Kristin Laemmert	5300f85a79	backend/manta: fix panic when insecure_skip_tls_verify was not set ... The DefaultFunc for insecure_skip_tls_verify was sending an empty string instead of a bool. Fixes to default to `false`.	7 years ago
Paddy	9b24ef7870	Merge pull request #21772 from luis-silva/21680/GCS_OAUTH ... Add OAuth2 token support for GCS backend	7 years ago
Martin Atkins	7e29b9b5d4	core: Warn when creating and applying with -target ... The documentation for the -target option warns that it's intended for exceptional circumstances only and not for routine use, but that's not a very prominent location for that warning and so some users miss it. Here we make the warning more prominent by including it directly in the Terraform output when -target is in use. We first warn during planning that the plan might be incomplete, and then warn again after apply concludes and direct the user to run "terraform plan" to make sure that there are no further changes outstanding. The latter message is intended to reinforce that -target should only be a one-off operation and that you should always run without it soon after to ensure that the workspace is left in a consistent, converged state.	7 years ago
Luis Silva	9ae8eca55d	Merge branch 'master' into 21680/GCS_OAUTH	7 years ago
yanndegat	be5280e4e1	remote-state/pg: add option to skip schema creation (#21607) ... * add `skip_schema_creation` option * add sanity check to avoid situations where postgres users hasn't been granted the "CREATE SCHEMA" right closes #21604 Signed-off-by: yann degat <yann@2kmail.net>	7 years ago
yuanye	b69c0b4199	oss backend support profile	7 years ago
James Bardin	10d94fb764	Merge pull request #21967 from williams-brian/SSE-C_Remote_State ... Add support for SSE-C to S3 backend	7 years ago
Radek Simko	f3357aad45	vendor: Downgrade Azure dependencies ... This is to allow Terraform providers to upgrade to at least one more minor version of the plugin SDK without major UX hiccups. This concludes (unsuccessful) experiments involving upgrades to SDK with https://github.com/Azure/go-autorest/pull/455 Even with that patch all providers still experience broken UX as described in https://github.com/hashicorp/terraform/pull/22490 This downgrade reduces the uncomfort to only a handful of providers from >100s. The affected providers more or less directly depend on Azure SDK(s), which is ~8. Affected providers practically cannot consume Terraform Plugin SDK with this patch (downgraded Azure SDKs) and can just wait for extracted Terraform Plugin SDK which is planned to be released soon. This reverts the following PRs: - https://github.com/hashicorp/terraform/pull/22247 - https://github.com/hashicorp/terraform/pull/22248 - https://github.com/hashicorp/terraform/pull/22524 - https://github.com/hashicorp/terraform/pull/22525 and it is otherwise result of the following commands ``` go get github.com/Azure/azure-sdk-for-go@v21.3.0 go get github.com/hashicorp/go-azure-helpers@166dfd221bb2 go mod tidy ```	7 years ago
Radek Simko	dee450cf8c	vendor: Bump go-azure-helpers to 0.7.0	7 years ago
Roberto Jung Drebes	b459a92575	backend/gcs: Use new endpoints for Google OAuth ... This is a consequence of googleapis/google-cloud-common#260.	7 years ago
Pam Selle	9631e4c73d	Merge pull request #20571 from sergkondr/fix_misspelling ... fix misspelling	7 years ago
Alex Pilon	4bf43efcfd	move hcl2shim package to configs	7 years ago
Chris Marchesi	d43fc71135	modules: update go-azure-helpers to v0.5.0 ... To help address the issues posed on #22087 and #22085.	7 years ago
He Guimin	a490dfa495	backend/oss: Support for assume role config	7 years ago
Kristin Laemmert	412d459292	backend/remote: remove milseading contents from error message (#22148) ... Previously, terraform was returning a potentially-misleading error message in response to anything other than a 404 from the b.client.Workspaces.Read operation. This PR simplifies Terraform's error message with the intent of encouraging those who encounter it to focus on the error message returned from the tfe client. The added test is odd, and a bit hacky, and possibly overkill.	7 years ago
Kristin Laemmert	190ef537ec	backend/remote: notify users when uploading something other than cwd ... When a TFC workspace is configured without a VCS root, and with a working directory, and a user is running `terraform init` from that same directory, TFC uploads the entire configuration directory, not only the user's cwd. This is not obvious to the user, so we are adding a descriptive message explaining what is being uploaded, and why.	7 years ago
Kristin Laemmert	89eeaed0a0	[WIP] backend/enhanced: start with absolute configuration path (#22096) ... * backend/enhanced: start with absolute config path We recently started normalizing the config path before all "command" operations, which was necessary for consistency but had unexpected consequences for remote backend operations, specifically when a vcs root with a working directory are configured. This PR de-normalizes the path back to an absolute path. * Check the error and add a test It turned out all required logic was already present, so I just needed to add a test for this specific use case.	7 years ago
Pam Selle	23a187d85d	Merge pull request #21739 from hasheddan/s3-backend-comment-typo ... s3 backend: minor typo in putMD5 comment	7 years ago
Colin Fowler	cd7bfba141	rebased to terraform master branch	7 years ago
Brian Williams	5e3c3bafb8	Add support for SSE-C to S3 backend ... These changes add support for encrypting terraform remote-state in S3 using customer-supplied encryption keys (SSE-C).	7 years ago
Luis Silva	f6c90c1d96	Add OAuth2 token support for GCS backend	7 years ago
Radek Simko	5b9f2fafc8	Standardise directory name for test data	7 years ago
Daniel Mangum	3bc14620c0	backend/remote-state: remove dead code ... This remote-state adapter is no longer used, because the old remote state mechanism was removed in Terraform v0.12.	7 years ago
hasheddan	961d43142c	s3 backend: minor typo in putMD5 comment ... Signed-off-by: hasheddan <georgedanielmangum@gmail.com>	7 years ago
Mary Cutrali	e44ca40702	update remote apply language to use proper its/it's	7 years ago
Pam Selle	cb593c25aa	Merge pull request #21381 from davidcelis/remove-cost-estimation ... Remove pre-alpha cost estimation logic from remote backend	7 years ago
kayrus	d06609dd23	Swift backend: add application credential support	7 years ago
Joe Topjian	d8343aa95f	backend/swift: Authentication updates ... Support for cross-domain authentication has been added and mapping environment variables to the correct domain settings has been fixed. In addition, support for clouds.yaml files has been added.	7 years ago
James Bardin	0c91d227fa	Merge branch 'master' into master	7 years ago
Ivan Kalita	5b6b1663ef	backend/http: implement retries for the http backend (#19702) ... Fixes #19619	7 years ago
Martin Atkins	b1213f7f6c	backend/local: don't panic when an instance has only a deposed object ... This unusual situation isn't supposed to arise in normal use, but it can come up in practice in some edge-case scenarios where Terraform fails in a severe way during a create_before_destroy. Some earlier versions of Terraform also had bugs in their handling of deposed objects, so this may also arise if upgrading from one of those older versions with some leftover deposed objects in the state.	7 years ago
Mateusz Gozdek	b6de825723	backend/gcs: make Unlock error message more clear	7 years ago
David Celis	5ccccfb91f	Remove pre-alpha cost estimation logic	7 years ago
Radek Simko	8a6d1d62b6	stringer: Regenerate files with latest version	7 years ago
Stephen Buergler	fc5b186e8d	Don't leak so many connections in the pg backend ... This change fixes an error I get: Error: pq: too many connections for role "asdf" because I can only have so many connections.	7 years ago
Sander van Harmelen	394f20f59c	backend/remote: do not unlock after a failed upload ... When changes are made and we failed to upload the state, we should not try to unlock the workspace. Leaving the workspace locked is a good indication something went wrong and also prevents other changes from being applied before the newest state is properly uploaded. Additionally we now output the lock ID when a lock or force-unlock action failed.	7 years ago
Paul Thrasher	151c91ffda	use scanner for reading logs ... Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	7 years ago
Paul Thrasher	0e27a8862f	remove duplicate remote output line ... Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	7 years ago
Sander van Harmelen	bb12206bca	Fixup the tests	7 years ago
Sander van Harmelen	7cf744241a	Do not use a scanner to read the logs ... Using a scanner can cause issues when reading long lines. Also make sure we return the error correctly while planning.	7 years ago
Paul Thrasher	c7a023a95c	update test for new go-tfe version ... Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	7 years ago
Paul Thrasher	53f977bee2	TFCE api correct pluralization ... Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	7 years ago
Paul Thrasher	e479bd5dc3	update to latest go-tfe ... same version number but pointing to a new sha Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	7 years ago
Sander van Harmelen	90bc237b7b	Prevent a panic caused by writing to a nil map	7 years ago
He Guimin	3f44dd9dec	Add tablestore config to store state lock	7 years ago
He Guimin	b887d44712	Add Alibaba Cloud backend OSS with lock	7 years ago
Sander van Harmelen	39a95e4222	backend/remote: correctly load remote variables ... When using `terraform console` in combination with the remote backend, variables defined in Terraform Enterprise were load loaded correctly.	7 years ago
Sander van Harmelen	57f6e01830	backend/local: preserve serial and lineage on failure ... When failing to write the state, the local backend writes the state to a local file called `errrored.tfstate`. Previously it would do so by creating a new state file which would use a new serial and lineage. By exorting the existing state file and directly assigning the new state, the serial and lineage are preserved.	7 years ago
Justin Downing	1e32ae243c	grammatical updates to comments and docs (#20195)	7 years ago
Stefan Schmidt	3ca1253796	backend/gcs: Mark the unused attributes project and region as removed. ... These two attributes are not used since aec45e6967.	7 years ago
Sander van Harmelen	9f6a126293	backend/remote: check for external updates	7 years ago
Sander van Harmelen	4628fbcc65	Merge pull request #20615 from hashicorp/svh/f-input-context ... core: add a context to the UIInput interface	7 years ago
Sander van Harmelen	e75e845804	Merge pull request #20588 from hashicorp/svh/f-retry ... backend/remote: also retry on server errors	7 years ago
Sander van Harmelen	973e2a7cf9	core: add a context to the UIInput interface	7 years ago
Sander van Harmelen	0232d84a0d	backend/remote: also retry on server errors ... Enably retrying on server errors in the updated `go-tfe` client and add a retry log hook for writing retry messages to the CLI.	7 years ago
Kristin Laemmert	b9d8e96e0c	command/plan: plan output should indicate if a resource is being (#20580) ... replaced because the instance was tainted.	7 years ago
Martin Atkins	709487b4f1	backend: Cap number of "undeclared variable" warnings at four ... For users who in previous versions have relied on our lack of checking for whether variables are declared, they may previously have seen an overwhelming number of warnings when running Terraform v0.12. Here we cap that number at three specific warnings and then one general warning, so we can still give a specific source location for the first couple (for users who have genuinely made a typo) but summarize away a large number for those who are seeing this because they've not yet migrated to using environment variables.	7 years ago
Mars Hall	34fa67c6b0	Correct pg backend error info	7 years ago
Mars Hall	ccf549a62d	Stricter pg backend locking during workspace creation	7 years ago
Sergey Kondrashov	43e7a7b552	fix misspelling	7 years ago
Mars Hall	31c9776d55	Switch pg backend to session-level advisory locking, to avoid rollback of partial state updates	7 years ago
Brian Flad	e34a97abca	backend/s3: Add debug logging and user agent ... Porting over previous behavior from terraform-provider-aws.	7 years ago
Sander van Harmelen	63e2dcef8a	Merge pull request #20481 from hashicorp/svh/b-exit-code ... backend/remote: exit with 1 when a run is canceled	7 years ago
James Bardin	eada955721	Merge pull request #19070 from mars/postgres-backend ... Postgres backend	7 years ago
Mars Hall	6d9e2048f4	Skip more pg backend acceptance tests	7 years ago
Mars Hall	920e7a7acc	Mutex pg backend‘s database transaction	7 years ago
Mars Hall	c6bf3442fc	Lock() in pg backend now returns LockError for retryable errors	7 years ago
Mars Hall	a075a68c58	Correct name of pg backend‘s default schema	7 years ago
Sander van Harmelen	01f17fa0ca	backend/remote: exit with 1 when a run is canceled	7 years ago
James Bardin	dd16455a79	fix s3 default region to match provider	7 years ago
Mars Hall	2621f95bd2	📚 doc corrections	7 years ago
Mars Hall	b9a91b7c1e	Switch pg backend to use native Postgres locks	7 years ago
James Bardin	c814f2da37	Change backend.ValidateConfig to PrepareConfig ... This mirrors the change made for providers, so that default values can be inserted into the config by the backend implementation. This is only the interface and method name changes, it does not yet add any default values.	7 years ago
Sander van Harmelen	435b82d6d0	Merge pull request #20460 from hashicorp/svh/f-permissions ... backend/remote: use the can-queue-apply permission	7 years ago
James Bardin	aebfecf871	Merge pull request #20211 from yanndegat/swift_remote_backend ... Swift remote backend support for workspaces & locking	7 years ago
Sander van Harmelen	58961026a2	backend/remote: use the can-queue-apply permission ... Previously we checked can-update in order to determine if a user had the required permissions to apply a run, but that wasn't sufficient. So we added a new permission, can-queue-apply, that we now use instead.	7 years ago
Mars Hall	8cb2943b6b	pg backend tests run when TF_ACC is set (no more TF_PG_TEST)	7 years ago
Mars Hall	c8b8227967	Compatibility fixes for 0.12.0	7 years ago
Mars Hall	d4d798c25e	Fix to use existing pg indexes	7 years ago
Mars Hall	9feda7aab3	Correct code comment for pg	7 years ago
Mars Hall	6d7e8268e7	Include pg backend in main init	7 years ago
Mars Hall	9043005cfb	Postgres database backend	7 years ago
James Bardin	31ca293777	fix slash handling around workspace_key_prefix ... The handling of slashes was broken around listing workspaces in workspace_key_prefix. While it worked in most places by splitting an extra time around the spurious slashes, it failed in the case that the prefix ended with a slash of its own. A test was temporarily added to verify that the backend works with the unusual keys, but rather than risking silent breakage around prefixes with trailing slashes, we also add validation to prevent users from entering keys with trailing slashes at all.	7 years ago
James Bardin	f6af61f990	fix test that never worked ... The 0.12 update left this test broken. Make sure we're working with the correct objects here.	7 years ago
James Bardin	6cc3e1d0bd	move init error to where it is generated ... The init error was output deep in the backend by detecting a special ResourceProviderError and formatted directly to the CLI. Create some Diagnostics closer to where the problem is detected, and passed that back through the normal diagnostic flow. While the output isn't as nice yet, this restores the helpful error message and makes the code easier to maintain. Better formatting can be handled later.	7 years ago
Brian Flad	185a3304e5	Merge pull request #20374 from hashicorp/td-backend-s3-dependencies ... backend/s3: Switch from github.com/terraform-providers/terraform-provider-aws to github.com/hashicorp/aws-sdk-go-base	7 years ago
Brian Flad	a41e545198	backend/s3: Reinstate region validation and update copy for skip_requesting_account_id deprecation message	7 years ago
Sander van Harmelen	43eb7c08e0	Merge pull request #20379 from hashicorp/svh/f-state-service ... backend/remote: use `state.v2` for remote state only	7 years ago
Brian Flad	43f12bbfe0	backend/s3: Update copy for skip_get_ec2_platforms and skip_requesting_account_id argument deprecations	7 years ago
Sander van Harmelen	54736b068b	backend/remote: use `state.v2` for remote state only ... The API surface area is much smaller when we use the remote backend for remote state only. So in order to try and prevent any backwards incompatibilities when TF runs inside of TFE, we’ve split up the discovery services into `state.v2` (which can be used for remote state only configurations, so when running in TFE) and `tfe.v2.1` (which can be used for all remote configurations).	7 years ago
Brian Flad	1aaac172b0	backend/s3: Switch from github.com/terraform-providers/terraform-provider-aws to github.com/hashicorp/aws-sdk-go-base ... Output from acceptance testing (no new failures): ``` --- PASS: TestBackend_impl (0.00s) --- PASS: TestBackendConfig (0.37s) --- PASS: TestBackendConfig_invalidKey (0.00s) --- PASS: TestBackend (3.26s) --- PASS: TestBackendLocked (6.80s) --- FAIL: TestBackendExtraPaths (2.32s) --- PASS: TestBackendPrefixInWorkspace (2.06s) --- PASS: TestKeyEnv (8.20s) --- PASS: TestRemoteClient_impl (0.00s) --- PASS: TestRemoteClient (2.42s) --- PASS: TestRemoteClientLocks (6.33s) --- PASS: TestForceUnlock (13.31s) --- PASS: TestRemoteClient_clientMD5 (11.75s) --- PASS: TestRemoteClient_stateChecksum (10.07s) ```	7 years ago
Yann DEGAT	e70b8928e9	remote/backend/swift: Add support for workspaces & locking	7 years ago
Martin Atkins	6eb7bfbdfb	Merge #20265: Don't presume unknown for values unset in config ... This changes the contract for `PlanResourceChange` so that the provider is now responsible for populating all default values during plan, including inserting any unknown values for defaults it will fill in at apply time.	7 years ago
Martin Atkins	e3618f915b	backend/local: Fix mock provider in tests ... We've changed the contract for PlanResourceChange to now require the provider to populate any default values (including unknowns) it wants to set for computed arguments, so our mock provider here now needs to be a little more complex to deal with that. This fixes several of the tests in this package. A minor change to TestLocal_applyEmptyDirDestroy was required to make it properly configure the mock provider so PlanResourceChange can access the schema.	7 years ago
Radek Simko	e6777105b7	Merge pull request #20275 from hashicorp/vendor-openstack-upgrade ... vendor: Bump openstack provider to v1.15.0	7 years ago
Sander van Harmelen	aefbec63b1	backend/remote: update the test logic	7 years ago
Sander van Harmelen	3b80f69eec	Merge pull request #20242 from hashicorp/svh/b-scanner-buffer-v0.12 ... backend/remote: fix bufio.Scanner: token too long	7 years ago
Radek Simko	a7f0722729	backend/swift: Fix interface after upgrade	7 years ago
Sander van Harmelen	47a00ea34b	backend/remote: cleanup test connections ... Cleanup test connection to prevent file descriptor issues when running the tests on a Mac.	7 years ago
Sander van Harmelen	5249d0fe83	backend/remote: fix bufio.Scanner: token too long	7 years ago
Radek Simko	6365fffe4f	Fix interface after upgrade	7 years ago
Sander van Harmelen	6dd9f22780	Merge pull request #20086 from hashicorp/svh/f-service-constraints ... backend/remote: make sure we show the correct error	7 years ago
Sander van Harmelen	1e4c20686e	backend/remote: make sure we show the correct error ... Previously we would show two errors when there was a version constraint error. But of course one is enough.	7 years ago
Martin Atkins	10bf4c763b	backend: Undeclared variables in -var-file is a warning, not an error ... In Terraform 0.11 and earlier we just silently ignored undeclared variables in -var-file and the automatically-loaded .tfvars files. This was a bad user experience for anyone who made a typo in a variable name and got no feedback about it, so we made this an error for 0.12. However, several users are now relying on the silent-ignore behavior for automation scenarios where they pass the same .tfvars file to all configurations in their organization and expect Terraform to ignore any settings that are not relevant to a specific configuration. We never intentionally supported that, but we don't want to immediately break that workflow during 0.12 upgrade. As a compromise, then, we'll make this a warning for v0.12.0 that contains a deprecation notice suggesting to move to using environment variables for this "cross-configuration variables" use-case. We don't produce errors for undeclared variables in environment variables, even though that potentially causes the same UX annoyance as ignoring them in vars files, because environment variables are assumed to live in the user's session and this it would be very inconvenient to have to unset such variables when moving between directories. Their "ambientness" makes them a better fit for these automatically-assigned general variable values that may or may not be used by a particular configuration. This can revert to being an error in a future major release, after users have had the opportunity to migrate their automation solutions over to use environment variables. We don't seem to have any tests covering this specific situation right now. That isn't ideal, but this change is so straightforward that it would be relatively expensive to build new targeted test cases for it and so I instead just hand-tested that it is indeed now producing a warning where we were previously producing an error. Hopefully if there is any more substantial work done on this codepath in future that will be our prompt to add some unit tests for this.	7 years ago
Sander van Harmelen	8937fedb76	backend/remote: fix a small typo	7 years ago
Sander van Harmelen	e08a7e979e	backend/remote: use the correct test operation	7 years ago
Martin Atkins	0c0a437bcb	Move module install functionality over to internal/initwd	7 years ago
Brian Flad	ed37d07632	backend/s3: Configure AWS Client MaxRetries and provide enhanced S3 NoSuchBucket error message ... The AWS Go SDK automatically provides a default request retryer with exponential backoff that is invoked via setting `MaxRetries` or leaving it `nil` will default to 3. The terraform-aws-provider `config.Client()` sets `MaxRetries` to 0 unless explicitly configured above 0. Previously, we were not overriding this behavior by setting the configuration and therefore not invoking the default request retryer. The default retryer already handles HTTP error codes above 500, including S3's InternalError response, so the extraneous handling can be removed. This will also start automatically retrying many additional cases, such as temporary networking issues or other retryable AWS service responses. Changes: * s3/backend: Add `max_retries` argument * s3/backend: Enhance S3 NoSuchBucket error to include additional information	7 years ago
Sander van Harmelen	bba03384d5	backend/remote: log early to indicate execution started	7 years ago
Sander van Harmelen	7b51af72b2	backend/remote: compare versions without the prerelease	7 years ago
Sander van Harmelen	55b6153b04	backend/remote: fix an error that prevents checking constraints	7 years ago
Sander van Harmelen	2ef8315885	Merge pull request #19659 from hashicorp/svh/f-check-constraints ... backend/remote: return detailed incompatibility info	7 years ago
Sander van Harmelen	8f04e93739	backend/remote: return detailed incompatibility info	7 years ago
Radek Simko	f64978b64c	backend/local: Render CBD replacement (+/-) correctly (#19642) ... * backend/local: Render CBD replacement (+/-) correctly * command/format: Use IsReplace helper function	7 years ago
Sander van Harmelen	da8e02eb2e	Merge pull request #19647 from hashicorp/svh/f-versions ... core: add a method to the disco package retrieve version constraints	7 years ago
Sander van Harmelen	268c0f85ce	Add a method to retrieve version contraints	7 years ago
Radek Simko	3ab4739ba4	backend/local: Avoid rendering data sources on destroy	7 years ago
Radek Simko	e55079abc9	backend/local: Fix incorrect destroy/update count on apply	7 years ago
Brian Flad	058434d28b	Merge pull request #19571 from hashicorp/f-backend-s3-other-endpoints ... backend/s3: Support DynamoDB, IAM, and STS endpoint configurations	7 years ago
Tom Harvey	383bc98f5c	backend/azurerm: Support for authenticating using the Azure CLI (#19465) ... * Upgrading to 2.0.0 of github.com/hashicorp/go-azure-helpers * Support for authenticating using Azure CLI * backend/azurerm: support for authenticating using the Azure CLI	7 years ago
Sander van Harmelen	a5a2156584	core: enhance service discovery ... This PR improves the error handling so we can provide better feedback about any service discovery errors that occured. Additionally it adds logic to test for specific versions when discovering a service using `service.vN`. This will enable more informational errors which can indicate any version incompatibilities.	7 years ago
Brian Flad	9a3b02cd6c	backend/s3: Support DynamoDB, IAM, and STS endpoint configurations ... This change enables a few related use cases: * AWS has partitions outside Commercial, GovCloud (US), and China, which are the only endpoints automatically handled by the AWS Go SDK. DynamoDB locking and credential verification can not currently be enabled in those regions. * Allows usage of any DynamoDB-compatible API for state locking * Allows usage of any IAM/STS-compatible API for credential verification	7 years ago
Sander van Harmelen	9062d887b8	backend/remote: use entitlements to select backends ... Use the entitlements to a) determine if the organization exists, and b) as a means to select which backend to use (the local backend with remote state, or the remote backend).	7 years ago
Kristin Laemmert	67aa944166	backend/local: decode variables with cty.DynamicPseudoType ... Variables values are marshalled with an explicit type of cty.DynamicPseudoType, but were being decoded using `Implied Type` to try and guess the type. This was causing errors because `Implied Type` does not expect to find a late-bound value.	7 years ago
Martin Atkins	12572e97bc	core: Automatically upgrade resource instance states on read ... If an instance object in state has an earlier schema version number then it is likely that the schema we're holding won't be able to decode the raw data that is stored. Instead, we must ask the provider to upgrade it for us first, which might also include translating it from flatmap form if it was last updated with a Terraform version earlier than v0.12. This ends up being a "seam" between our use of int64 for schema versions in the providers package and uint64 everywhere else. We intend to standardize on int64 everywhere eventually, but for now this remains consistent with existing usage in each layer to keep the type conversion noise contained here and avoid mass-updates to other Terraform components at this time. This also includes a minor change to the test helpers for the backend/local package, which were inexplicably setting a SchemaVersion of 1 on the basic test state but setting the mock schema version to zero, creating an invalid situation where the state would need to be downgraded.	7 years ago
Sander van Harmelen	fe05609c5e	backend/remote: support the new force-unlock API ... Add support for the new `force-unlock` API and at the same time improve performance a bit by reducing the amount of API calls made when using the remote backend for state storage only.	7 years ago
Sander van Harmelen	4c878db8fd	Merge pull request #19464 from hashicorp/svh/f-context ... backend/remote: implement the Local interface	8 years ago
Sander van Harmelen	a061725132	Merge pull request #19403 from hashicorp/svh/f-policies ... backend/remote: also show policies when there are no changes	8 years ago
Martin Atkins	168d84b3c4	core: Make resource type schema versions visible to callers ... Previously we were fetching these from the provider but then immediately discarding the version numbers because the schema API had nowhere to put them. To avoid a late-breaking change to the internal structure of terraform.ProviderSchema (which is constructed directly all over the tests) we're retaining the resource type schemas in a new map alongside the existing one with the same keys, rather than just switching to using the providers.Schema struct directly there. The methods that return resource type schemas now return two arguments, intentionally creating a little API friction here so each new caller can be reminded to think about whether they need to do something with the schema version, though it can be ignored by many callers. Since this was a breaking change to the Schemas API anyway, this also fixes another API wart where there was a separate method for fetching managed vs. data resource types and thus every caller ended up having a switch statement on "mode". Now we just accept mode as an argument and do the switch statement within the single SchemaForResourceType method.	8 years ago