47 Commits (6440c839474f052d8997bb5cec19c2743e5108e6)

Author	SHA1	Message	Date
Kristin Laemmert	6621501ae3	state: remove deprecated state package (#25490) ... Most of the state package has been deprecated by the states package. This PR replaces all the references to the old state package that can be done simply - the low-hanging fruit. * states: move state.Locker to statemgr The state.Locker interface was a wrapper around a statemgr.Full, so moving this was relatively straightforward. * command: remove unnecessary use of state package for writing local terraform state files * move state.LocalState into terraform package state.LocalState is responsible for managing terraform.States, so it made sense (to me) to move it into the terraform package. * slight change of heart: move state.LocalState into clistate instead of terraform	6 years ago
Kristin Laemmert	86e9ba3d65	* backend/local: push responsibility for unlocking state into individual operations ... * unlock the state if Context() has an error, exactly as backend/remote does today * terraform console and terraform import will exit before unlocking state in case of error in Context() * responsibility for unlocking state in the local backend is pushed down the stack, out of backend.go and into each individual state operation * add tests confirming that state is not locked after apply and plan * backend/local: add checks that the state is unlocked after operations This adds tests to plan, apply and refresh which validate that the state is unlocked after all operations, regardless of exit status. I've also added specific tests that force Context() to fail during each operation to verify that locking behavior specifically.	6 years ago
James Bardin	35d232481f	prevent panic in remote backend retry ... Ensure that the *http.Response is not nil before checking the status.	6 years ago
Kristin Laemmert	e6cf6cd758	backend/remote: do not panic if PrepareConfig or Configure receive null (#25135) ... * backend/remote: do not panic if PrepareConfig or Configure receive null objects If a user cancels (ctrl-c) terraform init while it is requesting missing configuration options for the remote backend, the PrepareConfig and Configure functions would receive a null cty.Value which would result in panics. This PR adds a check for null objects to the two functions in question. Fixes #23992	6 years ago
Kritonas	71395a0656	Fixed minor grammatical errors	6 years ago
Alisdair McDiarmid	f15e58adf8	Improve remote backend missing token error ... Prompt the user to run terraform login to generate and store a token for the configured remote backend.	6 years ago
Radek Simko	32f9722d9d	Replace import paths & set UA string where necessary	7 years ago
Kristin Laemmert	412d459292	backend/remote: remove milseading contents from error message (#22148) ... Previously, terraform was returning a potentially-misleading error message in response to anything other than a 404 from the b.client.Workspaces.Read operation. This PR simplifies Terraform's error message with the intent of encouraging those who encounter it to focus on the error message returned from the tfe client. The added test is odd, and a bit hacky, and possibly overkill.	7 years ago
Sander van Harmelen	4628fbcc65	Merge pull request #20615 from hashicorp/svh/f-input-context ... core: add a context to the UIInput interface	7 years ago
Sander van Harmelen	973e2a7cf9	core: add a context to the UIInput interface	7 years ago
Sander van Harmelen	0232d84a0d	backend/remote: also retry on server errors ... Enably retrying on server errors in the updated `go-tfe` client and add a retry log hook for writing retry messages to the CLI.	7 years ago
Sander van Harmelen	63e2dcef8a	Merge pull request #20481 from hashicorp/svh/b-exit-code ... backend/remote: exit with 1 when a run is canceled	7 years ago
Sander van Harmelen	01f17fa0ca	backend/remote: exit with 1 when a run is canceled	7 years ago
James Bardin	c814f2da37	Change backend.ValidateConfig to PrepareConfig ... This mirrors the change made for providers, so that default values can be inserted into the config by the backend implementation. This is only the interface and method name changes, it does not yet add any default values.	7 years ago
Sander van Harmelen	54736b068b	backend/remote: use `state.v2` for remote state only ... The API surface area is much smaller when we use the remote backend for remote state only. So in order to try and prevent any backwards incompatibilities when TF runs inside of TFE, we’ve split up the discovery services into `state.v2` (which can be used for remote state only configurations, so when running in TFE) and `tfe.v2.1` (which can be used for all remote configurations).	7 years ago
Sander van Harmelen	47a00ea34b	backend/remote: cleanup test connections ... Cleanup test connection to prevent file descriptor issues when running the tests on a Mac.	7 years ago
Sander van Harmelen	1e4c20686e	backend/remote: make sure we show the correct error ... Previously we would show two errors when there was a version constraint error. But of course one is enough.	7 years ago
Sander van Harmelen	8937fedb76	backend/remote: fix a small typo	7 years ago
Sander van Harmelen	7b51af72b2	backend/remote: compare versions without the prerelease	7 years ago
Sander van Harmelen	55b6153b04	backend/remote: fix an error that prevents checking constraints	7 years ago
Sander van Harmelen	8f04e93739	backend/remote: return detailed incompatibility info	7 years ago
Sander van Harmelen	268c0f85ce	Add a method to retrieve version contraints	7 years ago
Sander van Harmelen	a5a2156584	core: enhance service discovery ... This PR improves the error handling so we can provide better feedback about any service discovery errors that occured. Additionally it adds logic to test for specific versions when discovering a service using `service.vN`. This will enable more informational errors which can indicate any version incompatibilities.	7 years ago
Sander van Harmelen	9062d887b8	backend/remote: use entitlements to select backends ... Use the entitlements to a) determine if the organization exists, and b) as a means to select which backend to use (the local backend with remote state, or the remote backend).	7 years ago
Sander van Harmelen	fe05609c5e	backend/remote: support the new force-unlock API ... Add support for the new `force-unlock` API and at the same time improve performance a bit by reducing the amount of API calls made when using the remote backend for state storage only.	7 years ago
Sander van Harmelen	35d9ce3f92	backend/remote: implement the Local interface	8 years ago
Sander van Harmelen	a17f317025	Change how to fall back from remote to local backend ... In order to support free organizations, we need a way to load the `remote` backend and then, depending on the used offering/plan, enable or disable remote operations. In other words, we should be able to dynamically fall back to the `local` backend if needed, after first configuring the `remote` backend. To make this works we need to change the way this was done previously when the env var `TF_FORCE_LOCAL_BACKEND` was set. The clear difference of course being that the env var would be available on startup, while the used offering/plan is only known after being able to connect to TFE.	8 years ago
Sander van Harmelen	52a1b22f7a	Implement the remote enhanced backend ... This is a refactored version of the `remote` backend that was initially added to Terraform v0.11.8 which should now be compatible with v0.12.0.	8 years ago
Martin Atkins	541952bb8f	Revert some work that happened since v0.12-dev branched ... This work was done against APIs that were already changed in the branch before work began, and so it doesn't apply to the v0.12 development work. To allow v0.12 to merge down to master, we'll revert this work out for now and then re-introduce equivalent functionality in later commits that works against the new APIs.	8 years ago
Sander van Harmelen	8875fa660f	Make sure we also output policies while planning	8 years ago
Sander van Harmelen	775f8a9626	Make sure we always set a custom header ... This is for TFE to recognize were the calls come from.	8 years ago
Sander van Harmelen	b1fdbd7db8	Allow enhanced backends to pass custom exit codes ... In some cases this is needed to keep the UX clean and to make sure any remote exit codes are passed through to the local process. The most obvious example for this is when using the "remote" backend. This backend runs Terraform remotely and stream the output back to the local terminal. When an error occurs during the remote execution, all the needed error information will already be in the streamed output. So if we then return an error ourselves, users will get the same errors twice. By allowing the backend to specify the correct exit code, the UX remains the same while preserving the correct exit codes.	8 years ago
Sander van Harmelen	67db9da000	Add checks for all flags we currently don’t support ... For Plan only: -module-depth=n For Plan & Apply -parallelism=m -refresh=false -var “foo=bar” and -var-file=foo	8 years ago
Sander van Harmelen	a2241e7c43	backend/remote: introduce support for `-no-color` ... This is a bit of a hack to support the `-no-color` flag while we don’t have an option to set run variables. That is also the reason why the orginal method is commented out instead of deleted. This will be reverted when the TFE starts supporting run variables.	8 years ago
Sander van Harmelen	3979aec0ae	Ask to cancel a pending remote operation ... Except when a lock-timeout has exceeded or auto-approve is set.	8 years ago
Sander van Harmelen	b28f47055d	backend/remote: extend mocks and add sentinel tests	8 years ago
Sander van Harmelen	2bd1040bbd	backend/remote: extend mocks and add apply tests	8 years ago
Sander van Harmelen	9f9bbcb0e7	backend/remote: lots of improvements ... This commit adds: - support for `-lock-timeout` - custom error message when a 404 is received - canceling a pending run when TF is Ctrl-C’ed - discard a run when the apply is not approved	8 years ago
Sander van Harmelen	621d589189	backend/remote: add support for the apply operation	8 years ago
Sander van Harmelen	4aeb67b8ff	backend/remote: handle empty results correctly ... The pagination info of a list call that returns an empty list contains: ```go CurrentPage: 1 TotalPages: 0 ``` So checking if we have seen all pages using `CurrentPage == TotalPages` will not work and will result in an endless loop. The tests are updated so they will fail (timeout after 1m) if this is handled incorreclty.	8 years ago
Sander van Harmelen	7c1da2ffaa	Merge pull request #18818 from hashicorp/b-associate-state ... backend/remote: add the run ID to associate state	8 years ago
Sander van Harmelen	cd6d75bc03	backend/remote: add the run ID to associate state ... If a run ID is available, we need to make sure we pass that when creating a new state version so the state will be properly associated with the run.	8 years ago
Sander van Harmelen	3cc58813f0	backend/remote: use a search query and use pagination ... To prevent making unnecessary heavy calls to the backend, we should use a search query to limit the result. But even if we use a search query, we should still use the pagination details to make sure we retrieved all items.	8 years ago
Sander van Harmelen	62ab84a319	backend/remote: compat changes for latest `go-tfe`	8 years ago
Sander van Harmelen	7049d973a9	Do not use the TFE_TOKEN env variable ... Instead promote the use of shared credentials using the CLI Config File	8 years ago
Sander van Harmelen	83d5f4147b	backend/remote: use schema max/min items options	8 years ago
Sander van Harmelen	7fb2d1b8de	Implement the Enterprise enhanced remote backend	8 years ago