903 Commits (643fccc92377f85d688502ae0c19df7d3100d47c)

Author	SHA1	Message	Date
James Bardin	ae1f93a24f	Merge pull request #19236 from hashicorp/jbardin/resource-tests ... skip resource tests for now	8 years ago
James Bardin	a5ef403dfd	skip resource tests for now ... These aren't going to be fixed in the immediate future, and are preventing the CI tests from being helpful.	8 years ago
James Bardin	718a3c400a	fix state variable name	8 years ago
James Bardin	e0ea2a5d06	if there is no plan diff, prefer the prior state ... The prior state may contain customizations made by the provider. If there is no prior state, then take the proposed state.	8 years ago
James Bardin	f153720a36	add checks for timeouts attributes and blocks ... Don't overwrite anything the provider defined, in order to maintain existing behavior. Change strings to pre-defined constants	8 years ago
James Bardin	e38a5a769d	copy timouts into plan and apply state ... helper/schema will remove "timeouts" from the config, and stash them in the diff.Meta map. Terraform sees "timeouts" as a regular config block, so needs them to be present in the state in order to not show a diff. Have the GRPCProviderServer shim copy all timeout values into any state it returns to provide consistent diffs in core.	8 years ago
James Bardin	6dad121e70	insert resource timeouts into the config schema ... Resource timeouts were a separate config block, but did not exist in the resource schema. Insert any defined timeouts when generating the configshema.Block so that the fields can be accepted and validated by core.	8 years ago
James Bardin	dbaf347392	Merge pull request #19136 from hashicorp/jbardin/simple-diff ... panic fixes	8 years ago
Brian Flad	62bf23850b	Merge pull request #19122 from hashicorp/f-helper-validation-Any ... helper/validation: Add Any() SchemaValidateFunc	8 years ago
James Bardin	d50a152f8b	check for a nil diff in simpleDiff	8 years ago
Brian Flad	46804080aa	helper/validation: Add Any() SchemaValidateFunc ... `Any()` allows any single passing validation of multiple `SchemaValidateFunc` to pass validation to cover cases where a standard validation function does not cover the functionality or to make error messaging simpler. Example provider usage: ```go ValidateFunc: validation.Any( validation.IntAtLeast(42), validation.IntAtMost(5), ), ```	8 years ago
James Bardin	ff4e81cc2b	add old values when computing the new InstanceDiff ... This was previously done in the RequiresNew code, which is skipped in new style provider.	8 years ago
James Bardin	a8f75bc554	don't set defaults for deprecated or removed ... These may still have defaults set, even if they are not intended to be used.	8 years ago
James Bardin	e077c9ce95	Insert default values into provider config ... Add any top-level default attributes from the provider schema into Null config values.	8 years ago
James Bardin	a3ac49b3fb	GRPCProviderServer and PrepareProviderconfig ... Update the server side of the plugin to match the new method signature.	8 years ago
Sander van Harmelen	48ef7ecfa6	Updates after running `make fmt` with Go v1.11.1	8 years ago
Brian Flad	17ac9a5756	helper/validation: Add All() and IntInSlice() SchemaValidateFunc ... `All()` combines the outputs of multiple `SchemaValidateFunc`, to reduce the usage of custom validation functions that implement standard validation functions. Example provider usage: ```go ValidateFunc: validation.All( StringLenBetween(5, 42), StringMatch(regexp.MustCompile(`[a-zA-Z0-9]+`), "value must be alphanumeric"), ), ``` `IntInSlice()` is the `int` equivalent of `StringInSlice()` Example provider usage: ```go ValidateFunc: validation.IntInSlice([]int{30, 60, 120}) ``` Output from unit testing: ``` $ make test TEST=./helper/validation ==> Checking that code complies with gofmt requirements... go generate ./... 2018/10/17 14:16:03 Generated command/internal_plugin_list.go go list ./helper/validation | xargs -t -n4 go test -timeout=2m -parallel=4 go test -timeout=2m -parallel=4 github.com/hashicorp/terraform/helper/validation ok github.com/hashicorp/terraform/helper/validation 1.106s ```	8 years ago
James Bardin	1ab96f42b7	fail nonfunctional resource tests ... The helper/resource unit tests will panic, because they were using the legacy terraform.MockResourceProvider, which doesn't have the same internals required by the new GRPC shims. Fail these tests for now, and a new test provider will need to be made out of a schema.Provider instance.	8 years ago
James Bardin	38163f2b37	use SimpleDiff and set "id" as RequiresReplace ... Use the new SimpleDiff method of the provider so that the diff isn't altered by ForceNew attributes. Always set an "id" as RequiresReplace so core knows an instance will be replaced, even if all ForceNew attributes are filtered out due to ignore_changes.	8 years ago
James Bardin	46b4c27dbe	create a SimpleDiff for the new provider shims ... Terraform now handles any actual "diffing" of resource, and the existing Diff functions are only used to shim the schema.Provider to the new methods. Since terraform is handling what used to be the Diff, the provider now should not modify the diff based on RequiresNew due to it interfering with the ignore_changes handling.	8 years ago
James Bardin	0d4d572c39	start work on helper/resource test fixtures ... The helper resource tests won't pass for now, as they use a terraform.MockProvider which can't be used in the schema.Provider shims.	8 years ago
James Bardin	f8b1a3c7a4	make sure apply can properly destroy ... We need to ensure that a destroyed value is returned as such from apply	8 years ago
James Bardin	52c0032aed	update provisioners for multiple processes ... The "internal" provisioners are still run in a separate process, and need to be updated to restart on each walk.	8 years ago
James Bardin	caf74a218d	initialize empty diff in apply ... While the schema Diff fucntion returns a nil diff when creating an empty (except for id) resource, the Apply function expects the diff to be initialized and ampty.	8 years ago
James Bardin	0b8c38207a	a plan with no diff should return proposed state ... PlanResourceChange isn't returning the diff, but rather it is returning the destired state. If the propsed state results in a nil diff, then, the propsed state is what should be returned. Make sure Meta fields are not nil, as the schema package expects those to be initialised.	8 years ago
Radek Simko	d93b462e9c	helper/plugin: don't panic in ReadDataSource State	8 years ago
Martin Atkins	1908aff476	helper/resource: Fix duplicated function testConfig ... An earlier change introduced a new function testConfig to the main code for this package, which conflicted with a function of the same name in the test code. Here we rename the function from the test code, allowing for the more generally-named testConfig to be the one in the main code.	8 years ago
Radek Simko	2de0903538	Fix data source bug	8 years ago
Martin Atkins	33151f5011	core: Move StateValueFromInstanceState shim from helper/schema ... This one doesn't depend on any helper/schema specific bits and it'll also be useful for the shims in our mock provider in core.	8 years ago
Martin Atkins	76d11f44cc	core: Move some of the helper/schema shims so provider mock can use them ... The old names are now wrappers around these new functions.	8 years ago
James Bardin	a87470cc15	resource ids must always have a value ... The "id" field is assumed to always exist, and must have a valid value. Set "id" to unknown when planning new resource changes to indicate that it will be computed.	8 years ago
Martin Atkins	97da905c6e	helper/plugin: ReadResource to deal with missing remote object	8 years ago
Martin Atkins	a7342de274	core: Properly handle no-op changes in plan ... Previously we just left these out of the plan altogether, but in the new plan types we intentionally include change information for every resource instance, even if no changes are actually planned, to allow alternative plan file viewers to show what isn't changing as well as what is.	8 years ago
Martin Atkins	c27f900d92	helper/plugin: Don't panic while preparing response in ApplyResourceChange	8 years ago
Martin Atkins	686018ae12	helper/plugin: don't panic in PlanResourceChange PlannedState	8 years ago
Martin Atkins	44bc7519a6	terraform: More wiring in of new provider types ... This doesn't actually work yet, but it builds and then panics in a pretty satisfying way.	8 years ago
James Bardin	c07ce1cd4b	move conversion functions into separate package ... Managing which function need to be shared between the terraform plugin and the helper plugin without creating cycles was becoming difficult. Move all functions related to converting between terraform and proto type into plugin/convert.	8 years ago
Martin Atkins	a3403f2766	terraform: Ugly huge change to weave in new State and Plan types ... Due to how often the state and plan types are referenced throughout Terraform, there isn't a great way to switch them out gradually. As a consequence, this huge commit gets us from the old world to a _compilable_ new world, but still has a large number of known test failures due to key functionality being stubbed out. The stubs here are for anything that interacts with providers, since we now need to do the follow-up work to similarly replace the old terraform.ResourceProvider interface with its replacement in the new "providers" package. That work, along with work to fix the remaining failing tests, will follow in subsequent commits. The aim here was to replace all references to terraform.State and its downstream types with states.State, terraform.Plan with plans.Plan, state.State with statemgr.State, and switch to the new implementations of the state and plan file formats. However, due to the number of times those types are used, this also ended up affecting numerous other parts of core such as terraform.Hook, the backend.Backend interface, and most of the CLI commands. Just as with 5861dbf3fc before, I apologize in advance to the person who inevitably just found this huge commit while spelunking through the commit history.	8 years ago
James Bardin	7188d5cbfe	add grpc shims to helper/plugin ... Add shim functions to automatically wrap plugins in the new GRPC implementations.	8 years ago
James Bardin	63dcdbe948	helper/plugin package for grpc servers ... The new helper/plugin package contains the grpc servers for handling the new plugin protocol The GRPCProviderServer and GRPCProvisionerServer handle the grpc plugin protocol, and convert the requests to the legacy schema.Provider and schema.Provisioner methods.	8 years ago
James Bardin	b88410984b	legacy provider needs to handle StateUpgraders ... In order to not require state migrations to be supported in both MigrateState and StateUpgraders, the legacy provider codepath needs to handle the StateUpgraders transparently during Refresh.	8 years ago
James Bardin	dcaf5aa262	add some of the shims used for the grpc provider ... This adds some of the required shim functions to the schema package. While this further bloats the already huge package, adding the helpers here was significantly less disruptive than refactoring types into separate packages to prevent import cycles. The majority of tests here are directly adapted from existing schema tests to provide as many known good values to the shims as possible.	8 years ago
James Bardin	7d24936507	updates to teh StateUpgraders ... Fix documentation. Require StateUpgraders to be add in order, and test in validation.	8 years ago
James Bardin	0c33b26e04	StateUpgrade redux ... It turns out that state upgrades need to be handled differently since providers are going to be backwards compatible. This means that new state upgrades may still be stored in the flatmap format when used wih terraform 0.11. Because we can't account for the specific version which could produce a legacy state, all future state upgrades need to record the schema types for decoding. Rather than defining a single Upgrade function for states, we now have a list of functions, each of which handle upgrading a specific version to the next. In practice this isn't much different from the way many resources implement upgrades themselves, with a separate function for each version dispatched from the MigrateState function. The only added burden is the recording of the schema type, and we intend to supply tools and helper function to prevent the need to copy the entire existing schema in all cases.	8 years ago
James Bardin	9eef5e3f91	implement UpgradeState for schema.Resource ... This is the provider-side UpgradeState implementation for a particular resource. This new function will be called to upgrade a saved state with an old schema version to the current schema. UpgradeState also requires a record of the last schema and version that could have been stored as a flatmapped state. If the stored state is in the legacy flatmap format, this will allow the provider to properly decode the flatmapped state into the expected structure for the new json encoded state. If the stored state's version is below that of the LegacySchema.Version value, it will first be processed by the legacy MigrateState function.	8 years ago
James Bardin	bcc8be7400	add schema.InternalMap ... This exposes the internal schemaMap for use by the new provider shims.	8 years ago
James Bardin	0120d53baf	only add "id" to top-level resources ... Make sure we only add "id" to the top-level resource, since Resource is also used for nested blocks.	8 years ago
James Bardin	15ccf2dda5	use a custom comparer for cty.Type ... Make sure we also compare cty.Types in `cmp.Equal`, even though they contain unexported fields.	8 years ago
James Bardin	3112b707be	SetId should set the attribute as well ... The update protocol shims will also check for this this, but eventually "id" will only be a normal attribute, and we shouldn't have to special case this.	8 years ago
James Bardin	befa81c74f	add implicit "id" to resource attribute schemas ... When converting a legacy schemaMap to a configschema, we need to add "id" as a required attribute to top-level resources if it's not declared. The "id" field will be required to interoperate with the legacy helper schema, since the presence of an id was used to indicate the existence of a resource.	8 years ago