374 Commits (643fccc92377f85d688502ae0c19df7d3100d47c)

Author	SHA1	Message	Date
Sander van Harmelen	b846c5f653	Make the test compile again ... Not sure if these checks still make sense, but without this change the test don’t compile for the related packages.	8 years ago
Sander van Harmelen	48ef7ecfa6	Updates after running `make fmt` with Go v1.11.1	8 years ago
James Bardin	0a0eece15c	add backend cli options after configuration ... The cli should override the config	8 years ago
Martin Atkins	541952bb8f	Revert some work that happened since v0.12-dev branched ... This work was done against APIs that were already changed in the branch before work began, and so it doesn't apply to the v0.12 development work. To allow v0.12 to merge down to master, we'll revert this work out for now and then re-introduce equivalent functionality in later commits that works against the new APIs.	8 years ago
Martin Atkins	98bbd560b5	command: Fix most (but not all) "terraform plan" tests	8 years ago
Martin Atkins	741d334ee4	command: Even more fixes for "apply" command tests	8 years ago
Martin Atkins	c5940f2438	backend/local: Increase log verbosity for backend context construction ... There are several steps here and a number of them can include reaching out to remote servers or executing local processes, so it's helpful to have some trace logs to better narrow down causes of errors and hangs during this step.	8 years ago
Martin Atkins	a6f399517b	backend/local: reinstate additional steps in plan file processing ... In earlier refactoring we skipped implementing prior state safety checks, propagating the target addresses from plan, and verifying that all of the providers are exactly the same from the plan being created. This change reinstates those checks, including a new error message for the "stale plan" situation.	8 years ago
Martin Atkins	91d2de6a25	backend/local: Stub out remaining planfile todos with errors ... This is just to make sure they show up later when we are working on the tests, so we can be sure not to forget to address them.	8 years ago
Martin Atkins	fa3b4fc9de	backend/local: Populate changes into a context built from planfile	8 years ago
Martin Atkins	cbc548eb36	command: Do CLI init of backend loaded from plan ... If we don't do this, we can't produce any output when applying a saved plan file. Here we also introduce a check to the local backend's ReportResult function so that it won't panic if CLI init is skipped, although that will no longer happen in the apply-from-file case due to the change described in the previous paragraph.	8 years ago
Martin Atkins	2b80df0163	backend/local: Require caller to set PlanOutBackend with PlanOutPath ... We can't generate a valid plan file without a backend configuration to write into it, but it's the responsibility of the caller (the command package) to manage the backend configuration mechanism, so we require it to tell us what to write here. This feels a little strange because the backend in principle knows its own config, but in practice the backend only knows the _processed_ version of the config, not the raw configuration value that was used to configure it.	8 years ago
Kristin Laemmert	2d3cb87789	backend/local tests tests tests ... converted the existing testPlanState() from terraform.State to states.State to fix various plan tests. reverted the "bandaid" in plans/planfile/tfplan.go - at this moment the backend tests do not include backend configuration, and so the planfile package can write the plan file but not read it back in. That will be revisted in a separate track of work.	8 years ago
Kristin Laemmert	6a37ee9277	backend/local: more tests passing ... I have no confidence in the change to plans/planfile/tfplan.go. The tests were passing an empty backend config, which planfile was able to write to a file but not read from the same file. This change let me move past that and it did not break any tests in the planfile package, but I am concerned that it introduces undesired behavior.	8 years ago
Kristin Laemmert	56b879d0c0	backend/local: updated DiffFn adn ReadResourceFn for new models	8 years ago
Kristin Laemmert	64f696d9b3	backend/local refresh tests refactor	8 years ago
Kristin Laemmert	e84def1e29	backend/local: test fixes ... for TestLocal_applyBackendFail, config is relative to the tests' wd	8 years ago
Kristin Laemmert	d865df7338	revert to explicitly declare schema for TestLocal_applyEmptyDirDestroy	8 years ago
Kristin Laemmert	739bd5ef0d	backend/local tests	8 years ago
Martin Atkins	1c007473ba	backend: TestBackendConfig to allow nil config body ... This is not normally considered valid, but since this is a test helper we will allow it and just treat it as an empty body.	8 years ago
Martin Atkins	8565c7460e	backend/remote-state/inmem: remove FIXME guards on tests that no longer hang	8 years ago
Martin Atkins	20727945ee	backend/remote-state/inmem: enable optional logging in tests	8 years ago
Martin Atkins	aaf405b662	backend/remote-state: Get all the backend tests building again ... The state manager refactoring in an earlier commit was reflected in the implementations of these backends, but not in their tests. This gets us back to a state where the backend tests will compile, and gets _most_ of them passing again, with a few exceptions that will be addressed in a subsequent commit.	8 years ago
Martin Atkins	b0016e9cf6	command: Allow tests to run to completion without panics or hangs ... There are still 160 test failures as of this commit, but at least the test program can run to completion and list out all the failures.	8 years ago
Kristin Laemmert	3da04ef9fc	backend/local: adding some informative comments to commented-out tests	8 years ago
Kristin Laemmert	c661157999	plans/objchange: further harden ProposedNewObject against ~weird~ ... incoming values Addresses an odd state where the priorV of an object to be changed is known but null. While this situation should not happen, it seemed prudent to ensure that core is resilient to providers sending incorrect values (which might also occur with manually edited state).	8 years ago
Kristin Laemmert	2808df48ec	backend/local WIP commit - fixing tests	8 years ago
Kristin Laemmert	fbe959ae6e	backend/local: fix panic in tests ... update the function names in testDelegateBackend to match what was being called in TestLocal_multiStateBackend (matching the test behavior in master)	8 years ago
Martin Atkins	a43b7df282	core: Handle forced-create_before_destroy during the plan walk ... Previously we used a single plan action "Replace" to represent both the destroy-before-create and the create-before-destroy variants of replacing. However, this forces the apply graph builder to jump through a lot of hoops to figure out which nodes need it forced on and rebuild parts of the graph to represent that. If we instead decide between these two cases at plan time, the actual determination of it is more straightforward because each resource is represented by only one node in the plan graph, and then we can ensure we put the right nodes in the graph during DiffTransformer and thus avoid the logic for dealing with deposed instances being spread across various different transformers and node types. As a nice side-effect, this also allows us to show the difference between destroy-then-create and create-then-destroy in the rendered diff in the CLI, although this change doesn't fully implement that yet.	8 years ago
Martin Atkins	5390fb1eed	backend/local: Don't count outputs for choosing diff action symbols ... We're not yet showing outputs in the rendered diff, so it doesn't make sense to count them for the purpose of deciding which change action symbols to include in the legend.	8 years ago
Martin Atkins	20318ca193	backend/local: Sort planned resource changes before rendering them ... As in the old plan renderer, they are ordered by the natural ordering of the resource addresses.	8 years ago
Martin Atkins	239a54ad6f	command: initial structural diff rendering ... This is a light adaptation of our earlier prototype of structural diff rendering, as a starting point for what we'll actually ship. This is not consistent with the latest mocks, so will need some additional work before it is ready, but integrating this allows us to at least see the plan contents while fixing up remaining issues elsewhere.	8 years ago
Martin Atkins	a6b5980a4f	backend/local: Bail immediately if terraform.Context can't be created	8 years ago
Martin Atkins	44bc7519a6	terraform: More wiring in of new provider types ... This doesn't actually work yet, but it builds and then panics in a pretty satisfying way.	8 years ago
Martin Atkins	a3403f2766	terraform: Ugly huge change to weave in new State and Plan types ... Due to how often the state and plan types are referenced throughout Terraform, there isn't a great way to switch them out gradually. As a consequence, this huge commit gets us from the old world to a _compilable_ new world, but still has a large number of known test failures due to key functionality being stubbed out. The stubs here are for anything that interacts with providers, since we now need to do the follow-up work to similarly replace the old terraform.ResourceProvider interface with its replacement in the new "providers" package. That work, along with work to fix the remaining failing tests, will follow in subsequent commits. The aim here was to replace all references to terraform.State and its downstream types with states.State, terraform.Plan with plans.Plan, state.State with statemgr.State, and switch to the new implementations of the state and plan file formats. However, due to the number of times those types are used, this also ended up affecting numerous other parts of core such as terraform.Hook, the backend.Backend interface, and most of the CLI commands. Just as with 5861dbf3fc before, I apologize in advance to the person who inevitably just found this huge commit while spelunking through the commit history.	8 years ago
Martin Atkins	479c6b2466	move "configschema" from "config" to "configs" ... The "config" package is no longer used and will be removed as part of the 0.12 release cleanup. Since configschema is part of the "new world" of configuration modelling, it makes more sense for it to live as a subdirectory of the newer "configs" package.	8 years ago
Martin Atkins	ebc6238bee	backend/local: Update tests for changes in "terraform" package ... This mainly consists of adding schema information to the mock providers.	8 years ago
Martin Atkins	c937c06a03	terraform: ugly huge change to weave in new HCL2-oriented types ... Due to how deeply the configuration types go into Terraform Core, there isn't a great way to switch out to HCL2 gradually. As a consequence, this huge commit gets us from the old state to a _compilable_ new state, but does not yet attempt to fix any tests and has a number of known missing parts and bugs. We will continue to iterate on this in forthcoming commits, heading back towards passing tests and making Terraform fully-functional again. The three main goals here are: - Use the configuration models from the "configs" package instead of the older models in the "config" package, which is now deprecated and preserved only to help us write our migration tool. - Do expression inspection and evaluation using the functionality of the new "lang" package, instead of the Interpolator type and related functionality in the main "terraform" package. - Represent addresses of various objects using types in the addrs package, rather than hand-constructed strings. This is not critical to support the above, but was a big help during the implementation of these other points since it made it much more explicit what kind of address is expected in each context. Since our new packages are built to accommodate some future planned features that are not yet implemented (e.g. the "for_each" argument on resources, "count"/"for_each" on modules), and since there's still a fair amount of functionality still using old-style APIs, there is a moderate amount of shimming here to connect new assumptions with old, hopefully in a way that makes it easier to find and eliminate these shims later. I apologize in advance to the person who inevitably just found this huge commit while spelunking through the commit history.	8 years ago
Martin Atkins	ebafa51723	command: Various updates for the new backend package API ... This is a rather-messy, complex change to get the "command" package building again against the new backend API that was updated for the new configuration loader. A lot of this is mechanical rewriting to the new API, but meta_config.go and meta_backend.go in particular saw some major changes to interface with the new loader APIs and to deal with the change in order of steps in the backend API.	8 years ago
Martin Atkins	5782357c28	backend: Update interface and implementations for new config loader ... The new config loader requires some steps to happen in a different order, particularly in regard to knowing the schema in order to decode the configuration. Here we lean directly on the configschema package, rather than on helper/schema.Backend as before, because it's generally sufficient for our needs here and this prepares us for the helper/schema package later moving out into its own repository to seed a "plugin SDK".	8 years ago
James Bardin	a79d620f03	remove legacy remote state code	8 years ago
James Bardin	979faa5dbe	move artifactory remote state to backend	8 years ago
James Bardin	18ef072325	move legacy http remote state to a backend	8 years ago
James Bardin	fe527ec9d7	move legacy etcd remote state to a backend	8 years ago
Martin Atkins	bd10b84a8e	command/format: include source snippets in diagnostics ... If we get a diagnostic message that references a source range, and if the source code for the referenced file is available, we'll show a snippet of the source code with the source range highlighted. At the moment we have no cache of source code, so in practice this codepath can never be visited. Callers to format.Diagnostic will be gradually updated in subsequent commits.	8 years ago
Sander van Harmelen	8875fa660f	Make sure we also output policies while planning	8 years ago
Sander van Harmelen	775f8a9626	Make sure we always set a custom header ... This is for TFE to recognize were the calls come from.	8 years ago
Sander van Harmelen	0a59e54933	Improve the output just a bit	8 years ago
Sander van Harmelen	c08cd597c5	Omit any empty lines containing STX/ETX markers	8 years ago
Sander van Harmelen	fb0af07696	Print status updates while waiting for the run to start	8 years ago