28 Commits (5d289cc1a259ee7ea8d2668a0bf89d58bffe02b3)

Author	SHA1	Message	Date
Sarah French	6554bda227	refactor: Update `workspace select` and `new` subcommands to use the arguments package for parsing arguments and flags (#38430) ... * refactor: Move method `ValidWorkspaceName` and related const into arguments package, update references This function is primarily used to validate arguments, but it's used once (in (m *Meta) Workspace) in a different context, so I've left the original function signature in the command package. * feat: Add `workspace new`-related code to arguments package * refactor: Update `workspace new` to use the arguments package when parsing arguments Note that this changes the format of errors returned when arg parsing fails - this is now wrapped in a diagnostic so now starts with `\nError: ` and has an extra trailing newline. * feat: Add `workspace select`-related code to arguments package * refactor: Update `workspace select` to use the arguments package when parsing arguments Note that this changes the format of errors returned when arg parsing fails - this is now wrapped in a diagnostic so now starts with `\nError: ` and has an extra trailing newline.	4 weeks ago
Sarah French	dd35f66105	fix: warnings against using `terraform env list` are shown in JSON format when the -json flag is present (#38469)	4 weeks ago
Sarah French	e24abdf6ff	refactor: Update `workspace select` and `delete` subcommands to use the arguments package for parsing arguments and flags (#38429) ... * feat: Add `workspace show`-related code to arguments package * refactor: Update `workspace show` to use the arguments package when parsing arguments * refactor: Split code for workspace subcommands into separate files in arguments package * refactor: Move code common to all workspace commands into separate file in arguments package * feat: Add `workspace delete`-related code to arguments package * refactor: Update `workspace delete` to use the arguments package when parsing arguments	1 month ago
Sarah French	650fd346aa	refactor: Separate concerns in mock provider sources logic, handle callbacks using `t.Cleanup` (#38446) ... * refactor: Split temp file creation logic out of FakeInstallablePackageMeta & FakePackageMetaViaHTTP. Handle cleanup internally. * refactor: Use 'Must' helpers in `newMockProviderSourceUsingTestHttpServer` * refactor: Update tests using `newMockProviderSource` to not handle 'close' callback	1 month ago
Sarah French	694ed4a33d	Add machine-readable JSON output to the `workspace list` command (#38397) ... * feat: Add `-json` flag to the `workspace list` command * feat: Implement JSON view for `workspace list`, connect to -json flag, add tests defining new command output * Add change file * Address reviewer feedback	1 month ago
Sarah French	c975e0cd78	Refactor `workspace list` human output to use a views-like architecture, so adding JSON output is possible without breaking changes (#38392) ... * test: Add a test that asserts human output from workspace commands with colour enabled or disabled * refactor: Update `workspace list` to use cli.Ui in a Views-like way for human output. Update how output is returned by the command to use a single List method. * refactor: Make `workspace list` command parse its arguments using the `arguments` package * refactor: Replace use of `ModulePath` with ` c.WorkingDir.RootModuleDir()` to separate concerns * test: Update tests that feature the `workspace list` command to include a WorkingDir value. This is necessary after the changes in b32b60f6a7854c8f891ef2d78fd02536093ad590 * feat: Detect unexpected arguments and flags using the arguments package. * refactor: Remove duplicate call to c.View.Configure, add code comments explaining code. * fix: Make sure argument parsing errors are handled as soon as the view is usable. * test: Update TestWorkspace_extraArgError to account for new validation via the arguments package * fix: Update outdated copyright headers * test: Update test name * refactor: Reintroduce the old behaviour when unexpected positional arguments were present by using a specific ParseWorkspaceList method	1 month ago
Sarah French	ae14dc3ea8	refactor: Stop workspace new, show, and select commands using `ModulePath` method to determine the working directory (#38358) ... * test: Add test defining how workspace subcommands react to unexpected arguments. * refactor: Update `workspace new` and `select` commands to access the config path using `c.WorkingDir.RootModuleDir()` * refactor: Update `workspace delete` command to access the config path using `c.WorkingDir.RootModuleDir()` This results in test failures because the delete command's implementation doesn't indirectly invoke the (Meta).fixupMissingWorkingDir method. Other workspace subcommands do invoke the fixup method via calling (Meta).Workspace, which causes (Meta).DataDir to be invoked, which invokes the fixup. * tests: Update all workspace tests to include a `WorkingDir` value in the `Meta`. Prior to this change some commands would fixup this missing data, and depending on whether the meta was reused or not that would impact testing other commands. Commands that tested only the delete command would fail due to a missing workspace due to this.	2 months ago
Sarah French	2dbb7d9c05	PSS: Remove automatic creation of the default workspace's state file during `init` (#38281) ... * refactor: Stop Terraform creating the default workspace during init when using PSS This is part of reconciling how in the past backends always reported that the default backend existed, even when it didn't. We want state stores to report reality only, so we need to let Terraform handle the discrepancy. Prior to this commit we handled it by making reality match the old lie that the default workspace always exists. After this commit we're just embracing Terraform working with truthful information.	2 months ago
Daniel Schmidt	93f4c1b9b4	remove copied default value	3 months ago
Radek Simko	0fe906fa8c	make copyrightfix	3 months ago
Sarah French	8e59c3296a	PSS: Address edge case in `workspace list` when no state files/workspace artefacts exist (#38094) ... * test: Add test demonstrating how the `workspace list` command behaves when no workspaces are reported from a pluggable state store. This scenario isn't possible when using backends. See the code comment for the test for more information. * feat: Make Terraform warn when no workspaces exist, including guidance to users for how to create the workspace. This change is not a breaking change because all backends report that the "default" workspace always exists. This new warning can only be viewed in specific circumstances by users of pluggable state storage.	4 months ago
Sarah French	ac3e32b62b	test: Add test asserting deprecation warnings are present when legacy `env` subcommands are used (#38091)	4 months ago
Sarah French	4420c4dcc0	PSS: Update the `workspace new` subcommand to work with PSS, add E2E and integration tests for using `workspace` commands with PSS. (#37855) ... * feat: Update the `workspace new` subcommand to work with PSS, add E2E testing * refactor: Replace instances of `ioutil` with `os` while looking at the workspace command * docs: Update code comments in `workspace new` command * test: Update E2E test using PSS with workspace commands to assert state files are created by given commands * test: Include `workspace show` in happy path E2E test using PSS * fix: Allow DeleteState RPC to include the id of the state to delete * test: Include `workspace delete` in happy path E2E test using PSS * fix: Avoid assignment to nil map in mock provider during WriteStateBytes * test: Add integration test for workspace commands when using PSS We still need an E2E test for this, to ensure that the GRPC-related packages pass all the expected data between core and the provider. * test: Update test to reflect changes in the test fixture configuration * docs: Fix code comment * test: Change test to build its own Terraform binary with experiments enabled * refactor: Replace use of `newMeta` with reuse of Meta that we re-set the UI value on	6 months ago
Sarah French	8503c45013	Update `backend.Backend`'s `StateMgr` method to return diagnostics instead of primitive errors (#37496) ... * Fix S3 backend test affected by making the Workspaces method return errors via diagnostics * Address diagnostics comparison issues in test by ensuring expected diagnostics are defined in the context of the config they're triggered by * Fix failing test case `TestBackendConfig_EC2MetadataEndpoint/envvar_invalid_mode` by making `diagnosticBase` struct comparable * Add compile-time checks that diagnostic types fulfil interfaces * Stop diagnosticBase implementing ComparableDiagnostic, re-add S3-specific comparer code to s3 package * Update tests to use the S3-specific comparer again * Fix test case missed in refactoring * Update the backend.Backend interface to use diagnostics as return value from StateMgr method * Fix calls to `Fatalf`	9 months ago
Sarah French	7199fbd2bb	Update use of `testChdir` to standard library's `t.Chdir`, remove `testChdir` function from codebase (#37334) ... * Replace use of `testChdir` with `t.Chdir` * Update tests to use temporary directories with copied content, instead of using directories in the repo directly. * Remove stacks copy of testChdir function This has been replaced with t.Chdir from the standard library * Replace remaining simple usage of testChdir * Update guidance for using `tempWorkingDir` * Replace use of testChdir in a function reused in a single test * Update comments to no longer recommend using testChdir * Remove testChdir function!	11 months ago
Sarah French	15840b3eae	Replace use of `defer` with `t.Cleanup` in majority of `command` package tests, update `testChdir` to work with t.Cleanup (#37326) ... * Replace use of `defer` with `t.Cleanup` in tests * Fix test failures by making cleanup function permissive of the temp dir being already deleted.	11 months ago
Sarah French	38e2ed42c4	Make the `workspace` command explicitly protect the default workspace, instead of relying on backend implementations (#37256) ... * Add test showing that users cannot delete the default workspace Note: in the test this validation is being returned from the local backend's `DeleteWorkspace` method, not the command itself. * Make the `workspace delete` command return early if the user is trying to delete the default workspace. Update test. * Clean up redundant parts of test	11 months ago
Sarah French	3617b909c1	Make `workspace delete` command reject empty string arguments (#37275) ... * Disallow "" as the argument to workspaces delete command * Add change file	11 months ago
Sarah French	9212a2efdd	Make Terraform reject empty strings as invalid workspace names (#37267) ... * Add tests defining what are valid workspace names * Update workspace name validation to mark an empty string as not valid * Add change file * Add command-level test showing the "" workspace cannot be created or selected * Update invalid name error text to include empty string as invalid.	11 months ago
Martin Atkins	66bec6c3c7	command: TestWorkspace_deleteWithState uses modern state format ... This test is intending to test behavior in the presence of a state snapshot but was achieving that using the legacy state snapshot format that we preserved only for its previous (now eliminated, in an earlier commit) purpose of implementing the CLI backend state format. Instead, we'll construct a state snapshot format using the modern API for doing that, which therefore constructs a modern state snapshot file as would be created by today's Terraform. This eliminates the last use of the "legacy/terraform" package aside from the calls from other packages under "legacy".	2 years ago
Jamie Finnigan	05b0bdac99	adopt hashicorp/cli fork of mitchellh/cli (#34429)	2 years ago
hashicorp-copywrite[bot]	53c34ff49c	Update copyright file headers to BUSL-1.1	3 years ago
hashicorp-copywrite[bot]	325d18262e	[COMPLIANCE] Add Copyright and License Headers	3 years ago
Brittan DeYoung	5932540be3	New Terraform Workspace select flag:	4 years ago
Eng Zer Jun	fedd315275	test: use `T.TempDir` to create temporary test directory (#30803) ... This commit replaces `ioutil.TempDir` with `t.TempDir` in tests. The directory created by `t.TempDir` is automatically removed when the test and all its subtests complete. Prior to this commit, temporary directory created using `ioutil.TempDir` needs to be removed manually by calling `os.RemoveAll`, which is omitted in some tests. The error handling boilerplate e.g. defer func() { if err := os.RemoveAll(dir); err != nil { t.Fatal(err) } } is also tedious, but `t.TempDir` handles this for us nicely. Reference: https://pkg.go.dev/testing#T.TempDir Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>	4 years ago
Martin Atkins	bee7403f3e	command/workspace_delete: Allow deleting a workspace with empty husks ... Previously we would reject attempts to delete a workspace if its state contained any resources at all, even if none of the resources had any resource instance objects associated with it. Nowadays there isn't any situation where the normal Terraform workflow will leave behind resource husks, and so this isn't as problematic as it might've been in the v0.12 era, but nonetheless what we actually care about for this check is whether there might be any remote objects that this state is tracking, and for that it's more precise to look for non-nil resource instance objects, rather than whole resources. This also includes some adjustments to our error messaging to give more information about the problem and to use terminology more consistent with how we currently talk about this situation in our documentation and elsewhere in the UI. We were also using the old State.HasResources method as part of some of our tests. I considered preserving it to avoid changing the behavior of those tests, but the new check seemed close enough to the intent of those tests that it wasn't worth maintaining this method that wouldn't be used in any main code anymore. I've therefore updated those tests to use the new HasResourceInstanceObjects method instead.	5 years ago
Martin Atkins	f40800b3a4	Move states/ to internal/states/ ... This is part of a general effort to move all of Terraform's non-library package surface under internal in order to reinforce that these are for internal use within Terraform only. If you were previously importing packages under this prefix into an external codebase, you could pin to an earlier release tag as an interim solution until you've make a plan to achieve the same functionality some other way.	5 years ago
Martin Atkins	ffe056bacb	Move command/ to internal/command/ ... This is part of a general effort to move all of Terraform's non-library package surface under internal in order to reinforce that these are for internal use within Terraform only. If you were previously importing packages under this prefix into an external codebase, you could pin to an earlier release tag as an interim solution until you've make a plan to achieve the same functionality some other way.	5 years ago