terraform

Commit Graph

Author	SHA1	Message	Date
Nick Fagerlund	1ae8643201	Refactor `(*Cloud).Configure`, and fix TF_WORKSPACE bug This fixes issue #33976, introduced in https://github.com/hashicorp/terraform/pull/33489, which broke the intended behavior of specifying the active workspace via the TF_WORKSPACE variable when using a tag-based workspace mapping. Now that all the default and fallback value behaviors are cleanly isolated in a function, this whole flow can be a bit simpler. - Remove `setConfigurationFields`. Instead, `Configure` can just trade its Cty `obj` for a dumb struct and set a couple fields from it. The `TF_FORCE_LOCAL_BACKEND` handling can just join the relevant section of Configure directly. - Radically chop down PrepareConfig. It turns out we were violating the interface contract, which says PrepareConfig shouldn't trouble itself with the shell environment and fallback values... So, don't do that.	3 years ago
Nick Fagerlund	8e1b65ebc3	Add resolveCloudConfig function This will be the central location for everything involving combining environment variables with a `cloud` config block to obtain a final cloud config. It returns a plain Go value (so that nothing downstream of it ever needs to mess with Cty types), and doesn't mutate any fields on the backend, so it has a nice firm boundary of responsibilities. Also, it's quite a bit more pedantic and explicit about HOW the environment variables get consulted, in the hope of reducing future misunderstandings about our UI-level expectations.	3 years ago
Radek Simko	1d1dcc4b8b	cloud: Fix typo & align 'project' field description (#33946 )	3 years ago
Liam Cervante	ffbcaf8bef	Implement TFC integration for private module registry test runs (#33710 ) * implement module testing via TFC * ready for review * fix static checks * licence headers	3 years ago
Brandon Croft	6500b7c740	change visibility of cloud.Backend Hostname field	3 years ago
hashicorp-copywrite[bot]	53c34ff49c	Update copyright file headers to BUSL-1.1	3 years ago
Karl Kirch	d7e07e66fc	Add ability to specify Terraform Cloud Project in cloud block (#33489 ) * Add ability to specify Terraform Cloud Project in cloud block Adds project configuration to the workspaces section of the cloud block. Also configurable via the `TF_CLOUD_PROJECT` environment variable. When a project is configured, the following behaviors will occur: - `terraform init` with workspaces.name configured will create the workspace in the given project - `terraform workspace new <name>` with workspaces.tags configured will create workspaces in the given project - `terraform workspace list` will list workspaces only from the given project The following behaviors are NOT affected by project configuration - `terraform workspace delete <name>` does not validate the workspace's inclusion in the given project - When initializing a workspace that already exists in Terraform Cloud, the workspace's parent project is NOT validated against the given project Adds tests for cloud block configuration of project Update changelog * Update cloud block docs * Fix typos and changelog entry * Add speculative project lookup early in the cloud initialize process to capture inability to find a configured project * Add project config for alias test	3 years ago
Brandon Croft	c1a730314d	Relocate localterraform.com aliasing to backend configurators Previously, remote and cloud backends would automatically alias localterraform.com as the configured hostname during configuration. This turned out to be an issue with how backends could potentially be used within the builtin terraform_remote_state data source. Those data sources each configure the same service discovery with different targets for localterraform.com, and do so simultaneously, creating an occasional concurrent map read & write panic when multiple data sources are defined. localterraform.com is obviously not useful for every backend configuration. Therefore, I relocated the alias configuration to the callers, so they may specify when to use it. The modified design adds a new method to backend.Enhanced to allow configurators to ask which aliases should be defined.	3 years ago
Brandon Croft	86eed095b3	Rename disableIntermediateSnapshots > enableIntermediateSnapshots	3 years ago
Sebastian Rivera	d03fd37ee6	Add interval header check to enable snapshots	3 years ago
hashicorp-copywrite[bot]	325d18262e	[COMPLIANCE] Add Copyright and License Headers	3 years ago
Sebastian Rivera	71dac9bf5e	Add token field to cloud backend	3 years ago
Sebastian Rivera	de574ae6d4	Initial implementation of structured logging in cloud backend (#32504 ) * Implementation of structured logging. These are the changes that enable the cloud backend to consume structured logs and make use of the new plan renderer. This will enable CLI-driven runs to view the structured output in the Terraform Cloud UI. * Cloud structured logging unit tests * Remove deferred logs logic, fix minor issues Color formatting fixes, log type stop lists, default behavior for logs that are unknown * Use service disco path in redacted plan url	3 years ago
Brandon Croft	81a4e5ae44	Backport support for generic hostname to backend/remote	3 years ago
Brandon Croft	2fe3a23094	Add generic hostname (localterraform.com) support to cloud backend Aliases the backend hostname config as "localterraform.com" and duplicates any existing auth credentials during cloud backend configuration.	3 years ago
Anna Winkler	3cc7e55465	Expand error when discovery document request fails (#32394 ) * Expand error when discovery document request fails. * Use error type from svchost library * Use svchost v0.0.1	3 years ago
Jarrett Spiker	c16d726f2c	Succeed cloud workspace deletion if the workspace does not exist	3 years ago
Jarrett Spiker	060255a9d5	Use safe or force workspace delete for cloud backend	3 years ago
Megan Bang	dbf99f17b1	add test and removed backend state from cloud	4 years ago
Megan Bang	bddf6a9b34	updating to use the latest version of cloud/state.go and just pass schemas along to PersistState in the remote state	4 years ago
Megan Bang	021f1f69e9	updates to cloud state	4 years ago
Martin Atkins	783a07d9e8	build: Use Go 1.19 Go 1.19's "fmt" has some awareness of the new doc comment formatting conventions and adjusts the presentation of the source comments to make it clearer how godoc would interpret them. Therefore this commit includes various updates made by "go fmt" to acheve that. In line with our usual convention that we make stylistic/grammar/spelling tweaks typically only when we're "in the area" changing something else anyway, I also took this opportunity to review most of the comments that this updated to see if there were any other opportunities to improve them.	4 years ago
Brandon Croft	e1fa690879	style: goimports fixes	4 years ago
Brandon Croft	c33c8b013f	fix: have `terraform output` adhere to authorization w/ cloud Normally, `terraform output` refreshes and reads the entire state in the command package before pulling output values out of it. This doesn't give Terraform Cloud the opportunity to apply the read state outputs org permission and instead applies the read state versions permission. I decided to expand the state manager interface to provide a separate GetRootOutputValues function in order to give the cloud backend a more nuanced opportunity to fetch just the outputs. This required moving state Refresh/Read code that was previously in the command into the shared backend state as well as the filesystem state packages.	4 years ago
Anna Winkler	22c121df86	Bump compatibility version to 1.3.0 for terraform core release (#30988 ) * Bump compatibility version to 1.3.0 for terraform core release Co-authored-by: Brandon Croft <brandon.croft@gmail.com>	4 years ago
Sebastian Rivera	9d7fdbea2d	Handle -input=false in cloud integration For non-interactive contexts, Terraform is typically executed with the flag -input=false. However for runs that are not set to auto approve, the cloud integration will prompt a user for approval input even with input being set to false. This commit enables the cloud integration to know the value of the input flag and use it to determine whether or not to ask the user for input. If -input is set to false and the run cannot be auto approved, the cloud integration will throw an error stating run confirmation can no longer be handled in the CLI and that they must do so through the browser.	4 years ago
Sebastian Rivera	5ded48e081	Give token in cloud config higher precedence than CLI config file	4 years ago
Sebastian Rivera	f63ef2b5ef	Rename cloud env vars to use TF_CLOUD prefix	4 years ago
Brandon Croft	a38a0ee8a8	test(cloud): ensure mocks are used for backend configure tests Also adds a few new tests for cloud configuration using environment variables	4 years ago
Sebastian Rivera	dd864b1bac	Add TF_WORKSPACE validation method	4 years ago
Sebastian Rivera	995ef15ab9	Add cloud configuration support for TF_WORKSPACE TF_WORKSPACE can now be used for your cloud configuration, effectively serving as an alternative to setting the name attribute in your workspaces configuration.	4 years ago
Sebastian Rivera	232d48fe00	Add support for TF_HOSTNAME env var	4 years ago
Sebastian Rivera	b1c22d333e	Fix error formatting for missing env and config value We previously used to throw an error denoting where in the configuration the attribute was missing or invalid. Considering that organization can be now be omitted from the configuration, our previous error message will be improperly formatted. This commit also updates the message to mention `TF_ORGANIZATION` as a valid substitute if organization is missing or invalid in the configuration.	4 years ago
Sebastian Rivera	45357f5004	Add TF_ORGANIZATION env var support TF_ORGANIZATION will serve as a fallback for configuring the organization in the `cloud` block. This is the first step to make it easier for users wanting to configure Terraform programmatically.	4 years ago
Luces Huayhuaca	bdc7d8c0a1	Upgrade go-tfe dependency to use 1.0 version. It contains breaking changes, so we are updating method signatures, method names and the type of optional parameters, as needed. (#30626 )	4 years ago
Theo Chupp	d15a2bc024	fix: local variables should not be overridden by remote variables during `terraform import` (#29972 ) * fix: local variables should not be overridden by remote variables during `terraform import` * chore: applied the same fix in the 'internal/cloud' package * backport changes from cloud package to remote package Co-authored-by: Alisdair McDiarmid <alisdair@users.noreply.github.com> Co-authored-by: uturunku1 <luces.huayhuaca@gmail.com>	4 years ago
Chris Arcand	21750037d5	cloud: Help output typos	5 years ago
Luces Huayhuaca	4e3218b4d5	cloud: convert uses of worspaces.operations into workspaces.executionMode (#29844 ) * convert uses of worspaces.operations into workspaces.executionMode The cloud package currently uses a deprecated API on workspaces to determine a workspace's execution mode. Deprecated: Operations (boolean) New hotness: Execution mode (string - "local", "remote", or "agent") More details: https://www.terraform.io/docs/cloud/api/workspaces.html#request-body All uses of Operations field coming from the client (within the cloud package) should be converted to the appropriate ExecutionMode equivalent. Also, we need to update all acknowledgment of operations field on the tests that are testing the behavior of workspaces. Co-authored-by: Nick Fagerlund <nick.fagerlund@gmail.com> Co-authored-by: Nick Fagerlund <nick.fagerlund@gmail.com>	5 years ago
Omar Ismail	1da7031855	cloud: Add tags to workspace if necessary when fetching state	5 years ago
Alisdair McDiarmid	a61bd8a96b	cloud: Fix prerelease version constraint checks	5 years ago
Brandon Croft	6d9c919f55	adds X-Terraform-Integration header This can help differentiate cloud integration API requests from normal remote backend requests	5 years ago
Chris Arcand	3d23a8e062	cloud: Fix version check regression When the 'select the exact version if possible' behavior was added, the version check below it was never updated to take the newly updated version in to account, resulting in a failed version check even as the remote workspace updated to the correct version necessary.	5 years ago
Omar Ismail	fc5863844c	Cloud migration: ignore backend version check when empty worksapces	5 years ago
Chris Arcand	50997d9a32	Restore API version checking, with internal usage accounted for	5 years ago
Nick Fagerlund	c99f5972de	cloud.StateMgr(): Set terraform version AFTER creating workspace Previously, if the remote TFC/TFE instance doesn't happen to have a tool_version record whose name exactly matches the value of `tfversion.String()`, Terraform would be completely blocked from using the `terraform workspace new` command (when configured with the tags strategy) — the API would give a 422 to the whole create request. This commit changes the StateMgr() function to do the work in two passes; first create the workspace (which should work fine regardless), THEN update the Terraform version and print a warning to the terminal if it fails (which 99% of the time is a benign failure with little impact on your future CLI usage).	5 years ago
Chris Arcand	12a4af3e72	Temporarily skip API version checking	5 years ago
Nick Fagerlund	baa72ce235	Simplify logic flow: everything is a constraint Explicit version strings are actually also version constraints! And the special comparisons we were doing to allow a range of compatible versions can also be expressed as version constraints. Bonus: also simplify the way we handle version check errors, by composing the messages inline and only extracting the repetitive parts into a function.	5 years ago
Barrett Clark	83538fdd6b	Shift errors to error file, improve error text	5 years ago
Nick Fagerlund	b43daeaa8d	Cloud backend: accept version constraints from workspaces The cloud backend (and remote before it) previously expected a TFC workspace's `terraform-version` attribute to be either the magic string `"latest"` or an explicit semver value. But a workspace might have a version constraint instead (like `~> 1.1.0`), in which case the version check would blow up. This commit checks whether `terraform-version` is a valid version constraint before erroring out, and if so, returns success if the local version meets the constraint. Because it's not practical to deeply introspect the slice of version space defined by a constraint, this check is slightly less robust than the version comparisons below it: - It can give a false OK on open-ended constraints like `>= 1.1.0`. Say you're running 1.3.0, it changed the state format, and the TFE instance admin has not yet added any 1.3.x Terraform versions; your workspace will now break. - It will give a false not-OK when using different minor versions within a range that we know to be compatible, e.g. remote constraint of `~> 0.15.0` and local version of 1.1.0. - This would be totally useless with the pre-0.14 versions of Terraform, where patch releases could change state format... but we're not going back in time to add this feature to them anyway. Still, in the most common likely case (`~> x.y.z`), it'll complain at you (with an error you can choose to override) if you're not using the same minor version, and that seems proportionate, useful, and expected.	5 years ago
Barrett Clark	83337de654	Remove prefix from the cloud backend config Now that we have tags we no longer need prefix.	5 years ago

1 2

65 Commits (5848d8a2b4e0c500c384bcbdcc84b5feec3f6549)