409 Commits (551eedcf2616376b00d7da170b09f682bbfa3445)

Author	SHA1	Message	Date
Radek Simko	9867ce4dde	helper/schema: Disallow validation+diff suppression on computed-only fields	9 years ago
James Bardin	9aaf220efb	Merge pull request #13863 from hashicorp/jbardin/computed-list-requires-new ... make sure a computed list is can be RequiresNew	9 years ago
James Bardin	caadb4297f	make sure a computed list is can be RequiresNew ... If a schema.TypeList had a Schema with ForceNew, and if that list was NewComputed, the diff would not have RequiresNew set. This causes apply to fail when the diffs didn't match because of the change to RequiresNew. Set the RequiresNew field on the list's ResourceAttrDiff based on the Schema value.	9 years ago
Martin Atkins	b1763e262a	Restore stringer-generated files back to new version ... stringer has changed the boilerplate it generates in a recent version. We'd previously updated to the new format but accientally rolled back to the old while merging a long-running feature branch. This restores us back to the new format again.	9 years ago
Jasmin Gacic	61499cfcf0	Provider Oneandone (#13633) ... * Terraform Provider 1&1 * Addressing pull request remarks * Fixed imports * Fixing remarks * Test optimiziation	9 years ago
Sander van Harmelen	3d0073e05c	core: fix a crash by suggesting a different approach to solve #11170 (#13541) ... * Revert #11245, #11321, #11498 and #11757 These PR’s are all related to issue #11170 for which I would like to propose a different solution then the one currently implemented. * A different approach to solve #11170 This approach has (IMHO) a few advantages with regards to the solution currently implemented. I will elaborate on this in the PR.	9 years ago
James Bardin	735dfc416d	Merge pull request #13427 from hashicorp/jbardin/context-keys ... Fix context key types in schema	9 years ago
Martin Atkins	a0269c688c	helper/schema: Clarify the expectations for DefaultFunc ... Discussion in #9512 revealed that some of the comments here were inaccurate and that the comments here did not paint a complete enough picture of the behavior and expectations of Default and DefaultFunc. This is a comments-only change that aims to clarify the situation and call attention to the fact that the defaults only affect the handling of the configuration and that changes to defaults may require migration of existing resource states. This closes #9512.	9 years ago
James Bardin	8a1089a161	convert the other context keys to the correct type	9 years ago
James Bardin	812f9fb253	don't use primitive types for context value keys ... A context value key should be typed within the package namespace, otherwise different packages could have colliding values in a context.	9 years ago
Martin Atkins	21cd5595e2	Update stringer-generated files to new boilerplate ... golang/tools commit 23ca8a263 changed the format of the leading comment to comply with some new standards discussed here: https://golang.org/issue/13560 This is the result of running generate with the latest version of stringer. Everyone working on Terraform will need to update stringer after this is merged, to avoid reverting this: go get -u golang.org/x/tools/cmd/stringer	9 years ago
James Bardin	2e6a44d5ff	reify the list values before validation ... If the list was marked as computed, all values will be raw config values. Fetch the individual keys from the config to get any known values before validating.	9 years ago
James Bardin	99a12f5df3	interpolation strings were beeing validated ... Interpolation strings for non-computed values in a list were being passed to the schema's ValidateFunc.	9 years ago
James Bardin	efd0f5b0db	Fix logic when skipping schema input ... The Required||Optional logic in schemaMap.Input was incorrect, causing it to always request input. Fix the logic, and the associated tests which were passing "just because".	9 years ago
Radek Simko	1df1c21d5b	schema: Allow *Resource as Elem of TypeMap in validation (#12722)	9 years ago
Radek Simko	afd34f79df	schema: Enable map value validation (#12638)	9 years ago
Clint	3fdeacdca7	helper/schema: Rename Timeout resource block to Timeouts (#12533) ... helper/schema: Rename Timeout resource block to Timeouts - Pluralize configuration argument name to better represent that there is one block for many timeouts - use a const for the configuration timeouts key - update docs	9 years ago
James Bardin	ecb1944c31	Merge pull request #12498 from hashicorp/jbardin/test-reset ... Add schema.Provider.TestReset to reset StopContext between tests	9 years ago
James Bardin	1d9d7be28c	Add schema.Provider.TestReset method ... Provider.TestReset resets the internal state of the Provider at the start of a test. This also adds a MetaReset function field to schema.Provider, which is called by TestReset and can be used to reset any other tsated stored in the provider metadata. This is currently used to reset the internal Context returned by StopContext between tests, and should be implemented by a provider if it stores a Context from a previous test.	9 years ago
clint shryock	aa3677cd89	helper/schema: Guard against a panic if Timeout is not properly ... structured	9 years ago
Clint	2fe5976aec	helper/schema: Add configurable Timeouts (#12311) ... * helper/schema: Add custom Timeout block for resources * refactor DefaultTimeout to suuport multiple types. Load meta in Refresh from Instance State * update vpc but it probably wont last anyway * refactor test into table test for more cases * rename constant keys * refactor configdecode * remove VPC demo * remove comments * remove more comments * refactor some * rename timeKeys to timeoutKeys * remove note * documentation/resources: Document the Timeout block * document timeouts * have a test case that covers 'hours' * restore a System default timeout of 20 minutes, instead of 0 * restore system default timeout of 20 minutes, refactor tests, add test method to handle system default * rename timeout key constants * test applying timeout to state * refactor test * Add resource Diff test * clarify docs * update to use constants	9 years ago
Mitchell Hashimoto	3342aa580c	terraform: InstanceState.Meta is value type interface{} ... This changes the type of values in Meta for InstanceState to `interface{}`. They were `string` before. This will allow richer structures to be persisted to this without flatmapping them (down with flatmap!). The documentation clearly states that only primitives/collections are allowed here. The only thing using this was helper/schema for schema versioning. Appropriate type checking was added to make this change safe. The timeout work @catsby is doing will use this for a richer structure.	9 years ago
Mitchell Hashimoto	c6d0333dc0	flatmap: mark computed list as a computed value in Expand ... Fixes #12183 The fix is in flatmap for this but the entire issue is a bit more complex. Given a schema with a computed set, if you reference it like this: lookup(attr[0], "field") And "attr" contains a computed set within it, it would panic even though "field" is available. There were a couple avenues I could've taken to fix this: 1.) Any complex value containing any unknown value at any point is entirely unknown. 2.) Only the specific part of the complex value is unknown. I took route 2 so that the above works without any computed (since "name" is not computed but something else is). This may actually have an effect on other parts of Terraform configs, however those similar configs would've simply crashed previously so it shouldn't break any pre-existing configs.	9 years ago
James Bardin	7359a18a71	Make sure to diff all nested schema.Set elements ... This follows on GH-11498, using the same method to ensure all set elements are marked as NewRemoved if the set is being removed in the diff.	9 years ago
Mitchell Hashimoto	61881d2795	Merge pull request #10934 from hashicorp/f-provisioner-stop ... core: stoppable provisioners, helper/schema for provisioners	9 years ago
Radek Simko	d5ac48de2a	helper/schema: Remove missed subfields when parent list is removed (#11498)	9 years ago
Mitchell Hashimoto	487a37b0dd	helper/schema: PromoteSingle for legacy support of "maybe list" types	9 years ago
Mitchell Hashimoto	3c0c81957a	provisioners/remote-exec: switch to helper/schema	9 years ago
Mitchell Hashimoto	a2e044829b	provisioners/file: use the old communicator.New just to minimize risk	9 years ago
Mitchell Hashimoto	a1da59a73e	helper/schema: provisioner allows for nil state	9 years ago
Mitchell Hashimoto	b2891bc9ef	helper/schema: Provisioner support	9 years ago
Mitchell Hashimoto	251e5c6f87	helper/schema: framework for Backends	9 years ago
Conor Mongey	77c8683281	provider/vault: Remove user input for optional vault provider fields (#11082) ... * Remove the need to input vault optional settings * Allow TypeList to skip input * Remove conflicts on vault ca_cert_* fields	9 years ago
clint shryock	6bafd4c896	fix typo	9 years ago
James Bardin	01be1a5ecd	Check for interpolated values when reading a map ... Accessing an interpolated value in a map through ConfigFieldReader can fail, because GetRaw can't access interpolated values, so check if the value exists at all by looking in the config. If the config has a value, assume our map's value is interpolated and proceed as such. We also need to lookup the correct schema to properly read a field from a nested structure. - Maps previously always defaulted to TypeString. Now check if Elem is a ValueType and use that if applicable - Lists now return the schema for nested element types, defaulting to a TypeString like maps. This only allows maps and lists to be nested one level deep, and the inner map or list must only contain string values.	10 years ago
Mitchell Hashimoto	0634aada69	Revert "core: Ensure hasComputedSubKeys iterates over Sets and Lists properly" ... This reverts commit 4d8208d840.	10 years ago
Mitchell Hashimoto	f2fcf1494a	Merge branch 'fix-field-reader-setsubkeys-computed' of https://github.com/vancluever/terraform into vancluever-fix-field-reader-setsubkeys-computed	10 years ago
Chris Marchesi	8d06d68d0f	core: Backport NewComputed change to nested list/set tests ... Needed due to work done in 95d37ea, we may need to adjust hasComputedSubKeys to propagate NewComputed in the same way that we have added "~", however will wait for comment from @mitchellh.	10 years ago
Chris Marchesi	f258056731	core: Tests for hasComputedSubKeys fix ... This covers: * Complex sets with computed fields in a set * Complex lists with computed fields in a set Adding a test to test basic lists with computed fields seemed to fail, but possibly for an unrelated reason (the list returned as nil). The fix to this inparticular case may be out of the scope of this specific issue. Reference gist and details in hashicorp/terraform#9171.	10 years ago
Chris Marchesi	4d8208d840	core: Ensure hasComputedSubKeys iterates over Sets and Lists properly ... This fixes some edge-ish cases where a set in a config has a set or list in it that contains computed values, but non-set or list values in the parent do not. This can cause "diffs didn't match during apply" errors in a scenario such as when a set's hash is calculated off of child items (including any sub-lists or sets, as it should be), and the hash changes between the plan and apply diffs due to the computed values present in the sub-list or set items. These will be marked as computed, but due to the fact that the function was not iterating over the list or set items properly (ie: not adding the item number to the address, so set.0.set.foo was being yielded instead of set.0.set.0.foo), these computed values were not being properly propagated to the parent set to be marked as computed. Fixes hashicorp/terraform#6527. Fixes hashicorp/terraform#8271. This possibly fixes other non-CloudFront related issues too.	10 years ago
James Bardin	c4eefd4b5e	Allow primitive type in maps via all FieldReaders ... Now that we can read primitive type out of a map, each field reader needs to be able to set the proper type as expected.	10 years ago
James Bardin	730014b33e	Convert the map fields values when reading diff ... Convert the value to the correct type when reading a diff and the map schema has an primitive Elem type.	10 years ago
Radek Simko	ad34f1ec74	Add (failing) test for map w/ non-string values	10 years ago
Mitchell Hashimoto	39542898b0	helper/schema: mark diff as forcenew if element is computed ... Fixes #10125 If the elements are computed and the field is ForceNew, then we should mark the computed count as potentially forcing a new operation. Example, assuming `groups` forces new... **Step 1:** groups = ["1", "2", "3"] At this point, the resource isn't create, so this should result in a diff like: CREATE resource: groups: "" => ["1", "2", "3"] **Step 2:** groups = ["${computedvar}"] The OLD behavior was: UPDATE resource groups.#: "3" => "computed" This would cause a diff mismatch because if `${computedvar}` was different then it should force new. The NEW behavior is: DESTROY/CREATE resource: groups.#: "3" => "computed" (forces new)	10 years ago
Mitchell Hashimoto	15f50b86bf	helper/schema: passing tests for computed complex sets	10 years ago
Mitchell Hashimoto	29485f6167	terraform: ResourceConfig.IsComputed cases	10 years ago
Mitchell Hashimoto	5792b2cba2	helper/schema: convert _Diff to subtests	10 years ago
Mitchell Hashimoto	2b7177cfe7	Merge pull request #9607 from hashicorp/f-provider-stop-redo ... terraform: ResourceProvider.Stop (redo)	10 years ago
Mitchell Hashimoto	e45debe0e5	helper/schema: only mark "ForceNew" on resources that cause the ForceNew ... Fixes #2748 This changes the diff to only mark "forces new resource" on the fields that actually caused the new resource, not every field that changed. This makes diffs much more accurate. I'd like to request a review but I'm going to defer merging until Terraform 0.8. Changes like this are very possible to cause "diffs didn't match" errors and I want some real world testing in a beta before we hit prod with this.	10 years ago
Mitchell Hashimoto	b7bee66df5	helper/schema: sort errors in helper/schema test for deterministic tests	10 years ago