terraform

Commit Graph

Author	SHA1	Message	Date
Radek Simko	9867ce4dde	helper/schema: Disallow validation+diff suppression on computed-only fields	9 years ago
James Bardin	9aaf220efb	Merge pull request #13863 from hashicorp/jbardin/computed-list-requires-new make sure a computed list is can be RequiresNew	9 years ago
James Bardin	caadb4297f	make sure a computed list is can be RequiresNew If a schema.TypeList had a Schema with ForceNew, and if that list was NewComputed, the diff would not have RequiresNew set. This causes apply to fail when the diffs didn't match because of the change to RequiresNew. Set the RequiresNew field on the list's ResourceAttrDiff based on the Schema value.	9 years ago
Martin Atkins	b1763e262a	Restore stringer-generated files back to new version stringer has changed the boilerplate it generates in a recent version. We'd previously updated to the new format but accientally rolled back to the old while merging a long-running feature branch. This restores us back to the new format again.	9 years ago
Jasmin Gacic	61499cfcf0	Provider Oneandone (#13633 ) * Terraform Provider 1&1 * Addressing pull request remarks * Fixed imports * Fixing remarks * Test optimiziation	9 years ago
James Bardin	f5cda342f7	Merge pull request #13778 from hashicorp/jbardin/GH-13617 improve resource.WaitForState and add refreshGracePeriod	9 years ago
James Bardin	4c3a053f0c	lint errors	9 years ago
James Bardin	14bea66f4e	add test for proper cancelation	9 years ago
James Bardin	eb4b45941c	fix tests affected by refreshGracePeriod A couple tests require lowering the grace period to keep the test from taking the full 30s timeout. The Retry_hang test also needed to be removed from the Parallel group, becuase it modifies the global refreshGracePeriod variable.	9 years ago
James Bardin	af1628eaa4	add refreshGracePeriod Refresh calls may have side effects that need to be recorded if it succeeds, especially common when when WaitForState is called from resource.Retry. If the WaitForState timeout is reached and there is a Refresh call in-flight, wait up to refreshGracePeriod (set to 30s) for it to complete.	9 years ago
=	1608f5544f	Added error check	9 years ago
=	6bc3610c09	removing extraneous code	9 years ago
James Bardin	6601b9b8dd	adjust the inconsistent_negative test to match This test unfortunately relies on the timing of the loops in WaitForState, and the text of the error message. Adjust the timing so the timeout isn't an even multiple of the poll interval, and make sure we reach a minimum number of retries.	9 years ago
James Bardin	af5e22cf94	don't leave WaitForState goroutine running Make sure that we can cancel the WaitForState refresh loop when reaching a timeout, otherwise it may run indefinitely. There's no need to try and store and read the Result concurrently, just pass the value over a channel.	9 years ago
Sander van Harmelen	3d0073e05c	core: fix a crash by suggesting a different approach to solve #11170 (#13541 ) * Revert #11245, #11321, #11498 and #11757 These PR’s are all related to issue #11170 for which I would like to propose a different solution then the one currently implemented. * A different approach to solve #11170 This approach has (IMHO) a few advantages with regards to the solution currently implemented. I will elaborate on this in the PR.	9 years ago
Clint	9ef9501e65	provider/aws: Fix EMR Bootstrap Action Ordering (#13580 ) * provider/aws: Add failing test for EMR Bootstrap Actions * aws_emr_cluster: Fix bootstrap action parameter ordering * provider/aws: Fix EMR Bootstrap arguments * provider/aws: Args needs to be ForceNew, because we can't update them	9 years ago
James Bardin	735dfc416d	Merge pull request #13427 from hashicorp/jbardin/context-keys Fix context key types in schema	9 years ago
Martin Atkins	a0269c688c	helper/schema: Clarify the expectations for DefaultFunc Discussion in #9512 revealed that some of the comments here were inaccurate and that the comments here did not paint a complete enough picture of the behavior and expectations of Default and DefaultFunc. This is a comments-only change that aims to clarify the situation and call attention to the fact that the defaults only affect the handling of the configuration and that changes to defaults may require migration of existing resource states. This closes #9512.	9 years ago
James Bardin	8a1089a161	convert the other context keys to the correct type	9 years ago
James Bardin	812f9fb253	don't use primitive types for context value keys A context value key should be typed within the package namespace, otherwise different packages could have colliding values in a context.	9 years ago
Jake Champlin	fed7b6e781	Merge pull request #13129 from tombuildsstuff/validation provider/azurerm: Moving Reused JSON Validation -> Core	9 years ago
Jake Champlin	f24087ee54	core: Add ImportStateIdPrefix field for testing Adds the `ImportStateIdPrefix` field for import acceptance tests. There are (albeit fairly rare) import cases where a resource needs to be imported with a combination of the resource's ID and a known string prefix. This allows the developer to specify the known prefix, and omit the `ImportStateId` field. ``` $ make test TEST=./helper/resource TESTARGS="-run=TestTest_importStateIdPrefix" ==> Checking that code complies with gofmt requirements... ==> Checking AWS provider for unchecked errors... ==> NOTE: at this time we only look for uncheck errors in the AWS package go generate $(go list ./... \| grep -v /terraform/vendor/) 2017/03/30 18:08:36 Generated command/internal_plugin_list.go go test -i ./helper/resource \|\| exit 1 echo ./helper/resource \| \ xargs -t -n4 go test -run=TestTest_importStateIdPrefix -timeout=60s -parallel=4 go test -run=TestTest_importStateIdPrefix -timeout=60s -parallel=4 ./helper/resource ok github.com/hashicorp/terraform/helper/resource 0.025s ```	9 years ago
Martin Atkins	21cd5595e2	Update stringer-generated files to new boilerplate golang/tools commit 23ca8a263 changed the format of the leading comment to comply with some new standards discussed here: https://golang.org/issue/13560 This is the result of running generate with the latest version of stringer. Everyone working on Terraform will need to update stringer after this is merged, to avoid reverting this: go get -u golang.org/x/tools/cmd/stringer	9 years ago
James Nugent	0e3a7e6d0d	helper/resource: Allow unknown pending states (#13099 ) Sometimes when waiting on a target state, the set of valid states through which a value will transition is unknown. This commit adds support for an empty Pending slice and will treat any states that are not the target as valid provided the timeouts are not exceeded.	9 years ago
tombuildsstuff	64dda483dd	Adding tests for each helper method	9 years ago
James Nugent	5d734cee4e	helper/acctest: Add RandIntRange helper function This commit adds a new RandIntRange function to the helper/acctest package for generating random integers in a given range. This is useful when randomizing test spaces with a constrained range (e.g. 0-4095).	9 years ago
tombuildsstuff	6efdc94ae3	Splitting the structure tests	9 years ago
tombuildsstuff	459c9a0a5a	Returning a blank string if there's nothing to serialize	9 years ago
tombuildsstuff	277d1b6b2d	Refactoring the schema diff/validation -> core	9 years ago
James Bardin	2e6a44d5ff	reify the list values before validation If the list was marked as computed, all values will be raw config values. Fetch the individual keys from the config to get any known values before validating.	9 years ago
James Bardin	99a12f5df3	interpolation strings were beeing validated Interpolation strings for non-computed values in a list were being passed to the schema's ValidateFunc.	9 years ago
Joseph Anthony Pasquale Holsten	855adb47ed	alicloud: simplify validators (#12982 )	9 years ago
clint shryock	61355c33c5	testing: Add option to run only a plan on a TestStep configuration	9 years ago
James Nugent	9476fc4418	helper/acctest: Add NewSSHKeyPair function (#12894 ) Many cloud services prevent duplicate key pairs with different names. Among them are Digital Ocean, Joyent Triton and Packet. Consequently, if tests leave dangling resources it is not enough to simply randomise the name, the entire key material must be regenerated. This commit adds a helper method that returns a new randomly generated key pair, where the public key material is formatted in OpenSSH "authorized keys" format, and the private key material is PEM encoded.	9 years ago
James Bardin	efd0f5b0db	Fix logic when skipping schema input The Required\|\|Optional logic in schemaMap.Input was incorrect, causing it to always request input. Fix the logic, and the associated tests which were passing "just because".	9 years ago
Mitchell Hashimoto	df8529719c	command/init: backend-config accepts key=value pairs This augments backend-config to also accept key=value pairs. This should make Terraform easier to script rather than having to generate a JSON file. You must still specify the backend type as a minimal amount in configurations, example: ``` terraform { backend "consul" {} } ``` This is required because Terraform needs to be able to detect the _absense_ of that value for unsetting, if that is necessary at some point.	9 years ago
Radek Simko	1df1c21d5b	schema: Allow *Resource as Elem of TypeMap in validation (#12722 )	9 years ago
Radek Simko	afd34f79df	schema: Enable map value validation (#12638 )	9 years ago
Clint	3fdeacdca7	helper/schema: Rename Timeout resource block to Timeouts (#12533 ) helper/schema: Rename Timeout resource block to Timeouts - Pluralize configuration argument name to better represent that there is one block for many timeouts - use a const for the configuration timeouts key - update docs	9 years ago
James Bardin	ecb1944c31	Merge pull request #12498 from hashicorp/jbardin/test-reset Add schema.Provider.TestReset to reset StopContext between tests	9 years ago
James Bardin	5238f51dc7	move TestReset mock from terraform to helper the terraform package doesn't know about TestProvider, so don't put the hooks in terraform.MockResourceProvider. Wrap the mock in the test where we need to check the TestProvider functionality.	9 years ago
James Bardin	6fcb55d09e	reword TestProvider doc	9 years ago
James Bardin	4b2e96b2e2	test for TestReset and fixed resource factories	9 years ago
James Bardin	1eb9a2d083	Reset ResourceProviders Call all ResourceProviderFactories and reset the providers before tests. Store the provider and/or the error in a fixed factory function to be returned again later.	9 years ago
James Bardin	1d9d7be28c	Add schema.Provider.TestReset method Provider.TestReset resets the internal state of the Provider at the start of a test. This also adds a MetaReset function field to schema.Provider, which is called by TestReset and can be used to reset any other tsated stored in the provider metadata. This is currently used to reset the internal Context returned by StopContext between tests, and should be implemented by a provider if it stores a Context from a previous test.	9 years ago
clint shryock	aa3677cd89	helper/schema: Guard against a panic if Timeout is not properly structured	9 years ago
Clint	2fe5976aec	helper/schema: Add configurable Timeouts (#12311 ) * helper/schema: Add custom Timeout block for resources * refactor DefaultTimeout to suuport multiple types. Load meta in Refresh from Instance State * update vpc but it probably wont last anyway * refactor test into table test for more cases * rename constant keys * refactor configdecode * remove VPC demo * remove comments * remove more comments * refactor some * rename timeKeys to timeoutKeys * remove note * documentation/resources: Document the Timeout block * document timeouts * have a test case that covers 'hours' * restore a System default timeout of 20 minutes, instead of 0 * restore system default timeout of 20 minutes, refactor tests, add test method to handle system default * rename timeout key constants * test applying timeout to state * refactor test * Add resource Diff test * clarify docs * update to use constants	9 years ago
Mitchell Hashimoto	3342aa580c	terraform: InstanceState.Meta is value type interface{} This changes the type of values in Meta for InstanceState to `interface{}`. They were `string` before. This will allow richer structures to be persisted to this without flatmapping them (down with flatmap!). The documentation clearly states that only primitives/collections are allowed here. The only thing using this was helper/schema for schema versioning. Appropriate type checking was added to make this change safe. The timeout work @catsby is doing will use this for a richer structure.	9 years ago
Mitchell Hashimoto	c6d0333dc0	flatmap: mark computed list as a computed value in Expand Fixes #12183 The fix is in flatmap for this but the entire issue is a bit more complex. Given a schema with a computed set, if you reference it like this: lookup(attr[0], "field") And "attr" contains a computed set within it, it would panic even though "field" is available. There were a couple avenues I could've taken to fix this: 1.) Any complex value containing any unknown value at any point is entirely unknown. 2.) Only the specific part of the complex value is unknown. I took route 2 so that the above works without any computed (since "name" is not computed but something else is). This may actually have an effect on other parts of Terraform configs, however those similar configs would've simply crashed previously so it shouldn't break any pre-existing configs.	9 years ago
Mitchell Hashimoto	2124135287	helper/slowmessage	9 years ago

1 2 3 4 5 ...

698 Commits (551eedcf2616376b00d7da170b09f682bbfa3445)