602 Commits (551eedcf2616376b00d7da170b09f682bbfa3445)

Author	SHA1	Message	Date
Mitchell Hashimoto	3665fea2db	config: validate that data sources don't have provisioners	10 years ago
Mitchell Hashimoto	9cc52d83de	config: test that null characters show up as errors in parse	10 years ago
Martin Atkins	399542a168	core: allow outputs to have descriptions (#9722) ... We allow variables to have descriptions specified, as additional context for a module user as to what should be provided for a given variable. We previously lacked a similar mechanism for outputs. Since they too are part of a module's public interface, it makes sense to be able to add descriptions for these for symmetry's sake. This change makes a "description" attribute valid within an "output" configuration block and stores it within the configuration data structure, but doesn't yet do anything further with it. For now this is useful only for third-party tools that might parse a module's config to generate user documentation; later we could expose the descriptions as part of the "apply" output, but that is left for a separate change.	10 years ago
Mitchell Hashimoto	b3f80b9469	config: maintain slice index accounting for computed keys ... Fixes #10075 Fixes #10013 When interpolating, we were only maintaining the last known slice index. If you had sibling slices then you could lose your slice index when exiting the slice. The resulting behavior was that no some runs the computed key would be: "slice.0.attr" and on others would be "slice.attr", the latter being incorrect. We now maintain a list of slice indexes so that as we unnest, we properly restore the old value. Surprisingly unrelated to the graph but the shadow graph caught this which is great. :)	10 years ago
Mitchell Hashimoto	25d19ef3d0	Merge pull request #10080 from hashicorp/f-tf-version ... terraform: support version requirement in configuration	10 years ago
Mitchell Hashimoto	df34fa88ce	Merge pull request #10076 from hashicorp/f-depend-module ... terraform: depends_on can reference entire modules	10 years ago
Mitchell Hashimoto	e3a01ccfd8	Merge pull request #10072 from hashicorp/f-output-depends-on ... terraform: output nodes can have `depends_on`	10 years ago
Mitchell Hashimoto	15979435d6	config: update error string for new HIL merge	10 years ago
Mitchell Hashimoto	85d3439fa0	config: parse and validate terraform.required_version	10 years ago
Mitchell Hashimoto	576b61a21d	config: validate depends_on with module values	10 years ago
Mitchell Hashimoto	10426ba619	config: parse depends_on for outputs	10 years ago
Mitchell Hashimoto	5107c33119	command/import: load configurations and allow empty config dirs ... Fixes #7774 This modifies the `import` command to load configuration files from the pwd. This also augments the configuration loading section for the CLI to have a new option (default false, same as old behavior) to allow directories with no Terraform configurations. For import, we allow directories with no Terraform configurations so this option is set to true.	10 years ago
Mitchell Hashimoto	a8fbf3420c	config: clean up unused fucntions	10 years ago
Mitchell Hashimoto	2d656b484c	config: test that partial interpolation in a list works properly	10 years ago
Mitchell Hashimoto	b979d8927e	config: use ast.TypeUnknown and don't remove computed values	10 years ago
Mitchell Hashimoto	260fb81373	Merge pull request #9795 from hashicorp/b-formatlist-empty ... config: formatlist accepts an empty list	10 years ago
Mitchell Hashimoto	29287937e3	Merge pull request #9818 from hashicorp/b-var-parse ... config: manually parse variable blocks for better validation	10 years ago
Mitchell Hashimoto	ef3148bbfa	config: validate that outputs have a name	10 years ago
Mitchell Hashimoto	f054c5ca2c	config: manually parse variable blocks for better validation ... Fixes #7846 This changes from using the HCL decoder to manually decoding the `variable` blocks within the configuration. This gives us a lot more power to catch validation errors. This PR retains the same tests and fixes one additional issue (covered by a test) in the case where a variable has no named assigned.	10 years ago
Mitchell Hashimoto	d69b6257df	config: formatlist accepts an empty list ... Fixes #7607 An empty list is a valid value for formatlist which means to just return an empty list as a result. The logic was somewhat convoluted here so I cleaned that up a bit too. The function overall can definitely be cleaned up a lot more but I left it mostly as-is to fix the bug.	10 years ago
Raphael Randschau	e97785c899	terraform/core: typo in RawConfig documentation (#9714)	10 years ago
Jesse Szwedko	0fbd72a355	Add some basic math interpolation functions ... Support the following math functions for interpolation: * ceil * floor * max * min Fixes #7409	10 years ago
James Nugent	47bce79b29	core: Add zipmap interpolation function ... This commit adds a new interpolation function, zipmap, which produces a map given a list of string keys and a list of values of the same length as the list of keys. The name comes from the same operation in Clojure (and likely other functional langauges).	10 years ago
Gustavo	5910e3b8af	Adds ‘tittle’ built-in function. (#9087) ... The tittle function returns a copy of the string with the first characters of all the words capitalized.	10 years ago
Mitchell Hashimoto	694b16de5d	config: ignore_changes cannot have interpolations ... This is the limitation of all lifecycle attributes currently. Right now, interpolations are allowed through and the user ends up thinking it should work. We should give an error. In the future it should be possible to support some minimal set of interpolations (static variables, data sources even perhaps) but for now let's validate that this doesn't work.	10 years ago
Mitchell Hashimoto	fee0351c66	config: RawConfig merge should only set unknown keys non-nil if ... non-empty	10 years ago
Mitchell Hashimoto	5cd6898109	config: fix a conflicting test name ... A public API TestNewRawConfig was added to easily create a raw config for testing, but this conflicted with the test. Just rename it.	10 years ago
Mitchell Hashimoto	dfa02e4412	terraform: rename attach config to only attach provider config	10 years ago
Mitchell Hashimoto	55ef966b88	config/module: tree.Child on a nil tree works	10 years ago
Mitchell Hashimoto	0fe51b334c	Merge pull request #9334 from hashicorp/f-shadow-graph ... terraform: Shadow Graph	10 years ago
Mitchell Hashimoto	30596ca371	terraform: sanity test (passes, always passed)	10 years ago
Mitchell Hashimoto	098225dc0d	config/module: use the raw source as part of the key ... This changes the key for the storage to be the _raw_ source from the module, not the fully expanded source. Example: it'll be a relative path instead of an absolute path. This allows the ".terraform/modules" directory to be portable when moving to other machines. This was a behavior that existed in <= 0.7.2 and was broken with #8398. This amends that and adds a test to verify.	10 years ago
Mitchell Hashimoto	37c880c377	Update reflectwalk to fix failing tests ... As part of working on ResourceConfig.DeepCopy, Equal I updated reflectwalk (to fix some issues in the new functions) but this introduced more issues in other parts of Terraform. This update fixes those.	10 years ago
James Bardin	e2b6ccad8a	Failing test for GH-8820	10 years ago
Mitchell Hashimoto	609219fc65	command/meta: validate config immediately ... * config: test for validating multi-vars (passes) * command/plan: test invalid run * command/meta: validate module on load	10 years ago
James Bardin	94674fe93c	Add a test load of a data source with count	10 years ago
James Bardin	a3fc7e2e21	remove "count" while loading a data source ... Data sources should be able to support counts like a resource. We need to remove "count" when we load the config because the key doesn't exist in the schema, and the resource won't validate.	10 years ago
Sander van Harmelen	47dd1ad153	Add wildcard (match all) support to ignore_changes (#8599)	10 years ago
James Bardin	14138fc449	Add test for RawMap ... Ensure that RawMap() returns an identical copy, and not a reference to the original map.	10 years ago
James Bardin	632c16c212	Fix inconsistent results with self interpolation ... Due to a race in interpolateForce(), a reference to self could return inconsistent results.	10 years ago
Mitchell Hashimoto	706b2e2aea	Merge pull request #8482 from hashicorp/b-output-dup ... config: variable names and outputs must be unique	10 years ago
Mitchell Hashimoto	0fceeaaeb0	config: test for var uniqueness in overrides	10 years ago
Mitchell Hashimoto	4e7f2dd01e	Merge pull request #8398 from hashicorp/b-module-collide ... config/module: use source as part of key	10 years ago
Mitchell Hashimoto	8a3559560d	config: JSON resource keys with only one item load properly GH-5140 ... When a resource has only a single key set, the HCL parser treats that key as part of the overall set of object keys. This isn't valid since we expect resources to have exactly two keys. In this scenario, we have to "unwrap" the keys back into a set of objects.	10 years ago
Mitchell Hashimoto	fbf06e2a59	config: vars must be unique	10 years ago
Mitchell Hashimoto	099293b690	config: outputs must be unique	10 years ago
Mitchell Hashimoto	92336281a5	config/module: use source as part of key	10 years ago
Mitchell Hashimoto	f4faf2274b	config: count can't be a SimpleVariable	10 years ago
James Bardin	81bb6b7264	Merge pull request #7905 from hashicorp/jbardin/merge ... core: Add merge interpolation function	10 years ago
James Bardin	39bbbb8da6	Add merge interpolation function ... Add a `merge` interpolation function, which merges any number of maps. Duplicate keys are OK, with the last write winning.	10 years ago
James Bardin	1af7ee87a2	Silence log output when not verbose ... Set the default log package output to iotuil.Discard during tests if the `-v` flag isn't set. If we are verbose, then apply the filter according to the TF_LOG env variable.	10 years ago
James Bardin	c9e1522103	Use HIL to limit concat to ast.TypeList ... we can remove some type checks in the concat function	10 years ago
James Bardin	c15c0eb0cb	Disallow strings as arguments to concat ... The concat interpolation function now only accepts list arguments. Strings are no longer supported, for concatenation or appending to lists. All arguments must be a list, and single elements can be promoted with the `list` interpolation function.	10 years ago
James Nugent	796ce7bdd7	build: Opt-in to building rather than opt-out	10 years ago
James Nugent	b2d5b66508	Merge pull request #7880 from hashicorp/b-fix-freebsd ... build: Fix errors in FreeBSD build	10 years ago
James Nugent	2eb00c9184	build: Fix errors in FreeBSD build ... Fixes the following error when cross compiling: ``` --> freebsd/amd64 error: exit status 2 Stderr: # github.com/hashicorp/terraform/config/module config/module/inode.go:18: cannot use st.Ino (type uint32) as type uint64 in return argument ```	10 years ago
James Bardin	5802f76eaa	Make all terraform package tests pass under -race ... This isn't a pretty refactor, but fixes the race issues in this package for now. Fix race on RawConfig.Config() fix command package races	10 years ago
Paul Hinze	88030764ff	config: Audit all interpolation functions for list/map behavior ... - `distinct()` - error on non-flat lists - `element()` - error on non-flat lists - `join()` - error on non-flat lists - `length()` - support maps - `lookup()` - error on non-flat maps - `values()` - error on non-flat maps	10 years ago
Paul Hinze	1425b34562	config: Add map() interpolation function ... * `map(key, value, ...)` - Returns a map consisting of the key/value pairs specified as arguments. Every odd argument must be a string key, and every even argument must have the same type as the other values specified. Duplicate keys are not allowed. Examples: * `map("hello", "world")` * `map("us-east", list("a", "b", "c"), "us-west", list("b", "c", "d"))`	10 years ago
James Bardin	8dcbc0b0a0	Add concat to accept lists of lists and maps ... This will allow the concat interpolation function to accept lists of lists, and lists of maps as well as strings. We still allow bare strings for backwards compatibility, but remove some of the old comment wording as it could cause confusion of this function with actual string concatenation. Since maps are now supported in the config, this removes the superfluous (and failing) TestInterpolationFuncConcatListOfMaps.	10 years ago
James Bardin	2bd7cfd5fe	Expand list interpolation to lists and maps ... Allow lists and maps within the list interpolation function via variable interpolation. Since this requires setting the variadic type to TypeAny, we check for non-heterogeneous lists in the callback.	10 years ago
James Nugent	58dd41f3b1	core: Add list() interpolation function ... The list() interpolation function provides a way to add support for list literals (of strings) to HIL without having to invent new syntax for it and modify the HIL parser. It presents as a function, thus: - list() -> [] - list("a") -> ["a"] - list("a", "b") -> ["a", "b"] Thanks to @wr0ngway for the idea of this approach, fixes #7460.	10 years ago
James Nugent	c6e03cba96	core: Fix slice element keys on interpolateWalk ... Part of the interpolation walk is to detect keys which involve computed values and therefore cannot be resolved at this time. The interplation walker keeps sufficient state to be able to populate the ResourceConfig with a slice of such keys. Previously they didn't take slice indexes into account, so in the following case: ``` "services": []interface{}{ map[string]interface{}{ "elb": "___something computed___", }, map[string]interface{}{ "elb": "___something else computed___", }, map[string]interface{}{ "elb": "not computed", }, } ``` Unknown keys would be populated as follows: ``` services.elb services.elb ``` This is not sufficient information to be useful, as it is impossible to distinguish which of the `services.elb`s are unknown vs not. This commit therefore retains the slice indexes as part of the key for unknown keys - producing for the example above: ``` services.0.elb services.1.elb ```	10 years ago
James Bardin	e78dc291af	Add test to ensure key/values interp order ... Test that interpolated values are returned in the order of the sorted keys.	10 years ago
James Nugent	8284b79957	Merge pull request #7298 from hashicorp/jbardin/GH-7273-fixup ... code: Add proper build constraints for GH-7273	10 years ago
James Nugent	8403a465bc	core: Add test and fix for element with empty list ... The incldued test previously caused a panic, it now returns an error message explaining the issue.	10 years ago
James Bardin	525485c213	Add proper build constraints for GH-7273 ... The syscall.Stat_t type doesn't exist on windows, so the inode lookup needs to be in a file with proper build constraints.	10 years ago
James Bardin	558e023e26	Don't try to copy files over themselves ... When copying a config module, make sure the full path for src and dst files don't match, and also check the inode in case we resolved a different path to the same file. Make a note about the unsafe usage of reusing a tempDir path.	10 years ago
James Nugent	9d6c629689	config: Update test to reflect new behaviour ... Escaped quotes are no longer supported as HIL syntax (as of the last update to HIL), so this commit changes the Terraform config-layer test to verify the non-presence of this behaviour for 0.7.	10 years ago
James Nugent	4b6a632246	core: Rename uniq -> distinct and add docs	10 years ago
Jan Schumann	df3e017f6c	fix #7106	10 years ago
Paul Hinze	9bc980f569	core: Fix panic on concat() w/ list of nonprimitives ... The `concat()` interpolation function does not yet support types other than strings / lists of strings. Make it an error message instead of a panic when a list of non-primitives is supplied. Fixes the panic in #7030	10 years ago
Paul Hinze	ffa29090ec	core: Better error for dot indexing on user vars ... Dot indexing worked in the "regexps and strings" world of 0.6.x, but it no longer works on the 0.7 series w/ proper List / Map types. There is plenty of dot-indexed config out in the wild, so we need to do what we can to point users to the new syntax. Here is one place we can do it for user variables (`var.somemap`). We'll also need to address Resource Variables and Module Variables in a separate PR. This fixes the panic in #7103 - a proper error message is now returned.	10 years ago
James Nugent	01cd596c60	core: Fix detection of empty list/map defaults ... This commit changes config parsing from weak decoding lists and maps into []string and map[string]string respectively to decode into []interface{} and map[string]interface{} respectively. This is in order to take advantage of the work integrated in #7082 to defeat the backward compatibility features of the mapstructure library. Test coverage of loading empty variables and validating their default types against expectation.	10 years ago
James Nugent	578ff9569e	core: Add sort() interpolation function	10 years ago
James Nugent	cb9ef298f3	core: Defeat backward compatibilty in mapstructure ... The mapstructure library has a regrettable backward compatibility concern whereby a WeakDecode of []interface{}{} into a target of map[string]interface{} yields an empty map rather than an error. One possibility is to switch to using Decode instead of WeakDecode, but this loses the nice handling of type conversion, requiring a large volume of code to be added to Terraform or HIL in order to retain that behaviour. Instead we add a DecodeHook to our usage of the mapstructure library which checks for decoding []interface{}{} or []string{} into a map and returns an error instead. This has the effect of defeating the code added to retain backwards compatibility in mapstructure, giving us the correct (for our circumstances) behaviour of Decode for empty structures and the type conversion of WeakDecode. The code is identical to that in the HIL library, and packaged into a helper.	10 years ago
David Adams	b5d1279107	Allow specifying a default value to lookup() ... Fixes #4474, where lookup() calls fail out the entire interpolation when the provided key value is not found in the map. This will allow using coalesce() along with lookup() to greatly improve module flexibility.	10 years ago
David Glasser	594ea105d8	config: support lists and maps in jsonencode ... For now we only support lists and maps whose values are strings, not deeply nested data.	10 years ago
Martin Atkins	60c24e3319	command: Prevent data resources from being tainted ... Since the data resource lifecycle contains no steps to deal with tainted instances, we must make sure that they never get created. Doing this out in the command layer is not the best, but this is currently the only layer that has enough information to make this decision and so this simple solution was preferred over a more disruptive refactoring, under the assumption that this taint functionality eventually gets reworked in terms of StateFilter anyway.	10 years ago
Martin Atkins	718cdda77b	config: Parsing of data.TYPE.NAME.FIELD variables ... This allows ${data.TYPE.NAME.FIELD} interpolation syntax at the configuration level, though since there is no special handling of them in the core package this currently just acts as an alias for ${TYPE.NAME.FIELD}.	10 years ago
Martin Atkins	860140074f	config: Data source loading ... This allows the config loader to read "data" blocks from the config and turn them into DataSource objects. This just reads the data from the config file. It doesn't validate the data nor do anything useful with it.	10 years ago
Martin Atkins	fc4fa10981	config: "ResourceMode" concept for resources ... Previously resources were assumed to always support the full set of create, read, update and delete operations, and Terraform's resource management lifecycle. Data sources introduce a new kind of resource that only supports the "read" operation. To support this, a new "Mode" field is added to the Resource concept within the config layer, which can be set to ManagedResourceMode (to indicate the only mode previously possible) or DataResourceMode (to indicate that only "read" is supported). To support both managed and data resources in the tests, the stringification of resources in config_string.go is adjusted slightly to use the Id() method rather than the unusual type[name] serialization from before, causing a simple mechanical adjustment to the loader tests' expected result strings.	10 years ago
Mitchell Hashimoto	27452f0043	terraform: Module option to Import to add module to graph	10 years ago
Mitchell Hashimoto	3c9a92e04a	command: Context buliding allows empty module trees	10 years ago
James Nugent	f1d0fc46aa	core: Fix go vet issues shown by Travis	10 years ago
James Nugent	244da895cd	core: Remove StringList ... Much celebration may now ensue! ♪┏(°.°)┛┗(°.°)┓┗(°.°)┛┏(°.°)┓ ♪	10 years ago
James Nugent	f49583d25a	core: support native list variables in config ... This commit adds support for native list variables and outputs, building up on the previous change to state. Interpolation functions now return native lists in preference to StringList. List variables are defined like this: variable "test" { # This can also be inferred type = "list" default = ["Hello", "World"] } output "test_out" { value = "${var.a_list}" } This results in the following state: ``` ... "outputs": { "test_out": [ "hello", "world" ] }, ... ``` And the result of terraform output is as follows: ``` $ terraform output test_out = [ hello world ] ``` Using the output name, an xargs-friendly representation is output: ``` $ terraform output test_out hello world ``` The output command also supports indexing into the list (with appropriate range checking and no wrapping): ``` $ terraform output test_out 1 world ``` Along with maps, list outputs from one module may be passed as variables into another, removing the need for the `join(",", var.list_as_string)` and `split(",", var.list_as_string)` which was previously necessary in Terraform configuration. This commit also updates the tests and implementations of built-in interpolation functions to take and return native lists where appropriate. A backwards compatibility note: previously the concat interpolation function was capable of concatenating either strings or lists. The strings use case was deprectated a long time ago but still remained. Because we cannot return `ast.TypeAny` from an interpolation function, this use case is no longer supported for strings - `concat` is only capable of concatenating lists. This should not be a huge issue - the type checker picks up incorrect parameters, and the native HIL string concatenation - or the `join` function - can be used to replicate the missing behaviour.	10 years ago
James Nugent	e57a399d71	core: Use native HIL maps instead of flatmaps ... This changes the representation of maps in the interpolator from the dotted flatmap form of a string variable named "var.variablename.key" per map element to use native HIL maps instead. This involves porting some of the interpolation functions in order to keep the tests green, and adding support for map outputs. There is one backwards incompatibility: as a result of an implementation detail of maps, one could access an indexed map variable using the syntax "${var.variablename.key}". This is no longer possible - instead HIL native syntax - "${var.variablename["key"]}" must be used. This was previously documented, (though not heavily used) so it must be noted as a backward compatibility issue for Terraform 0.7.	10 years ago
James Nugent	b62f6af158	core: Add support for marking outputs as sensitive (#6559) ... * core: Add support for marking outputs as sensitive This commit allows an output to be marked "sensitive", in which case the value is redacted in the post-refresh and post-apply list of outputs. For example, the configuration: ``` variable "input" { default = "Hello world" } output "notsensitive" { value = "${var.input}" } output "sensitive" { sensitive = true value = "${var.input}" } ``` Would result in the output: ``` terraform apply Apply complete! Resources: 0 added, 0 changed, 0 destroyed. Outputs: notsensitive = Hello world sensitive = <sensitive> ``` The `terraform output` command continues to display the value as before. Limitations: Note that sensitivity is not tracked internally, so if the output is interpolated in another module into a resource, the value will be displayed. The value is still present in the state.	10 years ago
James Nugent	a0cc7115b3	deps: Update call sites of hil.Eval from update ... hil.Eval() now returns (hil.EvaluationResult, error) instead of (value, type, error). This commit updates the call sites, but retains all previous behaviour. Tests are also updated.	10 years ago
James Nugent	d7d39702c0	Type check variables between modules (#6185) ... These tests demonstrates a problem where the types to a module input are not checked. For example, if a module - inner - defines a variable "should_be_a_map" as a map, or with a default variable of map, we do not fail if the user sets the variable value in the outer module to a string value. This is also a problem in nested modules. The implementation changes add a type checking step into the graph evaluation process to ensure invalid types are not passed.	10 years ago
David Glasser	6cf06bb3ab	config: new interpolation function jsonencode	10 years ago
Paul Hinze	293c6ca68c	Revert "Revert "core: Add uuid() interpolate function."" ... This reverts commit 661be01d9b.	10 years ago
Paul Hinze	567a9b9e06	config: remove missing equals test to fix build ... This is behavior that's covered in the parser now - and the error message is nicer to boot!	10 years ago
James Nugent	87550b2b72	Merge pull request #5263 from uber/b-element-negative ... Error out on negative indices in element()	10 years ago
Paul Hinze	661be01d9b	Revert "core: Add uuid() interpolate function."	10 years ago
Paul Hinze	1e0b8ea478	core: Add uuid() interpolate function. ... Utilizes hashicorp's go-uuid library for proper random seeding setup.	10 years ago
Radek Simko	664ba5f5a6	config: Add new interpolation function - md5	10 years ago
Radek Simko	573d3bd7ab	config: Sort functions mapping alphabetically	10 years ago
Bill Fumerola	c0034e672b	Error out on negative indices in element()	10 years ago