139 Commits (551eedcf2616376b00d7da170b09f682bbfa3445)

Author	SHA1	Message	Date
Martin Atkins	76dca009e0	Allow escaped interpolation-like sequences in variable defaults ... The variable validator assumes that any AST node it gets from an interpolation walk is an indicator of an interpolation. Unfortunately, back in f223be15 we changed the interpolation walker to emit a LiteralNode as a way to signal that the result is a literal but not identical to the input due to escapes. The existence of this issue suggests a bit of a design smell in that the interpolation walker interface at first glance appears to skip over all literals, but it actually emits them in this one situation. In the long run we should perhaps think about whether the abstraction is right here, but this is a shallow, tactical change that fixes #13001.	9 years ago
James Bardin	8bcb9e19ca	restructure JSON terraform config block AST ... When configuration is read out of JSON, HCL assumes that empty levels of objects can be flattened, but this removes too much to decode into a config.Terraform struct. Reconstruct the appropriate AST to decode the config struct.	9 years ago
Mitchell Hashimoto	f7da5d323c	config: test that JSON loading terraform backend info works	9 years ago
James Bardin	3c41a7ca1e	Add test for Validate crash ... Crash during Validate walk with nested variable default.	9 years ago
Mitchell Hashimoto	6b4c007894	config: validate backend configuration can't contain interpolations	9 years ago
Mitchell Hashimoto	b6bfc4798d	config: Resource.Count should type check ... Fixes #11800 Type check the value of count so we don't panic on the conversion. I wondered "why didn't we do this before?" There is no excuse for NOT doing it at all but the reasoning was beacuse prior to the list/map work in 0.7, the value couldn't be anything other than a string since any primitive can turn into a string. Regardless, we should've always done this.	9 years ago
Mitchell Hashimoto	7b342100d0	config: add "backend" loading to the Terraform section	9 years ago
Mitchell Hashimoto	928fce71f7	config: parse "when" and "on_failure" on provisioners	9 years ago
Mitchell Hashimoto	8a102799c2	Merge pull request #10658 from hashicorp/b-var-keys ... config: validate invalid variable keys	10 years ago
Mitchell Hashimoto	3ba9720b3e	config: validate invalid variable keys ... Fixes #9416 A simple change to verify that only valid keys for `variable` blocks are used.	10 years ago
Mitchell Hashimoto	5d684b399c	config: error when loading multiple lifecycle blocks ... Fixes #8776 This introduces an error when multiple `lifecycle` blocks exist on a resource in the configuration.	10 years ago
Mitchell Hashimoto	6b458160b9	config: disallow names starting with ints ... Fixes #10597 This disallows any names for variables, modules, etc. starting with ints. This causes parse errors with the new HIL parser and actually causes long term ambiguities if we allow this. I've also updated the upgrade guide to note this as a backwards compatibility and how people can fix this going forward.	10 years ago
Mitchell Hashimoto	3665fea2db	config: validate that data sources don't have provisioners	10 years ago
Mitchell Hashimoto	9cc52d83de	config: test that null characters show up as errors in parse	10 years ago
Martin Atkins	399542a168	core: allow outputs to have descriptions (#9722) ... We allow variables to have descriptions specified, as additional context for a module user as to what should be provided for a given variable. We previously lacked a similar mechanism for outputs. Since they too are part of a module's public interface, it makes sense to be able to add descriptions for these for symmetry's sake. This change makes a "description" attribute valid within an "output" configuration block and stores it within the configuration data structure, but doesn't yet do anything further with it. For now this is useful only for third-party tools that might parse a module's config to generate user documentation; later we could expose the descriptions as part of the "apply" output, but that is left for a separate change.	10 years ago
Mitchell Hashimoto	25d19ef3d0	Merge pull request #10080 from hashicorp/f-tf-version ... terraform: support version requirement in configuration	10 years ago
Mitchell Hashimoto	df34fa88ce	Merge pull request #10076 from hashicorp/f-depend-module ... terraform: depends_on can reference entire modules	10 years ago
Mitchell Hashimoto	85d3439fa0	config: parse and validate terraform.required_version	10 years ago
Mitchell Hashimoto	576b61a21d	config: validate depends_on with module values	10 years ago
Mitchell Hashimoto	10426ba619	config: parse depends_on for outputs	10 years ago
Mitchell Hashimoto	29287937e3	Merge pull request #9818 from hashicorp/b-var-parse ... config: manually parse variable blocks for better validation	10 years ago
Mitchell Hashimoto	ef3148bbfa	config: validate that outputs have a name	10 years ago
Mitchell Hashimoto	f054c5ca2c	config: manually parse variable blocks for better validation ... Fixes #7846 This changes from using the HCL decoder to manually decoding the `variable` blocks within the configuration. This gives us a lot more power to catch validation errors. This PR retains the same tests and fixes one additional issue (covered by a test) in the case where a variable has no named assigned.	10 years ago
Mitchell Hashimoto	694b16de5d	config: ignore_changes cannot have interpolations ... This is the limitation of all lifecycle attributes currently. Right now, interpolations are allowed through and the user ends up thinking it should work. We should give an error. In the future it should be possible to support some minimal set of interpolations (static variables, data sources even perhaps) but for now let's validate that this doesn't work.	10 years ago
Mitchell Hashimoto	609219fc65	command/meta: validate config immediately ... * config: test for validating multi-vars (passes) * command/plan: test invalid run * command/meta: validate module on load	10 years ago
James Bardin	94674fe93c	Add a test load of a data source with count	10 years ago
Sander van Harmelen	47dd1ad153	Add wildcard (match all) support to ignore_changes (#8599)	10 years ago
Mitchell Hashimoto	706b2e2aea	Merge pull request #8482 from hashicorp/b-output-dup ... config: variable names and outputs must be unique	10 years ago
Mitchell Hashimoto	0fceeaaeb0	config: test for var uniqueness in overrides	10 years ago
Mitchell Hashimoto	8a3559560d	config: JSON resource keys with only one item load properly GH-5140 ... When a resource has only a single key set, the HCL parser treats that key as part of the overall set of object keys. This isn't valid since we expect resources to have exactly two keys. In this scenario, we have to "unwrap" the keys back into a set of objects.	10 years ago
Mitchell Hashimoto	fbf06e2a59	config: vars must be unique	10 years ago
Mitchell Hashimoto	099293b690	config: outputs must be unique	10 years ago
Mitchell Hashimoto	f4faf2274b	config: count can't be a SimpleVariable	10 years ago
Paul Hinze	ffa29090ec	core: Better error for dot indexing on user vars ... Dot indexing worked in the "regexps and strings" world of 0.6.x, but it no longer works on the 0.7 series w/ proper List / Map types. There is plenty of dot-indexed config out in the wild, so we need to do what we can to point users to the new syntax. Here is one place we can do it for user variables (`var.somemap`). We'll also need to address Resource Variables and Module Variables in a separate PR. This fixes the panic in #7103 - a proper error message is now returned.	10 years ago
James Nugent	01cd596c60	core: Fix detection of empty list/map defaults ... This commit changes config parsing from weak decoding lists and maps into []string and map[string]string respectively to decode into []interface{} and map[string]interface{} respectively. This is in order to take advantage of the work integrated in #7082 to defeat the backward compatibility features of the mapstructure library. Test coverage of loading empty variables and validating their default types against expectation.	10 years ago
Martin Atkins	860140074f	config: Data source loading ... This allows the config loader to read "data" blocks from the config and turn them into DataSource objects. This just reads the data from the config file. It doesn't validate the data nor do anything useful with it.	10 years ago
James Nugent	f49583d25a	core: support native list variables in config ... This commit adds support for native list variables and outputs, building up on the previous change to state. Interpolation functions now return native lists in preference to StringList. List variables are defined like this: variable "test" { # This can also be inferred type = "list" default = ["Hello", "World"] } output "test_out" { value = "${var.a_list}" } This results in the following state: ``` ... "outputs": { "test_out": [ "hello", "world" ] }, ... ``` And the result of terraform output is as follows: ``` $ terraform output test_out = [ hello world ] ``` Using the output name, an xargs-friendly representation is output: ``` $ terraform output test_out hello world ``` The output command also supports indexing into the list (with appropriate range checking and no wrapping): ``` $ terraform output test_out 1 world ``` Along with maps, list outputs from one module may be passed as variables into another, removing the need for the `join(",", var.list_as_string)` and `split(",", var.list_as_string)` which was previously necessary in Terraform configuration. This commit also updates the tests and implementations of built-in interpolation functions to take and return native lists where appropriate. A backwards compatibility note: previously the concat interpolation function was capable of concatenating either strings or lists. The strings use case was deprectated a long time ago but still remained. Because we cannot return `ast.TypeAny` from an interpolation function, this use case is no longer supported for strings - `concat` is only capable of concatenating lists. This should not be a huge issue - the type checker picks up incorrect parameters, and the native HIL string concatenation - or the `join` function - can be used to replicate the missing behaviour.	10 years ago
Paul Hinze	567a9b9e06	config: remove missing equals test to fix build ... This is behavior that's covered in the parser now - and the error message is nicer to boot!	10 years ago
Paul Hinze	3f72837f4b	core: Make copies when creating destroy nodes ... Fixes an interpolation race that was occurring when a tainted destroy node and a primary destroy node both tried to interpolate a computed count in their config. Since they were sharing a pointer to the _same_ config, depending on how the race played out one of them could catch the config uninterpolated and would then throw a syntax error. The `Copy()` tree implemented for this fix can probably be used elsewhere - basically we should copy the config whenever we drop nodes into the graph - but for now I'm just applying it to the place that fixes this bug. Fixes #4982 - Includes a test covering that race condition.	10 years ago
James Nugent	cb6cb8b96a	core: Support explicit variable type declaration ... This commit adds support for declaring variable types in Terraform configuration. Historically, the type has been inferred from the default value, defaulting to string if no default was supplied. This has caused users to devise workarounds if they wanted to declare a map but provide values from a .tfvars file (for example). The new syntax adds the "type" key to variable blocks: ``` variable "i_am_a_string" { type = "string" } variable "i_am_a_map" { type = "map" } ``` This commit does _not_ extend the type system to include bools, integers or floats - the only two types available are maps and strings. Validation is performed if a default value is provided in order to ensure that the default value type matches the declared type. In the case that a type is not declared, the old logic is used for determining the type. This allows backwards compatiblity with previous Terraform configuration.	10 years ago
Paul Hinze	87a9701f91	config: validation error when output is missing value field ... Also lists out invalid keys in errmsg when they are present Closes #4398	10 years ago
Mitchell Hashimoto	99fbb91ba2	config: validate lifecycle keys [GH-4413]	10 years ago
Paul Hinze	b6626eed57	config: friendlier error message on resource arity mismatch ... closes #2072	11 years ago
James Nugent	5ea25363a1	Add regression test for #4069 ... This may be brittle as it makes use of .gitattributes to override the autocrlf setting in order to have an input file with Windows line endings across multiple platforms.	11 years ago
Paul Hinze	d90eb2d88e	config: test replicating #4079 ... Should help cover terraform against regression once https://github.com/hashicorp/hcl/pull/70 lands.	11 years ago
James Nugent	7f5f8d300d	Add failing test replicating #4065	11 years ago
Paul Hinze	afb5136ac2	Merge pull request #3986 from hashicorp/phinze/hcl-escaped-quotes ... config: test covering escaped quotes syntax error	11 years ago
Paul Hinze	15e7927009	config: test covering escaped quotes syntax error ... This was never intended to be valid syntax, but it worked in the old HCL parser, and we've found a decent number of examples of it in the wild. Fixed in https://github.com/hashicorp/hcl/pull/62 and we'll keep this test in Terraform to cover the behavior.	11 years ago
James Nugent	6ae3218f8a	Add failing tests for JSON configuration parsing ... Reproduces the issue reported by @svanharmelen in #3964.	11 years ago
James Nugent	f4164b5322	Add resource with heredoc to config load tests ... This test reproduces the issue which is likely the root cause of #3840. Test is currently failing with an "illegal character" message corresponding with the location of the heredoc, which is also seen in various acceptance tests for providers.	11 years ago