terraform

Commit Graph

Author	SHA1	Message	Date
James Bardin	a111635908	Fix panic in interpolate_walk Verify that we have enough containers in the stack to look for a map in replaceCurrent.	9 years ago
Mitchell Hashimoto	b3f80b9469	config: maintain slice index accounting for computed keys Fixes #10075 Fixes #10013 When interpolating, we were only maintaining the last known slice index. If you had sibling slices then you could lose your slice index when exiting the slice. The resulting behavior was that no some runs the computed key would be: "slice.0.attr" and on others would be "slice.attr", the latter being incorrect. We now maintain a list of slice indexes so that as we unnest, we properly restore the old value. Surprisingly unrelated to the graph but the shadow graph caught this which is great. :)	10 years ago
Mitchell Hashimoto	a8fbf3420c	config: clean up unused fucntions	10 years ago
Mitchell Hashimoto	b979d8927e	config: use ast.TypeUnknown and don't remove computed values	10 years ago
James Nugent	c6e03cba96	core: Fix slice element keys on interpolateWalk Part of the interpolation walk is to detect keys which involve computed values and therefore cannot be resolved at this time. The interplation walker keeps sufficient state to be able to populate the ResourceConfig with a slice of such keys. Previously they didn't take slice indexes into account, so in the following case: ``` "services": []interface{}{ map[string]interface{}{ "elb": "___something computed___", }, map[string]interface{}{ "elb": "___something else computed___", }, map[string]interface{}{ "elb": "not computed", }, } ``` Unknown keys would be populated as follows: ``` services.elb services.elb ``` This is not sufficient information to be useful, as it is impossible to distinguish which of the `services.elb`s are unknown vs not. This commit therefore retains the slice indexes as part of the key for unknown keys - producing for the example above: ``` services.0.elb services.1.elb ```	10 years ago
James Nugent	f49583d25a	core: support native list variables in config This commit adds support for native list variables and outputs, building up on the previous change to state. Interpolation functions now return native lists in preference to StringList. List variables are defined like this: variable "test" { # This can also be inferred type = "list" default = ["Hello", "World"] } output "test_out" { value = "${var.a_list}" } This results in the following state: ``` ... "outputs": { "test_out": [ "hello", "world" ] }, ... ``` And the result of terraform output is as follows: ``` $ terraform output test_out = [ hello world ] ``` Using the output name, an xargs-friendly representation is output: ``` $ terraform output test_out hello world ``` The output command also supports indexing into the list (with appropriate range checking and no wrapping): ``` $ terraform output test_out 1 world ``` Along with maps, list outputs from one module may be passed as variables into another, removing the need for the `join(",", var.list_as_string)` and `split(",", var.list_as_string)` which was previously necessary in Terraform configuration. This commit also updates the tests and implementations of built-in interpolation functions to take and return native lists where appropriate. A backwards compatibility note: previously the concat interpolation function was capable of concatenating either strings or lists. The strings use case was deprectated a long time ago but still remained. Because we cannot return `ast.TypeAny` from an interpolation function, this use case is no longer supported for strings - `concat` is only capable of concatenating lists. This should not be a huge issue - the type checker picks up incorrect parameters, and the native HIL string concatenation - or the `join` function - can be used to replicate the missing behaviour.	10 years ago
James Nugent	e57a399d71	core: Use native HIL maps instead of flatmaps This changes the representation of maps in the interpolator from the dotted flatmap form of a string variable named "var.variablename.key" per map element to use native HIL maps instead. This involves porting some of the interpolation functions in order to keep the tests green, and adding support for map outputs. There is one backwards incompatibility: as a result of an implementation detail of maps, one could access an indexed map variable using the syntax "${var.variablename.key}". This is no longer possible - instead HIL native syntax - "${var.variablename["key"]}" must be used. This was previously documented, (though not heavily used) so it must be noted as a backward compatibility issue for Terraform 0.7.	10 years ago
Mitchell Hashimoto	5f3de02fa9	remove config/lang, use hashicorp/hil	10 years ago
Mitchell Hashimoto	f223be15cd	config: eval HEL as long as the result changes [GH-2909]	10 years ago
Paul Hinze	e88aeede9b	core: allow distinguishing between empty lists and strings Had to handle a lot of implicit leaning on a few properties of the old representation: * Old representation allowed plain strings to be treated as lists without problem (i.e. shoved into strings.Split), now strings need to be checked whether they are a list before they are treated as one (i.e. shoved into StringList(s).Slice()). * Tested behavior of 0 and 1 length lists in formatlist() was a side effect of the representation. Needs to be special cased now to maintain the behavior. * Found a pretty old context test failure that was wrong in several different ways. It's covered by TestContext2Apply_multiVar so I removed it.	11 years ago
Paul Hinze	10b3abf405	config: introduce StringList to abstract over list hack This is the initial pure "all tests passing without a diff" stage. The plan is to change the internal representation of StringList to include a suffix delimiter, which will allow us to recognize empty and single-element lists.	11 years ago
Josh Bleecher Snyder	a3f79cd790	config: fix minor comment errors	11 years ago
Mitchell Hashimoto	740c25d4ea	config: convert to config/lang	11 years ago
Luke Amdor	e970eea3cd	adding literal colon to interpolated regex	12 years ago
Mitchell Hashimoto	36f225dea0	fmt	12 years ago
Mitchell Hashimoto	1ebcedb22b	config: make the interp split pretty insane	12 years ago
Mitchell Hashimoto	7b48924532	config: validate that multi-variables are only used in slices	12 years ago
Mitchell Hashimoto	a931707a6a	config: removeCurrent finds the proper map	12 years ago
Mitchell Hashimoto	c6424e9569	config: make the replace function marginally more understandable	12 years ago
Mitchell Hashimoto	22908d67ba	config: first pass at replacing lists within a slice	12 years ago
Mitchell Hashimoto	eac01c2ac8	config: replace interpolations in block keys [GH-234]	12 years ago
Mitchell Hashimoto	4a3dff2441	config: allow '/' in string args	12 years ago
Mitchell Hashimoto	742e33c672	config: accept file("test.txt") [GH-145]	12 years ago
Mitchell Hashimoto	625fb65526	config: make errors a bit nicer	12 years ago
Mitchell Hashimoto	4f57437144	config: parser fixes and application	12 years ago
Mitchell Hashimoto	7578fb8bdc	config: interpolationWalker detects functions	12 years ago
Mitchell Hashimoto	cabc007ec4	config: get rid of the variable*Walkers, replace with more generic	12 years ago
Mitchell Hashimoto	e8fe26488a	config: interpolationWalk seems to work	12 years ago
Mitchell Hashimoto	4c9e0f395c	config: basic interpolationWalker	12 years ago

29 Commits (551eedcf2616376b00d7da170b09f682bbfa3445)