130 Commits (534366d0ff96cce928bb17dbebe68bed28dcaf53)

Author	SHA1	Message	Date
Ashlee Boyer	534366d0ff	Adding test-link-rewrites workflow	3 years ago
Ashlee Boyer	e81c849617	Adding docs-content-check-legacy-links-format workflow	3 years ago
CJ Horton	25d8f26e41	Remove docs bundle from build workflow	3 years ago
Liam Cervante	6a1a9928a2	[equivalence tests] Use the latest equivalence testing version when executing equivalence tests. (#32659)	3 years ago
Liam Cervante	2325ec716c	Update Terraform equivalence tests to remove unneeded input. (#32288) ... * test * update equivalence testing framework version * Remove debugging statements * remove more debugging statements * s/liamcervante/hashicorp/g * remove and update deprecated set-output statements	3 years ago
Liam Cervante	37b88b33ce	Rollout equivalence testing during Terraform releases and builds (#31928) ... * add some basic equivalence tests and execute them in the build pipeline * remove old file, now unused * update terraform-equivalence-testing to v0.2.0 * add separate action * make sure to read from hashicorp repo * remove elevated github token where possible * Don't need elevated token anymore * update with official mock provider * last change: don't need the authorization header for public repositories.	3 years ago
Craig Wright	3b8e97c38c	Update CONTRIBUTING.md ... Removing the statement which does not reflect the current status for reviews of community-contributed pull requests.	3 years ago
Craig Wright	ae4a8ba77b	Fixing a bug introduced in the review process.	3 years ago
Craig Wright	1650bb9892	Merge pull request #31951 from hashicorp/docs-issue-form ... Add Documentation Issue form template	3 years ago
Craig Wright	d40b5c7755	Update .github/ISSUE_TEMPLATE/documentation_issue.yml ... Co-authored-by: Judith Malnick <judith.patudith@gmail.com>	3 years ago
Craig Wright	a8d6d5c913	Correcting a line break visual issue.	3 years ago
Craig Wright	b1c720a633	Update .github/ISSUE_TEMPLATE/documentation_issue.yml ... Thanks! Co-authored-by: Judith Malnick <judith.patudith@gmail.com>	3 years ago
Craig Wright	f058392421	Apply suggestions from code review ... Thanks! Co-authored-by: Judith Malnick <judith.patudith@gmail.com>	3 years ago
Liam Cervante	4d7ba14f72	Add skeleton action for equivalence tests (#31940)	3 years ago
Craig Wright	3afa9bd08e	Create documentation_issue.yml ... Closes https://github.com/hashicorp/terraform/issues/31552. Adds a new issue form type for documentation issues. Format discussed with docs team.	3 years ago
Alisdair McDiarmid	3ff89c9cec	Update pull_request_template.md	3 years ago
Alisdair McDiarmid	99fcb747e9	Revise markup to avoid unwanted checklist UI	3 years ago
Alisdair McDiarmid	6c75e54681	Add initial pull request template ... This is intended to add some structure to pull request descriptions, and encourage peer review of changelog entries before merging a PR.	3 years ago
Martin Atkins	d735de3656	build: checks.yml GitHub Actions workflow doesn't need goimports installed ... The importscheck script now uses "go run" to run this program and so the Go toolchain will install it automatically using the version number of golang.org/x/tools specified in our go.mod file.	4 years ago
Craig Wright	a63a2e3ec8	Minor copy fixes for the issue form title reminder text.	4 years ago
Craig Wright	9ca1b18988	Fixing placeholder values, adding usage note to bottom of the form.	4 years ago
Craig Wright	dc0f196cbb	Merge pull request #31651 from hashicorp/issue-forms ... Migrating from Markdown to Form style Github issues.	4 years ago
Craig Wright	95c133f2ec	Modifying the version input to use shell rendering. ... This simplifies entry for the user, no longer requiring markdown formatting wrappers.	4 years ago
Alvin Huang	634c875bea	set PRODUCT_VERSION for default docker build	4 years ago
Craig Wright	aba0ac0fae	Migrating from Markdown to Form style Github issues. ... The goal of this change is to simplify the process of filing issues with hashicorp/terraform. In the previous Markdown syntax, the instructions tended to get washed out in a sea of comment markers. The new Github Form Issues breaks each section into a form element, with instructions printed clearly as HTML in the page. We are further hoping to guide users to the correct repository when filing provider issues, or the community forums when asking usage questions.	4 years ago
Liam Cervante	afd273d636	Add goimports as a check to the Github commit actions (#31432) ... * Add goimports as a check to the Github commit actions * check diff against main instead of last commit * goimports should fix the problems * fix up conditionals and wildcard matching * specify origin/main in diff * fetch main branch when checkout * back to origin main	4 years ago
Martin Atkins	284a38a04c	build: Accept version numbers with prereleases containing dashes ... Previously we'd discard everything after the second dash.	4 years ago
Martin Atkins	096f0dc0da	build: Write the detected version number into the generated executable ... This also sets an additional variable if it detects that this is an alpha or development build, which currently does nothing but might eventually turn on the ability to use experimental features, if we make that something available only in prereleases.	4 years ago
Martin Atkins	7dd3cdfab4	build: Fetch all tags before deciding which version we're building ... The actions/checkout workflow does some heroics to try to fetch exactly the commit being built and nothing else, even if asked to fetch the history leading up to that commit. That means we don't end up having enough information to get an accurate answer from "git describe". Since we're intentionally relying on the git history here, we'll fetch all of the tags explicitly after initial checkout. Although that does add some delay to this step, we're intentionally doing this version calculation only once as a separate workflow job so that all of the other jobs can still benefit from this action's quicker checkout behavior.	4 years ago
James Bardin	2bd72914d8	add internal/states to the race detector tests ... This runs relatively quickly, and there is at least 1 test with concurrent operations.	4 years ago
Claire Labry	dd2decf921	change action to pull v1 instead of main	4 years ago
James Bardin	0693c8dfe7	enable the race detector in tests	4 years ago
Martin Atkins	5b615882e2	build: "Quick Checks" to run for external contributions ... The "push" event is only for pushes to branches within the same repository. Since external contributors make commits in their own repositories rather than directly in the target repository, we also need the pull_request event to react to opening a pull request and to pushing new code to an external branch associated with a pull request. Since internal pull requests would in principle trigger both "push" _and_ "pull_request", we also constrain the push event only to the branches we typically release from, on the assumption that all other branches will merge into those via pull requests. This avoids redundantly running the same checks in response to two events at the same time.	4 years ago
Martin Atkins	bbf540e0e3	build: "Quick Checks" caches protoc between runs ... Building our protobuf files requires the protoc tool, which takes a little while to download and install. Hopefully downloading it out of the GitHub Actions cache will make it a little faster in the common case where we're still using the same version as the previous run.	4 years ago
Martin Atkins	42a618f7c1	build: "Quick Checks" runs consistency checks concurrently with others ... Originally we had this running as part of the Unit Tests job because most of the checks are relatively fast. However, the addition of the protobuf generation check made that no longer be true because it needs to download and run protoc. With that extra overhead it now _is_ productive to spend the time booting and installing Go on third worker, as long as GitHub Actions continues to let us run all three of these jobs concurrently most of the time.	4 years ago
Martin Atkins	95f26b340b	build: "Quick Checks" no longer uses goenv ... goenv was making things more complicated than needed since it's really designed to help with interactive use in a shell more than automated use like this. Instead, we'll follow the same strategy that our build.yml was doing of just reading the .go-version file directly and then using the official actions/setup-go action to do the actual installation. The key advantage here is that Go ends up installed in a way where just running "go" will do the right thing, and we no longer need to fuss with shims and version-based path prefixes. Rather than duplicating the logic from build.yml, instead it's factored out into a separate composite action which both build.yml and checks.yml will now share, in case we want to change the Go version selection methodology in the future.	4 years ago
Martin Atkins	67fedd48a6	build: "Quick Checks" avoid repeating Install Go ... This factors out the "Install Go" step into a separate composite action which we can then call from both of the jobs that need it. We can't factor out the "Cache Go Modules" because GitHub doesn't allow composite actions to refer to other external actions.	4 years ago
Martin Atkins	9210ce6cdd	build: GitHub Actions "Quick Checks" workflow ... This is intended to eventually replace the CircleCI-based checks we use as part of the PR process in this repository. We're already using GitHub Actions for various other processes in this repository, so this change is motivated by consistency of having all of our automation running in the same system and written in the same language. This is not a complete replacement for our CircleCI workflow yet, and probably won't ever be because the CircleCI workflow contains some steps that are arguably redundant with other processes we follow elsewhere. However, the CircleCI workflow remains for now and won't be removed until we're satisfied that enough of it is replicated by this GitHub Actions workflow.	4 years ago
Laura Pacilio	2a3b0f9c1e	Merge pull request #30017 from RubyElders/internal-contributing-docs ... Update go test commands in .github/CONTRIBUTING.md.	4 years ago
Alisdair McDiarmid	636499830b	Add merged pull request reminder	4 years ago
Katy Moe	eaf748f24d	remove dependabot	4 years ago
Michele Degges	2f465e6047	Update packaging action name	4 years ago
Martin Atkins	4ec1feaa3d	build: CGO_ENABLED when building for macOS ... Normally when we cross-compile we do so without CGo, because we don't have suitable C headers available for systems other than the host. However, building for macOS on macOS is special because there are sufficient headers available on darwin_amd64 to build for both darwin_amd64 _and_ darwin_arm64. Also, we _must_ use CGo on macOS because the system resolver is only available via darwin's libc, and so building without CGo produces executables that don't resolve hostnames correctly. This is a conditional in bash to avoid having to duplicate the entire step. Perhaps later we'll find a more general version of this which can avoid the special case, but this is sufficient for the moment.	4 years ago
Martin Atkins	28a6036cf2	build: Separate Linux distro package builds into separate job ... In our build workflow we'll treat Linux distribution packaging (currently .deb and .rpm packages) as a separate job, instead of embedding it into the "build" job, so that this step can happen concurrently with the other derived actions like the docker image build, and the e2etest runs.	4 years ago
Martin Atkins	c1699ea80c	build: Constrain permissions for the "build" workflow steps ... This workflow only generates artifacts and doesn't need to modify anything about the repository.	4 years ago
Martin Atkins	3bf758eaf5	build: Consolidate build-darwin job into just "build" ... We can use an extra matrix dimension to select which execution environment we'll use for each GOOS/GOARCH pair, and thus avoid duplicating the job definition for darwin just to set runs-on: macos-latest for it. This is not really an intended use of a matrix dimension because it's directly related to the existing "goos" one, rather than being an independent third dimension, but it doesn't matter in practice because we're using the "include" option to specify exact combinations, and thus we're not relying on the built-in functionality to generate all possible matrix combinations.	4 years ago
Martin Atkins	218e55b23c	build: Build docs source package as part of the release pipeline ... This should eventually grow to be a step that actually verifies the validity of the docs source prior to publishing the artifact that a downstream publishing pipeline can consume, but for the moment it's really just a placeholder since we have no such validation step and no downstream pipeline consuming this artifact. The general idea here is that the artifacts from this workflow should be sufficient for all downstream release steps to occur without any direct access to the Terraform CLI repository, and so this is intended to eventually meet that ideal but as of this commit the website docs publishing step _does_ still depend on direct access to this repository.	4 years ago
Martin Atkins	b802db75d7	build: Build and run e2etest as part of the release build pipeline ... This uses the decoupled build and run strategy to run the e2etests so that we can arrange to run the tests against the real release packages produced elsewhere in this workflow, rather than ones generated just in time by the test harness. The modifications to make-archive.sh here make it more consistent with its originally-intended purpose of producing a harness for testing "real" release executables. Our earlier compromise of making it include its own terraform executable came from a desire to use that script as part of manual cross-platform testing when we weren't yet set up to support automation of those tests as we're doing here. That does mean, however, that the terraform-e2etest package content must be combined with content from a terraform release package in order to produce a valid contest for running the tests. We use a single job to cross-compile the test harness for all of the supported platforms, because that build is relatively fast and so not worth the overhead of matrix build, but then use a matrix build to actually run the tests so that we can run them in a worker matching the target platform. We currently have access only to amd64 (x64) runners in GitHub Actions and so for the moment this process is limited only to the subset of our supported platforms which use that architecture.	4 years ago
Martin Atkins	6704f8c795	Initial work on a new package build process ... For the moment this is just an experimental additional sidecar package build process, separate from the one we really use for releases, so that we can get some experience building in the GitHub Actions environment before hopefully eventually switching to using the artifacts from this process as the packages we'll release through the official release channels. It will react to any push to one of our release branches or to a release tag by building official-release-like .zip, .deb, and .rpm packages, along with Docker images, based on the content of the corresponding commit. For the moment this doesn't actually produce _shippable_ packages because in particular it doesn't know how to update our version/version.go file to hard-code the correct version number. Once Go 1.18 is release and we've upgraded to it we'll switch to using debug.ReadBuildInfo to determine our version number at runtime and so no longer need to directly update a source file for each release, but that functionality isn't yet available in our current Go 1.17 release.	4 years ago
Josef Šimánek	ffcb167bce	Update go test commands in .github/CONTRIBUTING.md.	4 years ago