16 Commits (4e308ef3625a6f4e155ed547f604e16bf3d875ae)

Author	SHA1	Message	Date
Brian Flad	19cf34114f	lang/funcs: Switch fileset() function glob implementation to github.com/bmatcuk/doublestar to support additional glob patterns ... This allows the usage of the glob patterns `**` and `{alternative1,...}` to simplify Terraform configuration logic for more complex file matching.	7 years ago
Brian Flad	769f626a0e	lang/funcs: Remove homedir.Expand() and refactor path trimming with filepath.Rel() in fileset() function ... Reference: https://github.com/hashicorp/terraform/pull/22621#pullrequestreview-282259385	7 years ago
Brian Flad	820b79d91d	lang/funcs: Clarification update to MakeFileSetFunc comment for filepath.ToSlash usage	7 years ago
Brian Flad	af7f6ef441	lang/funcs: Update fileset() function to include path as separate first argument, automatically trim the path argument from results, and ensure results are always canonical with forward slash path separators ... Reference: https://github.com/hashicorp/terraform/pull/22523#pullrequestreview-279694703 These changes center around better function usability and consistency with other functions. The function has not yet been released, so these breaking changes can be applied safely.	7 years ago
Brian Flad	d48d9ed766	lang/funcs: Add fileset function ... Reference: https://github.com/hashicorp/terraform/issues/16697 Enumerates a set of regular file names from a given glob pattern. Implemented via the Go stdlib `path/filepath.Glob()` functionality. Notably, stdlib does not support `**` or `{}` extended patterns. See also: https://github.com/golang/go/issues/11862 To support the extended glob patterns, it will require adding a dependency on a third party library or adding our own matching code.	7 years ago
Andreas Sommer	042aead714	lang/funcs: add "abspath" function (#21409)	7 years ago
Martin Atkins	2b1e650df2	lang/funcs: Fix out-of-bounds ArgError in templatefile function ... The templatefile function only has two arguments, so ArgErrorf can be called with only zero or one as the argument index. If we are out of bounds then HCL itself will panic trying to build the error message for this call when called as an HCL function. Unfortunately there isn't really a great layer in Terraform to test for this class of bug systematically, because we are currently testing these functions directly rather than going through HCL to do it. For the moment we'll just live with that, but if we see this class of error arise again we might consider either reworking the tests in this package to work with HCL expression source code instead of direct calls or adding some additional tests elsewhere that do so.	7 years ago
Brian Flad	398fe8652d	config: Mention other file hashing functions when file() detects unsupported contents ... Reference: https://github.com/hashicorp/terraform/issues/20664	7 years ago
Martin Atkins	954d38e870	lang: New file-hashing functions ... In prior versions, we recommended using hash functions in conjunction with the file function as an idiom for detecting changes to upstream blobs without fetching and comparing the whole blob. That approach relied on us being able to return raw binary data from file(...). Since Terraform strings pass through intermediate representations that are not binary-safe (e.g. the JSON state), there was a risk of string corruption in prior versions which we have avoided for 0.12 by requiring that file(...) be used only with UTF-8 text files. The specific case of returning a string and immediately passing it into another function was not actually subject to that corruption risk, since the HIL interpreter would just pass the string through verbatim, but this is still now forbidden as a result of the stricter handling of file(...). To avoid breaking these use-cases, here we introduce variants of the hash functions a with "file" prefix that take a filename for a disk file to hash rather than hashing the given string directly. The configuration upgrade tool also now includes a rule to detect the documented idiom and rewrite it into a single function call for one of these new functions. This does cause a bit of function sprawl, but that seems preferable to introducing more complex rules for when file(...) can and cannot read binary files, making the behavior of these various functions easier to understand in isolation.	7 years ago
Martin Atkins	c753df6a93	lang/funcs: templatefile function ... This function is similar to the template_file data source offered by the template provider, but having it built in to the language makes it more convenient to use, allowing templates to be rendered from files anywhere an inline template would normally be allowed: user_data = templatefile("${path.module}/userdata.tmpl", { hostname = format("petserver%02d", count.index) }) Unlike the template_file data source, this function allows values of any type in its variables map, passing them through verbatim to the template. Its tighter integration with Terraform also allows it to return better error messages with source location information from the template itself. The template_file data source was originally created to work around the fact that HIL didn't have any support for map values at the time, and even once map support was added it wasn't very usable. With HCL2 expressions, there's little reason left to use a data source to render a template; the only remaining reason left to use template_file is to render a template that is constructed dynamically during the Terraform run, which is a very rare need.	7 years ago
Radek Simko	edaa4bbc82	lang: Add fileexists function	8 years ago
Kristin Laemmert	eb1d8b7909	cleanup comments for nicer godocs	8 years ago
Kristin Laemmert	755b1e2497	implement pathexpand	8 years ago
Kristin Laemmert	2a2ffb6ef4	implement dirname function	8 years ago
Kristin Laemmert	8c1f0842b0	implement basename function	8 years ago
Martin Atkins	129f5fe74d	lang/funcs: port some of Terraform's built-in functions ... These implementations are adaptations of the existing implementations in config/interpolate_funcs.go, updated to work with the cty API. The set of functions chosen here was motivated mainly by what Terraform's existing context tests depend on, so we can get the contexts tests back into good shape before fleshing out the rest of these functions.	8 years ago