129 Commits (4e175cc351638d8536dff251a47ce60f0446e441)

Author	SHA1	Message	Date
James Bardin	1fa7667ad4	s3 backend should use Client.Delete to DeleteState ... The s3.Backend was using it's own code for DeleteState, but the dynamo entries are only handled through the RemoteClient. Have DeleteState use a RemoteClient for delete.	9 years ago
James Bardin	ebf4413e95	add named named state delete+create-delete test ... This ensures that we don't leave any conflicting state artifacts preventing the recreation of a named state.	9 years ago
James Bardin	ac937a890d	improve plugin reinit error text	9 years ago
James Bardin	7a955f990c	make display plugin checksum error to user ... The error follows a generic message, so can be ignored by users who may not understand the implications.	9 years ago
James Bardin	5be15ed77c	have the local backend provide a plugin init msg ... During plan and apply, because the provider constraints need to be built from a plan, they are not checked until the terraform.Context is created. Since the context is always requested by the backend during the Operation, the backend needs to be responsible for generating contextual error messages for the user. Instead of formatting the ResolveProviders errors during NewContext, return a special error type, ResourceProviderError to signal that init will be required. The backend can then extract and format the errors.	9 years ago
James Bardin	ac959af6b4	rename aws provider import in s3 backend	9 years ago
Martin Atkins	f7ce6a15f8	backend: Operation.Environment renamed to "Workspace" ... This is part of an effort to switch this terminology across all of Terraform.	9 years ago
Martin Atkins	418a8a8bc9	command + backend: rename various API objects to "Workspace" terminology ... We're shifting terminology from "environment" to "workspace". This takes care of some of the main internal API surface that was using the old terminology, though is not intended to be entirely comprehensive and is mainly just to minimize the amount of confusion for maintainers as we continue moving towards eliminating the old terminology.	9 years ago
Martin Atkins	5026e1d313	backend/local: "environment_dir" renamed to "workspace_dir" ... As part of switching our terminology, we begin a deprecation cycle for "environment_dir" and advise users to switch to "workspace_dir" instead.	9 years ago
David Glasser	c25d848ffb	core: allow overriding environment name via env var ... This allows you to run multiple concurrent terraform operations against different environments from the same source directory. Fixes #14447. Also removes some dead code which appears to do the same thing as the function I modified.	9 years ago
Martin Atkins	c835ef8ff3	Update tests for the new ProviderResolver interface ... Rather than providing an already-resolved map of plugins to core, we now provide a "provider resolver" which knows how to resolve a set of provider dependencies, to be determined later, and produce that map. This requires the context to be instantiated in a different way, so this very noisy diff is a mostly-mechanical update of all of the existing places where contexts get created for testing, using some adapted versions of the pre-existing utilities for passing in mock providers.	9 years ago
Martin Atkins	a42ebe389c	Revert "have StateHook periodically PersistState" ... This reverts commit b73d037761. This commit seems to have introduced a race condition where we can concurrently keep updating state after we've checked if we need to increase the serial, and thus end up writing partial changes to the state backend. In the case of Terraform Enterprise, this fails altogether because of the state hash consistency check it does.	9 years ago
Radek Simko	1244309579	Fix stringer comments (#15069)	9 years ago
He Guimin	87562be855	provider/alicloud: Add the function of replacing ecs instance's system disk (#15048) ... * add replacing system disk function for ecs * remove ForceNew of system_disk_size	9 years ago
Jake Champlin	ac177492fb	core: Revert stringer changes from earlier commits	9 years ago
Thomas Schaaf	79c91e11c8	provider/aws: Add aws elastic beanstalk solution stack (#14944) ... * Add aws elastic beanstalk solution stack Signed-off-by: Thomas Schaaf <thomaschaaf@Thomass-MBP.fritz.box> * Fix incorrect naming Signed-off-by: Thomas Schaaf <thomaschaaf@Thomass-MBP.fritz.box> * Use unique go variable/function names Signed-off-by: Thomas Schaaf <thomaschaaf@Thomass-MacBook-Pro.local> * Add docs to sidebar * Sort provider by alphabet * Fix indent * Add required statement * Fix acceptance test	9 years ago
James Bardin	6b700ff1fb	replace lock_table with dynamodb_table in s3 cfg ... Since the DynamoDB table used by the S3 backend is no longer only used for locks, rename it in the config to remove any confusion about it being lock-specific.	9 years ago
James Bardin	ecc5bfb801	Merge pull request #14937 from hashicorp/jbardin/GH-14927 ... check for nil state in s3 client Get	9 years ago
James Bardin	82eba5801d	Test losing and reacquiring a consul lock	9 years ago
James Bardin	3df48bfc27	relock consul when lock is lost ... Consul locks are based on liveness, and may be lost due timeouts, network issued, etc. If the client determines the lock was lost, attempt to reacquire the lock immediately. The client was also not using the `lock` config option. Disable locks if that is not set.	9 years ago
James Bardin	e8330b6f53	use CAS for consul state Put	9 years ago
James Bardin	e7502454b4	check for nil state in s3 client Get ... The S3 client can return (nil, nil) when the remote state doesn't exist. The caused a nil pointer dereference when checking the payload.MD5 against the expected value. This can happen if the remote state was manually removed, but the digest entry was left in the DynamoDB table.	9 years ago
James Bardin	f8bfc0a80d	check for empty diff in CountHook.PreApply ... Make sure we don't try to count anything from a nil diff.	9 years ago
James Bardin	1d585762dd	Merge pull request #14834 from hashicorp/jbardin/state-hook ... Persist state more frequently	9 years ago
James Bardin	9e4c0ff2ad	call PersistState immediately when cancelling ... When the backend operation is cancelled, immediately call PersistState. The is a high likelihood that the user is going to terminate the process early if the provider doesn't return in a timely manner, so persist as much state as possible.	9 years ago
James Bardin	b73d037761	have StateHook periodically PersistState ... Have StateHook periodically call PersistState to flush any cached state to permanent storage. This uses a minimal 10 second interval between calls to PersistState.	9 years ago
James Bardin	ef1d53934c	Merge pull request #14746 from hashicorp/jbardin/s3-consistency ... store and verify s3 remote state checksum to avoid consistency issues.	9 years ago
James Bardin	91be40a577	add detailed error message s3 checksum mismatch ... Have the s3 RemoteClient return a detailed error message to the user in the case of a mismatch state checksum.	9 years ago
James Bardin	0022d224e8	store and verify s3 remote state checksum ... Updates to objects in S3 are only eventually consistent. If the RemoteClient has a DynamoDB table available, use that to store a checksum of the last written state, so the object can be verified by the next client to call Get. Terraform currently doesn't have any sort of user feedback around RefreshState/Get, so we poll only for a short time before returning an error.	9 years ago
James Bardin	e1d9ad40d3	Merge pull request #14680 from hashicorp/jbardin/unlock-s3 ... Check that a named state in s3 doesn't exist before acquiring a lock	9 years ago
Martin Atkins	9cda37205d	backend/local: create local state file if backend write fails ... In the old remote state system we had the idea of a local backup, which is actually still present for the legacy backends but no longer applies for the new-style backends like the s3 backend. It's problematic when an apply runs for long enough that someone's time-limited AWS STS credentials expire and then Terraform fails and can't persist state to S3. To reduce the risk of lost state, here we add some extra fallback code for the local apply operation in particular. If either state writing or state persisting fail then we attempt to write the state to a special backup file errored.tfstate, and produce an error message that guides the user on how to retry uploading this state. In the unlikely event that we can't write to local disk either (e.g. permissions problems) we take a last-ditch attempt to dump the JSON onto stdout and advise the user to manually copy it into a file for import. If even that doesn't work for some reason, we assume a critical Terraform bug (JSON-serialization problem with states?) and bail out with an apologetic error message. This is implemented for the apply command in particular because this is the one command where new objects are created in real APIs that we don't want to lose track of. For other operations it's less bad to just generate a simple error message and have the user retry. This fixes #14298.	9 years ago
James Bardin	b279b1abb5	check for named s3 states before acquiring a lock ... In order to force-unlock a named state, we have to fetch that state first. Don't attempt to acquire a lock if we know the state already exists in s3.	9 years ago
James Bardin	a2d452acec	failing test to force-unlock a named state in s3 ... The State call attempts to get a lock before determining if a named state exists. This prevents force-unlock, since we need the state to call Unlock.	9 years ago
James Bardin	58759b1167	Merge pull request #13941 from hashicorp/jbardin/sigint-message ... improve SIGINT output	9 years ago
James Bardin	7dad3f4d48	remove redundant output when interrupting apply ... The backend apply operation doesn't need to output the same text as the cli itself. Instead notify the user that we are in the process of stopping the operation.	9 years ago
James Bardin	563cfd00df	always wrap remote state in a BackupState ... Use a local backup for remote state operations. This allows for manual recovery in the case of a put failure.	9 years ago
Martin Atkins	b1763e262a	Restore stringer-generated files back to new version ... stringer has changed the boilerplate it generates in a recent version. We'd previously updated to the new format but accientally rolled back to the old while merging a long-running feature branch. This restores us back to the new format again.	9 years ago
Jasmin Gacic	61499cfcf0	Provider Oneandone (#13633) ... * Terraform Provider 1&1 * Addressing pull request remarks * Fixed imports * Fixing remarks * Test optimiziation	9 years ago
James Bardin	928e60672f	context Refresh and Apply sometimes return nil ... The documentation for Refresh indicates that it will always return a valid state, but that wasn't true in the case of a graph builder error. While this same concept wasn't documented for Apply, it was still assumed in the terraform apply code. Since the helper testing framework relies on the absence of a state to determine if it can call Destroy, the Context can't can't start returning a state in all cases. Document this, and use the State method to fetch the correct state value after Apply. Add a nil check to the WriteState function, so that writing a nil state is a noop. Make sure to init before sorting the state, to make sure we're not attempting to sort nil values. This isn't technically needed with the current code, but it's just safer in general.	9 years ago
James Bardin	9c431aee1b	only list environments when the keyName matches ... Prevent extra keys in the s3 envPrefix path from showing up as listed environments. Better handle keys containing slashes Add tests for unexpected keys in s3.	9 years ago
James Bardin	5621d97925	cleanup consul lock entries ... This matches the consul cli behavior, where locks are cleaned up after use. Return an error from re-locking the state. This isn't required by the Locker interface, but it's an added sanity check for state operations. What was incorrect here was returning an empty ID and error, which would indicate that Lock/Unlock isn't supported.	9 years ago
James Bardin	6e136c848a	use the aws provider client initialization ... Use the aws provider code to create the clients for the s3 backend, so that all the behavior matches that of the provider. Remove the fake creds from the test, as the aws provider will attempt to validate them.	9 years ago
James Bardin	54aa466b74	initialize the s3 lock path in one place	9 years ago
James Bardin	d059939f88	Merge pull request #13262 from hashicorp/jbardin/lock-timeouts ... lock timeouts	9 years ago
James Bardin	305ef43aa6	provide contexts to clistate.Lock calls ... Add fields required to create an appropriate context for all calls to clistate.Lock. Add missing checks for Meta.stateLock, where we would attempt to lock, even if locking should be skipped.	9 years ago
James Bardin	3f0dcd1308	Have the clistate Lock use LockWithContext ... - Have the ui Lock helper use state.LockWithContext. - Rename the message package to clistate, since that's how it's imported everywhere. - Use a more idiomatic placement of the Context in the LockWithContext args.	9 years ago
James Bardin	75458a182d	remove extra state.Locker assertions ... All states are lockers, so get rid of extra asertions.	9 years ago
Paul Stack	4501be7e5c	backend/remote-state: Add support for assume role extensions to s3 backend (#13236) ... Fixes: #13234 This now matches the AWS provider for the Assume Role support	9 years ago
Martin Atkins	21cd5595e2	Update stringer-generated files to new boilerplate ... golang/tools commit 23ca8a263 changed the format of the leading comment to comply with some new standards discussed here: https://golang.org/issue/13560 This is the result of running generate with the latest version of stringer. Everyone working on Terraform will need to update stringer after this is merged, to avoid reverting this: go get -u golang.org/x/tools/cmd/stringer	9 years ago
James Bardin	7b8e1aff3d	fix local backend test ... The local backend can't define a StateOut path if we want to test writing multiple named state files. Use a default local backend.	9 years ago