69 Commits (4d53eaa6df2f2f597e18c352ae0ef8baa3e4ed32)

Author	SHA1	Message	Date
Martin Atkins	610fcb605e	plugin/discovery: allow customizing the OS/arch for auto-install ... Previously we forced only installing for the current GOOS and GOARCH. Now we allow this to be optionally overridden, which allows building tools that can, for example, populate a directory with plugins to run on a Linux server while working on a Mac.	9 years ago
James Bardin	beebd5cee3	improve discovery logging ... Display whether we're looking for a provider or provisioner in the log messages.	9 years ago
James Bardin	e059eb80d1	add test for signature mismatch	9 years ago
James Bardin	2cca6f10fa	return sig error when fetching a plugin ... A signature error was being ignored while fetching a plugin	9 years ago
James Bardin	c10f5caf05	Merge pull request #15345 from hashicorp/jbardin/plugin-sig ... verify automatically downloaded plugins	9 years ago
Martin Atkins	af2111f24e	plugin/discovery: sentinel error values for Get errors ... Some errors from Get are essentially user error, so we want to be able to recognize them and give the user good feedback on how to proceed. Although sentinel values are not an ideal solution to this, it's something reasonably simple we can do to get this done without lots of refactoring.	9 years ago
James Bardin	13d835f996	test signature verification ... use a published provider's checksum file and signature to check the verification.	9 years ago
James Bardin	415d562d36	add signature verification ... Fetch the SHA256SUMS file and verify it's signature before downloading any plugins. This embeds the hashicorp public key in the binary. If the publickey is replaced, new releases will need to be cut anyway. A --verify-plugin=false flag will be added to skip signature verification in these cases.	9 years ago
James Bardin	2e57d284cb	Merge pull request #15323 from hashicorp/jbardin/constraint-suggestion ... remove "~> 0.0" constraint suggestions	9 years ago
James Bardin	ec99b6910b	remove "~> 0.0" constraint suggestions ... Don't suggest constraints when the available plugin isn't versioned. Add zero version const for comparisons.	9 years ago
James Bardin	6faace287d	remove restriction on unversioned plugins ... Discover unversioned plugins regarless of location.	9 years ago
James Bardin	ba5b0dc609	mostly remove OS_ARCH knowledge from discovery ... Since the command package also needs to know about the specific OS_ARCH directories, remove the logic fom the discovery package. This doesn't completely remove the knowledge of the path from discovery, in order to maintain the current behavior of skipping legacy plugin names within a new-style path.	9 years ago
James Bardin	f723270e3e	search the vendor directory for plugins ... The default location for users to manually add plugins will be ./terraform.d/plugins/	9 years ago
Martin Atkins	af4c82d151	plugin/discovery: Installer.PurgeUnused method ... Given a map describing the chosen plugin for each provider name, this method should purge any other plugins present in the local cache directory.	9 years ago
Martin Atkins	f753974bb3	plugin/discovery: Installer interface, and provider implementation ... Previously we had a "getProvider" function type used to implement plugin fetching. Here we replace that with an interface type, initially with just a "Get" function. For now this just simplifies the interface by allowing the target directory and protocol version to be members of the struct rather than passed as arguments. A later change will extend this interface to also include a method to purge unused plugins, so that upgrading frequently doesn't leave behind a trail of unused executable files.	9 years ago
James Bardin	840978b2d5	udpate to plugin name convention ... Names are case-insensitive, using lowercase by default.	9 years ago
James Bardin	1b201e67ea	fix releases path and protocol header ... Last minute change to the location of the binaries	9 years ago
James Bardin	283ae0c7c4	fix comment and add some logging in discovery	9 years ago
James Bardin	ea3d9c86ba	sort constraints for consistent output	9 years ago
Martin Atkins	4ba20f9c1c	command init: show suggested constraints for unconstrained providers ... When running "terraform init" with providers that are unconstrained, we will now produce information to help the user update configuration to constrain for the particular providers that were chosen, to prevent inadvertently drifting onto a newer major release that might contain breaking changes. A ~> constraint is used here because pinning to a single specific version is expected to create dependency hell when using child modules. By using this constraint mode, which allows minor version upgrades, we avoid the need for users to constantly adjust version constraints across many modules, but make major version upgrades still be opt-in. Any constraint at all in the configuration will prevent the display of these suggestions, so users are free to use stronger or weaker constraints if desired, ignoring the recommendation.	9 years ago
James Bardin	dbbafbd43f	clean up plugin fetching ... We can filter the allowed versions and sort them before checking the protocol version, that way we can just return the first one found reducing network requests.	9 years ago
James Bardin	48d37131e0	more tests for fetching providers ... Extend the test reslease server to return the protocol version header and a dummy zip file for the provider. Test filtering the plugins by plugin protocol version and add a full GetProvder test.	9 years ago
James Bardin	5f053a2e64	refactor GetProvider ... Get provider needs to be provided with the plugin protocol version, because it can't be imported here directly. The plugin url types and methods were confusing; replace them with a few functions to format the urls.	9 years ago
James Bardin	8ad67991a5	check protocol version on plugins ... Verify that the plugin we're requesting has a compatible protocol version.	9 years ago
James Bardin	fdeb3d929c	Add Versions.Sort ... Sort versions from newest to oldest.	9 years ago
Martin Atkins	04bcece59c	plugin/discovery: handle the -Xn suffix used by auto-installed plugins ... This is used to mark the plugin protocol version. Currently we actually just ignore this entirely, since only one protocol version exists anyway. Later we will need to add checks here to ensure that we only pay attention to plugins of the right version.	9 years ago
Martin Atkins	e3401947a6	plugin/discovery: PluginRequirements can specify SHA256 digests ... As well as constraining plugins by version number, we also want to be able to pin plugins to use specific executables so that we can detect drift in available plugins between commands. This commit allows such requirements to be specified, but doesn't yet specify any such requirements, nor validate them.	9 years ago
James Bardin	044ad5ef59	rename some Constraints methods per code review	9 years ago
James Bardin	211f5b5d6e	add test for newestVersion	9 years ago
James Bardin	46190590cb	change []*Version to []Version ... Versions are used as values, so don't keep them as pointers here	9 years ago
James Bardin	a547e7c2f0	add releases version listing test	9 years ago
James Bardin	2749946f5c	basic plugin getter ... Add discovery.GetProviders to fetch plugins from the relases site. This is an early version, with no tests, that only (probably) fetches plugins from the default location. The URLs are still subject to change, and since there are no plugin releases, it doesn't work at all yet.	9 years ago
James Bardin	fa49c69793	expose Version.NewerThan ... NewerThan is useful outside of the package	9 years ago
James Bardin	7d2d951f27	Rename VersionSet to Constraints ... VersionSet is a wrapper around version.Contraints, so rename it it as such.	9 years ago
James Bardin	718ede0636	have Meta.Backend use a Config rather than loading ... Instead of providing the a path in BackendOpts, provide a loaded *config.Config instead. This reduces the number of places where configuration is loaded.	9 years ago
Martin Atkins	cfc08ae7e3	plugin/discovery: provide an AllVersions set ... Various implied dependencies will accept all versions, so this is convenient for populating dependency data structures for such implied dependencies.	9 years ago
Martin Atkins	a1e29ae290	plugin/discovery: use go-version instead of semver ... The semver library we were using doesn't have support for a "pessimistic constraint" where e.g. the user wants to accept only minor or patch version upgrades. This is important for providers since users will generally want to pin their dependencies to not inadvertantly accept breaking changes. So here we switch to hashicorp's home-grown go-version library, which has the ~> constraint operator for this sort of constraint. Given how much the old version object was already intruding into the interface and creating dependency noise in callers, this also now wraps the "raw" go-version objects in package-local structs, thus keeping the details encapsulated and allowing callers to deal just with this package's own types.	9 years ago
Martin Atkins	9b4f15c261	plugin: move Client function into plugin, from plugin/discovery ... Having this as a method of PluginMeta felt most natural, but unfortunately that means that discovery must depend on plugin and plugin in turn depends on core Terraform, thus making the discovery package hard to use without creating dependency cycles. To resolve this, we invert the dependency and make the plugin package be responsible for instantiating clients given a meta, using a top-level function.	9 years ago
Martin Atkins	bcd395e6bd	plugin/discovery: Allow overriding the paths of certain plugin names ... The .terraformrc file allows the user to override the executable location for certain plugins. This mechanism allows us to retain that behavior for a deprecation period by treating such executables as an unversioned plugin for the given name and excluding all other candidates for that name, thus ensuring that the override will "win". Users must eventually transition away from using this mechanism and use vendor directories instead, because these unversioned overrides will never match for a provider referenced with non-zero version constraints.	9 years ago
Martin Atkins	551bc9c4a4	plugin/discovery: build plugin clients ... These new methods ClientConfig and Client provide the bridge into the main plugin infrastructure by configuring and instantiating (respectively) a client object for the referenced plugin. This stops short of getting the proxy object from the client since that then requires referencing the interface for the plugin kind, which would then create a dependency on the main terraform package which we'd rather avoid here. It'll be the responsibility of the caller in the command package to do the final wiring to get a provider instance out of a provider plugin client.	9 years ago
Martin Atkins	0a08214a74	plugin/discovery: SHA256() method to get the hash of each plugin ... This will be used later to verify that installed plugins match what's available on the releases server.	9 years ago
Martin Atkins	a94e9a4362	plugin/discovery: find plugins in a given set of directories ... For now this supports both our old and new directory layouts, so we can preserve compatibility with existing configurations until a future major release where support for the old paths will be removed. Currently this allows both styles in all given directories, which means we support more variants than we actually intend to but this is accepted to keep the interface simple such that we can easily remove the legacy exception later. The documentation will reflect only the subset of path layouts that we actually intend to support.	9 years ago
Martin Atkins	39deb1ff6b	plugin/discovery: helpers for wrangling plugin versions ... With forthcoming support for versioned plugins we need to be able to answer questions like what versions of plugins are currently installed, what's the newest version of a given plugin available, etc. PluginMetaSet gives us a building block for this sort of plugin version wrangling.	9 years ago
Mitchell Hashimoto	700c74bdd0	plugin: bump protocol version ... We changed the type of InstanceState.Meta and this will break pre-existing plugins. They simply have to recompile to work.	9 years ago
Mitchell Hashimoto	96884ec42d	plugin: bump the protocol version due to Provisioner change	9 years ago
Mitchell Hashimoto	2e894c4ef7	plugin: add ResourceProvisioner.Stop API	9 years ago
Mitchell Hashimoto	b3124e16ca	plugin: bump protocol version ... This is necessary since the TypeUnknown HIL handling in helper/schema makes providers compiled WITHOUT TypeUnknown incompatible with the way core handles unknown values.	9 years ago
Mitchell Hashimoto	045ddf3695	plugin: implement ResourceProvider.Stop	9 years ago
Mitchell Hashimoto	60140b28f4	Revert "Merge pull request #9536 from hashicorp/f-provider-stop" ... This reverts commit c3a4cff133, reversing changes made to 791a02e6e4. This change requires plugin recompilation and we should hold off until a minor release for that.	9 years ago
Mitchell Hashimoto	43b5818b55	plugin: implement ResourceProvider.Stop	9 years ago