29 Commits (449ea72e87da7e697ef7b68283a852cc9cc09045)

Author	SHA1	Message	Date
Martin Atkins	e21f0fa61e	backend/local: Handle interactive prompts for variables in UI layer ... During the 0.12 work we intended to move all of the variable value collection logic into the UI layer (command package and backend packages) and present them all together as a unified data structure to Terraform Core. However, we didn't quite succeed because the interactive prompts for unset required variables were still being handled _after_ calling into Terraform Core. Here we complete that earlier work by moving the interactive prompts for variables out into the UI layer too, thus allowing us to handle final validation of the variables all together in one place and do so in the UI layer where we have the most context still available about where all of these values are coming from. This allows us to fix a problem where previously disabling input with -input=false on the command line could cause Terraform Core to receive an incomplete set of variable values, and fail with a bad error message. As a consequence of this refactoring, the scope of terraform.Context.Input is now reduced to only gathering provider configuration arguments. Ideally that too would move into the UI layer somehow in a future commit, but that's a problem for another day.	6 years ago
Sander van Harmelen	ef9054562e	commands: make sure the correct flagset is used ... A lot of commands used `c.Meta.flagSet()` to create the initial flagset for the command, while quite a few of them didn’t actually use or support the flags that are then added. So I updated a few commands to use `flag.NewFlagSet()` instead to only add the flags that are actually needed/supported. Additionally this prevents a few commands from using locking while they actually don’t need locking (as locking is enabled as a default in `c.Meta.flagSet()`.	7 years ago
Martin Atkins	e20346bf4f	command: fix TestMeta_process ... The mission of this process method used to include dealing with auto-loaded tfvars files, but it doesn't do that anymore. It does still deal with the -no-color option, but the test wasn't exercising that part before. Now the test here focuses on the -no-color behavior. The process method still has a "vars" flag argument which is no longer used. Since this is an unexported method we could potentially address this but this commit is intentionally limited only to fixing the test.	7 years ago
Sander van Harmelen	178ec8f7b4	Remove support for the -module-depth flag ... # Conflicts: # backend/backend.go	7 years ago
James Bardin	0fdcf2c01e	properly cleanup and print correct error messages ... Some Meta tests were not cleaning up their temp directories. The process test wasn't printing the correct arguments in the error messages.	9 years ago
Robert Liebowitz	4bf2269784	Add test case for autoloading tfvars	9 years ago
Robert Liebowitz	8d98fdecac	Autoload only .auto.tfvars files	9 years ago
Robert Liebowitz	006744bfe0	Use all tfvars files in working directory ... As a side effect, several commands that previously did not have a failure state can now fail during meta-parameter processing.	9 years ago
Martin Atkins	418a8a8bc9	command + backend: rename various API objects to "Workspace" terminology ... We're shifting terminology from "environment" to "workspace". This takes care of some of the main internal API surface that was using the old terminology, though is not intended to be entirely comprehensive and is mainly just to minimize the amount of confusion for maintainers as we continue moving towards eliminating the old terminology.	9 years ago
James Bardin	b53704ed87	Thread the environment through all commands ... Add Env and SetEnv methods to command.Meta to retrieve the current environment name inside any command. Make sure all calls to Backend.State contain an environment name, and make the package compile against the update backend package.	9 years ago
Mitchell Hashimoto	1248b147ac	command/meta: always ask for unset variable input ... Fixes #7975 This changes the InputMode for the CLI to always be: InputModeProvider | InputModeVar | InputModeVarUnset Which means: * Ask for provider variables * Ask for user variables _that are not already set_ The change is the latter point. Before, we'd only ask for variables if zero were given. This forces the user to either have no variables set via the CLI, env vars, tfvars or ALL variables, but no in between. As reported in #7975, this isn't expected behavior. The new change makes is so that unset variables are always asked for. Users can retain the previous behavior by setting `-input=false`. This would ensure that variables set by external sources cover all cases.	9 years ago
Paul Hinze	e67fc0fe9b	command: Change module-depth default to -1 ... This means that terraform commands like `plan`, `apply`, `show`, and `graph` will expand all modules by default. While modules-as-black-boxes is still very true in the conceptual design of modules, feedback on this behavior has consistently suggested that users would prefer to see more verbose output by default. The `-module-depth` flag and env var are retained to allow output to be optionally limited / summarized by these commands.	10 years ago
Anthony Scalisi	198e1a5186	remove various typos	11 years ago
Mitchell Hashimoto	96b53cc06c	command: ask for input even if tfvars is set [GH-2161]	11 years ago
Paul Hinze	29d34cd5a4	command: allow module depth to be set via env var ... Another convienence env var here with TF_MODULE_DEPTH. Works like you'd expect it to!	11 years ago
Paul Hinze	5f1ea7fccc	command: add env var equivalent to -input arg ... Setting TF_INPUT has the equivalent effect of setting the flag. I got sick of specifying this when iterating on TF config locally.	11 years ago
Mitchell Hashimoto	9062bfda89	command/meta: fix test	11 years ago
Mitchell Hashimoto	579f102f37	command: start migrating to new state package	11 years ago
Armon Dadgar	ba01e27026	command: Refresh remote state when loading	11 years ago
Armon Dadgar	53704db4ee	command: Enable reading remote-enabled state	11 years ago
Armon Dadgar	bf10111745	command/apply: Move state persistence to Meta	11 years ago
Mitchell Hashimoto	16b023bd2b	command: ask for the proper level of input	12 years ago
Mitchell Hashimoto	817f0d9f30	command: don't ask for input if terraform.tfvars file given [GH-346]	12 years ago
Mitchell Hashimoto	af548c9b53	command/plan: ask for input	12 years ago
Mitchell Hashimoto	5b0859b3f5	command: Input tells us whether we should ask for input or not	12 years ago
Mitchell Hashimoto	69294b1ba3	command: adhere to -no-color, fix test [GH-250]	12 years ago
Mitchell Hashimoto	642fed0356	command: terraform.tfvars loaded by default if it exists	12 years ago
Mitchell Hashimoto	541d23eea0	command: can set Color to false explicitly	12 years ago
Mitchell Hashimoto	6c736bd3c4	command: introduce Meta and "-no-color" option	12 years ago