terraform

Commit Graph

Author	SHA1	Message	Date
Martin Atkins	3b620bfe69	terraform: Stabilize the variable_validation_crossref experiment Previously we introduced a language experiment that would permit variable validation rules to refer to other objects declared in the same module as the variable. Now that experiment is concluded and its behavior is available for all modules. This final version deviates slightly from the experiment: we learned from the experimental implementation that we accidentally made the "validate" command able to validate constant-valued input variables in child modules despite the usual rule that input variables are unknown during validation, because the previous compromise bypassed the main expression evaluator and built its own evaluation context directly. Even though that behavior was not intended, it's a useful behavior that is protected by our compatibility promises and so this commit includes a slightly hacky emulation of that behavior, in eval_variable.go, that fetches the variable value in the same way the old implementation would have and then modifies the hcl evaluation context to include that value, while preserving anything else that our standard evaluation context builder put in there. That narrowly preserves the old behavior for expressions that compare the variable value directly to a constant, while treating all other references (which were previously totally invalid) in the standard way. This quirk was already covered by the existing test TestContext2Validate_variableCustomValidationsFail, which fails if the special workaround is removed.	2 years ago
Rose	0eac58dcab	Change the header names	2 years ago
Brian McClain	670bcb0cb1	root_block_device requires an index	2 years ago
Ari Summer	d12984064a	Correct EC2 instance encryption condition example in custom-conditions.mdx	2 years ago
Chris Trombley	6d817660eb	docs: dissociate CV from preconditions and postconditions	3 years ago
Kieran Lowe	0a2f62c8a0	fix: update broken links to `checks` section in docs (#33357 ) This also capitalises the 'a' in assertions to keep it consistent with the rest of the document	3 years ago
Rose M Koron	46e47e07d9	Adding links to the Checks tutorial and fixing headers to be sentence case (#33328 )	3 years ago
Liam Cervante	6fa5784129	Add documentation page for checks and assertions (#33241 ) * Add documentation page for checks and assertions * address comments * Apply suggestions from code review Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * address comments * Apply suggestions from code review Co-authored-by: Radek Simko <radek.simko@gmail.com> Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * address comments * Apply suggestions from code review Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * revamp choosing checks or other custom conditions section * expand on depends_on * fix issues link * Apply suggestions from code review Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> * address comments * Apply suggestions from code review Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> --------- Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com> Co-authored-by: Radek Simko <radek.simko@gmail.com>	3 years ago
Ashlee Boyer	32f7b8ebd0	Migrating links to new format	3 years ago
Laura Pacilio	c8d8536160	Add callout to Continuous Validation	4 years ago
zisom-hc	d08fcd63db	Update custom-conditions.mdx Made a change to code example within the Preconditions and Postconditions section so that it technically makes sense; prior it was missing the data resource that was being called within the precondition lifecycle event on line 135, and the aws_instance resource was not utilizing the ami being provided by the data source in line 129, so i changed that as well.	4 years ago
Bryce Kalow	b54017ef83	website: content updates for developer (#31779 ) Co-authored-by: Matthew Garrell <69917312+mgarrell777@users.noreply.github.com> Co-authored-by: Laura Pacilio <83350965+laurapacilio@users.noreply.github.com> Co-authored-by: Kevin Wang <kwangsan@gmail.com> Co-authored-by: Judith Malnick <judith@hashicorp.com> Co-authored-by: Martin Atkins <mart@degeneration.co.uk> Co-authored-by: HashiBot <62622282+hashibot-web@users.noreply.github.com>	4 years ago
Tocho Tochev	4e506d5fda	docs: Fix condition example	4 years ago
Laura Pacilio	6aa960c239	Update website/docs/language/expressions/custom-conditions.mdx	4 years ago
Laura Pacilio	9b57fc2964	Add guidance about using the format function	4 years ago
Adam Christie	50919044d5	Fix custom conditions example Original code block erroneously references `aws_vpc.example` but appears to actually mean `data.aws_vpc.example`.	4 years ago
Laura Pacilio	83a700b313	Update version notes for custom conditions	4 years ago
Laura Pacilio	b2d3e594ca	Remove duplicate versioning note for custom condition checks.	4 years ago
Laura Pacilio	54d084159f	Add version note, fix typos, add link to environment variables	4 years ago
Laura Pacilio	179e108cd1	Update website/docs/language/expressions/custom-conditions.mdx	4 years ago
Laura Pacilio	edf9324a9e	Add learn tutorial link	4 years ago
Laura Pacilio	1666aa8463	Update website/docs/language/expressions/custom-conditions.mdx Co-authored-by: Robin Norwood <rnorwood@hashicorp.com>	4 years ago
Laura Pacilio	5841db00b3	Change private to public dns :-)	4 years ago
Martin Atkins	289bb60ce1	core: Defer on transitive dependencies for data resources with conditions When a data resource is used for the purposes of verifying a condition about an object managed elsewhere (e.g. if the managed resource doesn't directly export all of the information required for the condition) it's important that we defer the data resource read to the apply step if the corresponding managed resource has any changes pending. Typically we'd expect that to come "for free" but unfortunately we have a pragmatic special case in our handling of data resources where we normally defer to the apply step only if a _direct_ dependency of the data resource has a change pending, and allow a plan-time read if there's a pending change in an indirect dependency. This allowed us to preserve some compatibility with the questionable historical behavior of always reading data resources proactively unless the configuration contains unknown values, since the arguably-more-correct behavior would've been a regression for anyone who had been depending on that before. Since preconditions and postconditions didn't exist until now, we are not constrained in the same way by backward compatibility, and so we can adopt the more correct behavior in the case where a data resource has conditions specified. This does unfortunately make the handling of data resources with conditions subtly inconsistent with those that don't, but this is a better situation than the alternative where it would be easy to get into a trapped situation where the remote system is invalid and it's impossible to plan the change that would make it valid again because the conditions evaluate too soon, prior to the fix being applied.	4 years ago
Alisdair McDiarmid	b0f837e1f3	Fix custom conditions Markdown typo	4 years ago
Laura Pacilio	b1d9339368	Final formatting nits	4 years ago
Laura Pacilio	3c7c5bbd21	add links to function and expressions; move result types back to conditionals page (oops)	4 years ago
Laura Pacilio	2a206c7984	fix incorrect HCL syntax for example	4 years ago
Laura Pacilio	7a43db405c	Add link to operators page and all out other types	4 years ago
Laura Pacilio	ba3bb5ad5d	Apply suggestions from PR review	4 years ago
Laura Pacilio	f660f54b87	Final nits from review	4 years ago
Laura Pacilio	f9462d5d51	Update links to say "Custom Condition Checks"	4 years ago
Laura Pacilio	3ed8c5c467	Fix in-text link	4 years ago
Laura Pacilio	4c097842df	Move conditionals information to conditional expressions page	4 years ago
Laura Pacilio	375b3583fd	APply suggestions from PR review	4 years ago
Laura Pacilio	3bc3bc52f8	Update website/docs/language/expressions/custom-conditions.mdx Co-authored-by: Martin Atkins <mart@degeneration.co.uk>	4 years ago
Laura Pacilio	b997c983a5	Update website/docs/language/expressions/custom-conditions.mdx Co-authored-by: Martin Atkins <mart@degeneration.co.uk>	4 years ago
Laura Pacilio	4ab955eeab	Update website/docs/language/expressions/custom-conditions.mdx Co-authored-by: Martin Atkins <mart@degeneration.co.uk>	4 years ago
Laura Pacilio	6b986c94bc	Update website/docs/language/expressions/custom-conditions.mdx Co-authored-by: Martin Atkins <mart@degeneration.co.uk>	4 years ago
Laura Pacilio	d69cb58ff5	Add additional sections to condition expressions section	4 years ago
Laura Pacilio	eea860e0cf	Fixing typos and doing a read through	4 years ago
Laura Pacilio	5803963be8	more nitpicks	4 years ago
Laura Pacilio	62a7b51ba7	more edits	4 years ago
Laura Pacilio	3ae238a448	More language edits	4 years ago
Laura Pacilio	af7e688859	more language cleanup for clarity	4 years ago
Laura Pacilio	b2576a3df3	Update page name to Custom Conditions per feedback	4 years ago

46 Commits (4338b75acd20a64c39bdba8d9028e06175bbdde2)