terraform

Commit Graph

Author	SHA1	Message	Date
Mitchell Hashimoto	b486354a9c	communicator/ssh: Disconnect() should also kill the actual connection	9 years ago
Mitchell Hashimoto	4b1d9cfd7d	communicator/ssh: don't share rand object to guarantee unique values Fixes #10463 I'm really surprised this flew under the radar for years... By having unique PRNGs, the SSH communicator could and would generate identical ScriptPaths and two provisioners running in parallel could overwrite each other and execute the same script. This would happen because they're both seeded by the current time which could potentially be identical if done in parallel... Instead, we share the rand now so that the sequence is guaranteed unique. As an extra measure of robustness, we also multiple by the PID so that we're also protected against two processes at the same time.	9 years ago
James Bardin	8174037a2b	Remove deprecated key_file and bastion_key_file These were deprecated in the 0.6.x series. Their functionality was broken in a recent release which whould have removed them as well.	10 years ago
Sander van Harmelen	968472a63e	Support recreating clients and configuring Chef Vaults (#8577 ) Fixes #3605 and adds the functionality suggested in PR #7440. This PR is using a different appraoch that (IMHO) feels cleaner and (even more important) adds support for Windows at the same time.	10 years ago
Kristinn Örn Sigurðsson	bc5518f993	provisioners: Allow provisioning over IPv6	10 years ago
Paul Hinze	2f237eca44	communicator/ssh: correct test typo Copy pasta!!	10 years ago
Paul Hinze	96c20f0dd7	communicator/{ssh,winrm}: seed random script paths Without a seed, the "random" script path locations for the remote-exec provisioner were actually deterministic! Every rand.Int31() would return the same pseudorandom chain starting w/ the numbers: 1298498081, 2019727887, 1427131847, 939984059, ... So here we properly seed the communicators so the script paths are actually random, and multiple runs on a single remote host have much less chance of clobbering each other. Fixes #4186 Kudos to @DustinChaloupka for the correct hunch leading to this fix!	10 years ago
James Nugent	f2fef2556a	Fix import formatting across code base	10 years ago
Sander van Harmelen	c72342eefc	Add SSH agent support for Windows The Windows support is limited to the Pageant SSH authentication agent. This fixes #3423	10 years ago
Paul Hinze	b6aed3fec3	communicator/ssh: fix typos travis didn't catch I think rebasing and splitting got me into a weird state. This should fix the build failures on master.	10 years ago
Paul Hinze	7ffa66d1a5	ssh: accept private key contents instead of path We've been moving away from config fields expecting file paths that Terraform will load, instead prefering fields that expect file contents, leaning on `file()` to do loading from a path. This helps with consistency and also flexibility - since this makes it easier to shift sensitive files into environment variables. Here we add a little helper package to manage the transitional period for these fields where we support both behaviors. Also included is the first of several fields being shifted over - SSH private keys in provisioner connection config. We're moving to new field names so the behavior is more intuitive, so instead of `key_file` it's `private_key` now. Additional field shifts will be included in follow up PRs so they can be reviewed and discussed individually.	10 years ago
Anthony Scalisi	198e1a5186	remove various typos	11 years ago
Paul Hinze	814d05b96e	communicator/ssh: missing newline on bastion host output	11 years ago
Paul Hinze	98891aef96	Merge pull request #2684 from hashicorp/f-print-bastion-host-details communicator/ssh: print ssh bastion host details to output	11 years ago
Paul Hinze	448a6a1b48	communicator/ssh: print ssh bastion host details to output	11 years ago
Paul Hinze	138018c896	communicator/ssh: agent forward failure is not fatal On connections where no second hop is made, there's no problem if the agent forwarding connection is denied, so we shouldn't treat that as a fatal error.	11 years ago
Paul Hinze	801aaf1eec	communicator/ssh: sort agent after static keyfile In the SSH client configuration, we had SSH Agent authentication listed before the static PrivateKey loaded from the `key_file` setting. Switching the default of the `agent` setting exposed the fact that the SSH agent overrides the `key_file` during the handshake. By listing the `key_file` first, we catch the provided key before any query goes out to the agent. Adds a key-based authentication SSH test to cover this new behavior. It fails without the reordering on any machine with an SSH agent running. Fixes #2614	11 years ago
Paul Hinze	a7cbbbd258	communicator/ssh: bastion host support * adds `bastion_` fields to `connection` which add configuration for a bastion host if `bastion_host` is set, connect to that host first, then jump through it to make the SSH connection to `host` * enables SSH Agent forwarding by default	11 years ago
Paul Hinze	44de0996c5	communicator/ssh: switch agent default to true This changes SSH Agent utilization from opt-in to opt-out, bringing Terraform in line with the behavior of Packer and the `ssh` command itself. But skip SSH agent connections if the SSH_AUTH_SOCK env var doesn't exist, whcih means there's no agent to connect to.	11 years ago
Sander van Harmelen	f146a31ded	Fixing #2033 by adding a small check on the input If the input begins with a shebang, we’ll leave it as is. If not we’ll add a default shebang…	11 years ago
Sander van Harmelen	a8dacede24	Improved some logging... I added a debug log line in the last commit, only to find out it’s now logging the same info twice. So removed the double entry and tweaked the existing once.	11 years ago
Sander van Harmelen	3881c81a66	Added the exit code as well...	11 years ago
Sander van Harmelen	48f4d499f9	Fixing a small vet warning introduced by PR #1796 While fixing the vet warning also tried to improve any feedback by showing the actual output/error instead of just the error code. While testing this I noticed only adding stderr output is not enough as not all error info is send to stderr, but sometimes also to stdout.	11 years ago
Luke Amdor	fbae7884eb	remote-exec (ssh): chmod'ing right path	11 years ago
Luke Amdor	11b4060fee	remote-exec (ssh): checking chmod command	11 years ago
Sander van Harmelen	41748003c0	Updated the PR according to the review comments * We now return an error when you set the script_path to C:\Windows\Temp explaining this is currently not supported * The fix in PR #1588 is converted to the updated setup in this PR including the unit tests Last thing to do is add a few tests for the WinRM communicator…	11 years ago
Sander van Harmelen	4a29c714e5	Adding support for WinRM	11 years ago
Sander van Harmelen	c9e9e374bb	Adding some abstractions for the communicators This is needed as preperation for adding WinRM support. There is still one error in the tests which needs another look, but other than that it seems like were now ready to start working on the WinRM part…	11 years ago

28 Commits (3fdcbda3aad99bbcf02bf69ceed926e0ee9f4ec2)