101 Commits (3d1e07dcf3d7fb4555e2a21af4e69901bdb543d9)

Author	SHA1	Message	Date
hashicorp-copywrite[bot]	53c34ff49c	Update copyright file headers to BUSL-1.1	3 years ago
kmoe	765c25d2ed	allow interpolation in import block id (#33618) ... The import block id field can now reference variables, attributes, and module outputs, as long as the result is a known non-empty string at plan time. A null or unknown value will result in an error. This commit slightly modifies the legacy CLI terraform import code path to construct a synthetic hcl.Expression from the import id passed in from the command line, with no intended change of functionality.	3 years ago
Liam Cervante	f397954c52	testing framework: allow users to specify deeply nested testing directories (#33584)	3 years ago
Liam Cervante	4122ba86fc	terraform test: fix crash when using nested modules from test run blocks (#33589)	3 years ago
Liam Cervante	e1019b3641	testing framework: validate the configuration before terraform test (#33559) ... * testing framework: call validate on the configuration before running terraform test * address comments * make tests pass after merge * fix tests	3 years ago
Liam Cervante	222676390c	testing framework: add validation for provider blocks in test files (#33542) ... * testing framework: add validation for provider blocks in test files * .tftest -> .tftest.hcl	3 years ago
Liam Cervante	c91f91cc9e	testing framework: change test file extension to .tftest.hcl (#33553)	3 years ago
Liam Cervante	4b34902fab	[testing framework] allow tests to define and override providers (#33466) ... * [testing framework] prepare for beta phase of development * [Testing Framework] Add module block to test run blocks * [testing framework] allow tests to define and override providers	3 years ago
Liam Cervante	5acc95dda7	[Testing Framework] Add module block to test run blocks (#33456) ... * [testing framework] prepare for beta phase of development * [Testing Framework] Add module block to test run blocks	3 years ago
Liam Cervante	f74a8d16cf	[testing framework] implement expect_failures functionality (#33443)	3 years ago
Liam Cervante	212ae6c4ba	Introduce separate testing scope for reference validation (#33339)	3 years ago
kmoe	fbff64ad45	configs: remove import block duplicate id check (#33434)	3 years ago
Liam Cervante	cad9aa9025	[Testing Framework] Add test file HCL configuration and parser functionality (#33325) ... * Add test structure to views package for rendering test output * Add test file HCL configuration and parser functionality * address comments	3 years ago
Martin Atkins	9f6a3ba701	build: Generate copyright headers automatically ... HashiCorp legal now requires a copyright claim in a comment at the top of every substantial file in this repository. If we don't add this ourselves then a bot will open a PR to add missing entries, but that process adds git history, pull request, and GitHub notification noise so instead we'll deal with it proactively as part of our usual code generation steps. This means that pull requests will fail their checks if there are any files that lack copyright headers, so we can deal with those before we merge rather than in a subsequent PR.	3 years ago
kmoe	be2ad69eda	plannable import: safer config generation and schema filters (#33232) ... * genconfig: fix nil nested block panic * genconfig: null NestingSingle blocks should be absent A NestingSingle block that is null in state should be completely absent from config. * configschema: make FilterOr variadic * configschema: apply filters to nested types * configschema: filter helper/schema id attribute The legacy SDK adds an Optional+Computed "id" attribute to the resource schema even if not defined in provider code. During validation, however, the presence of an extraneous "id" attribute in config will cause an error. Remove this attribute so we do not generate an "id" attribute where there is a risk that it is not in the real resource schema. * configschema: filter test * terraform: do not pre-validate generated config Config generated from a resource's import state may fail validation in the case of schema behaviours such as ExactlyOneOf and ConflictsWith. We don't want to fail the plan now, because that would give the user no way to proceed and fix the config to make it valid. We allow the plan to complete and output the generated config. * generate config alongside import process Rather than waiting until we call `plan()`, generate the configuration at the point of the import call, so we have the necessary data to return in case planning fails later. The `plan` and `state` predeclared variables in the plan() method were obfuscating the actual return of nil throughout, so those identifiers were removed for clarity. * move generateHCLStringAttributes closer to caller * store generated config in plan on error * test for config gen with error * add simple warning when generating config --------- Co-authored-by: James Bardin <j.bardin@gmail.com>	3 years ago
Masayuki Morita	53755180fd	Fix an error message for import block with moved block (#33221) ... Fixes #33220	3 years ago
CJ Horton	adcecddb4f	Merge pull request #33193 from hashicorp/radditude/no-import-blocks-in-child-modules ... plannable import: disallow import blocks in child modules	3 years ago
kmoe	1172d40d7b	error if import target is move source (#33192) ... It is invalid for any import block to have a "to" argument matching any moved block's "from" argument.	3 years ago
CJ Horton	2dd89d9776	import blocks are only allowed in the root module	3 years ago
CJ Horton	bd6ba6cf99	check for duplicate import blocks (#33190) ... Importing to the same target address twice or importing the same ID to multiple different resources of the same type is not allowed.	3 years ago
Liam Cervante	5d6c5a9a33	plannable import: add a provider argument to the import block (#33175) ... * command: keep our promises * remove some nil config checks Remove some of the safety checks that ensure plan nodes have config attached at the appropriate time. * add GeneratedConfig to plan changes objects Add a new GeneratedConfig field alongside Importing in plan changes. * add config generation package The genconfig package implements HCL config generation from provider state values. Thanks to @mildwonkey whose implementation of terraform add is the basis for this package. * generate config during plan If a resource is being imported and does not already have config, attempt to generate that config during planning. The config is generated from the state as an HCL string, and then parsed back into an hcl.Body to attach to the plan graph node. The generated config string is attached to the change emitted by the plan. * complete config generation prototype, and add tests * plannable import: add a provider argument to the import block * Update internal/configs/config.go Co-authored-by: kmoe <5575356+kmoe@users.noreply.github.com> * Update internal/configs/config.go Co-authored-by: kmoe <5575356+kmoe@users.noreply.github.com> * Update internal/configs/config.go Co-authored-by: kmoe <5575356+kmoe@users.noreply.github.com> * fix formatting and tests --------- Co-authored-by: Katy Moe <katy@katy.moe> Co-authored-by: kmoe <5575356+kmoe@users.noreply.github.com>	3 years ago
Liam Cervante	79f7f59155	Plannable import: Generate config for imported resources during the plan. (#33153) ... * command: keep our promises * remove some nil config checks Remove some of the safety checks that ensure plan nodes have config attached at the appropriate time. * add GeneratedConfig to plan changes objects Add a new GeneratedConfig field alongside Importing in plan changes. * add config generation package The genconfig package implements HCL config generation from provider state values. Thanks to @mildwonkey whose implementation of terraform add is the basis for this package. * generate config during plan If a resource is being imported and does not already have config, attempt to generate that config during planning. The config is generated from the state as an HCL string, and then parsed back into an hcl.Body to attach to the plan graph node. The generated config string is attached to the change emitted by the plan. * complete config generation prototype, and add tests --------- Co-authored-by: Katy Moe <katy@katy.moe>	3 years ago
hashicorp-copywrite[bot]	325d18262e	[COMPLIANCE] Add Copyright and License Headers	3 years ago
kmoe	c6400fabb1	configs: add import block (#33081)	3 years ago
kmoe	531efd303b	add types for plannable import (#33080)	3 years ago
Liam Cervante	3827120c25	Checks: Add configuration for check blocks (#32734) ... * Add support for scoped resources * refactor existing checks addrs and add check block addr * Add configuration for check blocks * address comments	3 years ago
Liam Cervante	af05cbb645	Add support for scoped resources (#32732)	3 years ago
Eugene Dementyev	36aac6b498	Fixes depends_on when overriding modules (#32796) ... Fixes #32795	3 years ago
Alisdair McDiarmid	8df065a2fe	initwd: Switch from earlyconfig to configs ... This is a mostly mechanical refactor with a handful of changes which are necessary due to the semantic difference between earlyconfig and configs. When parsing root and descendant modules in the module installer, we now check the core version requirements inline. If the Terraform version is incompatible, we drop any other module loader diagnostics. This ensures that future language additions don't clutter the output and confuse the user. We also add two new checks during the module load process: * Don't try to load a module with a `nil` source address. This is a necessary change due to the move away from earlyconfig. * Don't try to load a module with a blank name (i.e. `module ""`). Because our module loading manifest uses the stringified module path as its map key, this causes a collision with the root module, and a later panic. This is the bug which triggered this refactor in the first place.	3 years ago
Nick Fagerlund	83428c91f1	Fix accidental mutation of shared `cty.Path`s in ValueMarks funcs ... Go's `append()` reserves the right to mutate its primary argument in-place, and expects the caller to assign its return value to the same variable that was passed as the primary argument. Due to what was almost definitely a typo (followed by copy-paste mishap), the configschema `Block.ValueMarks` and `Object.ValueMarks` functions were treating it like an immutable function that returns a new slice. In rare and hard-to-reproduce cases, this was causing bizarre malfunctions when marking sensitive schema attributes in deeply-nested block structures -- omitting the marks for some sensitive values (🚨), and marking other entire blocks as sensitive (which is supposed to be impossible). The chaotic and unreliable nature of the bugs is likely related to `append()`'s automatic slice reallocation behavior (if the append operation overflows the original array allocation, the resulting behavior can _look_ immutable), but there might be other contributing factors too. This commit fixes existing instances of the problem, and wraps the desired copy-and-append behavior in a helper function to simplify handling shared parent paths in an immutable way.	3 years ago
Alisdair McDiarmid	551f6316fa	Do not apply type defaults to null values ... Applying object type defaults to null values can convert null to an object with partial attributes. This means that even a specified default value of null will not remain null after variable evaluation. In turn, the result can then be invalid, if not all attributes in an object type have defaults specified. This commit skips the type default application step during config load and variable evaluation if the default or given value is null of any type. We still perform type conversion.	4 years ago
Alisdair McDiarmid	9d864c2430	Use upstreamed HCL typexpr package ... The 2.14.0 release of HCL includes the typeexpr changes we tested here, so now we can revert to using the HCL package and remove our fork.	4 years ago
Martin Atkins	209b8de7a5	configs: Variable and Output both have Addr methods ... We previously added methods like this for some of the other types in this package, including Local in this same file, but apparently haven't needed these two yet.	4 years ago
Martin Atkins	783a07d9e8	build: Use Go 1.19 ... Go 1.19's "fmt" has some awareness of the new doc comment formatting conventions and adjusts the presentation of the source comments to make it clearer how godoc would interpret them. Therefore this commit includes various updates made by "go fmt" to acheve that. In line with our usual convention that we make stylistic/grammar/spelling tweaks typically only when we're "in the area" changing something else anyway, I also took this opportunity to review most of the comments that this updated to see if there were any other opportunities to improve them.	4 years ago
James Bardin	8354bc46cf	Merge pull request #31576 from hashicorp/jbardin/validate-deprecated-computed ... validate deprecated attributes from static traversals	4 years ago
James Bardin	1a5e403329	Merge pull request #31532 from hashicorp/jbardin/static-validate-nested-types ... Account for `NestedType` in static traversal validation	4 years ago
James Bardin	25f5a81048	validate deprecated attrs from static traversals ... We can't validate that data from deprecated nested attributes is used in the configuration, but we can at least catch the simple case where a deprecated attribute is referenced directly.	4 years ago
Radek Simko	fc62afb6dc	fix: validate implied provider names in submodules (#31573)	4 years ago
James Bardin	43100fbe39	handle nested types in StaticValidateTraversal ... The StaticValidateTraversal code was not taking into account nested structural types. Rather than create more special cases for checking Type vs NestedType, we move the ImpliedType method up to the Attribute to ensure both are used to generate the final type spec.	4 years ago
Radek Simko	7feef1c4aa	Use hashicorp/terraform-registry-address as a decoupled library (#28338) ... * refactor: Use tfaddr for provider address parsing * refactor: Use tfaddr for module address parsing * deps: introduce hashicorp/terraform-registry-address	4 years ago
Martin Atkins	b88e29e473	configs: Show tailored message for optional attrs experiment ... Since we've both concluded the module_variables_optional_attrs experiment and made experiments available only in alpha releases in the same minor release, we accidentally made the more general message about experiments not being available mask the specific message about the experiment being concluded. In order to give better feedback to those who were participating in the experiment in earlier Terraform releases, we'll retain a minimal exception to our checks to allow the "experiment has concluded" error message to shine through if and only if that is the only selected experiment.	4 years ago
Alisdair McDiarmid	64cf53bd7e	configs: Fix check block configuration diagnostics ... When validating self-references for resource and data source preconditions and postconditions, we previously did not nil-check the block's condition field, which caused a panic when the block had no condition. While fixing this I noticed that we were not validating that there are no self-references in the error message, so fixed that.	4 years ago
Martin Atkins	fda0579537	Experiments supported only in alpha/dev builds ... We originally introduced the idea of language experiments as a way to get early feedback on not-yet-proven feature ideas, ideally as part of the initial exploration of the solution space rather than only after a solution has become relatively clear. Unfortunately, our tradeoff of making them available in normal releases behind an explicit opt-in in order to make it easier to participate in the feedback process had the unintended side-effect of making it feel okay to use experiments in production and endure the warnings they generate. This in turn has made us reluctant to make use of the experiments feature lest experiments become de-facto production features which we then feel compelled to preserve even though we aren't yet ready to graduate them to stable features. In an attempt to tweak that compromise, here we make the availability of experiments _at all_ a build-time flag which will not be set by default, and therefore experiments will not be available in most release builds. The intent (not yet implemented in this PR) is for our release process to set this flag only when it knows it's building an alpha release or a development snapshot not destined for release at all, which will therefore allow us to still use the alpha releases as a vehicle for giving feedback participants access to a feature (without needing to install a Go toolchain) but will not encourage pretending that these features are production-ready before they graduate from experimental. Only language experiments have an explicit framework for dealing with them which outlives any particular experiment, so most of the changes here are to that generalized mechanism. However, the intent is that non-language experiments, such as experimental CLI commands, would also in future check Meta.AllowExperimentalFeatures and gate the use of those experiments too, so that we can be consistent that experimental features will never be available unless you explicitly choose to use an alpha release or a custom build from source code. Since there are already some experiments active at the time of this commit which were not previously subject to this restriction, we'll pragmatically leave those as exceptions that will remain generally available for now, and so this new approach will apply only to new experiments started in the future. Once those experiments have all concluded, we will be left with no more exceptions unless we explicitly choose to make an exception for some reason we've not imagined yet. It's important that we be able to write tests that rely on experiments either being available or not being available, so here we're using our typical approach of making "package main" deal with the global setting that applies to Terraform CLI executables while making the layers below all support fine-grain selection of this behavior so that tests with different needs can run concurrently without trampling on one another. As a compromise, the integration tests in the terraform package will run with experiments enabled _by default_ since we commonly need to exercise experiments in those tests, but they can selectively opt-out if they need to by overriding the loader setting back to false again.	4 years ago
Alisdair McDiarmid	479c71f93d	Merge pull request #31210 from hashicorp/update-optional-type-attributes ... Edit type constraints docs for style and flow	4 years ago
James Bardin	57c0deb01e	check for duplicate defaults from resource names	4 years ago
Alisdair McDiarmid	922de89be1	Conclude module variable optional attrs experiment	4 years ago
James Bardin	2581bc93cb	Check for duplicate types in required_providers ... Adding multiple local names for the same provider type in required_providers was not prevented, which can lead to ambiguous behavior in Terraform. Providers are always indexed by the providers fully qualified name, so duplicate local names cannot be differentiated.	4 years ago
Alisdair McDiarmid	650380f3ae	configs: Add default argument to optional() ... The optional modifier previously accepted a single argument: the attribute type. This commit adds an optional second argument, which specifies a default value for the attribute. To record the default values for a variable's type, we use a separate parallel structure of `typeexpr.Defaults`, rather than extending `cty.Type` to include a `cty.Value` of defaults (which may in turn include a `cty.Type` with defaults, and so on, and so forth). The new `typeexpr.TypeConstraintWithDefaults` returns a type constraint and defaults value. Defaults will be `nil` unless there are default values specified somewhere in the variable's type.	4 years ago
James Bardin	a6968b5b20	Merge pull request #31060 from hashicorp/alisdair/fix-configload-snapshot-panic ... configs: Fix module loader nil pointer panic	4 years ago
Martin Atkins	ec421fe02d	configs: A test for the regression reported in #31081 ... 5417975946 addressed a regression in the logic for catching when the newer module meta-arguments are used in conjunction with the legacy practice of including provider configurations inside modules, where the check started incorrectly catching situations where the legacy nested provider configuration was in the same module as the child call using one of those meta-arguments. This is a regression test to catch if a similar bug arises in the future. Since it's testing validation rules that apply to an entire configuration tree, it ended up in a rather idiosyncratic location under the "configload" package, rather than directly in "configs". The "configs" package only knows how to load one module at a time, so it's harder to write a test like this in that context. Due to it being further removed from the code it is testing, I included a test for the correct error too in order to increase the chance that we'll learn if future changes in the "configs" package invalidate this regression test. I've verified that this new test fails without the change made in the earlier commit.	4 years ago