1228 Commits (39ef97beff463e8fe6cccd849c748027cfab1b09)

Author	SHA1	Message	Date
Frederic	0f1f504c22	command/format: indicate in diff when adding an attribute forces replacement	7 years ago
Pam Selle	ff7245f27c	Add status link to make message more helpful	7 years ago
Pam Selle	d72456d188	Add friendly error for when registry unresponsive ... If the registry is unresponsive, you will now get an error specific to this, rather than a misleading "provider unavailable" type error. Also adds debug logging for when errors like this may occur	7 years ago
Kristin Laemmert	d5bb09b13b	command/show: refresh is required to show remote state (#20818)	7 years ago
Justin Downing	1e32ae243c	grammatical updates to comments and docs (#20195)	7 years ago
findkim	161fe47b34	plugin/discovery: improve providery discovery verification errors	7 years ago
Martin Atkins	e918fa83ec	command/format: Don't panic when item removed from list of objects ... Due to these tests happening in the wrong order, removing an object from the end of a sequence of objects would previously cause a bounds-check panic. Rather than a more severe rework of the logic here, for now we'll just introduce an extra precondition to prevent the panic. The code that follows already handles the case where there _is_ no new object (i.e. the "old" object is being deleted) as long as we're able to pass through this type-checking logic. The new "JSON list of objects - removing item" test covers this problem by rendering a diff for an object being removed from the end of a list of objects within a JSON value.	7 years ago
Justin Campbell	e696e063dc	Merge pull request #20674 from hashicorp/registry-warnings ... plugin/discovery: Parse warnings from TF Registry	7 years ago
Justin Campbell	e6316c9de6	plugin/discovery: Parse warnings from TF Registry ... Terraform Registry (and other registry implementations) can now return an array of warnings with the versions response. These warnings are now displayed to the user during a `terraform init`.	7 years ago
Justin Campbell	24e13d8ec1	plugin/discovery: Return tfdiags from Get ... Allows us to surface warnings to the user using the tfdiags interfaces.	7 years ago
Martin Atkins	c39905e1a8	command: Fix various issues in the "terraform state ..." subcommands ... In earlier refactoring we updated these commands to support the new address and state types, but attempted to partially retain the old-style "StateFilter" abstraction that originally lived in the Terraform package, even though that was no longer being used for any other functionality. Unfortunately the adaptation of the existing filtering to the new types wasn't exact and so these commands ended up having a few bugs that were not covered by the existing tests. Since the old StateFilter behavior was the source of various misbehavior anyway, here it's removed altogether and replaced with some simpler functions in the state_meta.go file that are tailored to the use-cases of these sub-commands. As well as just generally behaving more consistently with the other parts of Terraform that use the new resource address types, this commit fixes the following bugs: - A resource address of aws_instance.foo would previously match an resource of that type and name in any module, which disagreed with the expected interpretation elsewhere of meaning a single resource in the root module. - The "terraform state mv" command was not supporting moves from a single resource address to an indexed address and vice-versa, because the old logic didn't need to make that distinction while they are two separate address types in the new logic. Now we allow resources that do not have count/for_each to be treated as if they are instances for the purposes of this command, which is a better match for likely user intent and for the old behavior. Finally, we also clean up a little some of the usage output from these commands, which hasn't been updated for some time and so had both some stale information and some inaccurate terminology.	7 years ago
Kristin Laemmert	c73a5fc07d	command/show: add provider name to resource changes (#20711)	7 years ago
Kristin Laemmert	9d0d564ec7	`terraform show` and `terraform providers schema -json` should return valid json (#20697) ... * command/providers schemas: return empty json object if config parses successfully but no providers found * command/show (state): return an empty object if state is nil	7 years ago
James Bardin	0569e39788	don't try to treat "null" as json in diff output ... Trying to decode and write "null" as json will panic, since it decodes to nil.	7 years ago
Kristin Laemmert	a15a4acf2f	configs/configupgrade: detect possible relative module sources (#20646) ... * configs/configupgrade: detect possible relative module sources If a module source appears to be a relative local path but does not have a preceding ./, print a #TODO message for the user. * internal/initwd: limit go-getter detectors to those supported by terraform * internal/initwd: move isMaybeRelativeLocalPath check into getWithGoGetter To avoid making two calls to getter.Detect, which potentially makes non-trivial API calls, the "isMaybeRelativeLocalPath" check was moved to a later step and a custom error type was added so user-friendly diagnostics could be displayed in the event that a possible relative local path was detected.	7 years ago
James Bardin	a8df5586c0	check for errors when loading a backend config ... We can't dereference the config module if there were any errors loading it.	7 years ago
Martin Atkins	2d41c1009b	command/format: Diffs for NestingMap block types ... Our initial prototype of new-style diff rendering excluded this because the old SDK has no support for this construct. However, we want to be able to introduce this construct in the new SDK without breaking compatibility with existing versions of Terraform Core, so we need to implement it now so it's ready to be used once the SDK implements it. The key associated with each block allows us to properly correlate the items to recognize the difference between an in-place update of an existing block and the addition/deletion of a block.	7 years ago
Martin Atkins	dd1fa322a7	command/format: Support list/map blocks with dynamic-typed attrs ... Our null-to-empty normalization was previously assuming these would always be collection types, but that isn't true when a block contains something dynamic since we must then use tuple or object types instead to properly represent all of the individual element types.	7 years ago
Martin Atkins	69772b11b1	command/format: test for diff rendering with dynamic-typed subattrs ... We use cty a little differently when a nested list block contains a dynamically-typed attribute: it appears as a tuple value instead of a list value so that we can retain the individual types of each element. Here we introduce a test for that case, but doing so required also making the runTestCases function handle types in a stricter way so that it will produce planned values that match how Terraform Core would do it, including the necessary late-bound type information for the dynamically-typed attribute.	7 years ago
Kristin Laemmert	30672faebe	remove indentation from json output of `show` and `providers schema` (#20623) ... * command/providers schema: correct help text * command/show: remove indentation from json output * command/providers schema: remove indentation from json output	7 years ago
James Bardin	b8e53255b4	Revert "remove NormalizeObjectFromLegacySDK from diff" ... This reverts commit 5c40d6610c.	7 years ago
Sander van Harmelen	973e2a7cf9	core: add a context to the UIInput interface	7 years ago
James Bardin	a95d97f066	Merge pull request #20595 from hashicorp/jbardin/normalize-objects ... normalize all objects read from the provider	7 years ago
James Bardin	5c40d6610c	remove NormalizeObjectFromLegacySDK from diff ... The NormalizeObjectFromLegacySDK calls have been moved into the provider shims, so all objects generated by the provider should conform now.	7 years ago
Brian Flad	20a814028d	command: Consistency implement and document parallelism default of 10 ... References: * f4da82a023/command/command.go (L41) * b9d8e96e0c/terraform/context.go (L149-L155)	7 years ago
Kristin Laemmert	b9d8e96e0c	command/plan: plan output should indicate if a resource is being (#20580) ... replaced because the instance was tainted.	7 years ago
Kristin Laemmert	d72defd044	command/show and state show: honor user-specified plugin-dir (#20557) ... Previously, these commands were not checking if the user specified a `-plugin-dir` flag during `terraform init` and would therefor fail if providers were not in one of the standard directories. Fixes #20547	7 years ago
James Bardin	369d512e22	Merge pull request #20546 from hashicorp/jbardin/backend-init-panic ... don't panic of the users aborts backend input	7 years ago
James Bardin	2adf5801d9	don't panic of the users aborts backend input ... When the user aborts input, it may end up as an unknown value, which needs to be converted to null for PrepareConfig. Allow PrepareConfig to accept null config values in order to fill in missing defaults.	7 years ago
Kristin Laemmert	8fb4e5ce6e	command/show: differentiate between state schemas and plan schemas. (#20516) ... When a planfile is supplied to the `terraform show -json` command, the context that loads only included schemas for resources in the plan. We found an edge case where removing a data source from the configuration (though only if there are no managed resources from the same provider) would cause jsonstate.Marshal to fail because the provider schema wasn't in the plan context. jsonplan.Marshal now takes two schemas, one for plan and one for state. If the state schema is nil it will simply use the plan schemas.	7 years ago
Kristin Laemmert	c4151b7c7c	command/show: fixing bugs in modulecalls (#20513) ... * command/show: fixing bugs in modulecalls jsonconfig and jsonplan both had subtle bugs with the logic for marshaling module calls that only showed up when multiple modules were referenced. This PR fixes those bugs and extends the existing tests to include multiple modules. * sort all the things, mostly for tests	7 years ago
Kristin Laemmert	21f6e3dffd	Mildwonkey/012 docs updated (#20542) ... * docs: update plan command documentation. Fixes #19235 * docs: added a missing reserved variable name. Fixes #19159. * website: add note that resource names cannot start with a number * website: add some notes to the 0.12 upgrade guide	7 years ago
Martin Atkins	f193b11073	command/format: Normalize before/after values before rendering ... We are now allowing the legacy SDK to opt out of the safety checks we try to do after plan and apply, and so in such cases the before/after values in planned changes may be inconsistent with our usual rules. To avoid adding lots of extra complexity to the diff renderer to deal with these situations, instead we'll normalize the handling of nested blocks prior to using these values. In the long run it'd be better to do this normalization at the source, immediately after we receive an object from a provider using the opt-out, but we're doing this at the outermost layer for now to avoid risking unintended impacts on other Terraform Core components when we're just about to enter the beta phase of the v0.12.0 release cycle.	7 years ago
James Bardin	f43b87a61e	Merge pull request #20480 from hashicorp/jbardin/backend-init ... backend init defaults and inputs	7 years ago
James Bardin	c814f2da37	Change backend.ValidateConfig to PrepareConfig ... This mirrors the change made for providers, so that default values can be inserted into the config by the backend implementation. This is only the interface and method name changes, it does not yet add any default values.	7 years ago
Martin Atkins	6b6be3af35	command: Remove promise of plan -validate-only from validate docs ... We brought forward a new implementation of "terraform validate" that was originally scheduled for a later release after finding that it would be simpler than reworking the old implementation for new v0.12 assumptions, but we didn't yet implement "terraform plan -validate-only" in spite of it being mentioned in the updated docs for "terraform validate". For now then, the documentation will make the weaker suggestion of running "terraform plan" to validate a particular _run_ rather than a particular _module_, which is the closest thing we have for now. At some point after v0.12.0 we will evaluate whether a validate-only mode for "terraform plan" (which could then run without configuring the providers at all) is needed.	7 years ago
Kristin Laemmert	16823f43de	command/jsonprovider: export providers schemas to json (#20446) ... * command/jsonprovider: a new package for exporting providers schemas as JSON	7 years ago
Martin Atkins	552dddfb4c	command: Specialized error message for var decls in tfvars ... A common new-user mistake is to place variable _declarations_ into .tfvars files instead of variable _values_. To guide towards the correct approach here, we add a specialized error message for that situation that includes guidance on the distinction between declaring and setting values for variables, and an example of what setting a value should look like.	7 years ago
Kristin Laemmert	4dd8192ec7	Merge pull request #20352 from hashicorp/mildwonkey/show-docs ... mildwonkey/show-docs	7 years ago
Nick Fagerlund	3c42508700	Apply suggestions from code review ... Co-Authored-By: mildwonkey <mildwonkey@users.noreply.github.com>	7 years ago
Kristin Laemmert	0c94e20a83	command/show enhancements and bugfixes ... * command/jsonconfig: provider config marshaling enhancements This PR fixes a bug wherein the keys in "provider_config" were the "addrs.ProviderConfig", and therefore being overwritten for each module, instead of the intended "addrs.AbsProviderConfig". We realized that there was still opportunity for ambiguity, for example if a user made a provider alias that was the same name as a module, so we opted to use the syntax `modulename:providername(.provideralias)` * command/json*: fixed a bug where we were attempting to lookup schemas with the provider name, instead of provider type.	7 years ago
Kristin Laemmert	b14472f22c	command/jsonconfig: add missing fields from configuration output (#20387) ... Display depends_on for resources and outputs, and description for outputs.	7 years ago
Kristin Laemmert	874b333962	command/format: fix an issue where data resources were not displaying (#20386) ... Fixes #20245	7 years ago
Kristin Laemmert	c59a274e96	command/jsonplan: "deposed" should be a string, not a bool. (#20351)	7 years ago
Kristin Laemmert	818b4ec068	command/show: add "module_version" to "module_calls" in config (#20367) ... * command/show: add "module_version" to "module_calls" in config portion of `terraform show`. Also extended the `terraform show -json` test to run `init` so we could add examples with modules. This does _not_ test the "module_version" yet, but it _did_ help expose a bug in jsonplan where modules were duplicated. This is also fixed in this PR. * command/jsonconfig: rename version to version_constraint and resolved_source to source.	7 years ago
Kristin Laemmert	a43004e382	website/docs: add detailed documentation for the json serialization of ... terraform plan	7 years ago
Kristin Laemmert	f7ab90207c	website/docs: add -json flag to terraform show docsn	7 years ago
Kristin Laemmert	f783ed0d45	command/jsonconfig: display module variables in config output (#20311) ... * command/jsonconfig: display module variables in config output The tests have been updated to reflect this change. * command/jsonconfig: properly handle variables with nil defaults	7 years ago
Martin Atkins	eb1346447f	Merge #20282: Enforce expected behaviors for provider PlanResourceChange ... An exception remains for the legacy SDK, which does not meet all of these requirements.	7 years ago
Martin Atkins	0b7179c363	command: Apply tests with realistic mock providers ... Now that we're actually verifying correct behavior of providers during plan and apply, our mock providers need to behave like real providers, properly propagating any configured values through the plan and into the final state. For most of these it was simpler to just switch over to using the newer PlanResourceChangeFn mock interface, away from the legacy DiffFn approach, because then we can just return the ProposedNewState verbatim because our schema for these tests does not require any default values to be populated.	7 years ago