928 Commits (356cee7b89c99ea1f77ea002bb2249b2950ad331)

Author	SHA1	Message	Date
Alisdair McDiarmid	356cee7b89	typeexpr: Add test coverage for optional modifier	4 years ago
Alisdair McDiarmid	bf9f733ca2	typeexpr: Import tests from hashicorp/hcl ... This package is a fork of the HCL ext/typeexpr package, but we dropped the tests when bringing it across. This commit imports those tests verbatim.	4 years ago
Alisdair McDiarmid	12c8f9498c	json-output: Add output type to JSON format ... Previously the supported JSON plan and state formats included only serialized output values, which was a lossy serialization of the Terraform type system. This commit adds a type field in the usual cty JSON format, which allows reconstitution of the original value. For example, previously a list(string) and a set(string) containing the same values were indistinguishable. This change serializes these as follows: { "value": ["a","b","c"], "type": ["list","string"] } and: { "value": ["a","b","c"], "type": ["set","string"] }	4 years ago
Sebastian Rivera	9d7fdbea2d	Handle -input=false in cloud integration ... For non-interactive contexts, Terraform is typically executed with the flag -input=false. However for runs that are not set to auto approve, the cloud integration will prompt a user for approval input even with input being set to false. This commit enables the cloud integration to know the value of the input flag and use it to determine whether or not to ask the user for input. If -input is set to false and the run cannot be auto approved, the cloud integration will throw an error stating run confirmation can no longer be handled in the CLI and that they must do so through the browser.	4 years ago
Sebastian Rivera	c557078704	Merge pull request #30917 from hashicorp/sebasslash/config-token-precedence ... Give the configuration token higher precedence over the CLI config file	4 years ago
James Bardin	d9af967a6e	build a test apply graph during plan ... The plan graph does not contain all the information necessary to detect cycles which may happen when building the apply graph. Once we have more information from the plan we can build the complete apply graph with all individual instances to verify that the apply can begin without errors.	4 years ago
James Bardin	7da52d94f2	Merge pull request #30900 from hashicorp/jbardin/replace-triggered-by ... Configurable instance replacement via lifecycle `replace_triggered_by`	4 years ago
Sebastian Rivera	5ded48e081	Give token in cloud config higher precedence than CLI config file	4 years ago
Keith Clawson	23dffee568	Always use token in backend config when provided	4 years ago
chavacava	5f58daaf57	fix typo in struct tag (#30884) ... typo found by [`revive`](https://github.com/mgechev/revive)	4 years ago
James Bardin	7b6dfabb74	Merge pull request #30906 from hashicorp/jbardin/races ... Fix known races and enable race detector in tests	4 years ago
James Bardin	0731213ecf	sync retry goroutine return	4 years ago
James Bardin	c52e3ed37b	test fixture race	4 years ago
James Bardin	0fe38fba6c	prevent unsynchronized output changes access ... The raw plan output changes were stored in the output exec node, when they should have instead been fetch lazily through the context via the synchronized ChangesSync value.	4 years ago
Sebastian Rivera	f63ef2b5ef	Rename cloud env vars to use TF_CLOUD prefix	4 years ago
James Bardin	1e79682c24	minor fixes	4 years ago
Martin Atkins	d4776e8ef1	lang/funcs: type conversion functions can convert null values ... We had intended these functions to attempt to convert any given value, but there is a special behavior in the function system where functions must opt in to being able to handle dynamically-typed arguments so that we don't need to repeat the special case for that inside every function implementation. In this case we _do_ want to specially handle dynamically-typed values, because the keyword "null" in HCL produces cty.NullVal(cty.DynamicPseudoType) and we want the conversion function to convert it to a null of a more specific type. These conversion functions are already just a thin wrapper around the underlying type conversion functionality anyway, and that already supports converting dynamic-typed values in the expected way, so we can just opt in to allowing dynamically-typed values and let the conversion functionality do the expected work. Fixing this allows module authors to use type conversion functions to give additional type information to Terraform in situations that are too ambiguous to be handled automatically by the type inference/unification process. Previously tostring(null) was effectively a no-op, totally ignoring the author's request to treat the null as a string.	4 years ago
Tom Harvey	2eb9118cd1	backend/remote-state/azure: defaulting the Azure Backend to use MSAL (#30891) ... * backend/remote-state/azure: defaulting the Azure Backend to use MSAL Fixes #30881 * backend/remote-state/azurerm: deprecating `use_microsoft_graph`	4 years ago
James Bardin	3a0a019521	round-trip replace triggers	4 years ago
James Bardin	54c1791a1b	add triggers reason to plan proto	4 years ago
James Bardin	868052c9e3	set replace_trigered_by reason in diff output	4 years ago
James Bardin	e2fc9a19f5	use ResourceInstanceReplaceByTriggers ... Set ResourceInstanceReplaceByTriggers in the change.	4 years ago
James Bardin	e4c4dcbd14	add ResourceInstanceReplaceByTriggers	4 years ago
James Bardin	91121aa856	limit replace_triggered_by to same module instance ... replace_triggered_by references are scoped to the current module, so we need to filter changes for the current module instance. Rather than creating a ConfigResource and filtering the result, make a Changes.InstancesForAbsResource method to get only the AbsResource changes.	4 years ago
James Bardin	fb6fcf783b	Fix replace_triggered_by criteria ... Only immediate changes to the resource are considered.	4 years ago
James Bardin	6670b71a2e	context test demonstrating replace_triggered_by	4 years ago
James Bardin	7598665c90	check for replacement via replace_triggered_by ... Check for triggered resource replacement in the plan. While the functionality of the feature works here, we ill want to follow up with a way to indicate in the plan _why_ the resource was replaced.	4 years ago
James Bardin	4f2195af2b	collect references from replace_triggered_by ... The replace_triggered_by expressions create edges in the graph, so must be returned in the References method.	4 years ago
James Bardin	4d43d6f699	Use the EvalContext to lookup trigger changes ... The EvalContext is the only place with all the information to be able to complete the evaluation of the replace_triggered_by expressions. These need to be evaluated into a reference, which is then looked up in the pending changes which the context has access too. On top of needing the plan changes, we also need access to all providers and schemas to decode the changes if we need to traverse the resource values for individual attributes.	4 years ago
James Bardin	8b4c89bdaf	evaluate replace_triggered_by expressions ... Evaluate the expressions stored in replace_triggered_by into the *addrs.Reference needed to lookup changes in the plan.	4 years ago
James Bardin	6eb3264d1a	parse replace_triggered_by in resource configs	4 years ago
Brandon Croft	1943af51a2	fix(creds): allow periods in TF_TOKEN_... credentials vars	4 years ago
Brandon Croft	42da030090	Merge pull request #30850 from hashicorp/brandonc/cloud_test_revisions ... test(cloud): ensure mocks are used for backend configure tests	4 years ago
Radek Simko	746af015ea	internal/getproviders: Add URL to error message for clarity (#30810) ... * internal/getproviders: Add URL to error message for clarity Occasionally `terraform init` on some providers may return the following error message: Error while installing citrix/citrixadc v1.13.0: could not query provider registry for registry.terraform.io/citrix/citrixadc: failed to retrieve authentication checksums for provider: 403 Forbidden The 403 is most often returned from GitHub (rather than Registry API) and this change makes it more obvious. * Use Host instead of full URL	4 years ago
James Bardin	d360a78771	Merge pull request #30832 from hashicorp/jbardin/data-readResourceInstanceState ... remove the use of data source prior state from planning	4 years ago
James Bardin	f31dab4838	Merge pull request #30830 from hashicorp/jbardin/data-schema-change ... data schema changes may prevent state decoding	4 years ago
Sebastian Rivera	3ebd8c9483	Merge pull request #30836 from hashicorp/sebasslash/env-cloud-e2e-tests ... Cloud e2e tests for configuring `cloud` with env vars	4 years ago
Brandon Croft	f04202d222	Update credentials_test.go	4 years ago
Brandon Croft	fda05f3d44	feat(credentials): allow hyphens to be encoded as __ in variables ... Hyphen characters are allowed in environment variable names, but are not valid POSIX variable names. Usually, it's still possible to set variable names with hyphens using utilities like env or docker. But, as a fallback, host names may encode their hyphens as double underscores in the variable name. For the example "café.fr", the variable name "TF_TOKEN_xn____caf__dma_fr" or "TF_TOKEN_xn--caf-dma_fr" may be used.	4 years ago
Brandon Croft	307326fa3a	allow remote service creds to be configured using env ... Introduces a new method of configuring token service credentials using a host-specific environment variable. This configuration was previously possible using the [terraform-credentials-env](https://github.com/apparentlymart/terraform-credentials-env) credentials helper. This new method is now consulted first, as it is seen to be the most proximate source of credentials before CLI configuration while still falling back to the credentials helper.	4 years ago
Brandon Croft	0dc26a9585	test(cloud): nonexisting org not a valid test when using mocks	4 years ago
Brandon Croft	a38a0ee8a8	test(cloud): ensure mocks are used for backend configure tests ... Also adds a few new tests for cloud configuration using environment variables	4 years ago
Alisdair McDiarmid	fadcaaaad2	cli: Fix double-quoted map keys in diff UI ... A previous change added missing quoting around object keys which do not parse as barewords. At the same time we introduced a bug where map keys could be double-quoted, due to calling the `displayAttributeName` helper function (to quote non-bareword keys) then using the `writeValue` method (which quotes all strings). This commit fixes this and adds test coverage for map keys which require quoting.	4 years ago
Sebastian Rivera	b191faf8a4	Add skip test if missing vars helper	4 years ago
Sebastian Rivera	34114286ff	Cloud e2e tests for configuring with env vars	4 years ago
Sebastian Rivera	8040dfec34	Merge pull request #30787 from hashicorp/sebasslash/tf-workspace-cloud-config ... Add cloud config support for TF_WORKSPACE	4 years ago
Sebastian Rivera	dd864b1bac	Add TF_WORKSPACE validation method	4 years ago
James Bardin	74885b1108	remove data sources from state read and upgrade ... Data sources should not require reading the previous versions. While we previously skipped the decoding if it were to fail, this removes the need for any prior state at all. The only place where the prior state was functionally used was in the destroy path. Because a data source destroy is only for cleanup purposes to clean out the state using the same code paths as a managed resource, we can substitute the prior state in the change change with a null value to maintain the same behavior.	4 years ago
James Bardin	29ecac0808	remove the use of data source prior state entirely ... After data source handling was moved from a separate refresh phase into the planning phase, reading the existing state was only used for informational purposes. This had been reduced to reporting warnings when the provider returned an unexpected value to try and help locate legacy provider bugs, but any actual issues located from those warnings were very few and far between. Because the prior state cannot be reliably decoded when faced with incompatible provider schema upgrades, and there is no longer any significant reason to try and get the prior state at all, we can skip the process entirely.	4 years ago
James Bardin	a7987dec9f	remove redundant readResourceInstanceState	4 years ago