terraform

Commit Graph

Author	SHA1	Message	Date
Radek Simko	6d11e670c1	website: (Re)Move markdown documentation (#37417 ) * website: (Re)Move markdown documentation * make: remove website targets * gitignore: remove website paths * CODEOWNERS: remove website paths * gh/ISSUE_TEMPLATE: Direct folks to unified repo for docs * Readme: Update link to docs * Update refs to website folder * Re-add Readme.md with a warning and link to the unified repo	6 months ago
Liam Cervante	eeacced8f0	Add go vet as a check to the Github commit actions (#31461 ) * Add go vet as a check to the Github commit actions * deliberately break to test * fix after successful test * Use directly * fix more errors	1 year ago
Martin Atkins	5811be26f8	go.mod: Separate modules at code ownership boundaries Historically it's been hard for us to keep on top of dependency upgrades as a matter of course because it's unclear which code owners might be affected by or responsible for an upgrade of each module. After trying a few different techniques to try to mitigate this, the most promising one seems to be to tell the Go toolchain that each of these components is a separate Go module, but then to stitch them all back together again using replace directives so that we can mostly ignore these module boundaries in everyday development. The one case where we _do_ need to pay attention to these boundaries is also the case where the separation is useful: upgrading a dependency of any one of these modules might potentially force upgrading it for another module too, and so the Go toolchain will help us notice that interaction and we can immediately which code owners might need to be involved in reviewing and testing that particular upgrade. To make that process less onerous, this adds a new makefile target "make syncdeps" which runs "go mod tidy" in all of the modules at once and thus forces the toolchain to align their dependencies to the extent required for them all to be linked together successfully, and to generate go.mod and/or go.sum diffs that will match our configured code ownership paths to trigger the appropriate code review requests. Hopefully before too long we'll be able to move all the backends out into provider plugins and delete the "legacy" module entirely and then this oddness won't be needed anymore, but as long as we're all trying to play together in this same sandbox this is a small amount of extra ceremony in return for hopefully reducing the level of anxiety involved in keeping the system's dependencies up to date more consistently.	2 years ago
Radek Simko	0c509183d1	ci: Add test for license headers (#34624 ) * ci: Add test for copyright headers * replace GHA workflow with make target (copyright) This makes it reusable for outside of CI, such that anyone cloning the repo locally can still easily verify compliance before raising a PR. * remove go:generate for copywrite This should no longer be needed as we leverage copywrite via a shell script now. * introduce make copyrightfix	2 years ago
HashiBot	54de574e2b	chore: Update Digital Team Files (#32037 ) * Update generated scripts (website-start.sh) * Update generated website Makefile * Update generated scripts (should-build.sh) * Update generated scripts (website-build.sh) * chore: update root `Makefile` Co-authored-by: Kevin Wang <kwangsan@gmail.com>	3 years ago
Martin Atkins	4c7f20853f	build: Run scripts directly from makefile, rather than via sh All four of these scripts have #! lines calling for them to run in bash, and they are all marked as executable, so there's no harm in running them directly and it makes it clearer that we're running them in the shell specified on the #! line, rather than with whatever "sh' happens to be on the current system. (Note that this _was_ still correctly using the #! lines before, because it's `sh -c` rather than just `sh`, but nonetheless that old way seemed needlessly confusing.)	4 years ago
Martin Atkins	edb1152ae0	build: Enable command echo for various Makefile targets When we run many of these together e.g. in the checks.yaml GitHub Actions workflow, it's hard to tell from the output exactly which command is producing which subset of the output. To help clarify that, we'll ask make to print out the command line it's running before it runs it.	4 years ago
Liam Cervante	afd273d636	Add goimports as a check to the Github commit actions (#31432 ) * Add goimports as a check to the Github commit actions * check diff against main instead of last commit * goimports should fix the problems * fix up conditionals and wildcard matching * specify origin/main in diff * fetch main branch when checkout * back to origin main	4 years ago
Kevin Wang	2563bf3f96	feat: support local preview, post split; add deploy preview (#30814 ) * chore: support local preview, post split * feat: deploy preview * update script perms - chmod +x ./website/scripts/website-build.sh * npm i * chore: website-build uses 'kevin/terraform-split' * deploy preview test * chore: test * PREVIEW_DIR & CLONE_DIR = preview * rm dupe preview path * empty commit * ../data & ..docs * website-preview * remove REPO var * move `intro` and `guides` back to where they were * empty commit * chore move `intro` and `guides` * chore: copy over images * move images into `/website` - content API requires this * chore: `CURRENT_GIT_BRANCH` * fix: `CURRENT_GIT_BRANCH` * fix `CURRENT_GIT_BRANCH` * debug current dir * fix `CURRENT_GIT_BRANCH` * chore: comment CURRENT_GIT_BRANCH * Update Makefile * Update website/scripts/website-build.sh * optimize images * chore(Makefile): move vars to top * remove branch	4 years ago
Dylan Staley	a086f0c1a5	update make website workflow	4 years ago
Alisdair McDiarmid	e09bad76ff	build: Add exhaustive switch statement lint For now, only check the JSON views package, since this was the instance that most recently tripped us up. There are a few dozen failures elsewhere in Terraform which would need to be addressed before expanding this to other packages.	4 years ago
James Bardin	a3fb07d008	add staticcheck make target cleanup the old fmtcheck script while we're in here	5 years ago
Martin Atkins	ce96d82de0	build: Centralize our protobuf compilation steps We have a few different .proto files in this repository that all need to get recompiled into .pb.go files each time we change them, but we were previously handling that with some scripts that just assumed that protoc and the relevant plugins were already installed on the system somewhere, at the right versions. In practice we've been constantly flopping between different versions of these tools due to folks having different versions installed in their development environments. In particular, the state of the .pb.go files in the prior commit wasn't reproducible by any single version of the tools because they've all slightly diverged from one another. In the interests of being more consistent here and avoiding accidental inconsistencies, we'll now centralize the protocol buffer compile steps all into a single tool that knows how to fetch and install the expected versions of the various tools we need and then run those tools with the right options to get a stable result. If we want to upgrade to either a newer protoc or a newer protoc-gen-go in future then we'll do that in a central location and update all of the .pb.go files at the same time, so that we're always consistently tracking the same version of protocol buffers everywhere. While doing this I attempted to keep as close as possible to the toolchain we'd most recently used, but since they were not consistent with each other they've now all changed which version numbers they record at minimum, and the planproto stub in particular now also has a slightly different descriptor serialization but is otherwise offering the same API.	5 years ago
Martin Atkins	d35bc05312	Update various non-code references to renamed Go packages Previous commits have moved all of our Go packages under "internal", so this is a retroactive update of non-Go references to those same packages.	5 years ago
Nick Fagerlund	bf5522aaec	Remove website-test task from Makefile This task relied on using `wget` to spider the entire site, which is no longer a useful way of checking for broken links on a non-production instance of terraform.io. Also, it didn't include a step for pausing until the server came online, so the task wouldn't have functioned properly anyway.	5 years ago
James Bardin	85b7027048	File no longer exists to be formatted Were no longer generating the internal plugins list which needs to be formatted.	5 years ago
James Bardin	8bfbafa790	remove vendor from some tooling	5 years ago
Pam Selle	0eac3de22a	Fix missing VERSION for running make website	6 years ago
Alisdair McDiarmid	ba374baef0	Makefile: remove unused targets Most of the targets in the Makefile have not been used in either CI or the normal development workflow for some time. Removing them clarifies that the expected way to build Terraform locally is simple: go install. Remaining targets: - fmtcheck, generate: these are used in CI to verify that the code is correctly formatted and that generate has been run appropriately - protobuf: referenced in CONTRIBUTING.md as the simplest way to build the proto files - website, website-test: used to compile and test the local website in isolation from the terraform-website repo	6 years ago
Pam Selle	9ae266f8fe	Coverage updates, roll back makefile change, use travis specific script	6 years ago
Pam Selle	6a4cfa18da	Coverage	6 years ago
Kristin Laemmert	c72d2c6c44	build: add terraform-bundle e2etests	6 years ago
Radek Simko	7860f55e4f	Version tools per Go convention under tools.go	6 years ago
Peter Dave Hello	0c63c7c854	build/Makefile: Properly exclude files under "./vendor/" path for `go fmt` (#19097 ) Properly exclude files under "./vendor/" path, and find "files" only. The original method "might" found "directories" with the same naming, or, might exclude occasionally exclude the go files with "vendor" string in any part of its path.	7 years ago
Radek Simko	01bc8898fc	make: Add check for protobuf dependencies	7 years ago
Martin Atkins	a9274beaca	build: Run "go generate" in modules mode It seems that all of the tools we run here are now sufficiently modules-aware to run without problems in modules mode, and indeed running _not_ in modules mode was causing problems with locating packages in mockgen.	7 years ago
Radek Simko	357dcc924f	make: Make test-compile module-aware	7 years ago
Radek Simko	5691c8b337	make: Pull all generate dependencies before generating	7 years ago
James Bardin	a24e307af0	remove govendor	7 years ago
Martin Atkins	4fe9632f09	plugin: Establish our current plugin protocol as version 5 The main significant change here is that the package name for the proto definition is "tfplugin5", which is important because this name is part of the wire protocol for references to types defined in our package. Along with that, we also move the generated package into "internal" to make it explicit that importing the generated Go package from elsewhere is not the right approach for externally-implemented SDKs, which should instead vendor the proto definition they are using and generate their own stubs to ensure that the wire protocol is the only hard dependency between Terraform Core and plugins. After this is merged, any provider binaries built against our helper/schema package will need to be rebuilt so that they use the new "tfplugin5" package name instead of "proto". In a future commit we will include more elaborate and organized documentation on how an external codebase might make use of our RPC interface definition to implement an SDK, but the primary concern here is to ensure we have the right wire package name before release.	7 years ago
Martin Atkins	c133de863b	build: Update most things for Go 1.11 modules We're still using vendoring for now until we get _all_ of our tooling updated, so the main idea here is to force use of the vendor directory when running tests and building for development so we can quickly find situations where we forget to run "go mod vendor". We also setting GO111MODULE=off for installation of tools. Right now this is the best way to install a tool in GOBIN without also interfering with go.mod and go.sum, until a better pattern for managing tool dependencies is devised by the Go team. Finally, we run "go mod download" before launching "gox" in the main build process, to prime the local module cache once so that the concurrent "go build" processes won't race to populate it redundantly. This means that we'll be producing final builds from the module cache rather than from vendor as with everything else -- there's currently no way to tell gox to use -mod=vendor -- but that should be fine in practice since our go.sum file will ensure that we get the exact sources we expect in the module cache before building.	7 years ago
Martin Atkins	ec57927ea3	build: Take protoc out of the "go generate" path Since protoc is not go-gettable, and most development tasks in Terraform won't involve recompiling protoc files anyway, we'll use a separate mechanism for these. This way "go generate" only depends on things we can "go get" in the "make tools" target. In a later commit we should also in some way specify a particular version of protoc to use so that we don't get "flapping" regenerations as developers work with different versions, but the priority here is just to make "make generate" minimally usable again to restore the dev workflow documented in the README. This also includes some updates that resulted from running "make generate" and "make protobuf" after those Makefile changes were in place.	7 years ago
Sander van Harmelen	fb0af07696	Print status updates while waiting for the run to start	7 years ago
Radek Simko	c4ffdb1f57	make: Add website + website-test targets	8 years ago
James Bardin	ec62819b3a	finish removing vet from the makefile The test target will already cover vet, since it's run as part of the test command now. Also remove the `go test -i` since it's no longer needed with the new build cache.	8 years ago
James Bardin	3bc1dcf21a	update travis to build with go1.10 Remove the vet target too, since vet is now always run with every test.	8 years ago
Martin Atkins	f45aae9b70	build: run end-to-end tests during Travis run We don't usually run "acceptance tests" during a Travis run, but this particular suite doesn't require any special credentials since it just accesses releases.hashicorp.com to download plugins, so therefore it's safe to run in Travis at the expense of adding a few more seconds to the runtime. Running it in Travis can therefore give us some extra confidence for pull requests that may inadvertently break certain details of the workflow, as well as ensuring that these tests are kept up-to-date as the system changes.	9 years ago
Martin Atkins	8cf6756ab7	build: Remove vendor-grepping from Makefile As of Go 1.9, ./... excludes the vendor directory by default and so we no longer need to jump through hoops to exclude vendored packages from testing, vetting, etc. As a simplification this also re-introduces builtin/bins to the set of packages we run tests on. With the providers now split into their own repositories there's far fewer of these and so including them doesn't really hurt anything, and makes our invocations here simpler.	9 years ago
James Bardin	77a32f3df0	remove "core" distinction Since there is little left that isn't core, remove the distinction for now to reduce confusion, since a "core" binary will mostly work except for provisioners.	9 years ago
James Bardin	1bd0205e49	remove errcheck The existing harness was only for aws, which fails now that aws is gone.	9 years ago
Christoph Blecker	3f7a117148	build: Fix Travis vet issues (#14010 ) * Use latest in go 1.8 branch for travis * Fix ongoing vet issues Move vet step after the testing step in travis Correct Makefile vet step to check correct files	9 years ago
James Bardin	4ef90d803b	test changes to travis Increase timeout to 60s. The consul backend tests come too close to that and timout every time they stall a little.	9 years ago
Clint	b0deb7736b	Makefile: restore test check deps (#12525 )	9 years ago
Mitchell Hashimoto	4ed2a563ca	Disallow parallelism in Makefile	9 years ago
James Bardin	87253e448c	install packages for tests Running `go test -i` installs the requirements for a package's tests. This way when running the tests in batches of 4, we can cut the runtime in half be only compiling the dependencies once.	9 years ago
Mitchell Hashimoto	f4ca79d7b7	Update Makefile to run tests 4 packages at a time We were running out of RAM on Travis	9 years ago
James Bardin	7f6f11b9f2	Add vendor-status make target Have vendor-status run govendor-status Add all the missing .PHONY targets	9 years ago
James Bardin	dfb1d9cbe0	fix vet make target to vet all packages The vet target was only vetting the topmmost packages.	9 years ago
James Nugent	b9f74e388e	build: Add test-compile target (#10348 )	9 years ago
Clint	740b8bb9cb	provider/aws: Run errcheck in tests (#8579 ) * provider/aws: Add errcheck to Makefile, error on unchecked errors * more exceptions * updates for errcheck to pass * reformat and spilt out the ignore statements * narrow down ignores * fix typo, only ignore Close and Write, instead of close or write	10 years ago

1 2 3

129 Commits (31291c551ef4bb3eb3c4326bef0822b93a4ee071)