15 Commits (2edd9f4e10faf38e65d5fc5ce4e29c3c4e3b59b0)

Author	SHA1	Message	Date
James Bardin	58d85fcc2e	add test for planing unknown data source values	5 years ago
James Bardin	18d354223e	objchange: fix ProposedNew from null objects ... The codepath for AllAttributesNull was not correct for any nested object types with collections, and should create single null values for the correct NestingMode rather than a single object with null attributes. Since there is no reason to descend into nested object types to create nullv alues, we can drop the AllAttributesNull function altogether and create null values as needed during ProposedNew. The corresponding AllBlockAttributesNull was only called internally in 1 location, and simply delegated to schema.EmptyValue. We can reduce the package surface area by dropping that function too and calling EmptyValue directly.	5 years ago
James Bardin	331dc8b14c	handle empty containers in ProposedNew NestedTypes ... Empty containers of NestedTypes were not handled in ProposedNew, causing plans to be submitted with null values where there was configuration present.	5 years ago
James Bardin	8ed9a270e5	Merge pull request #29559 from hashicorp/jbardin/optional-attrs ... Prevent `ObjectWithOptionalAttrs` from escaping	5 years ago
James Bardin	43123d284e	optional attrs should not be in ProposedNew	5 years ago
James Bardin	782132da33	remove incorrect computed check ... The config is already validated, and does not need to be checked in AssertPlanValid. Add some more coverage for plan validation.	5 years ago
James Bardin	f195ce7fd4	remove temp test	5 years ago
James Bardin	ea68d79ea2	nested object values can be computed ... While blocks were not allowed to be computed by the provider, nested objects can be. Remove the errors regarding blocks and verify unknown values are valid.	5 years ago
James Bardin	903797084a	objects vs maps in nested object types ... When using NestedMap objects, unify the codepath for both maps and objects as they may be interchangeable.	5 years ago
James Bardin	7ca6be8285	correctly verify planned nested object values ... The validation for nested object types with computed attributes was using the incorrect function call.	5 years ago
James Bardin	da007517b0	handle null NestingSingle values ... Null NestingSingle attributes were not being handled in ProposedNew	5 years ago
Kristin Laemmert	0d80a74539	configs/configschema: fix missing "computed" attributes from NestedObject's ImpliedType (#29172) ... * configs/configschema: fix missing "computed" attributes from NestedObject's ImpliedType listOptionalAttrsFromObject was not including "computed" attributes in the list of optional object attributes. This is now fixed. I've also added some tests and fixed some panics and otherwise bad behavior when bad input is given. One natable change is in ImpliedType, which was panicking on an invalid nesting mode. The comment expressly states that it will return a result even when the schema is inconsistent, so I removed the panic and instead return an empty object.	5 years ago
James Bardin	d9dfd451ea	update to use typed sensitive marks	5 years ago
James Bardin	b7f8ef4dc6	handle unexpected changes to unknown block ... An unknown block represents a dynamic configuration block with an unknown for_each value. We were not catching the case where a provider modified this value unexpectedly, which would crash with block of type NestingList blocks where the config value has no length for comparison.	5 years ago
Martin Atkins	034e944070	Move plans/ to internal/plans/ ... This is part of a general effort to move all of Terraform's non-library package surface under internal in order to reinforce that these are for internal use within Terraform only. If you were previously importing packages under this prefix into an external codebase, you could pin to an earlier release tag as an interim solution until you've make a plan to achieve the same functionality some other way.	5 years ago